* [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'
@ 2019-05-27 15:34 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-27 15:34 UTC (permalink / raw)
To: hao.wu, atull, mdf; +Cc: linux-kernel, linux-fpga, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy:
drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used [-Wunused-but-set-variable]
It's never used since introduction in commit 29de76240e86 ("fpga:
dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/fpga/dfl-fme-main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
index 086ad2420ade..cb7c4e258298 100644
--- a/drivers/fpga/dfl-fme-main.c
+++ b/drivers/fpga/dfl-fme-main.c
@@ -213,10 +213,8 @@ static int fme_dev_init(struct platform_device *pdev)
static void fme_dev_destroy(struct platform_device *pdev)
{
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
- struct dfl_fme *fme;
mutex_lock(&pdata->lock);
- fme = dfl_fpga_pdata_get_private(pdata);
dfl_fpga_pdata_set_private(pdata, NULL);
mutex_unlock(&pdata->lock);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'
@ 2019-05-27 15:34 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-27 15:34 UTC (permalink / raw)
To: hao.wu, atull, mdf; +Cc: linux-kernel, linux-fpga, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy:
drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used [-Wunused-but-set-variable]
It's never used since introduction in commit 29de76240e86 ("fpga:
dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/fpga/dfl-fme-main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
index 086ad2420ade..cb7c4e258298 100644
--- a/drivers/fpga/dfl-fme-main.c
+++ b/drivers/fpga/dfl-fme-main.c
@@ -213,10 +213,8 @@ static int fme_dev_init(struct platform_device *pdev)
static void fme_dev_destroy(struct platform_device *pdev)
{
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
- struct dfl_fme *fme;
mutex_lock(&pdata->lock);
- fme = dfl_fpga_pdata_get_private(pdata);
dfl_fpga_pdata_set_private(pdata, NULL);
mutex_unlock(&pdata->lock);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'
2019-05-27 15:34 ` YueHaibing
(?)
@ 2019-05-27 22:02 ` Ben Widawsky
-1 siblings, 0 replies; 3+ messages in thread
From: Ben Widawsky @ 2019-05-27 22:02 UTC (permalink / raw)
To: YueHaibing; +Cc: hao.wu, atull, mdf, linux-kernel, linux-fpga
On 19-05-27 23:34:24, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/fpga/dfl-fme-main.c: In function fme_dev_destroy:
> drivers/fpga/dfl-fme-main.c:216:18: warning: variable fme set but not used [-Wunused-but-set-variable]
>
> It's never used since introduction in commit 29de76240e86 ("fpga:
> dfl: fme: add partial reconfiguration sub feature support")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-27 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 15:34 [PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme' YueHaibing
2019-05-27 15:34 ` YueHaibing
2019-05-27 22:02 ` Ben Widawsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.