From: Daniel Vetter <daniel.vetter@ffwll.ch> To: LKML <linux-kernel@vger.kernel.org> Cc: DRI Development <dri-devel@lists.freedesktop.org>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, linux-fbdev@vger.kernel.org, Daniel Thompson <daniel.thompson@linaro.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Daniel Vetter <daniel.vetter@intel.com>, Sam Ravnborg <sam@ravnborg.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jingoohan1@gmail.com> Subject: [PATCH 33/33] backlight: simplify lcd notifier Date: Tue, 28 May 2019 11:03:04 +0200 [thread overview] Message-ID: <20190528090304.9388-34-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> With all the work I've done on replacing fb notifier calls with direct calls into fbcon the backlight/lcd notifier is the only user left. It will only receive events now that it cares about, hence we can remove this check. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Daniel Thompson <daniel.thompson@linaro.org> Cc: Jingoo Han <jingoohan1@gmail.com> --- drivers/video/backlight/lcd.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index ecdda06989d0..d6b653aa4ee9 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c @@ -30,17 +30,6 @@ static int fb_notifier_callback(struct notifier_block *self, struct lcd_device *ld; struct fb_event *evdata = data; - /* If we aren't interested in this event, skip it immediately ... */ - switch (event) { - case FB_EVENT_BLANK: - case FB_EVENT_MODE_CHANGE: - case FB_EARLY_EVENT_BLANK: - case FB_R_EARLY_EVENT_BLANK: - break; - default: - return 0; - } - ld = container_of(self, struct lcd_device, fb_notif); if (!ld->ops) return 0; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: LKML <linux-kernel@vger.kernel.org> Cc: DRI Development <dri-devel@lists.freedesktop.org>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, linux-fbdev@vger.kernel.org, Daniel Thompson <daniel.thompson@linaro.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Daniel Vetter <daniel.vetter@intel.com>, Sam Ravnborg <sam@ravnborg.org>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Jingoo Han <jingoohan1@gmail.com> Subject: [PATCH 33/33] backlight: simplify lcd notifier Date: Tue, 28 May 2019 09:03:04 +0000 [thread overview] Message-ID: <20190528090304.9388-34-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20190528090304.9388-1-daniel.vetter@ffwll.ch> With all the work I've done on replacing fb notifier calls with direct calls into fbcon the backlight/lcd notifier is the only user left. It will only receive events now that it cares about, hence we can remove this check. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Daniel Thompson <daniel.thompson@linaro.org> Cc: Jingoo Han <jingoohan1@gmail.com> --- drivers/video/backlight/lcd.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c index ecdda06989d0..d6b653aa4ee9 100644 --- a/drivers/video/backlight/lcd.c +++ b/drivers/video/backlight/lcd.c @@ -30,17 +30,6 @@ static int fb_notifier_callback(struct notifier_block *self, struct lcd_device *ld; struct fb_event *evdata = data; - /* If we aren't interested in this event, skip it immediately ... */ - switch (event) { - case FB_EVENT_BLANK: - case FB_EVENT_MODE_CHANGE: - case FB_EARLY_EVENT_BLANK: - case FB_R_EARLY_EVENT_BLANK: - break; - default: - return 0; - } - ld = container_of(self, struct lcd_device, fb_notif); if (!ld->ops) return 0; -- 2.20.1
next prev parent reply other threads:[~2019-05-28 9:04 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-28 9:02 [PATCH 00/33] fbcon notifier begone v3! Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 01/33] dummycon: Sprinkle locking checks Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 02/33] fbdev: locking check for fb_set_suspend Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 03/33] vt: might_sleep() annotation for do_blank_screen Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 04/33] vt: More locking checks Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 05/33] fbdev/sa1100fb: Remove dead code Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 06/33] fbdev/cyber2000: Remove struct display Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 07/33] fbdev/aty128fb: Remove dead code Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 08/33] fbcon: s/struct display/struct fbcon_display/ Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 09/33] fbcon: Remove fbcon_has_exited Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 12/33] fbdev/omap: sysfs files can't disappear before the device is gone Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 13/33] fbdev: " Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 14/33] staging/olpc: lock_fb_info can't fail Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 15/33] fbdev/atyfb: " Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 16/33] fbdev: lock_fb_info cannot fail Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 17/33] fbcon: call fbcon_fb_bind directly Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 18/33] fbdev: make unregister/unlink functions not fail Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 19/33] fbdev: unify unlink_framebuffer paths Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 20/33] fbdev/sh_mob: Remove fb notifier callback Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 21/33] fbdev: directly call fbcon_suspended/resumed Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 22/33] fbcon: Call fbcon_mode_deleted/new_modelist directly Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 23/33] fbdev: Call fbcon_get_requirement directly Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 24/33] Revert "backlight/fbcon: Add FB_EVENT_CONBLANK" Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-06-11 14:09 ` Daniel Thompson 2019-06-11 14:09 ` Daniel Thompson 2019-06-11 14:09 ` Daniel Thompson 2019-06-11 15:39 ` Daniel Vetter 2019-06-11 15:39 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 25/33] fbmem: pull fbcon_fb_blanked out of fb_blank Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 26/33] fbdev: remove FBINFO_MISC_USEREVENT around fb_blank Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 27/33] fb: Flatten control flow in fb_set_var Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-05-28 9:02 ` [PATCH 28/33] fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls Daniel Vetter 2019-05-28 9:02 ` Daniel Vetter 2019-06-11 14:11 ` Daniel Thompson 2019-06-11 14:11 ` Daniel Thompson 2019-06-11 14:11 ` Daniel Thompson 2019-05-28 9:03 ` [PATCH 29/33] vgaswitcheroo: call fbcon_remap_all directly Daniel Vetter 2019-05-28 9:03 ` Daniel Vetter 2019-05-28 9:03 ` [PATCH 30/33] fbcon: Call con2fb_map functions directly Daniel Vetter 2019-05-28 9:03 ` Daniel Vetter 2019-05-28 9:03 ` [PATCH 31/33] fbcon: Document what I learned about fbcon locking Daniel Vetter 2019-05-28 9:03 ` Daniel Vetter 2019-05-28 9:03 ` [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO Daniel Vetter 2019-05-28 9:03 ` Daniel Vetter 2019-05-28 9:03 ` Daniel Vetter [this message] 2019-05-28 9:03 ` [PATCH 33/33] backlight: simplify lcd notifier Daniel Vetter 2019-06-11 14:11 ` Daniel Thompson 2019-06-11 14:11 ` Daniel Thompson 2019-06-11 14:11 ` Daniel Thompson 2019-05-28 12:22 ` ✗ Fi.CI.CHECKPATCH: warning for fbcon notifier begone v3! Patchwork 2019-05-28 12:36 ` ✗ Fi.CI.SPARSE: " Patchwork 2019-05-28 12:41 ` ✓ Fi.CI.BAT: success " Patchwork 2019-05-28 18:11 ` ✓ Fi.CI.IGT: " Patchwork 2019-06-06 7:38 ` [PATCH 00/33] " Daniel Vetter 2019-06-06 7:38 ` Daniel Vetter 2019-06-07 10:07 ` Bartlomiej Zolnierkiewicz 2019-06-07 10:07 ` Bartlomiej Zolnierkiewicz 2019-06-07 14:43 ` Daniel Vetter 2019-06-07 14:43 ` Daniel Vetter 2019-06-07 14:43 ` Daniel Vetter 2019-06-11 14:16 ` Daniel Thompson 2019-06-11 14:16 ` Daniel Thompson 2019-06-11 14:16 ` Daniel Thompson 2019-06-11 15:50 ` Daniel Vetter 2019-06-11 15:50 ` Daniel Vetter 2019-06-11 15:50 ` Daniel Vetter 2019-06-12 6:09 ` Lee Jones 2019-06-12 6:09 ` Lee Jones -- strict thread matches above, loose matches on Subject: below -- 2019-05-24 8:53 [PATCH 00/33] fbcon notifier begone! Daniel Vetter 2019-05-24 8:53 ` [PATCH 33/33] backlight: simplify lcd notifier Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190528090304.9388-34-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=b.zolnierkie@samsung.com \ --cc=daniel.thompson@linaro.org \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.