From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org,
Masahisa Kojima <masahisa.kojima@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Graeme Gregory <graeme.gregory@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3 1/4] acpi/irq: implement helper to create hierachical domains
Date: Tue, 28 May 2019 13:07:28 +0300 [thread overview]
Message-ID: <20190528100728.GV2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190527112720.2266-2-ard.biesheuvel@linaro.org>
On Mon, May 27, 2019 at 01:27:17PM +0200, Ard Biesheuvel wrote:
> +
> +/**
> + * acpi_irq_create_hierarchy - Create a hierarchical IRQ domain with the default
> + * GSI domain as its parent.
Please document the arguments as well.
> + */
> +struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags,
> + unsigned int size,
> + struct fwnode_handle *fwnode,
> + const struct irq_domain_ops *ops,
> + void *host_data)
Otherwise looks good to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Graeme Gregory <graeme.gregory@linaro.org>,
linux-gpio@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org,
Masahisa Kojima <masahisa.kojima@linaro.org>,
linux-arm-kernel@lists.infradead.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3 1/4] acpi/irq: implement helper to create hierachical domains
Date: Tue, 28 May 2019 13:07:28 +0300 [thread overview]
Message-ID: <20190528100728.GV2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190527112720.2266-2-ard.biesheuvel@linaro.org>
On Mon, May 27, 2019 at 01:27:17PM +0200, Ard Biesheuvel wrote:
> +
> +/**
> + * acpi_irq_create_hierarchy - Create a hierarchical IRQ domain with the default
> + * GSI domain as its parent.
Please document the arguments as well.
> + */
> +struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags,
> + unsigned int size,
> + struct fwnode_handle *fwnode,
> + const struct irq_domain_ops *ops,
> + void *host_data)
Otherwise looks good to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Graeme Gregory <graeme.gregory@linaro.org>,
linux-gpio@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org,
Masahisa Kojima <masahisa.kojima@linaro.org>,
linux-arm-kernel@lists.infradead.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v3 1/4] acpi/irq: implement helper to create hierachical domains
Date: Tue, 28 May 2019 13:07:28 +0300 [thread overview]
Message-ID: <20190528100728.GV2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190527112720.2266-2-ard.biesheuvel@linaro.org>
On Mon, May 27, 2019 at 01:27:17PM +0200, Ard Biesheuvel wrote:
> +
> +/**
> + * acpi_irq_create_hierarchy - Create a hierarchical IRQ domain with the default
> + * GSI domain as its parent.
Please document the arguments as well.
> + */
> +struct irq_domain *acpi_irq_create_hierarchy(unsigned int flags,
> + unsigned int size,
> + struct fwnode_handle *fwnode,
> + const struct irq_domain_ops *ops,
> + void *host_data)
Otherwise looks good to me.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-28 10:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 11:27 [PATCH v3 0/4] synquacer: implement ACPI gpio/interrupt support Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` [PATCH v3 1/4] acpi/irq: implement helper to create hierachical domains Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-28 10:07 ` Mika Westerberg [this message]
2019-05-28 10:07 ` Mika Westerberg
2019-05-28 10:07 ` Mika Westerberg
2019-05-28 12:54 ` Marc Zyngier
2019-05-28 12:54 ` Marc Zyngier
2019-05-28 12:54 ` Marc Zyngier
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-28 13:02 ` Lorenzo Pieralisi
2019-05-28 13:02 ` Lorenzo Pieralisi
2019-05-28 13:02 ` Lorenzo Pieralisi
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-28 13:12 ` Ard Biesheuvel
2019-05-27 11:27 ` [PATCH v3 2/4] irqchip/exiu: preparatory refactor for ACPI support Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` [PATCH v3 3/4] irqchip/exiu: implement " Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-28 10:12 ` Mika Westerberg
2019-05-28 10:12 ` Mika Westerberg
2019-05-28 10:12 ` Mika Westerberg
2019-05-27 11:27 ` [PATCH v3 4/4] gpio: mb86s7x: enable " Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-27 11:27 ` Ard Biesheuvel
2019-05-28 8:34 ` Linus Walleij
2019-05-28 8:34 ` Linus Walleij
2019-05-28 8:34 ` Linus Walleij
2019-05-28 11:26 ` Ard Biesheuvel
2019-05-28 11:26 ` Ard Biesheuvel
2019-05-28 11:26 ` Ard Biesheuvel
2019-05-28 13:00 ` [PATCH v3 0/4] synquacer: implement ACPI gpio/interrupt support Marc Zyngier
2019-05-28 13:00 ` Marc Zyngier
2019-05-28 13:00 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528100728.GV2781@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=masahisa.kojima@linaro.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.