From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Yury Norov <ynorov@marvell.com>, Andrew Morton <akpm@linux-foundation.org> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse" Date: Tue, 28 May 2019 13:04:12 +0200 [thread overview] Message-ID: <20190528110412.gg66fl67yahtwb6i@linutronix.de> (raw) | CC arch/arm/boot/compressed/decompress.o |In file included from include/linux/mm_types_task.h:14, | from include/linux/mm_types.h:5, | from include/linux/mmzone.h:21, | from include/linux/gfp.h:6, | from include/linux/umh.h:4, | from include/linux/kmod.h:22, | from include/linux/module.h:13, | from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39, | from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:13, | from arch/arm/boot/compressed/decompress.c:55: |include/linux/cpumask.h: In function ‘cpumask_parse’: |include/linux/cpumask.h:636:21: error: implicit declaration of function ‘strchrnul’; did you mean ‘strchr’? [-Werror=implicit-function-declaration] | unsigned int len = strchrnul(buf, '\n') - buf; | ^~~~~~~~~ | strchr |include/linux/cpumask.h:636:42: error: invalid operands to binary - (have ‘int’ and ‘const char *’) | unsigned int len = strchrnul(buf, '\n') - buf; | ~~~~~~~~~~~~~~~~~~~~ ^ |cc1: some warnings being treated as errors 3713a4e1fdb8da86f96a3e770b08e278d97529b4 is the first bad commit commit 3713a4e1fdb8da86f96a3e770b08e278d97529b4 Author: Yury Norov <ynorov@marvell.com> Date: Tue May 14 15:44:46 2019 -0700 include/linux/cpumask.h: fix double string traverse in cpumask_parse cpumask_parse() finds first occurrence of either or strchr() and strlen(). We can do it better with a single call of strchrnul(). [akpm@linux-foundation.org: remove unneeded cast] Link: http://lkml.kernel.org/r/20190409204208.12190-1-ynorov@marvell.com Signed-off-by: Yury Norov <ynorov@marvell.com> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> :040000 040000 f20d8a9ec1755b3981520ecf015248f6a0d9f116 db67caf64f99a9be808cd73e413c106c5aee15b7 M include This commit is v5.2-rc1~62^2~49. How do we deal with this one? Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Yury Norov <ynorov@marvell.com>, Andrew Morton <akpm@linux-foundation.org> Cc: tglx@linutronix.de, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse" Date: Tue, 28 May 2019 13:04:12 +0200 [thread overview] Message-ID: <20190528110412.gg66fl67yahtwb6i@linutronix.de> (raw) | CC arch/arm/boot/compressed/decompress.o |In file included from include/linux/mm_types_task.h:14, | from include/linux/mm_types.h:5, | from include/linux/mmzone.h:21, | from include/linux/gfp.h:6, | from include/linux/umh.h:4, | from include/linux/kmod.h:22, | from include/linux/module.h:13, | from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39, | from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:13, | from arch/arm/boot/compressed/decompress.c:55: |include/linux/cpumask.h: In function ‘cpumask_parse’: |include/linux/cpumask.h:636:21: error: implicit declaration of function ‘strchrnul’; did you mean ‘strchr’? [-Werror=implicit-function-declaration] | unsigned int len = strchrnul(buf, '\n') - buf; | ^~~~~~~~~ | strchr |include/linux/cpumask.h:636:42: error: invalid operands to binary - (have ‘int’ and ‘const char *’) | unsigned int len = strchrnul(buf, '\n') - buf; | ~~~~~~~~~~~~~~~~~~~~ ^ |cc1: some warnings being treated as errors 3713a4e1fdb8da86f96a3e770b08e278d97529b4 is the first bad commit commit 3713a4e1fdb8da86f96a3e770b08e278d97529b4 Author: Yury Norov <ynorov@marvell.com> Date: Tue May 14 15:44:46 2019 -0700 include/linux/cpumask.h: fix double string traverse in cpumask_parse cpumask_parse() finds first occurrence of either or strchr() and strlen(). We can do it better with a single call of strchrnul(). [akpm@linux-foundation.org: remove unneeded cast] Link: http://lkml.kernel.org/r/20190409204208.12190-1-ynorov@marvell.com Signed-off-by: Yury Norov <ynorov@marvell.com> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> :040000 040000 f20d8a9ec1755b3981520ecf015248f6a0d9f116 db67caf64f99a9be808cd73e413c106c5aee15b7 M include This commit is v5.2-rc1~62^2~49. How do we deal with this one? Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-05-28 11:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-28 11:04 Sebastian Andrzej Siewior [this message] 2019-05-28 11:04 ` LZ4 decompressor broken on ARM due to missing strchrnul() string traverse in cpumask_parse" Sebastian Andrzej Siewior 2019-05-28 11:33 ` Rasmus Villemoes 2019-05-28 11:33 ` Rasmus Villemoes 2019-05-28 11:53 ` Sebastian Andrzej Siewior 2019-05-28 11:53 ` Sebastian Andrzej Siewior
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190528110412.gg66fl67yahtwb6i@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=akpm@linux-foundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=tglx@linutronix.de \ --cc=ynorov@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.