[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[deinok at deinok.com]

From: deinok <deinok@deinok.com>

Signed-off-by: deinok <deinok@deinok.com>
---
 package/mender/Config.in   | 1 +
 package/mender/mender.hash | 2 +-
 package/mender/mender.mk   | 3 ++-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/mender/Config.in b/package/mender/Config.in
index 5ab2304e49..3fc93f9f06 100644
--- a/package/mender/Config.in
+++ b/package/mender/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_MENDER
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_UBOOT_TOOLS # runtime
 	select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV # runtime
+	select BR2_PACKAGE_XZ
 	help
 	  Mender is an open source over-the-air (OTA) software updater
 	  for embedded Linux devices. Mender comprises a client
diff --git a/package/mender/mender.hash b/package/mender/mender.hash
index 89aec239b1..d5c319e9c5 100644
--- a/package/mender/mender.hash
+++ b/package/mender/mender.hash
@@ -1,5 +1,5 @@
 # Locally computed:
-sha256 caee18d1b8446df0cbb9a9c5a1c040d7eb1924332da94c3489494443a8077eb8 1.7.0.tar.gz
+sha256 af37a11c4189097b485254c35450f289b078bc61f6a230d6540743f202d81b98 2.0.0.tar.gz
 
 # Apache-2.0 license, locally computed
 sha256 98ed35b5a138f58164b5c0dbccd9d7f01ef4d84b9dba01e896f0a3241c50c0f7 LICENSE
diff --git a/package/mender/mender.mk b/package/mender/mender.mk
index 07f6e5e5f9..132b09c738 100644
--- a/package/mender/mender.mk
+++ b/package/mender/mender.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-MENDER_VERSION = 1.7.0
+MENDER_VERSION = 2.0.0
 MENDER_SITE = https://github.com/mendersoftware/mender/archive
 MENDER_SOURCE = $(MENDER_VERSION).tar.gz
 MENDER_LICENSE = Apache-2.0, BSD-2-Clause, BSD-3-Clause, ISC, MIT, OLDAP-2.8
+MENDER_DEPENDENCIES = xz
 
 # Vendor license paths generated with:
 #    awk '{print $2}' LIC_FILES_CHKSUM.sha256 | grep vendor
-- 
2.17.1

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[deinok at deinok.com]

From: deinok <deinok@deinok.com>

Signed-off-by: deinok <deinok@deinok.com>
---
 package/mender/mender.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/mender/mender.conf b/package/mender/mender.conf
index 979f16aaf6..7eb9fb18b4 100644
--- a/package/mender/mender.conf
+++ b/package/mender/mender.conf
@@ -2,9 +2,9 @@
   "InventoryPollIntervalSeconds": 1800,
   "UpdatePollIntervalSeconds": 1800,
   "RetryPollIntervalSeconds": 300,
-  "RootfsPartA": "mmcblk0p2",
-  "RootfsPartB": "mmcblk0p3",
+  "RootfsPartA": "/dev/mmcblk0p1",
+  "RootfsPartB": "/dev/mmcblk0p2",
   "ServerCertificate": "/etc/mender/server.crt",
-  "ServerURL": "https://docker.mender.io",
+  "ServerURL": "https://hosted.mender.io",
   "TenantToken": "dummy"
 }
-- 
2.17.1

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Mirza Krak]

On Tue, May 28, 2019 at 1:59 PM <deinok@deinok.com> wrote:
>
> From: deinok <deinok@deinok.com>
>
> Signed-off-by: deinok <deinok@deinok.com>
> ---
>  package/mender/Config.in   | 1 +
>  package/mender/mender.hash | 2 +-
>  package/mender/mender.mk   | 3 ++-
>  3 files changed, 4 insertions(+), 2 deletions(-)


There is already a patch pending for the 2.0.0 bump, [1].

[1]. https://patchwork.ozlabs.org/patch/1097130/
-- 
Mirza Krak | Embedded Solutions Architect | https://mender.io

 Northern.tech AS | @northerntechHQ

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Arnout Vandecappelle]

On 28/05/2019 20:47, Mirza Krak wrote:
> On Tue, May 28, 2019 at 1:59 PM <deinok@deinok.com> wrote:
>>
>> From: deinok <deinok@deinok.com>
>>
>> Signed-off-by: deinok <deinok@deinok.com>
>> ---
>>  package/mender/Config.in   | 1 +
>>  package/mender/mender.hash | 2 +-
>>  package/mender/mender.mk   | 3 ++-
>>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> There is already a patch pending for the 2.0.0 bump, [1].
> 
> [1]. https://patchwork.ozlabs.org/patch/1097130/

 That one, however, is marked as Changes Requested because it failed to explain
why the license file hashes have changed.

 Since this patch doesn't even update the license file hashes, I've alse marked
it as changes requested. Hint: test the version bump with 'make legal-info'.

 Regards,
 Arnout

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Mirza Krak]

On Tue, May 28, 2019 at 10:39 PM Arnout Vandecappelle <arnout@mind.be>
wrote:

>
>
> On 28/05/2019 20:47, Mirza Krak wrote:
> > On Tue, May 28, 2019 at 1:59 PM <deinok@deinok.com> wrote:
> >>
> >> From: deinok <deinok@deinok.com>
> >>
> >> Signed-off-by: deinok <deinok@deinok.com>
> >> ---
> >>  package/mender/Config.in   | 1 +
> >>  package/mender/mender.hash | 2 +-
> >>  package/mender/mender.mk   | 3 ++-
> >>  3 files changed, 4 insertions(+), 2 deletions(-)
> >
> >
> > There is already a patch pending for the 2.0.0 bump, [1].
> >
> > [1]. https://patchwork.ozlabs.org/patch/1097130/
>
>  That one, however, is marked as Changes Requested because it failed to
> explain
> why the license file hashes have changed.
>

Yeah I noticed that, but what I was trying to get at was to try to
coordinate this instead of creating duplicates.


>  Since this patch doesn't even update the license file hashes, I've alse
> marked
> it as changes requested. Hint: test the version bump with 'make
> legal-info'.
>

For info to who ever creates a v2 patch, the license hash change in
mendersoftware/mender is due to a an update to copyright year in the
LICENSE file. The vendor hashes only seem to have different indentation and
that is why git produced a diff, the hashes seem to be the same.

-- 
Mirza Krak | Embedded Solutions Architect | https://mender.io

 Northern.tech AS <https://northern.tech> | @northerntechHQ
<https://twitter.com/northerntechhq>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190529/cef1c851/attachment.html>

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Raul Hidalgo Caballero]

For me, aduskett's patch is okey.
But for me is important to have the latest mender and mender-artifact in
the 2019.05 as it will be our main update mechanism for a bus system

On Wed, May 29, 2019 at 10:03 AM Mirza Krak <mirza.krak@northern.tech>
wrote:

> On Tue, May 28, 2019 at 10:39 PM Arnout Vandecappelle <arnout@mind.be>
> wrote:
>
>>
>>
>> On 28/05/2019 20:47, Mirza Krak wrote:
>> > On Tue, May 28, 2019 at 1:59 PM <deinok@deinok.com> wrote:
>> >>
>> >> From: deinok <deinok@deinok.com>
>> >>
>> >> Signed-off-by: deinok <deinok@deinok.com>
>> >> ---
>> >>  package/mender/Config.in   | 1 +
>> >>  package/mender/mender.hash | 2 +-
>> >>  package/mender/mender.mk   | 3 ++-
>> >>  3 files changed, 4 insertions(+), 2 deletions(-)
>> >
>> >
>> > There is already a patch pending for the 2.0.0 bump, [1].
>> >
>> > [1]. https://patchwork.ozlabs.org/patch/1097130/
>>
>>  That one, however, is marked as Changes Requested because it failed to
>> explain
>> why the license file hashes have changed.
>>
>
> Yeah I noticed that, but what I was trying to get at was to try to
> coordinate this instead of creating duplicates.
>
>
>>  Since this patch doesn't even update the license file hashes, I've alse
>> marked
>> it as changes requested. Hint: test the version bump with 'make
>> legal-info'.
>>
>
> For info to who ever creates a v2 patch, the license hash change in
> mendersoftware/mender is due to a an update to copyright year in the
> LICENSE file. The vendor hashes only seem to have different indentation and
> that is why git produced a diff, the hashes seem to be the same.
>
> --
> Mirza Krak | Embedded Solutions Architect | https://mender.io
>
>  Northern.tech AS <https://northern.tech> | @northerntechHQ
> <https://twitter.com/northerntechhq>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190529/693e105c/attachment.html>

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[Arnout Vandecappelle]

On 29/05/2019 15:24, Raul Hidalgo Caballero wrote:
> For me, aduskett's patch is okey.?
> But for me is important to have the latest mender and mender-artifact in
> the?2019.05 as it will be our main update mechanism for a bus system

 Sorry, that's not going to happen. We don't do version bumps anymore for
2019.05. Only pure security bumps.

 Regards,
 Arnout

> 
> On Wed, May 29, 2019 at 10:03 AM Mirza Krak <mirza.krak@northern.tech> wrote:
> 
>     On Tue, May 28, 2019 at 10:39 PM Arnout Vandecappelle <arnout@mind.be
>     <mailto:arnout@mind.be>> wrote:
> 
> 
> 
>         On 28/05/2019 20:47, Mirza Krak wrote:
>         > On Tue, May 28, 2019 at 1:59 PM <deinok@deinok.com
>         <mailto:deinok@deinok.com>> wrote:
>         >>
>         >> From: deinok <deinok at deinok.com <mailto:deinok@deinok.com>>
>         >>
>         >> Signed-off-by: deinok <deinok at deinok.com <mailto:deinok@deinok.com>>
>         >> ---
>         >>? package/mender/Config.in? ?| 1 +
>         >>? package/mender/mender.hash | 2 +-
>         >>? package/mender/mender.mk <http://mender.mk>? ?| 3 ++-
>         >>? 3 files changed, 4 insertions(+), 2 deletions(-)
>         >
>         >
>         > There is already a patch pending for the 2.0.0 bump, [1].
>         >
>         > [1]. https://patchwork.ozlabs.org/patch/1097130/
> 
>         ?That one, however, is marked as Changes Requested because it failed to
>         explain
>         why the license file hashes have changed.
> 
> 
>     Yeah I noticed that, but what I was trying to get at was to try to
>     coordinate this instead of creating duplicates.
> 
> 
>         ?Since this patch doesn't even update the license file hashes, I've alse
>         marked
>         it as changes requested. Hint: test the version bump with 'make legal-info'.
> 
> 
>     For info to who ever creates a v2 patch, the license hash change in
>     mendersoftware/mender is due to a an update to copyright year in the LICENSE
>     file. The vendor hashes only seem to have different indentation and that is
>     why git produced a diff, the hashes seem to be the same.
> 
>     -- 
>     Mirza Krak | Embedded Solutions Architect |?https://mender.io
> 
>     ?Northern.tech AS <https://northern.tech>?|?@northerntechHQ
>     <https://twitter.com/northerntechhq>
> 
> 
> 
> 

[Buildroot] [PATCH 1/2] package/mender: bump version to 2.0

[deinok at deinok.com]

From: deinok <deinok@deinok.com>

Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
---
 package/mender/Config.in   | 1 +
 package/mender/mender.hash | 2 +-
 package/mender/mender.mk   | 3 ++-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/mender/Config.in b/package/mender/Config.in
index 5ab2304e49..3fc93f9f06 100644
--- a/package/mender/Config.in
+++ b/package/mender/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_MENDER
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_UBOOT_TOOLS # runtime
 	select BR2_PACKAGE_UBOOT_TOOLS_FWPRINTENV # runtime
+	select BR2_PACKAGE_XZ
 	help
 	  Mender is an open source over-the-air (OTA) software updater
 	  for embedded Linux devices. Mender comprises a client
diff --git a/package/mender/mender.hash b/package/mender/mender.hash
index 89aec239b1..d5c319e9c5 100644
--- a/package/mender/mender.hash
+++ b/package/mender/mender.hash
@@ -1,5 +1,5 @@
 # Locally computed:
-sha256 caee18d1b8446df0cbb9a9c5a1c040d7eb1924332da94c3489494443a8077eb8 1.7.0.tar.gz
+sha256 af37a11c4189097b485254c35450f289b078bc61f6a230d6540743f202d81b98 2.0.0.tar.gz
 
 # Apache-2.0 license, locally computed
 sha256 98ed35b5a138f58164b5c0dbccd9d7f01ef4d84b9dba01e896f0a3241c50c0f7 LICENSE
diff --git a/package/mender/mender.mk b/package/mender/mender.mk
index 07f6e5e5f9..132b09c738 100644
--- a/package/mender/mender.mk
+++ b/package/mender/mender.mk
@@ -4,10 +4,11 @@
 #
 ################################################################################
 
-MENDER_VERSION = 1.7.0
+MENDER_VERSION = 2.0.0
 MENDER_SITE = https://github.com/mendersoftware/mender/archive
 MENDER_SOURCE = $(MENDER_VERSION).tar.gz
 MENDER_LICENSE = Apache-2.0, BSD-2-Clause, BSD-3-Clause, ISC, MIT, OLDAP-2.8
+MENDER_DEPENDENCIES = xz
 
 # Vendor license paths generated with:
 #    awk '{print $2}' LIC_FILES_CHKSUM.sha256 | grep vendor
-- 
2.17.1

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[deinok at deinok.com]

From: Raul Hidalgo Caballero <deinok@deinok.com>

Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
---
 package/mender/mender.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/mender/mender.conf b/package/mender/mender.conf
index 979f16aaf6..7eb9fb18b4 100644
--- a/package/mender/mender.conf
+++ b/package/mender/mender.conf
@@ -2,9 +2,9 @@
   "InventoryPollIntervalSeconds": 1800,
   "UpdatePollIntervalSeconds": 1800,
   "RetryPollIntervalSeconds": 300,
-  "RootfsPartA": "mmcblk0p2",
-  "RootfsPartB": "mmcblk0p3",
+  "RootfsPartA": "/dev/mmcblk0p1",
+  "RootfsPartB": "/dev/mmcblk0p2",
   "ServerCertificate": "/etc/mender/server.crt",
-  "ServerURL": "https://docker.mender.io",
+  "ServerURL": "https://hosted.mender.io",
   "TenantToken": "dummy"
 }
-- 
2.17.1

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[Arnout Vandecappelle]

 Hi Raul,

On 28/05/2019 15:41, deinok at deinok.com wrote:
> From: Raul Hidalgo Caballero <deinok@deinok.com>
> 

 Please give a better explanation than "better" :-). The summary line is OK, but
the body of the commit message should specify why it is better. Even if the
explanation is obvious, like I say below.

> Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
> ---
>  package/mender/mender.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/mender/mender.conf b/package/mender/mender.conf
> index 979f16aaf6..7eb9fb18b4 100644
> --- a/package/mender/mender.conf
> +++ b/package/mender/mender.conf
> @@ -2,9 +2,9 @@
>    "InventoryPollIntervalSeconds": 1800,
>    "UpdatePollIntervalSeconds": 1800,
>    "RetryPollIntervalSeconds": 300,
> -  "RootfsPartA": "mmcblk0p2",
> -  "RootfsPartB": "mmcblk0p3",
> +  "RootfsPartA": "/dev/mmcblk0p1",
> +  "RootfsPartB": "/dev/mmcblk0p2",

 This one seems kind of obvious...

 Mirza, how is it possible that this used to work for you?

>    "ServerCertificate": "/etc/mender/server.crt",
> -  "ServerURL": "https://docker.mender.io",
> +  "ServerURL": "https://hosted.mender.io",

 This one is also obvious: docker.mender.io doesn't exist, and according to
wayback machine it never did. Well, it doesn't know hosted.mender.io either and
that one definitely exists, so maybe it just changed name. Mirza?

 Regards,
 Arnout

>    "TenantToken": "dummy"
>  }
> 

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[Mirza Krak]

On Tue, May 28, 2019 at 8:28 PM Arnout Vandecappelle <arnout@mind.be> wrote:

>  Hi Raul,
>
> On 28/05/2019 15:41, deinok at deinok.com wrote:
> > From: Raul Hidalgo Caballero <deinok@deinok.com>
> >
>
>  Please give a better explanation than "better" :-). The summary line is
> OK, but
> the body of the commit message should specify why it is better. Even if the
> explanation is obvious, like I say below.
>
> > Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
> > ---
> >  package/mender/mender.conf | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/mender/mender.conf b/package/mender/mender.conf
> > index 979f16aaf6..7eb9fb18b4 100644
> > --- a/package/mender/mender.conf
> > +++ b/package/mender/mender.conf
> > @@ -2,9 +2,9 @@
> >    "InventoryPollIntervalSeconds": 1800,
> >    "UpdatePollIntervalSeconds": 1800,
> >    "RetryPollIntervalSeconds": 300,
> > -  "RootfsPartA": "mmcblk0p2",
> > -  "RootfsPartB": "mmcblk0p3",
> > +  "RootfsPartA": "/dev/mmcblk0p1",
> > +  "RootfsPartB": "/dev/mmcblk0p2",
>
>  This one seems kind of obvious...
>
>  Mirza, how is it possible that this used to work for you?
>

I actually sent out a patch recently fixing this as well [1], as I noticed
this and it is a bug. I guess I did not notice earlier as I had this file
provided trough an "rootfs_overlay" (with correct paths)


>
> >    "ServerCertificate": "/etc/mender/server.crt",
> > -  "ServerURL": "https://docker.mender.io",
> > +  "ServerURL": "https://hosted.mender.io",
>
>  This one is also obvious: docker.mender.io doesn't exist, and according
> to
> wayback machine it never did. Well, it doesn't know hosted.mender.io
> either and
> that one definitely exists, so maybe it just changed name. Mirza?
>

The "docker.mender.io" URL is actually is valid when you use the Mender
Demo environment [1] and what you typically do is the following:

     echo "192.168.1.120 docker.mender.io s3.docker.mender.io" >> /etc/hosts

There is also a demo certificate (servert.crt [3]) which is installed by
default and this certificate is only valid for "docker.mender.io and
s3.docker.mender.io" and this is the reason on why this was the default
URL. I did mention this in the commit message when this file was updated [4]

[1]. https://patchwork.ozlabs.org/patch/1099369/
[2]. https://docs.mender.io/2.0/getting-started/create-a-test-environment
[3].
https://github.com/buildroot/buildroot/blob/dd97b055b11b8708438974555d1746a18924ceba/package/mender/server.crt
[4].
https://github.com/buildroot/buildroot/commit/9b297505eb7992965c32dc2cf1d083f26b563246#diff-320fbe73257a3e8f47413a56ef19b7de
-- 
Mirza Krak | Embedded Solutions Architect | https://mender.io

 Northern.tech AS <https://northern.tech> | @northerntechHQ
<https://twitter.com/northerntechhq>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190528/a216ceb4/attachment.html>

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[Mirza Krak]

On Tue, May 28, 2019 at 8:42 PM Mirza Krak <mirza.krak@northern.tech> wrote:
>
> On Tue, May 28, 2019 at 8:28 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>  Hi Raul,
>>
>> On 28/05/2019 15:41, deinok at deinok.com wrote:
>> > From: Raul Hidalgo Caballero <deinok@deinok.com>
>> >
>>
>>  Please give a better explanation than "better" :-). The summary line is OK, but
>> the body of the commit message should specify why it is better. Even if the
>> explanation is obvious, like I say below.
>>
>> > Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
>> > ---
>> >  package/mender/mender.conf | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/package/mender/mender.conf b/package/mender/mender.conf
>> > index 979f16aaf6..7eb9fb18b4 100644
>> > --- a/package/mender/mender.conf
>> > +++ b/package/mender/mender.conf
>> > @@ -2,9 +2,9 @@
>> >    "InventoryPollIntervalSeconds": 1800,
>> >    "UpdatePollIntervalSeconds": 1800,
>> >    "RetryPollIntervalSeconds": 300,
>> > -  "RootfsPartA": "mmcblk0p2",
>> > -  "RootfsPartB": "mmcblk0p3",
>> > +  "RootfsPartA": "/dev/mmcblk0p1",
>> > +  "RootfsPartB": "/dev/mmcblk0p2",
>>
>>  This one seems kind of obvious...
>>
>>  Mirza, how is it possible that this used to work for you?
>
>
> I actually sent out a patch recently fixing this as well [1], as I noticed this and it is a bug. I guess I did not notice earlier as I had this file provided trough an "rootfs_overlay" (with correct paths)
>
>>
>>
>> >    "ServerCertificate": "/etc/mender/server.crt",
>> > -  "ServerURL": "https://docker.mender.io",
>> > +  "ServerURL": "https://hosted.mender.io",
>>
>>  This one is also obvious: docker.mender.io doesn't exist, and according to
>> wayback machine it never did. Well, it doesn't know hosted.mender.io either and
>> that one definitely exists, so maybe it just changed name. Mirza?
>
>
> The "docker.mender.io" URL is actually is valid when you use the Mender Demo environment [1] and what you typically do is the following:
>
>      echo "192.168.1.120 docker.mender.io s3.docker.mender.io" >> /etc/hosts
>
> There is also a demo certificate (servert.crt [3]) which is installed by default and this certificate is only valid for "docker.mender.io and s3.docker.mender.io" and this is the reason on why this was the default URL. I did mention this in the commit message when this file was updated [4]
>
> [1]. https://patchwork.ozlabs.org/patch/1099369/
> [2]. https://docs.mender.io/2.0/getting-started/create-a-test-environment
> [3]. https://github.com/buildroot/buildroot/blob/dd97b055b11b8708438974555d1746a18924ceba/package/mender/server.crt
> [4]. https://github.com/buildroot/buildroot/commit/9b297505eb7992965c32dc2cf1d083f26b563246#diff-320fbe73257a3e8f47413a56ef19b7de

Sorry, previous email was sent as HTML.

-- 
Mirza Krak | Embedded Solutions Architect | https://mender.io

 Northern.tech AS | @northerntechHQ

[Buildroot] [PATCH 2/2] package/mender: better default mender.config

[Arnout Vandecappelle]

On 28/05/2019 20:28, Arnout Vandecappelle wrote:
>  Hi Raul,
> 
> On 28/05/2019 15:41, deinok at deinok.com wrote:
>> From: Raul Hidalgo Caballero <deinok@deinok.com>
>>
> 
>  Please give a better explanation than "better" :-). The summary line is OK, but
> the body of the commit message should specify why it is better. Even if the
> explanation is obvious, like I say below.
> 
>> Signed-off-by: Raul Hidalgo Caballero <deinok@deinok.com>
>> ---
>>  package/mender/mender.conf | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/mender/mender.conf b/package/mender/mender.conf
>> index 979f16aaf6..7eb9fb18b4 100644
>> --- a/package/mender/mender.conf
>> +++ b/package/mender/mender.conf
>> @@ -2,9 +2,9 @@
>>    "InventoryPollIntervalSeconds": 1800,
>>    "UpdatePollIntervalSeconds": 1800,
>>    "RetryPollIntervalSeconds": 300,
>> -  "RootfsPartA": "mmcblk0p2",
>> -  "RootfsPartB": "mmcblk0p3",
>> +  "RootfsPartA": "/dev/mmcblk0p1",
>> +  "RootfsPartB": "/dev/mmcblk0p2",
> 
>  This one seems kind of obvious...
> 
>  Mirza, how is it possible that this used to work for you?

 Ha, it was already submitted before by Mirza! [1]

 I'll go and apply that one instead.

 Regards,
 Arnout

[1] http://patchwork.ozlabs.org/patch/1099369/

> 
>>    "ServerCertificate": "/etc/mender/server.crt",
>> -  "ServerURL": "https://docker.mender.io",
>> +  "ServerURL": "https://hosted.mender.io",
> 
>  This one is also obvious: docker.mender.io doesn't exist, and according to
> wayback machine it never did. Well, it doesn't know hosted.mender.io either and
> that one definitely exists, so maybe it just changed name. Mirza?
> 
>  Regards,
>  Arnout
> 
>>    "TenantToken": "dummy"
>>  }
>>