* [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI
@ 2019-05-28 13:51 Philippe Mathieu-Daudé
2019-05-28 14:42 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-28 13:51 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Laurent Vivier, Thomas Huth, Juan Quintela,
Peter Maydell, Philippe Mathieu-Daudé,
Dr. David Alan Gilbert, Paolo Bonzini, Alex Bennée
This started to fail 6 months ago [1] and lately occurs too
often on the main Travis CI.
Travis CI set the CONTINUOUS_INTEGRATION variable in the process
environment [2]. Let's use it to disable it when running this test
there.
[1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
[2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/migration-test.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index bd3f5c3125..c5091e1fb1 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -764,6 +764,11 @@ static void test_postcopy(void)
{
QTestState *from, *to;
+ if (getenv("CONTINUOUS_INTEGRATION")) {
+ /* Test failing on Travis-CI */
+ g_test_skip("Running on Travis-CI");
+ }
+
if (migrate_postcopy_prepare(&from, &to, false)) {
return;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI
2019-05-28 13:51 [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI Philippe Mathieu-Daudé
@ 2019-05-28 14:42 ` Dr. David Alan Gilbert
2019-05-28 14:46 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-28 14:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Laurent Vivier, Thomas Huth, Juan Quintela,
Peter Maydell, qemu-devel, Paolo Bonzini, Alex Bennée
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> This started to fail 6 months ago [1] and lately occurs too
> often on the main Travis CI.
>
> Travis CI set the CONTINUOUS_INTEGRATION variable in the process
> environment [2]. Let's use it to disable it when running this test
> there.
>
> [1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
> [2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
I think the right solution here is to disable it under TCG.
Dave
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/migration-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index bd3f5c3125..c5091e1fb1 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -764,6 +764,11 @@ static void test_postcopy(void)
> {
> QTestState *from, *to;
>
> + if (getenv("CONTINUOUS_INTEGRATION")) {
> + /* Test failing on Travis-CI */
> + g_test_skip("Running on Travis-CI");
> + }
> +
> if (migrate_postcopy_prepare(&from, &to, false)) {
> return;
> }
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI
2019-05-28 14:42 ` Dr. David Alan Gilbert
@ 2019-05-28 14:46 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-05-28 14:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Fam Zheng, Peter Maydell, Thomas Huth, Juan Quintela,
Dr. David Alan Gilbert, qemu-devel, Paolo Bonzini,
Alex Bennée
On 28/05/2019 16:42, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
>> This started to fail 6 months ago [1] and lately occurs too
>> often on the main Travis CI.
>>
>> Travis CI set the CONTINUOUS_INTEGRATION variable in the process
>> environment [2]. Let's use it to disable it when running this test
>> there.
>>
>> [1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
>> [2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
>
> I think the right solution here is to disable it under TCG.
>
For example, it's already done for ppc64 and s390x:
d254b392cb10 tests/migration-test: Disable s390x test when running with TCG
5fd4a9c97397 tests/migration: Skip tests for ppc tcg
You need the same for aarch64 since:
c02b37814cf6 tests: Add migration test for aarch64
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-28 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 13:51 [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI Philippe Mathieu-Daudé
2019-05-28 14:42 ` Dr. David Alan Gilbert
2019-05-28 14:46 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.