From: Mark Brown <broonie@kernel.org>
To: Banajit Goswami <bgoswami@codeaurora.org>
Cc: alsa-devel@alsa-project.org, srinivas.kandagatla@linaro.org,
plai@codeaurora.org
Subject: Re: [PATCH] ASoC: Add a debug log to track DAPM widget power up/down
Date: Tue, 28 May 2019 16:20:08 +0100 [thread overview]
Message-ID: <20190528152008.GM2456@sirena.org.uk> (raw)
In-Reply-To: <e65750b3-1fa6-e982-e695-4566f5e51e0c@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]
On Mon, May 27, 2019 at 06:15:20PM -0700, Banajit Goswami wrote:
> having the dev_dbg here are-
> 1. Do not need to enable trace, which helps collecting logs, without much
> know-how
> about audio or kernel
That approach results in kernel logs that are really hard to use and
wrap round far too fast - if everything starts spamming the logs it does
nothing for readability.
> 2. Dynamic debug (using /sys/kernel/debug/dynamic_debug) can be enabled for
> either just this line of code, or, for the function containing this debug
> statement.
> This way, logs can be collected just for the DAPM widget enable/disable, and
> thereby
> avoid having the output logs filled with unwanted logs.
That's into needing to learn about the kernel at which point there's no
real advantage of this approach.
> 3. Though I agree with you about the additional DAPM debug logs being
> present for
> someone who may not be specifically working on Audio, based on the number of
> widgets in the audio path used, the number of prints should be limited to
> only widget
> power on/off.
Some devices are *much* bigger than others, and some systems will start
and stop audio much more frequently than others (things like noises for
taps for example) both of which will massively amplify the noise. Even
when actively working on audio with those systems logging everything
gets old really fast.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2019-05-28 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 7:54 [PATCH] ASoC: Add a debug log to track DAPM widget power up/down bgoswami
2019-05-24 11:29 ` Mark Brown
2019-05-28 1:15 ` Banajit Goswami
2019-05-28 15:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528152008.GM2456@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.