All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Guo Ren <guoren@kernel.org>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	arnout@mind.be, linux-csky@vger.kernel.org,
	buildroot@buildroot.org, Guo Ren <ren_guo@c-sky.com>
Subject: Re: [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options
Date: Wed, 29 May 2019 09:57:39 +0200	[thread overview]
Message-ID: <20190529095739.18d4d3c8@windsurf.home> (raw)
In-Reply-To: <CAJF2gTSgReEOOJAvXY=MraqTLV4DwkKOqsbQ-4rBdNiaibxQfQ@mail.gmail.com>

Hello,

On Wed, 29 May 2019 15:30:14 +0800
Guo Ren <guoren@kernel.org> wrote:

> > What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is
> > apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is
> > defined for all cases, which seems to contradict your commit log.  
> abiv1 contain: ck610
> abiv2 contain: ck807 ck810 ck860
> 
> Abiv1 is almost the same as mcore and it's ELF_CODE is 39
> Abiv2 is C-SKY own ISA and it's ELF_CODE is 252
> 
> We don't support FPU in abiv1, because its opcode width is only
> 16-bits and we don't want to continue developing it.

Ah, and indeed BR2_CSKY_FPU cannot be selected for BR2_ck610.

Please explain all of this in the commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options
Date: Wed, 29 May 2019 09:57:39 +0200	[thread overview]
Message-ID: <20190529095739.18d4d3c8@windsurf.home> (raw)
In-Reply-To: <CAJF2gTSgReEOOJAvXY=MraqTLV4DwkKOqsbQ-4rBdNiaibxQfQ@mail.gmail.com>

Hello,

On Wed, 29 May 2019 15:30:14 +0800
Guo Ren <guoren@kernel.org> wrote:

> > What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is
> > apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is
> > defined for all cases, which seems to contradict your commit log.  
> abiv1 contain: ck610
> abiv2 contain: ck807 ck810 ck860
> 
> Abiv1 is almost the same as mcore and it's ELF_CODE is 39
> Abiv2 is C-SKY own ISA and it's ELF_CODE is 252
> 
> We don't support FPU in abiv1, because its opcode width is only
> 16-bits and we don't want to continue developing it.

Ah, and indeed BR2_CSKY_FPU cannot be selected for BR2_ck610.

Please explain all of this in the commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-05-29  7:57 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  7:18 [PATCH V3 00/10] Update arch/csky for buildroot guoren
2019-05-29  7:18 ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:21   ` Thomas Petazzoni
2019-05-29  7:21     ` [Buildroot] " Thomas Petazzoni
2019-05-29  7:30     ` Guo Ren
2019-05-29  7:30       ` [Buildroot] " Guo Ren
2019-05-29  7:56       ` Thomas Petazzoni
2019-05-29  7:56         ` [Buildroot] " Thomas Petazzoni
2019-05-29  8:12         ` Guo Ren
2019-05-29  8:12           ` [Buildroot] " Guo Ren
2019-05-29  8:38           ` Thomas Petazzoni
2019-05-29  8:38             ` [Buildroot] " Thomas Petazzoni
2019-05-29  9:02             ` Guo Ren
2019-05-29  9:02               ` [Buildroot] " Guo Ren
2019-05-29  9:06               ` Guo Ren
2019-05-29  9:06                 ` [Buildroot] " Guo Ren
2019-05-29  9:23               ` Thomas Petazzoni
2019-05-29  9:23                 ` [Buildroot] " Thomas Petazzoni
2019-05-29  9:45                 ` Guo Ren
2019-05-29  9:45                   ` [Buildroot] " Guo Ren
2019-05-29 11:58                   ` Thomas Petazzoni
2019-05-29 11:58                     ` [Buildroot] " Thomas Petazzoni
2019-05-29 12:34                     ` Guo Ren
2019-05-29 12:34                       ` [Buildroot] " Guo Ren
2019-05-29  7:18 ` [PATCH V3 02/10] arch/csky: Add ck860 supported guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:23   ` Thomas Petazzoni
2019-05-29  7:23     ` [Buildroot] " Thomas Petazzoni
2019-05-29  7:30     ` Guo Ren
2019-05-29  7:30       ` [Buildroot] " Guo Ren
2019-05-29  7:57       ` Thomas Petazzoni [this message]
2019-05-29  7:57         ` Thomas Petazzoni
2019-05-29  8:30         ` Guo Ren
2019-05-29  8:30           ` [Buildroot] " Guo Ren
2019-05-29  8:39           ` Thomas Petazzoni
2019-05-29  8:39             ` [Buildroot] " Thomas Petazzoni
2019-05-29  8:53             ` Guo Ren
2019-05-29  8:53               ` [Buildroot] " Guo Ren
2019-05-29  7:39     ` Guo Ren
2019-05-29  7:39       ` [Buildroot] " Guo Ren
2019-05-29  7:18 ` [PATCH V3 04/10] arch/csky: Add ABI variable for toolchain build guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 05/10] package/binutils: Add C-SKY support guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 06/10] package/gcc: " guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 07/10] package/gdb: " guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 08/10] package/glibc: " guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 09/10] configs/qemu_cskyXXX_virt: new defconfig guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org
2019-05-29  7:18 ` [PATCH V3 10/10] arch/csky: Enable csky toolchain build guoren
2019-05-29  7:18   ` [Buildroot] " guoren at kernel.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529095739.18d4d3c8@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=guoren@kernel.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=ren_guo@c-sky.com \
    --cc=thomas.de_schampheleire@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.