* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
@ 2019-05-27 15:30 Bartosz Bilas
2019-05-28 6:41 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Bartosz Bilas @ 2019-05-27 15:30 UTC (permalink / raw)
To: buildroot
Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
boot/barebox/barebox.hash | 1 +
1 file changed, 1 insertion(+)
diff --git a/boot/barebox/barebox.hash b/boot/barebox/barebox.hash
index fb371ab671..aa9038b9d4 100644
--- a/boot/barebox/barebox.hash
+++ b/boot/barebox/barebox.hash
@@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f barebox-2019.05.0.tar.bz2
# Locally calculated
sha256 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d barebox-2019.05.0.tar.bz2
+sha256 ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4 COPYING
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
2019-05-27 15:30 [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file Bartosz Bilas
@ 2019-05-28 6:41 ` Thomas Huth
2019-05-28 16:53 ` Bartosz Biłas
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-05-28 6:41 UTC (permalink / raw)
To: buildroot
Am Mon, 27 May 2019 17:30:54 +0200
schrieb Bartosz Bilas <b.bilas@grinn-global.com>:
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
> boot/barebox/barebox.hash | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/boot/barebox/barebox.hash b/boot/barebox/barebox.hash
> index fb371ab671..aa9038b9d4 100644
> --- a/boot/barebox/barebox.hash
> +++ b/boot/barebox/barebox.hash
> @@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
> barebox-2019.05.0.tar.bz2
> # Locally calculated
> sha256
> 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d
> barebox-2019.05.0.tar.bz2 +sha256
> ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4
> COPYING
The COPYING file is only a short description which refers to
LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash
for that file, too?
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
2019-05-28 6:41 ` Thomas Huth
@ 2019-05-28 16:53 ` Bartosz Biłas
2019-05-28 18:16 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Bartosz Biłas @ 2019-05-28 16:53 UTC (permalink / raw)
To: buildroot
There is also BSD-3-Clause used in some files so there is necessity to
complete licence files with them. I will prepare a new patch with that.
Best
Bartek
On 28.05.2019 08:41, Thomas Huth wrote:
> Am Mon, 27 May 2019 17:30:54 +0200
> schrieb Bartosz Bilas <b.bilas@grinn-global.com>:
>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>> ---
>> boot/barebox/barebox.hash | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/boot/barebox/barebox.hash b/boot/barebox/barebox.hash
>> index fb371ab671..aa9038b9d4 100644
>> --- a/boot/barebox/barebox.hash
>> +++ b/boot/barebox/barebox.hash
>> @@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
>> barebox-2019.05.0.tar.bz2
>> # Locally calculated
>> sha256
>> 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d
>> barebox-2019.05.0.tar.bz2 +sha256
>> ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4
>> COPYING
> The COPYING file is only a short description which refers to
> LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash
> for that file, too?
>
> Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
2019-05-28 16:53 ` Bartosz Biłas
@ 2019-05-28 18:16 ` Arnout Vandecappelle
2019-05-29 8:14 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-05-28 18:16 UTC (permalink / raw)
To: buildroot
On 28/05/2019 18:53, Bartosz Bi?as wrote:
> There is also BSD-3-Clause used in some files so there is necessity to complete
> licence files with them. I will prepare a new patch with that.
Can you also check (and specify in the commit message) if this file exists in
*all* versions of barebox? It is possible to configure a custom version of
barebox, so it can be pretty much anything...
Well, I checked myself: the LICENSES directory exists since 2019.04.0...
There is unfortunately no simple way to conditionally add license files: if a
file specified in _LICENSE_FILES doesn't exist, it's a hard error. You can use
$(wildcard ...) but then you have to strip off the source directory again.
Regards,
Arnout
>
> Best
> Bartek
> On 28.05.2019 08:41, Thomas Huth wrote:
>> Am Mon, 27 May 2019 17:30:54 +0200
>> schrieb Bartosz Bilas <b.bilas@grinn-global.com>:
>>
>>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>>> ---
>>> ? boot/barebox/barebox.hash | 1 +
>>> ? 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/boot/barebox/barebox.hash b/boot/barebox/barebox.hash
>>> index fb371ab671..aa9038b9d4 100644
>>> --- a/boot/barebox/barebox.hash
>>> +++ b/boot/barebox/barebox.hash
>>> @@ -3,3 +3,4 @@ md5 2e721cce90f1ea1492710ca23680311f
>>> barebox-2019.05.0.tar.bz2
>>> ? # Locally calculated
>>> ? sha256
>>> 704bb09b2bf1347e43ebb9138da32a7e1b4d13892fd187be98f4f9dae000501d
>>> barebox-2019.05.0.tar.bz2 +sha256
>>> ab1122aa9f9073ad1ec824edcd970b16a6a7881a34a18fd56c080debb2dca5d4
>>> COPYING
>> The COPYING file is only a short description which refers to
>> LICENSES/preferred/GPL-2.0 ... so I think you should provide a hash
>> for that file, too?
>>
>> ? Thomas
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
2019-05-28 18:16 ` Arnout Vandecappelle
@ 2019-05-29 8:14 ` Thomas Huth
2019-05-29 20:52 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2019-05-29 8:14 UTC (permalink / raw)
To: buildroot
Am Tue, 28 May 2019 20:16:42 +0200
schrieb Arnout Vandecappelle <arnout@mind.be>:
>
>
> On 28/05/2019 18:53, Bartosz Bi?as wrote:
> > There is also BSD-3-Clause used in some files so there is necessity
> > to complete licence files with them. I will prepare a new patch
> > with that.
>
> Can you also check (and specify in the commit message) if this file
> exists in *all* versions of barebox? It is possible to configure a
> custom version of barebox, so it can be pretty much anything...
>
> Well, I checked myself: the LICENSES directory exists since
> 2019.04.0...
>
> There is unfortunately no simple way to conditionally add license
> files: if a file specified in _LICENSE_FILES doesn't exist, it's a
> hard error. You can use $(wildcard ...) but then you have to strip
> off the source directory again.
Hmm, don't we have the problem with the hash of the tarball itself
already? If you specify another version, the hash of the tar.bz2 file
certainly does not match anymore...
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file
2019-05-29 8:14 ` Thomas Huth
@ 2019-05-29 20:52 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-05-29 20:52 UTC (permalink / raw)
To: buildroot
On 29/05/2019 10:14, Thomas Huth wrote:
> Am Tue, 28 May 2019 20:16:42 +0200
> schrieb Arnout Vandecappelle <arnout@mind.be>:
>
>>
>>
>> On 28/05/2019 18:53, Bartosz Bi?as wrote:
>>> There is also BSD-3-Clause used in some files so there is necessity
>>> to complete licence files with them. I will prepare a new patch
>>> with that.
>>
>> Can you also check (and specify in the commit message) if this file
>> exists in *all* versions of barebox? It is possible to configure a
>> custom version of barebox, so it can be pretty much anything...
>>
>> Well, I checked myself: the LICENSES directory exists since
>> 2019.04.0...
>>
>> There is unfortunately no simple way to conditionally add license
>> files: if a file specified in _LICENSE_FILES doesn't exist, it's a
>> hard error. You can use $(wildcard ...) but then you have to strip
>> off the source directory again.
>
> Hmm, don't we have the problem with the hash of the tarball itself
> already? If you specify another version, the hash of the tar.bz2 file
> certainly does not match anymore...
The hash of the tarball isn't checked for custom versions:
ifeq ($(BR2_TARGET_BAREBOX)$(BR2_TARGET_BAREBOX_LATEST_VERSION),y)
BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)
endif
Regards,
Arnout
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-29 20:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 15:30 [Buildroot] [PATCH 1/1] boot/barebox: add hash for the license file Bartosz Bilas
2019-05-28 6:41 ` Thomas Huth
2019-05-28 16:53 ` Bartosz Biłas
2019-05-28 18:16 ` Arnout Vandecappelle
2019-05-29 8:14 ` Thomas Huth
2019-05-29 20:52 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.