All of lore.kernel.org
 help / color / mirror / Atom feed
* [liu-song6-linux:uprobe-thp 92/185] arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
@ 2019-05-29  7:54 kbuild test robot
  2019-05-29 21:49 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-05-29  7:54 UTC (permalink / raw)
  To: Robin Murphy
  Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 3378 bytes --]

tree:   https://github.com/liu-song-6/linux.git uprobe-thp
head:   950e997c620db50b4f7e578631f6c8b0e1315778
commit: 5760548d3bd197b0858ccaf3ec8039aedba5832f [92/185] arm64: mm: Implement pte_devmap support
config: arm64-allnoconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 5760548d3bd197b0858ccaf3ec8039aedba5832f
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/mm.h:99:0,
                    from arch/arm64/kernel/asm-offsets.c:23:
>> arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
    #define pte_devmap(pte)  (!!(pte_val(pte) & PTE_DEVMAP))
                              ^
>> arch/arm64/include/asm/pgtable.h:390:26: note: in expansion of macro 'pte_devmap'
    #define pmd_devmap(pmd)  pte_devmap(pmd_pte(pmd))
                             ^~~~~~~~~~
>> include/linux/mm.h:540:19: note: in expansion of macro 'pmd_devmap'
    static inline int pmd_devmap(pmd_t pmd)
                      ^~~~~~~~~~
   In file included from arch/arm64/kernel/asm-offsets.c:23:0:
>> include/linux/mm.h:544:19: error: redefinition of 'pud_devmap'
    static inline int pud_devmap(pud_t pud)
                      ^~~~~~~~~~
   In file included from include/linux/mm.h:99:0,
                    from arch/arm64/kernel/asm-offsets.c:23:
   arch/arm64/include/asm/pgtable.h:549:19: note: previous definition of 'pud_devmap' was here
    static inline int pud_devmap(pud_t pud)
                      ^~~~~~~~~~
   In file included from arch/arm64/kernel/asm-offsets.c:23:0:
>> include/linux/mm.h:548:19: error: redefinition of 'pgd_devmap'
    static inline int pgd_devmap(pgd_t pgd)
                      ^~~~~~~~~~
   In file included from include/linux/mm.h:99:0,
                    from arch/arm64/kernel/asm-offsets.c:23:
   arch/arm64/include/asm/pgtable.h:641:19: note: previous definition of 'pgd_devmap' was here
    static inline int pgd_devmap(pgd_t pgd)
                      ^~~~~~~~~~
   make[2]: *** [arch/arm64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2

vim +93 arch/arm64/include/asm/pgtable.h

    83	
    84	/*
    85	 * The following only work if pte_present(). Undefined behaviour otherwise.
    86	 */
    87	#define pte_present(pte)	(!!(pte_val(pte) & (PTE_VALID | PTE_PROT_NONE)))
    88	#define pte_young(pte)		(!!(pte_val(pte) & PTE_AF))
    89	#define pte_special(pte)	(!!(pte_val(pte) & PTE_SPECIAL))
    90	#define pte_write(pte)		(!!(pte_val(pte) & PTE_WRITE))
    91	#define pte_user_exec(pte)	(!(pte_val(pte) & PTE_UXN))
    92	#define pte_cont(pte)		(!!(pte_val(pte) & PTE_CONT))
  > 93	#define pte_devmap(pte)		(!!(pte_val(pte) & PTE_DEVMAP))
    94	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7835 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [liu-song6-linux:uprobe-thp 92/185] arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
  2019-05-29  7:54 [liu-song6-linux:uprobe-thp 92/185] arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token kbuild test robot
@ 2019-05-29 21:49 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-05-29 21:49 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Robin Murphy, kbuild-all, Johannes Weiner, Linux Memory Management List

On Wed, 29 May 2019 15:54:52 +0800 kbuild test robot <lkp@intel.com> wrote:

> tree:   https://github.com/liu-song-6/linux.git uprobe-thp
> head:   950e997c620db50b4f7e578631f6c8b0e1315778
> commit: 5760548d3bd197b0858ccaf3ec8039aedba5832f [92/185] arm64: mm: Implement pte_devmap support
> config: arm64-allnoconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 5760548d3bd197b0858ccaf3ec8039aedba5832f
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=arm64 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/mm.h:99:0,
>                     from arch/arm64/kernel/asm-offsets.c:23:
> >> arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token
>     #define pte_devmap(pte)  (!!(pte_val(pte) & PTE_DEVMAP))
>                               ^
> >> arch/arm64/include/asm/pgtable.h:390:26: note: in expansion of macro 'pte_devmap'
>     #define pmd_devmap(pmd)  pte_devmap(pmd_pte(pmd))
>                              ^~~~~~~~~~
> >> include/linux/mm.h:540:19: note: in expansion of macro 'pmd_devmap'
>     static inline int pmd_devmap(pmd_t pmd)
>                       ^~~~~~~~~~
>    In file included from arch/arm64/kernel/asm-offsets.c:23:0:
> >> include/linux/mm.h:544:19: error: redefinition of 'pud_devmap'
>     static inline int pud_devmap(pud_t pud)
>                       ^~~~~~~~~~
>    In file included from include/linux/mm.h:99:0,
>                     from arch/arm64/kernel/asm-offsets.c:23:
>    arch/arm64/include/asm/pgtable.h:549:19: note: previous definition of 'pud_devmap' was here
>     static inline int pud_devmap(pud_t pud)
>                       ^~~~~~~~~~
>    In file included from arch/arm64/kernel/asm-offsets.c:23:0:
> >> include/linux/mm.h:548:19: error: redefinition of 'pgd_devmap'
>     static inline int pgd_devmap(pgd_t pgd)
>                       ^~~~~~~~~~
>    In file included from include/linux/mm.h:99:0,
>                     from arch/arm64/kernel/asm-offsets.c:23:
>    arch/arm64/include/asm/pgtable.h:641:19: note: previous definition of 'pgd_devmap' was here
>     static inline int pgd_devmap(pgd_t pgd)
>                       ^~~~~~~~~~

Thanks.  I guess we need some `#if defined(CONFIG_ARCH_HAS_PTE_DEVMAP)
&& defined(CONFIG_TRANSPARENT_HUGEPAGE)' sprinkled around.  I'll drop
this copy.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-29 21:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29  7:54 [liu-song6-linux:uprobe-thp 92/185] arch/arm64/include/asm/pgtable.h:93:27: error: expected identifier or '(' before '!' token kbuild test robot
2019-05-29 21:49 ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.