* [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase()
@ 2019-05-28 19:53 Max Reitz
2019-05-30 9:40 ` Kevin Wolf
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Max Reitz @ 2019-05-28 19:53 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Max Reitz
img_rebase() can leak a QDict in two occasions. Fix it.
Coverity: CID 1401416
Fixes: d16699b64671466b42079c45b89127aeea1ca565
Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
qemu-img.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qemu-img.c b/qemu-img.c
index b0535919b1..86e1923acf 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3347,6 +3347,7 @@ static int img_rebase(int argc, char **argv)
out_baseimg,
&local_err);
if (local_err) {
+ qobject_unref(options);
error_reportf_err(local_err,
"Could not resolve backing filename: ");
ret = -1;
@@ -3359,7 +3360,9 @@ static int img_rebase(int argc, char **argv)
*/
prefix_chain_bs = bdrv_find_backing_image(bs, out_real_path);
if (prefix_chain_bs) {
+ qobject_unref(options);
g_free(out_real_path);
+
blk_new_backing = blk_new(BLK_PERM_CONSISTENT_READ,
BLK_PERM_ALL);
ret = blk_insert_bs(blk_new_backing, prefix_chain_bs,
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase()
2019-05-28 19:53 [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase() Max Reitz
@ 2019-05-30 9:40 ` Kevin Wolf
2019-05-31 11:58 ` Max Reitz
2019-06-03 22:15 ` [Qemu-devel] [Qemu-block] " John Snow
2019-06-13 19:40 ` [Qemu-devel] " Max Reitz
2 siblings, 1 reply; 5+ messages in thread
From: Kevin Wolf @ 2019-05-30 9:40 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-devel, qemu-block
Am 28.05.2019 um 21:53 hat Max Reitz geschrieben:
> img_rebase() can leak a QDict in two occasions. Fix it.
>
> Coverity: CID 1401416
> Fixes: d16699b64671466b42079c45b89127aeea1ca565
> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Is this based on some other patch? The second hunk doesn't apply.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase()
2019-05-30 9:40 ` Kevin Wolf
@ 2019-05-31 11:58 ` Max Reitz
0 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2019-05-31 11:58 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, qemu-block
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On 30.05.19 11:40, Kevin Wolf wrote:
> Am 28.05.2019 um 21:53 hat Max Reitz geschrieben:
>> img_rebase() can leak a QDict in two occasions. Fix it.
>>
>> Coverity: CID 1401416
>> Fixes: d16699b64671466b42079c45b89127aeea1ca565
>> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>
> Is this based on some other patch? The second hunk doesn't apply.
Yes, it’s based on 330c72957196e0ae382abcaa97ebf4eb9bc8574f, as the
commit message says. At the time I sent this patch, that was just in my
pull request, now it’s in master.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img: Fix options leakage in img_rebase()
2019-05-28 19:53 [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase() Max Reitz
2019-05-30 9:40 ` Kevin Wolf
@ 2019-06-03 22:15 ` John Snow
2019-06-13 19:40 ` [Qemu-devel] " Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2019-06-03 22:15 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 5/28/19 3:53 PM, Max Reitz wrote:
> img_rebase() can leak a QDict in two occasions. Fix it.
>
> Coverity: CID 1401416
> Fixes: d16699b64671466b42079c45b89127aeea1ca565
> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> qemu-img.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index b0535919b1..86e1923acf 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -3347,6 +3347,7 @@ static int img_rebase(int argc, char **argv)
> out_baseimg,
> &local_err);
> if (local_err) {
> + qobject_unref(options);
> error_reportf_err(local_err,
> "Could not resolve backing filename: ");
> ret = -1;
> @@ -3359,7 +3360,9 @@ static int img_rebase(int argc, char **argv)
> */
> prefix_chain_bs = bdrv_find_backing_image(bs, out_real_path);
> if (prefix_chain_bs) {
> + qobject_unref(options);
> g_free(out_real_path);
> +
> blk_new_backing = blk_new(BLK_PERM_CONSISTENT_READ,
> BLK_PERM_ALL);
> ret = blk_insert_bs(blk_new_backing, prefix_chain_bs,
>
I was going to ask about the other branch after this one, but:
"The reference to the QDict belongs to the block layer after the call
(even on failure)"
"Oh, well... OK."
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase()
2019-05-28 19:53 [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase() Max Reitz
2019-05-30 9:40 ` Kevin Wolf
2019-06-03 22:15 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2019-06-13 19:40 ` Max Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Max Reitz @ 2019-06-13 19:40 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]
On 28.05.19 21:53, Max Reitz wrote:
> img_rebase() can leak a QDict in two occasions. Fix it.
>
> Coverity: CID 1401416
> Fixes: d16699b64671466b42079c45b89127aeea1ca565
> Fixes: 330c72957196e0ae382abcaa97ebf4eb9bc8574f
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> qemu-img.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-13 19:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 19:53 [Qemu-devel] [PATCH] qemu-img: Fix options leakage in img_rebase() Max Reitz
2019-05-30 9:40 ` Kevin Wolf
2019-05-31 11:58 ` Max Reitz
2019-06-03 22:15 ` [Qemu-devel] [Qemu-block] " John Snow
2019-06-13 19:40 ` [Qemu-devel] " Max Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.