* [U-Boot] omap2 lowlevel_init.S quirk / question
@ 2019-05-30 23:27 Adam Ford
2019-05-31 1:47 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2019-05-30 23:27 UTC (permalink / raw)
To: u-boot
Just before ENTRY(cpy_clk_code), there is an #if statement, but it
appears to be repeated:
#if !defined(CONFIG_SYS_NAND_BOOT) && !defined(CONFIG_SYS_NAND_BOOT)
Can we remove one of these or should this be something different, like
NOR boot or something?
I can see the argument for not relocating code if you're using XIP,
but I don't have a board that works this way, so I cannot run any
tests.
adam
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] omap2 lowlevel_init.S quirk / question
2019-05-30 23:27 [U-Boot] omap2 lowlevel_init.S quirk / question Adam Ford
@ 2019-05-31 1:47 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2019-05-31 1:47 UTC (permalink / raw)
To: u-boot
On Thu, May 30, 2019 at 06:27:33PM -0500, Adam Ford wrote:
> Just before ENTRY(cpy_clk_code), there is an #if statement, but it
> appears to be repeated:
> #if !defined(CONFIG_SYS_NAND_BOOT) && !defined(CONFIG_SYS_NAND_BOOT)
>
> Can we remove one of these or should this be something different, like
> NOR boot or something?
>
> I can see the argument for not relocating code if you're using XIP,
> but I don't have a board that works this way, so I cannot run any
> tests.
My guess is it should have read ONENAND not NAND in the second case, to
match the other places.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190530/228dc90e/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-31 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30 23:27 [U-Boot] omap2 lowlevel_init.S quirk / question Adam Ford
2019-05-31 1:47 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.