* [PATCH] sched/core: add __sched tag for io_schedule()
@ 2019-05-31 8:29 Gao Xiang
2019-05-31 14:37 ` Tejun Heo
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Gao Xiang @ 2019-05-31 8:29 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar; +Cc: LKML, Gao Xiang, Tejun Heo, Peter Zijlstra
non-inline io_schedule() was introduced in
commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
Keep in line with io_schedule_timeout, Otherwise
"/proc/<pid>/wchan" will report io_schedule()
rather than its callers when waiting io.
Reported-by: Jilong Kou <koujilong@huawei.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 102dfcf0a29a..361d60423c11 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5122,7 +5122,7 @@ long __sched io_schedule_timeout(long timeout)
}
EXPORT_SYMBOL(io_schedule_timeout);
-void io_schedule(void)
+void __sched io_schedule(void)
{
int token;
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] sched/core: add __sched tag for io_schedule()
2019-05-31 8:29 [PATCH] sched/core: add __sched tag for io_schedule() Gao Xiang
@ 2019-05-31 14:37 ` Tejun Heo
2019-06-03 4:25 ` Gao Xiang
2019-06-03 8:58 ` Peter Zijlstra
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2 siblings, 1 reply; 9+ messages in thread
From: Tejun Heo @ 2019-05-31 14:37 UTC (permalink / raw)
To: Gao Xiang; +Cc: Andrew Morton, Ingo Molnar, LKML, Peter Zijlstra
On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
>
> Reported-by: Jilong Kou <koujilong@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] sched/core: add __sched tag for io_schedule()
2019-05-31 14:37 ` Tejun Heo
@ 2019-06-03 4:25 ` Gao Xiang
0 siblings, 0 replies; 9+ messages in thread
From: Gao Xiang @ 2019-06-03 4:25 UTC (permalink / raw)
To: Tejun Heo, Andrew Morton
Cc: Ingo Molnar, LKML, Peter Zijlstra, stable, Miao Xie, koujilong
On 2019/5/31 22:37, Tejun Heo wrote:
> On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
>> non-inline io_schedule() was introduced in
>> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
>> Keep in line with io_schedule_timeout, Otherwise
>> "/proc/<pid>/wchan" will report io_schedule()
>> rather than its callers when waiting io.
>>
>> Reported-by: Jilong Kou <koujilong@huawei.com>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
Cc: <stable@vger.kernel.org> # 4.11+
Thanks Tejun. This patch will be needed for io performance analysis
since we found that Android systrace tool cannot show the callers of
iowait raised from io_schedule() on linux-4.14 LTS kernel.
Hi Andrew, could you kindly take this patch?
Thanks,
Gao Xiang
>
> Thanks.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sched/core: add __sched tag for io_schedule()
2019-05-31 8:29 [PATCH] sched/core: add __sched tag for io_schedule() Gao Xiang
2019-05-31 14:37 ` Tejun Heo
@ 2019-06-03 8:58 ` Peter Zijlstra
2019-06-03 9:00 ` Gao Xiang
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2 siblings, 1 reply; 9+ messages in thread
From: Peter Zijlstra @ 2019-06-03 8:58 UTC (permalink / raw)
To: Gao Xiang; +Cc: Andrew Morton, Ingo Molnar, LKML, Tejun Heo
On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
>
> Reported-by: Jilong Kou <koujilong@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
This is lacking a Fixes: tag.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] sched/core: add __sched tag for io_schedule()
2019-06-03 8:58 ` Peter Zijlstra
@ 2019-06-03 9:00 ` Gao Xiang
0 siblings, 0 replies; 9+ messages in thread
From: Gao Xiang @ 2019-06-03 9:00 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Andrew Morton, Ingo Molnar, LKML, Tejun Heo
Hi Peter,
On 2019/6/3 16:58, Peter Zijlstra wrote:
> On Fri, May 31, 2019 at 04:29:12PM +0800, Gao Xiang wrote:
>> non-inline io_schedule() was introduced in
>> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
>> Keep in line with io_schedule_timeout, Otherwise
>> "/proc/<pid>/wchan" will report io_schedule()
>> rather than its callers when waiting io.
>>
>> Reported-by: Jilong Kou <koujilong@huawei.com>
>> Cc: Tejun Heo <tj@kernel.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>
> This is lacking a Fixes: tag.
>
OK, thanks for pointing out. It seems enough to resend this patch.
I will resend this patch with all necessary tags.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] sched/core: add __sched tag for io_schedule()
2019-05-31 8:29 [PATCH] sched/core: add __sched tag for io_schedule() Gao Xiang
2019-05-31 14:37 ` Tejun Heo
2019-06-03 8:58 ` Peter Zijlstra
@ 2019-06-03 9:13 ` Gao Xiang
2019-06-03 9:44 ` Peter Zijlstra
` (2 more replies)
2 siblings, 3 replies; 9+ messages in thread
From: Gao Xiang @ 2019-06-03 9:13 UTC (permalink / raw)
To: Andrew Morton
Cc: LKML, Tejun Heo, Ingo Molnar, Peter Zijlstra, stable, Miao Xie,
koujilong, Gao Xiang
non-inline io_schedule() was introduced in
commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
Keep in line with io_schedule_timeout, Otherwise
"/proc/<pid>/wchan" will report io_schedule()
rather than its callers when waiting io.
Reported-by: Jilong Kou <koujilong@huawei.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Acked-by: Tejun Heo <tj@kernel.org>
Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
Cc: <stable@vger.kernel.org> # 4.11+
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
---
change log v2:
- add missing tags
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 874c427742a9..4d5962232a55 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5123,7 +5123,7 @@ long __sched io_schedule_timeout(long timeout)
}
EXPORT_SYMBOL(io_schedule_timeout);
-void io_schedule(void)
+void __sched io_schedule(void)
{
int token;
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] sched/core: add __sched tag for io_schedule()
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
@ 2019-06-03 9:44 ` Peter Zijlstra
2019-06-12 11:34 ` Gao Xiang
2019-06-17 14:20 ` [tip:sched/core] sched/core: Add " tip-bot for Gao Xiang
2 siblings, 0 replies; 9+ messages in thread
From: Peter Zijlstra @ 2019-06-03 9:44 UTC (permalink / raw)
To: Gao Xiang
Cc: Andrew Morton, LKML, Tejun Heo, Ingo Molnar, stable, Miao Xie, koujilong
On Mon, Jun 03, 2019 at 05:13:38PM +0800, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
>
> Reported-by: Jilong Kou <koujilong@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Acked-by: Tejun Heo <tj@kernel.org>
> Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Cc: <stable@vger.kernel.org> # 4.11+
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] sched/core: add __sched tag for io_schedule()
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2019-06-03 9:44 ` Peter Zijlstra
@ 2019-06-12 11:34 ` Gao Xiang
2019-06-17 14:20 ` [tip:sched/core] sched/core: Add " tip-bot for Gao Xiang
2 siblings, 0 replies; 9+ messages in thread
From: Gao Xiang @ 2019-06-12 11:34 UTC (permalink / raw)
To: Andrew Morton
Cc: LKML, Tejun Heo, Ingo Molnar, Peter Zijlstra, stable, Miao Xie,
koujilong
Friendly ping...
Thanks,
Gao Xiang
On 2019/6/3 17:13, Gao Xiang wrote:
> non-inline io_schedule() was introduced in
> commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Keep in line with io_schedule_timeout, Otherwise
> "/proc/<pid>/wchan" will report io_schedule()
> rather than its callers when waiting io.
>
> Reported-by: Jilong Kou <koujilong@huawei.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Acked-by: Tejun Heo <tj@kernel.org>
> Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
> Cc: <stable@vger.kernel.org> # 4.11+
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> change log v2:
> - add missing tags
>
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 874c427742a9..4d5962232a55 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5123,7 +5123,7 @@ long __sched io_schedule_timeout(long timeout)
> }
> EXPORT_SYMBOL(io_schedule_timeout);
>
> -void io_schedule(void)
> +void __sched io_schedule(void)
> {
> int token;
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* [tip:sched/core] sched/core: Add __sched tag for io_schedule()
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2019-06-03 9:44 ` Peter Zijlstra
2019-06-12 11:34 ` Gao Xiang
@ 2019-06-17 14:20 ` tip-bot for Gao Xiang
2 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Gao Xiang @ 2019-06-17 14:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, linux-kernel, koujilong, akpm, tj, miaoxie, mingo, peterz,
gaoxiang25, tglx, torvalds
Commit-ID: e3b929b0a184edb35531153c5afcaebb09014f9d
Gitweb: https://git.kernel.org/tip/e3b929b0a184edb35531153c5afcaebb09014f9d
Author: Gao Xiang <gaoxiang25@huawei.com>
AuthorDate: Mon, 3 Jun 2019 17:13:38 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 17 Jun 2019 12:15:56 +0200
sched/core: Add __sched tag for io_schedule()
Non-inline io_schedule() was introduced in:
commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
Keep in line with io_schedule_timeout(), otherwise "/proc/<pid>/wchan" will
report io_schedule() rather than its callers when waiting for IO.
Reported-by: Jilong Kou <koujilong@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miao Xie <miaoxie@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and io_schedule_finish()")
Link: https://lkml.kernel.org/r/20190603091338.2695-1-gaoxiang25@huawei.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 29984d8c41f0..cd047927f707 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5122,7 +5122,7 @@ long __sched io_schedule_timeout(long timeout)
}
EXPORT_SYMBOL(io_schedule_timeout);
-void io_schedule(void)
+void __sched io_schedule(void)
{
int token;
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-17 14:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 8:29 [PATCH] sched/core: add __sched tag for io_schedule() Gao Xiang
2019-05-31 14:37 ` Tejun Heo
2019-06-03 4:25 ` Gao Xiang
2019-06-03 8:58 ` Peter Zijlstra
2019-06-03 9:00 ` Gao Xiang
2019-06-03 9:13 ` [PATCH v2] " Gao Xiang
2019-06-03 9:44 ` Peter Zijlstra
2019-06-12 11:34 ` Gao Xiang
2019-06-17 14:20 ` [tip:sched/core] sched/core: Add " tip-bot for Gao Xiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.