* [Qemu-devel] [PATCH 0/1] accel: get rid of AccelClass::opt_name
@ 2019-05-31 16:53 Wainer dos Santos Moschetta
2019-05-31 16:53 ` [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute Wainer dos Santos Moschetta
0 siblings, 1 reply; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2019-05-31 16:53 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, ehabkost
The AccelClass::opt_name is not used. Unless there is a reason
for keeping hat attribute, this patch remove it.
Git: https://github.com/wainersm/qemu
Branch: accel_del_opt_name
Travis: https://travis-ci.org/wainersm/qemu/builds/539721285
(Failed test case is not related with this change as well as
fails on master too.)
Wainer dos Santos Moschetta (1):
accel: Remove unused AccelClass::opt_name attribute
include/sysemu/accel.h | 1 -
1 file changed, 1 deletion(-)
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute
2019-05-31 16:53 [Qemu-devel] [PATCH 0/1] accel: get rid of AccelClass::opt_name Wainer dos Santos Moschetta
@ 2019-05-31 16:53 ` Wainer dos Santos Moschetta
2019-06-05 13:33 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2019-05-31 16:53 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, ehabkost
The AccelType type was converted to AccelClass QOM
object on b14a0b7469f, and the original data type had
a field to store the option name which in turn was
used to search an accelerator. The lookup method
(accel_find) changed too, making the option field
unnecessary but it became AccelClass::opt_name despite
that. Therefore, and given that none accelerator
implementation sets AccelClass::opt_name, let's
remove this attribute.
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
include/sysemu/accel.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
index 70e9e2f2a1..81293cdb08 100644
--- a/include/sysemu/accel.h
+++ b/include/sysemu/accel.h
@@ -36,7 +36,6 @@ typedef struct AccelClass {
ObjectClass parent_class;
/*< public >*/
- const char *opt_name;
const char *name;
int (*init_machine)(MachineState *ms);
void (*setup_post)(MachineState *ms, AccelState *accel);
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute
2019-05-31 16:53 ` [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute Wainer dos Santos Moschetta
@ 2019-06-05 13:33 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2019-06-05 13:33 UTC (permalink / raw)
To: Wainer dos Santos Moschetta; +Cc: thuth, qemu-devel
On Fri, May 31, 2019 at 12:53:34PM -0400, Wainer dos Santos Moschetta wrote:
> The AccelType type was converted to AccelClass QOM
> object on b14a0b7469f, and the original data type had
> a field to store the option name which in turn was
> used to search an accelerator. The lookup method
> (accel_find) changed too, making the option field
> unnecessary but it became AccelClass::opt_name despite
> that. Therefore, and given that none accelerator
> implementation sets AccelClass::opt_name, let's
> remove this attribute.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Queued, thanks!
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-05 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 16:53 [Qemu-devel] [PATCH 0/1] accel: get rid of AccelClass::opt_name Wainer dos Santos Moschetta
2019-05-31 16:53 ` [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute Wainer dos Santos Moschetta
2019-06-05 13:33 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.