* [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error
@ 2019-06-02 12:07 Rhys Kidd
2019-06-04 18:07 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Rhys Kidd @ 2019-06-02 12:07 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, Daniel Vetter, dri-devel, nouveau,
linux-kernel, Karol Herbst, Lyude Paul, Ilia Mirkin
Cc: Rhys Kidd
Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA
gpu is not connected directly to any outputs.
Reporting an error in this scenario is too harsh. Accordingly, change the
error message to an info message.
By default the error message also causes a boot flicker for these sytems.
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 66bf2aff4a3e..bdfadc63204a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios,
tmdstableptr = ROM16(bios->data[bitentry->offset]);
if (!tmdstableptr) {
- NV_ERROR(drm, "Pointer to TMDS table invalid\n");
+ NV_INFO(drm, "Pointer to TMDS table not found\n");
return -EINVAL;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error
2019-06-02 12:07 [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error Rhys Kidd
@ 2019-06-04 18:07 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2019-06-04 18:07 UTC (permalink / raw)
To: Rhys Kidd, Ben Skeggs, David Airlie, Daniel Vetter, dri-devel,
nouveau, linux-kernel, Karol Herbst, Ilia Mirkin
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Sun, 2019-06-02 at 22:07 +1000, Rhys Kidd wrote:
> Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA
> gpu is not connected directly to any outputs.
>
> Reporting an error in this scenario is too harsh. Accordingly, change the
> error message to an info message.
>
> By default the error message also causes a boot flicker for these sytems.
>
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
> b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 66bf2aff4a3e..bdfadc63204a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device
> *dev, struct nvbios *bios,
>
> tmdstableptr = ROM16(bios->data[bitentry->offset]);
> if (!tmdstableptr) {
> - NV_ERROR(drm, "Pointer to TMDS table invalid\n");
> + NV_INFO(drm, "Pointer to TMDS table not found\n");
> return -EINVAL;
> }
>
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02 12:07 [PATCH] drm/nouveau/bios: downgrade absence of tmds table to info from an error Rhys Kidd
2019-06-04 18:07 ` Lyude Paul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.