* [PATCH] mfd: menelaus: Remove superfluous error message
@ 2019-05-21 20:43 Alexandre Belloni
2019-06-03 12:52 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2019-05-21 20:43 UTC (permalink / raw)
To: Lee Jones; +Cc: Tony Lindgren, linux-omap, linux-kernel, Alexandre Belloni
The RTC core already has error messages in case of failure, there is no
need to have another message in the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/mfd/menelaus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index d28ebe7ecd21..91c568ef5857 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -1138,8 +1138,6 @@ static inline void menelaus_rtc_init(struct menelaus_chip *m)
menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
device_init_wakeup(&m->client->dev, 0);
}
- dev_err(&m->client->dev, "can't register RTC: %d\n",
- (int) PTR_ERR(m->rtc));
the_menelaus->rtc = NULL;
}
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: menelaus: Remove superfluous error message
2019-05-21 20:43 [PATCH] mfd: menelaus: Remove superfluous error message Alexandre Belloni
@ 2019-06-03 12:52 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2019-06-03 12:52 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Tony Lindgren, linux-omap, linux-kernel
On Tue, 21 May 2019, Alexandre Belloni wrote:
> The RTC core already has error messages in case of failure, there is no
> need to have another message in the driver.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/mfd/menelaus.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-03 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 20:43 [PATCH] mfd: menelaus: Remove superfluous error message Alexandre Belloni
2019-06-03 12:52 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.