* [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops
@ 2019-05-07 12:44 Simon Ser
2019-05-07 13:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Simon Ser @ 2019-05-07 12:44 UTC (permalink / raw)
To: igt-dev
The loop condition is never satisfied, since after filling the array i > 0. For
this reason the loop is always a no-op.
Use a more conventional loop instead.
Fixes: 964e39159c64 ("tests/i915/gem_mmap: Add invalid parameters tests")
Signed-off-by: Simon Ser <simon.ser@intel.com>
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_mmap.c | 7 ++++---
tests/i915/gem_mmap_gtt.c | 7 ++++---
tests/i915/gem_mmap_wc.c | 7 ++++---
3 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
index d1b10013a1b8..c96aa2c0a7a5 100644
--- a/tests/i915/gem_mmap.c
+++ b/tests/i915/gem_mmap.c
@@ -158,14 +158,15 @@ igt_main
igt_subtest("bad-object") {
uint32_t real_handle = gem_create(fd, 4096);
uint32_t handles[20];
- int i = 0;
+ size_t i = 0, len;
handles[i++] = 0xdeadbeef;
for(int bit = 0; bit < 16; bit++)
handles[i++] = real_handle | (1 << (bit + 16));
- handles[i] = real_handle + 1;
+ handles[i++] = real_handle + 1;
+ len = i;
- for (; i < 0; i--) {
+ for (i = 0; i < len; ++i) {
struct drm_i915_gem_mmap arg = {
.handle = handles[i],
.size = 4096,
diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 9a670f030149..034658e64990 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -886,14 +886,15 @@ igt_main
igt_subtest("bad-object") {
uint32_t real_handle = gem_create(fd, 4096);
uint32_t handles[20];
- int i = 0;
+ size_t i = 0, len;
handles[i++] = 0xdeadbeef;
for(int bit = 0; bit < 16; bit++)
handles[i++] = real_handle | (1 << (bit + 16));
- handles[i] = real_handle + 1;
+ handles[i++] = real_handle + 1;
+ len = i;
- for (; i < 0; i--) {
+ for (i = 0; i < len; ++i) {
struct drm_i915_gem_mmap_gtt arg = {
.handle = handles[i],
};
diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
index 159eedbf4cfb..63538f791aae 100644
--- a/tests/i915/gem_mmap_wc.c
+++ b/tests/i915/gem_mmap_wc.c
@@ -496,14 +496,15 @@ igt_main
igt_subtest("bad-object") {
uint32_t real_handle = gem_create(fd, 4096);
uint32_t handles[20];
- int i = 0;
+ size_t i = 0, len;
handles[i++] = 0xdeadbeef;
for(int bit = 0; bit < 16; bit++)
handles[i++] = real_handle | (1 << (bit + 16));
- handles[i] = real_handle + 1;
+ handles[i++] = real_handle + 1;
+ len = i;
- for (; i < 0; i--) {
+ for (i = 0; i < len; ++i) {
struct drm_i915_gem_mmap arg = {
.handle = handles[i],
.size = 4096,
--
2.21.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gen_mmap: fix no-op loops
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
@ 2019-05-07 13:54 ` Patchwork
2019-05-07 14:31 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-05-07 13:54 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gen_mmap: fix no-op loops
URL : https://patchwork.freedesktop.org/series/60371/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6058 -> IGTPW_2948
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2948 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- {fi-icl-y}: [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-icl-y/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-icl-y/igt@i915_selftest@live_hangcheck.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-pnv-d510: [FAIL][7] ([fdo#100368]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-pnv-d510/igt@kms_flip@basic-flip-vs-wf_vblank.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-pnv-d510/igt@kms_flip@basic-flip-vs-wf_vblank.html
#### Warnings ####
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: [INCOMPLETE][9] ([fdo#103927] / [fdo#110624]) -> [DMESG-FAIL][10] ([fdo#110620])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-apl-guc/igt@i915_selftest@live_hangcheck.html
* igt@runner@aborted:
- fi-apl-guc: [FAIL][11] ([fdo#110624]) -> [FAIL][12] ([fdo#110622])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/fi-apl-guc/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/fi-apl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110620]: https://bugs.freedesktop.org/show_bug.cgi?id=110620
[fdo#110622]: https://bugs.freedesktop.org/show_bug.cgi?id=110622
[fdo#110624]: https://bugs.freedesktop.org/show_bug.cgi?id=110624
Participating hosts (53 -> 45)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_4972 -> IGTPW_2948
CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
2019-05-07 13:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-05-07 14:31 ` Chris Wilson
2019-05-07 15:10 ` Ser, Simon
2019-05-07 18:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-05-10 15:39 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
3 siblings, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2019-05-07 14:31 UTC (permalink / raw)
To: Simon Ser, igt-dev
Quoting Simon Ser (2019-05-07 13:44:41)
> The loop condition is never satisfied, since after filling the array i > 0. For
> this reason the loop is always a no-op.
>
> Use a more conventional loop instead.
Or a classic while loop? Bad me for not reading the check was
back-to-front.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops
2019-05-07 14:31 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2019-05-07 15:10 ` Ser, Simon
2019-05-08 11:27 ` Jani Nikula
0 siblings, 1 reply; 14+ messages in thread
From: Ser, Simon @ 2019-05-07 15:10 UTC (permalink / raw)
To: igt-dev, chris
On Tue, 2019-05-07 at 15:31 +0100, Chris Wilson wrote:
> Quoting Simon Ser (2019-05-07 13:44:41)
> > The loop condition is never satisfied, since after filling the
> > array i > 0. For
> > this reason the loop is always a no-op.
> >
> > Use a more conventional loop instead.
>
> Or a classic while loop? Bad me for not reading the check was
> back-to-front.
You mean while(i--)?
I generally prioritize code clarity in these situations, hence the for
loop. Also not a fan of decrementing operators returning a value.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
2019-05-07 13:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-07 14:31 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2019-05-07 18:42 ` Patchwork
2019-05-08 9:54 ` Ser, Simon
2019-05-10 15:39 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
3 siblings, 1 reply; 14+ messages in thread
From: Patchwork @ 2019-05-07 18:42 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/i915/gen_mmap: fix no-op loops
URL : https://patchwork.freedesktop.org/series/60371/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6058_full -> IGTPW_2948_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2948_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2948_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2948_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap@bad-object:
- shard-iclb: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@gem_mmap@bad-object.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@gem_mmap@bad-object.html
- shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk7/igt@gem_mmap@bad-object.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@gem_mmap@bad-object.html
- shard-hsw: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw4/igt@gem_mmap@bad-object.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw7/igt@gem_mmap@bad-object.html
- shard-kbl: [PASS][7] -> [FAIL][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_mmap@bad-object.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl1/igt@gem_mmap@bad-object.html
* igt@gem_mmap_wc@bad-object:
- shard-apl: [PASS][9] -> [FAIL][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl5/igt@gem_mmap_wc@bad-object.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl5/igt@gem_mmap_wc@bad-object.html
- shard-snb: [PASS][11] -> [FAIL][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-snb5/igt@gem_mmap_wc@bad-object.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-snb1/igt@gem_mmap_wc@bad-object.html
Known issues
------------
Here are the changes found in IGTPW_2948_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vebox:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl6/igt@gem_workarounds@suspend-resume.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl6/igt@gem_workarounds@suspend-resume.html
* igt@kms_atomic_transition@plane-all-transition-fencing:
- shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#109052])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-fencing.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_atomic_transition@plane-all-transition-fencing.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#109247]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271] / [fdo#109278]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
* igt@kms_psr@primary_blt:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#107383] / [fdo#110215]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@primary_blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@primary_blt.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@kms_sysfs_edid_timing.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_sysfs_edid_timing.html
#### Possible fixes ####
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +9 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][35] ([fdo#105767]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-hsw: [INCOMPLETE][37] ([fdo#103540]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
- shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: [INCOMPLETE][45] ([fdo#103665]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation.html
* igt@tools_test@tools_test:
- shard-iclb: [SKIP][47] ([fdo#109352]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb4/igt@tools_test@tools_test.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@tools_test@tools_test.html
#### Warnings ####
* igt@i915_pm_rpm@i2c:
- shard-iclb: [FAIL][49] ([fdo#104097]) -> [DMESG-WARN][50] ([fdo#109982])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb1/igt@i915_pm_rpm@i2c.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@i915_pm_rpm@i2c.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-kbl: [SKIP][51] ([fdo#109271]) -> [SKIP][52] ([fdo#105602] / [fdo#109271])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [FAIL][54] ([fdo#107383] / [fdo#110215])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4972 -> IGTPW_2948
* Piglit: piglit_4509 -> None
CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-07 18:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2019-05-08 9:54 ` Ser, Simon
2019-05-20 6:26 ` Ser, Simon
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Ser, Simon @ 2019-05-08 9:54 UTC (permalink / raw)
To: igt-dev
These failures happen because of:
(gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
(gem_mmap:5289) CRITICAL: error: -2 != -22
Is this a genuine driver bug? Is the driver supposed to fail with
ENOENT or EINVAL?
On Tue, 2019-05-07 at 18:42 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: tests/i915/gen_mmap: fix no-op loops
> URL : https://patchwork.freedesktop.org/series/60371/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6058_full -> IGTPW_2948_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_2948_full absolutely need
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the
> changes
> introduced in IGTPW_2948_full, please notify your bug team to allow
> them
> to document this new failure mode, which will reduce false
> positives in CI.
>
> External URL:
> https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in
> IGTPW_2948_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@gem_mmap@bad-object:
> - shard-iclb: [PASS][1] -> [FAIL][2] +1 similar issue
> [1]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@gem_mmap@bad-object.html
> [2]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@gem_mmap@bad-object.html
> - shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
> [3]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk7/igt@gem_mmap@bad-object.html
> [4]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@gem_mmap@bad-object.html
> - shard-hsw: [PASS][5] -> [FAIL][6] +1 similar issue
> [5]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw4/igt@gem_mmap@bad-object.html
> [6]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw7/igt@gem_mmap@bad-object.html
> - shard-kbl: [PASS][7] -> [FAIL][8] +1 similar issue
> [7]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_mmap@bad-object.html
> [8]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl1/igt@gem_mmap@bad-object.html
>
> * igt@gem_mmap_wc@bad-object:
> - shard-apl: [PASS][9] -> [FAIL][10] +1 similar issue
> [9]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl5/igt@gem_mmap_wc@bad-object.html
> [10]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl5/igt@gem_mmap_wc@bad-object.html
> - shard-snb: [PASS][11] -> [FAIL][12] +1 similar issue
> [11]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-snb5/igt@gem_mmap_wc@bad-object.html
> [12]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-snb1/igt@gem_mmap_wc@bad-object.html
>
>
> Known issues
> ------------
>
> Here are the changes found in IGTPW_2948_full that come from known
> issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_ctx_exec@basic-invalid-context-vebox:
> - shard-kbl: [PASS][13] -> [DMESG-WARN][14]
> ([fdo#103558] / [fdo#105602]) +1 similar issue
> [13]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> [14]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
>
> * igt@gem_workarounds@suspend-resume:
> - shard-apl: [PASS][15] -> [DMESG-WARN][16]
> ([fdo#108566]) +3 similar issues
> [15]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl6/igt@gem_workarounds@suspend-resume.html
> [16]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl6/igt@gem_workarounds@suspend-resume.html
>
> * igt@kms_atomic_transition@plane-all-transition-fencing:
> - shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#109052])
> [17]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-fencing.html
> [18]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_atomic_transition@plane-all-transition-fencing.html
>
> * igt@kms_flip@2x-flip-vs-expired-vblank:
> - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
> [19]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
> [20]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
>
> * igt@kms
> _frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
> - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#109247]) +4
> similar issues
> [21]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> [22]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
> - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +2
> similar issues
> [23]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> [24]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
>
> * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
> - shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271] /
> [fdo#109278]) +1 similar issue
> [25]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> [26]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
>
> * igt@kms_psr@primary_blt:
> - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#107383] /
> [fdo#110215]) +2 similar issues
> [27]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@primary_blt.html
> [28]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@primary_blt.html
>
> * igt@kms_psr@psr2_sprite_mmap_cpu:
> - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1
> similar issue
> [29]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
> [30]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
>
> * igt@kms_sysfs_edid_timing:
> - shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
> [31]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@kms_sysfs_edid_timing.html
> [32]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_sysfs_edid_timing.html
>
>
> #### Possible fixes ####
>
> * igt@i915_suspend@fence-restore-untiled:
> - shard-apl: [DMESG-WARN][33] ([fdo#108566]) ->
> [PASS][34] +9 similar issues
> [33]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
> [34]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
>
> * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> - shard-hsw: [FAIL][35] ([fdo#105767]) -> [PASS][36]
> [35]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> [36]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>
> * igt@kms_flip@2x-flip-vs-suspend-interruptible:
> - shard-hsw: [INCOMPLETE][37] ([fdo#103540]) ->
> [PASS][38]
> [37]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> [38]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
>
> * igt@kms
> _frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
> - shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2
> similar issues
> [39]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> [40]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
> - shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
> [41]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> [42]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
>
> * igt@kms_psr@psr2_sprite_blt:
> - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1
> similar issue
> [43]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
> [44]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
>
> * igt@kms_rotation_crc@multiplane-rotation:
> - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) ->
> [PASS][46]
> [45]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
> [46]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation.html
>
> * igt@tools_test@tools_test:
> - shard-iclb: [SKIP][47] ([fdo#109352]) -> [PASS][48]
> [47]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb4/igt@tools_test@tools_test.html
> [48]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@tools_test@tools_test.html
>
>
> #### Warnings ####
>
> * igt@i915_pm_rpm@i2c:
> - shard-iclb: [FAIL][49] ([fdo#104097]) -> [DMESG-
> WARN][50] ([fdo#109982])
> [49]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb1/igt@i915_pm_rpm@i2c.html
> [50]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@i915_pm_rpm@i2c.html
>
> * igt@kms
> _frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
> - shard-kbl: [SKIP][51] ([fdo#109271]) -> [SKIP][52]
> ([fdo#105602] / [fdo#109271])
> [51]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> [52]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
>
> * igt@kms_psr@psr2_cursor_mmap_cpu:
> - shard-iclb: [SKIP][53] ([fdo#109441]) -> [FAIL][54]
> ([fdo#107383] / [fdo#110215])
> [53]:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
> [54]:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
>
>
> [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
> [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
> [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
>
>
> Participating hosts (10 -> 6)
> ------------------------------
>
> Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-
> j5005
>
>
> Build changes
> -------------
>
> * IGT: IGT_4972 -> IGTPW_2948
> * Piglit: piglit_4509 -> None
>
> CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops
2019-05-07 15:10 ` Ser, Simon
@ 2019-05-08 11:27 ` Jani Nikula
0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2019-05-08 11:27 UTC (permalink / raw)
To: Ser, Simon, igt-dev, chris
On Tue, 07 May 2019, "Ser, Simon" <simon.ser@intel.com> wrote:
> On Tue, 2019-05-07 at 15:31 +0100, Chris Wilson wrote:
>> Quoting Simon Ser (2019-05-07 13:44:41)
>> > The loop condition is never satisfied, since after filling the
>> > array i > 0. For
>> > this reason the loop is always a no-op.
>> >
>> > Use a more conventional loop instead.
>>
>> Or a classic while loop? Bad me for not reading the check was
>> back-to-front.
>
> You mean while(i--)?
>
> I generally prioritize code clarity in these situations, hence the for
> loop. Also not a fan of decrementing operators returning a value.
FWIW I always go for (i = 0; i < N; i++). It takes half an eyeblink for
that to sink in.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
` (2 preceding siblings ...)
2019-05-07 18:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2019-05-10 15:39 ` Antonio Argenziano
3 siblings, 0 replies; 14+ messages in thread
From: Antonio Argenziano @ 2019-05-10 15:39 UTC (permalink / raw)
To: Simon Ser, igt-dev
On 07/05/19 05:44, Simon Ser wrote:
> The loop condition is never satisfied, since after filling the array i > 0. For
> this reason the loop is always a no-op.
>
> Use a more conventional loop instead.
Ops, my bad.
Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>
I have no preference in the loop definition.
>
> Fixes: 964e39159c64 ("tests/i915/gem_mmap: Add invalid parameters tests")
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_mmap.c | 7 ++++---
> tests/i915/gem_mmap_gtt.c | 7 ++++---
> tests/i915/gem_mmap_wc.c | 7 ++++---
> 3 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
> index d1b10013a1b8..c96aa2c0a7a5 100644
> --- a/tests/i915/gem_mmap.c
> +++ b/tests/i915/gem_mmap.c
> @@ -158,14 +158,15 @@ igt_main
> igt_subtest("bad-object") {
> uint32_t real_handle = gem_create(fd, 4096);
> uint32_t handles[20];
> - int i = 0;
> + size_t i = 0, len;
>
> handles[i++] = 0xdeadbeef;
> for(int bit = 0; bit < 16; bit++)
> handles[i++] = real_handle | (1 << (bit + 16));
> - handles[i] = real_handle + 1;
> + handles[i++] = real_handle + 1;
> + len = i;
>
> - for (; i < 0; i--) {
> + for (i = 0; i < len; ++i) {
nit: go even further and just use another loop variable?
Antonio
> struct drm_i915_gem_mmap arg = {
> .handle = handles[i],
> .size = 4096,
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 9a670f030149..034658e64990 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -886,14 +886,15 @@ igt_main
> igt_subtest("bad-object") {
> uint32_t real_handle = gem_create(fd, 4096);
> uint32_t handles[20];
> - int i = 0;
> + size_t i = 0, len;
>
> handles[i++] = 0xdeadbeef;
> for(int bit = 0; bit < 16; bit++)
> handles[i++] = real_handle | (1 << (bit + 16));
> - handles[i] = real_handle + 1;
> + handles[i++] = real_handle + 1;
> + len = i;
>
> - for (; i < 0; i--) {
> + for (i = 0; i < len; ++i) {
> struct drm_i915_gem_mmap_gtt arg = {
> .handle = handles[i],
> };
> diff --git a/tests/i915/gem_mmap_wc.c b/tests/i915/gem_mmap_wc.c
> index 159eedbf4cfb..63538f791aae 100644
> --- a/tests/i915/gem_mmap_wc.c
> +++ b/tests/i915/gem_mmap_wc.c
> @@ -496,14 +496,15 @@ igt_main
> igt_subtest("bad-object") {
> uint32_t real_handle = gem_create(fd, 4096);
> uint32_t handles[20];
> - int i = 0;
> + size_t i = 0, len;
>
> handles[i++] = 0xdeadbeef;
> for(int bit = 0; bit < 16; bit++)
> handles[i++] = real_handle | (1 << (bit + 16));
> - handles[i] = real_handle + 1;
> + handles[i++] = real_handle + 1;
> + len = i;
>
> - for (; i < 0; i--) {
> + for (i = 0; i < len; ++i) {
> struct drm_i915_gem_mmap arg = {
> .handle = handles[i],
> .size = 4096,
> --
> 2.21.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-08 9:54 ` Ser, Simon
@ 2019-05-20 6:26 ` Ser, Simon
2019-05-27 15:25 ` Ser, Simon
2019-05-31 11:36 ` Ser, Simon
2 siblings, 0 replies; 14+ messages in thread
From: Ser, Simon @ 2019-05-20 6:26 UTC (permalink / raw)
To: igt-dev
Hi Chris and Antonio,
On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> These failures happen because of:
>
> (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> (gem_mmap:5289) CRITICAL: error: -2 != -22
>
> Is this a genuine driver bug? Is the driver supposed to fail with
> ENOENT or EINVAL?
Any ideas?
> On Tue, 2019-05-07 at 18:42 +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/i915/gen_mmap: fix no-op loops
> > URL : https://patchwork.freedesktop.org/series/60371/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_6058_full -> IGTPW_2948_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **FAILURE**
> >
> > Serious unknown changes coming with IGTPW_2948_full absolutely need
> > to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the
> > changes
> > introduced in IGTPW_2948_full, please notify your bug team to allow
> > them
> > to document this new failure mode, which will reduce false
> > positives in CI.
> >
> > External URL:
> > https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
> >
> > Possible new issues
> > -------------------
> >
> > Here are the unknown changes that may have been introduced in
> > IGTPW_2948_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> > * igt@gem_mmap@bad-object:
> > - shard-iclb: [PASS][1] -> [FAIL][2] +1 similar issue
> > [1]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@gem_mmap@bad-object.html
> > [2]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@gem_mmap@bad-object.html
> > - shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
> > [3]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk7/igt@gem_mmap@bad-object.html
> > [4]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@gem_mmap@bad-object.html
> > - shard-hsw: [PASS][5] -> [FAIL][6] +1 similar issue
> > [5]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw4/igt@gem_mmap@bad-object.html
> > [6]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw7/igt@gem_mmap@bad-object.html
> > - shard-kbl: [PASS][7] -> [FAIL][8] +1 similar issue
> > [7]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_mmap@bad-object.html
> > [8]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl1/igt@gem_mmap@bad-object.html
> >
> > * igt@gem_mmap_wc@bad-object:
> > - shard-apl: [PASS][9] -> [FAIL][10] +1 similar issue
> > [9]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > [10]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > - shard-snb: [PASS][11] -> [FAIL][12] +1 similar issue
> > [11]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-snb5/igt@gem_mmap_wc@bad-object.html
> > [12]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-snb1/igt@gem_mmap_wc@bad-object.html
> >
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in IGTPW_2948_full that come from known
> > issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_ctx_exec@basic-invalid-context-vebox:
> > - shard-kbl: [PASS][13] -> [DMESG-WARN][14]
> > ([fdo#103558] / [fdo#105602]) +1 similar issue
> > [13]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> > [14]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> >
> > * igt@gem_workarounds@suspend-resume:
> > - shard-apl: [PASS][15] -> [DMESG-WARN][16]
> > ([fdo#108566]) +3 similar issues
> > [15]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl6/igt@gem_workarounds@suspend-resume.html
> > [16]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl6/igt@gem_workarounds@suspend-resume.html
> >
> > * igt@kms_atomic_transition@plane-all-transition-fencing:
> > - shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#109052])
> > [17]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-fencing.html
> > [18]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_atomic_transition@plane-all-transition-fencing.html
> >
> > * igt@kms_flip@2x-flip-vs-expired-vblank:
> > - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
> > [19]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
> > [20]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
> > - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#109247]) +4
> > similar issues
> > [21]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> > [22]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> >
> > * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
> > - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +2
> > similar issues
> > [23]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> > [24]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> >
> > * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
> > - shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271] /
> > [fdo#109278]) +1 similar issue
> > [25]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> > [26]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> >
> > * igt@kms_psr@primary_blt:
> > - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#107383] /
> > [fdo#110215]) +2 similar issues
> > [27]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@primary_blt.html
> > [28]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@primary_blt.html
> >
> > * igt@kms_psr@psr2_sprite_mmap_cpu:
> > - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1
> > similar issue
> > [29]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
> > [30]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
> >
> > * igt@kms_sysfs_edid_timing:
> > - shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
> > [31]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@kms_sysfs_edid_timing.html
> > [32]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_sysfs_edid_timing.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@i915_suspend@fence-restore-untiled:
> > - shard-apl: [DMESG-WARN][33] ([fdo#108566]) ->
> > [PASS][34] +9 similar issues
> > [33]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
> > [34]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
> >
> > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> > - shard-hsw: [FAIL][35] ([fdo#105767]) -> [PASS][36]
> > [35]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > [36]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> >
> > * igt@kms_flip@2x-flip-vs-suspend-interruptible:
> > - shard-hsw: [INCOMPLETE][37] ([fdo#103540]) ->
> > [PASS][38]
> > [37]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> > [38]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
> > - shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2
> > similar issues
> > [39]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> > [40]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
> > - shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
> > [41]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> > [42]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> >
> > * igt@kms_psr@psr2_sprite_blt:
> > - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1
> > similar issue
> > [43]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
> > [44]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
> >
> > * igt@kms_rotation_crc@multiplane-rotation:
> > - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) ->
> > [PASS][46]
> > [45]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
> > [46]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation.html
> >
> > * igt@tools_test@tools_test:
> > - shard-iclb: [SKIP][47] ([fdo#109352]) -> [PASS][48]
> > [47]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb4/igt@tools_test@tools_test.html
> > [48]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@tools_test@tools_test.html
> >
> >
> > #### Warnings ####
> >
> > * igt@i915_pm_rpm@i2c:
> > - shard-iclb: [FAIL][49] ([fdo#104097]) -> [DMESG-
> > WARN][50] ([fdo#109982])
> > [49]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb1/igt@i915_pm_rpm@i2c.html
> > [50]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@i915_pm_rpm@i2c.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
> > - shard-kbl: [SKIP][51] ([fdo#109271]) -> [SKIP][52]
> > ([fdo#105602] / [fdo#109271])
> > [51]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> > [52]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> >
> > * igt@kms_psr@psr2_cursor_mmap_cpu:
> > - shard-iclb: [SKIP][53] ([fdo#109441]) -> [FAIL][54]
> > ([fdo#107383] / [fdo#110215])
> > [53]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
> > [54]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >
> >
> > [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> > [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> > [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> > [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
> > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
> > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
> > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
> > [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
> >
> >
> > Participating hosts (10 -> 6)
> > ------------------------------
> >
> > Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-
> > j5005
> >
> >
> > Build changes
> > -------------
> >
> > * IGT: IGT_4972 -> IGTPW_2948
> > * Piglit: piglit_4509 -> None
> >
> > CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> > IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-08 9:54 ` Ser, Simon
2019-05-20 6:26 ` Ser, Simon
@ 2019-05-27 15:25 ` Ser, Simon
2019-05-31 11:36 ` Ser, Simon
2 siblings, 0 replies; 14+ messages in thread
From: Ser, Simon @ 2019-05-27 15:25 UTC (permalink / raw)
To: igt-dev, Argenziano, Antonio, chris
Hi Chris and Antonio,
On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> These failures happen because of:
>
> (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> (gem_mmap:5289) CRITICAL: error: -2 != -22
>
> Is this a genuine driver bug? Is the driver supposed to fail with
> ENOENT or EINVAL?
Any ideas?
> On Tue, 2019-05-07 at 18:42 +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/i915/gen_mmap: fix no-op loops
> > URL : https://patchwork.freedesktop.org/series/60371/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_6058_full -> IGTPW_2948_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **FAILURE**
> >
> > Serious unknown changes coming with IGTPW_2948_full absolutely need
> > to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the
> > changes
> > introduced in IGTPW_2948_full, please notify your bug team to allow
> > them
> > to document this new failure mode, which will reduce false
> > positives in CI.
> >
> > External URL:
> > https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
> >
> > Possible new issues
> > -------------------
> >
> > Here are the unknown changes that may have been introduced in
> > IGTPW_2948_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> > * igt@gem_mmap@bad-object:
> > - shard-iclb: [PASS][1] -> [FAIL][2] +1 similar issue
> > [1]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@gem_mmap@bad-object.html
> > [2]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@gem_mmap@bad-object.html
> > - shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
> > [3]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk7/igt@gem_mmap@bad-object.html
> > [4]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@gem_mmap@bad-object.html
> > - shard-hsw: [PASS][5] -> [FAIL][6] +1 similar issue
> > [5]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw4/igt@gem_mmap@bad-object.html
> > [6]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw7/igt@gem_mmap@bad-object.html
> > - shard-kbl: [PASS][7] -> [FAIL][8] +1 similar issue
> > [7]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_mmap@bad-object.html
> > [8]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl1/igt@gem_mmap@bad-object.html
> >
> > * igt@gem_mmap_wc@bad-object:
> > - shard-apl: [PASS][9] -> [FAIL][10] +1 similar issue
> > [9]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > [10]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > - shard-snb: [PASS][11] -> [FAIL][12] +1 similar issue
> > [11]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-snb5/igt@gem_mmap_wc@bad-object.html
> > [12]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-snb1/igt@gem_mmap_wc@bad-object.html
> >
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in IGTPW_2948_full that come from known
> > issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_ctx_exec@basic-invalid-context-vebox:
> > - shard-kbl: [PASS][13] -> [DMESG-WARN][14]
> > ([fdo#103558] / [fdo#105602]) +1 similar issue
> > [13]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> > [14]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> >
> > * igt@gem_workarounds@suspend-resume:
> > - shard-apl: [PASS][15] -> [DMESG-WARN][16]
> > ([fdo#108566]) +3 similar issues
> > [15]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl6/igt@gem_workarounds@suspend-resume.html
> > [16]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl6/igt@gem_workarounds@suspend-resume.html
> >
> > * igt@kms_atomic_transition@plane-all-transition-fencing:
> > - shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#109052])
> > [17]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-fencing.html
> > [18]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_atomic_transition@plane-all-transition-fencing.html
> >
> > * igt@kms_flip@2x-flip-vs-expired-vblank:
> > - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
> > [19]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
> > [20]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
> > - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#109247]) +4
> > similar issues
> > [21]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> > [22]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> >
> > * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
> > - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +2
> > similar issues
> > [23]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> > [24]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> >
> > * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
> > - shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271] /
> > [fdo#109278]) +1 similar issue
> > [25]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> > [26]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> >
> > * igt@kms_psr@primary_blt:
> > - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#107383] /
> > [fdo#110215]) +2 similar issues
> > [27]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@primary_blt.html
> > [28]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@primary_blt.html
> >
> > * igt@kms_psr@psr2_sprite_mmap_cpu:
> > - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1
> > similar issue
> > [29]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
> > [30]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
> >
> > * igt@kms_sysfs_edid_timing:
> > - shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
> > [31]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@kms_sysfs_edid_timing.html
> > [32]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_sysfs_edid_timing.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@i915_suspend@fence-restore-untiled:
> > - shard-apl: [DMESG-WARN][33] ([fdo#108566]) ->
> > [PASS][34] +9 similar issues
> > [33]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
> > [34]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
> >
> > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> > - shard-hsw: [FAIL][35] ([fdo#105767]) -> [PASS][36]
> > [35]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > [36]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> >
> > * igt@kms_flip@2x-flip-vs-suspend-interruptible:
> > - shard-hsw: [INCOMPLETE][37] ([fdo#103540]) ->
> > [PASS][38]
> > [37]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> > [38]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
> > - shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2
> > similar issues
> > [39]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> > [40]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
> > - shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
> > [41]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> > [42]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> >
> > * igt@kms_psr@psr2_sprite_blt:
> > - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1
> > similar issue
> > [43]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
> > [44]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
> >
> > * igt@kms_rotation_crc@multiplane-rotation:
> > - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) ->
> > [PASS][46]
> > [45]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
> > [46]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation.html
> >
> > * igt@tools_test@tools_test:
> > - shard-iclb: [SKIP][47] ([fdo#109352]) -> [PASS][48]
> > [47]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb4/igt@tools_test@tools_test.html
> > [48]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@tools_test@tools_test.html
> >
> >
> > #### Warnings ####
> >
> > * igt@i915_pm_rpm@i2c:
> > - shard-iclb: [FAIL][49] ([fdo#104097]) -> [DMESG-
> > WARN][50] ([fdo#109982])
> > [49]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb1/igt@i915_pm_rpm@i2c.html
> > [50]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@i915_pm_rpm@i2c.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
> > - shard-kbl: [SKIP][51] ([fdo#109271]) -> [SKIP][52]
> > ([fdo#105602] / [fdo#109271])
> > [51]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> > [52]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> >
> > * igt@kms_psr@psr2_cursor_mmap_cpu:
> > - shard-iclb: [SKIP][53] ([fdo#109441]) -> [FAIL][54]
> > ([fdo#107383] / [fdo#110215])
> > [53]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
> > [54]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >
> >
> > [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> > [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> > [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> > [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
> > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
> > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
> > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
> > [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
> >
> >
> > Participating hosts (10 -> 6)
> > ------------------------------
> >
> > Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-
> > j5005
> >
> >
> > Build changes
> > -------------
> >
> > * IGT: IGT_4972 -> IGTPW_2948
> > * Piglit: piglit_4509 -> None
> >
> > CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> > IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-08 9:54 ` Ser, Simon
2019-05-20 6:26 ` Ser, Simon
2019-05-27 15:25 ` Ser, Simon
@ 2019-05-31 11:36 ` Ser, Simon
2019-05-31 11:41 ` Chris Wilson
2 siblings, 1 reply; 14+ messages in thread
From: Ser, Simon @ 2019-05-31 11:36 UTC (permalink / raw)
To: igt-dev
Hi Martin,
On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> These failures happen because of:
>
> (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> (gem_mmap:5289) CRITICAL: error: -2 != -22
>
> Is this a genuine driver bug? Is the driver supposed to fail with
> ENOENT or EINVAL?
The authors haven't replied, so could we file a bug for this? Discussed
with Arek, the correct sequence of actions would be:
- Open a new bug, setup filters
- Push the change
Can I open the bug and let you setup filters?
> On Tue, 2019-05-07 at 18:42 +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: tests/i915/gen_mmap: fix no-op loops
> > URL : https://patchwork.freedesktop.org/series/60371/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_6058_full -> IGTPW_2948_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **FAILURE**
> >
> > Serious unknown changes coming with IGTPW_2948_full absolutely need
> > to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the
> > changes
> > introduced in IGTPW_2948_full, please notify your bug team to allow
> > them
> > to document this new failure mode, which will reduce false
> > positives in CI.
> >
> > External URL:
> > https://patchwork.freedesktop.org/api/1.0/series/60371/revisions/1/mbox/
> >
> > Possible new issues
> > -------------------
> >
> > Here are the unknown changes that may have been introduced in
> > IGTPW_2948_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> > * igt@gem_mmap@bad-object:
> > - shard-iclb: [PASS][1] -> [FAIL][2] +1 similar issue
> > [1]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@gem_mmap@bad-object.html
> > [2]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@gem_mmap@bad-object.html
> > - shard-glk: [PASS][3] -> [FAIL][4] +1 similar issue
> > [3]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk7/igt@gem_mmap@bad-object.html
> > [4]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@gem_mmap@bad-object.html
> > - shard-hsw: [PASS][5] -> [FAIL][6] +1 similar issue
> > [5]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw4/igt@gem_mmap@bad-object.html
> > [6]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw7/igt@gem_mmap@bad-object.html
> > - shard-kbl: [PASS][7] -> [FAIL][8] +1 similar issue
> > [7]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_mmap@bad-object.html
> > [8]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl1/igt@gem_mmap@bad-object.html
> >
> > * igt@gem_mmap_wc@bad-object:
> > - shard-apl: [PASS][9] -> [FAIL][10] +1 similar issue
> > [9]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > [10]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl5/igt@gem_mmap_wc@bad-object.html
> > - shard-snb: [PASS][11] -> [FAIL][12] +1 similar issue
> > [11]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-snb5/igt@gem_mmap_wc@bad-object.html
> > [12]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-snb1/igt@gem_mmap_wc@bad-object.html
> >
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in IGTPW_2948_full that come from known
> > issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_ctx_exec@basic-invalid-context-vebox:
> > - shard-kbl: [PASS][13] -> [DMESG-WARN][14]
> > ([fdo#103558] / [fdo#105602]) +1 similar issue
> > [13]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> > [14]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@gem_ctx_exec@basic-invalid-context-vebox.html
> >
> > * igt@gem_workarounds@suspend-resume:
> > - shard-apl: [PASS][15] -> [DMESG-WARN][16]
> > ([fdo#108566]) +3 similar issues
> > [15]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl6/igt@gem_workarounds@suspend-resume.html
> > [16]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl6/igt@gem_workarounds@suspend-resume.html
> >
> > * igt@kms_atomic_transition@plane-all-transition-fencing:
> > - shard-kbl: [PASS][17] -> [FAIL][18] ([fdo#109052])
> > [17]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl2/igt@kms_atomic_transition@plane-all-transition-fencing.html
> > [18]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_atomic_transition@plane-all-transition-fencing.html
> >
> > * igt@kms_flip@2x-flip-vs-expired-vblank:
> > - shard-glk: [PASS][19] -> [FAIL][20] ([fdo#105363])
> > [19]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank.html
> > [20]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt:
> > - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#109247]) +4
> > similar issues
> > [21]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> > [22]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt.html
> >
> > * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
> > - shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +2
> > similar issues
> > [23]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> > [24]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
> >
> > * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
> > - shard-glk: [PASS][25] -> [SKIP][26] ([fdo#109271] /
> > [fdo#109278]) +1 similar issue
> > [25]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> > [26]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> >
> > * igt@kms_psr@primary_blt:
> > - shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#107383] /
> > [fdo#110215]) +2 similar issues
> > [27]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@primary_blt.html
> > [28]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@primary_blt.html
> >
> > * igt@kms_psr@psr2_sprite_mmap_cpu:
> > - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1
> > similar issue
> > [29]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
> > [30]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
> >
> > * igt@kms_sysfs_edid_timing:
> > - shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#100047])
> > [31]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb5/igt@kms_sysfs_edid_timing.html
> > [32]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_sysfs_edid_timing.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@i915_suspend@fence-restore-untiled:
> > - shard-apl: [DMESG-WARN][33] ([fdo#108566]) ->
> > [PASS][34] +9 similar issues
> > [33]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
> > [34]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
> >
> > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
> > - shard-hsw: [FAIL][35] ([fdo#105767]) -> [PASS][36]
> > [35]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> > [36]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
> >
> > * igt@kms_flip@2x-flip-vs-suspend-interruptible:
> > - shard-hsw: [INCOMPLETE][37] ([fdo#103540]) ->
> > [PASS][38]
> > [37]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> > [38]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-hsw5/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
> > - shard-iclb: [FAIL][39] ([fdo#103167]) -> [PASS][40] +2
> > similar issues
> > [39]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> > [40]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
> > - shard-glk: [FAIL][41] ([fdo#103167]) -> [PASS][42]
> > [41]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> > [42]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
> >
> > * igt@kms_psr@psr2_sprite_blt:
> > - shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1
> > similar issue
> > [43]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
> > [44]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
> >
> > * igt@kms_rotation_crc@multiplane-rotation:
> > - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) ->
> > [PASS][46]
> > [45]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation.html
> > [46]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl3/igt@kms_rotation_crc@multiplane-rotation.html
> >
> > * igt@tools_test@tools_test:
> > - shard-iclb: [SKIP][47] ([fdo#109352]) -> [PASS][48]
> > [47]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb4/igt@tools_test@tools_test.html
> > [48]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb5/igt@tools_test@tools_test.html
> >
> >
> > #### Warnings ####
> >
> > * igt@i915_pm_rpm@i2c:
> > - shard-iclb: [FAIL][49] ([fdo#104097]) -> [DMESG-
> > WARN][50] ([fdo#109982])
> > [49]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb1/igt@i915_pm_rpm@i2c.html
> > [50]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@i915_pm_rpm@i2c.html
> >
> > * igt@kms
> > _frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
> > - shard-kbl: [SKIP][51] ([fdo#109271]) -> [SKIP][52]
> > ([fdo#105602] / [fdo#109271])
> > [51]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-kbl1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> > [52]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-kbl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
> >
> > * igt@kms_psr@psr2_cursor_mmap_cpu:
> > - shard-iclb: [SKIP][53] ([fdo#109441]) -> [FAIL][54]
> > ([fdo#107383] / [fdo#110215])
> > [53]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6058/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
> > [54]:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> >
> >
> > [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
> > [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> > [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
> > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
> > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> > [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
> > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> > [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
> > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > [fdo#109352]: https://bugs.freedesktop.org/show_bug.cgi?id=109352
> > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
> > [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
> >
> >
> > Participating hosts (10 -> 6)
> > ------------------------------
> >
> > Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-
> > j5005
> >
> >
> > Build changes
> > -------------
> >
> > * IGT: IGT_4972 -> IGTPW_2948
> > * Piglit: piglit_4509 -> None
> >
> > CI_DRM_6058: ebfcf73f5c4c6967e886b60356fbf2784b53cccb @
> > git://anongit.freedesktop.org/gfx-ci/linux
> > IGTPW_2948: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> > IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @
> > git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> > git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see:
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2948/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-31 11:36 ` Ser, Simon
@ 2019-05-31 11:41 ` Chris Wilson
2019-05-31 11:52 ` Ser, Simon
0 siblings, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2019-05-31 11:41 UTC (permalink / raw)
To: Ser, Simon, igt-dev
Quoting Ser, Simon (2019-05-31 12:36:26)
> Hi Martin,
>
> On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> > These failures happen because of:
> >
> > (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> > (gem_mmap:5289) CRITICAL: error: -2 != -22
> >
> > Is this a genuine driver bug? Is the driver supposed to fail with
> > ENOENT or EINVAL?
>
> The authors haven't replied, so could we file a bug for this? Discussed
> with Arek, the correct sequence of actions would be:
Don't knowingly push a broken test purporting to fix one breakage. The
test is wrong.
You have git and could have checked that ENOENT was the ABI we settled
on in
commit bf79cb914dbfe848add8bb76cbb8ff89110d29ff
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Aug 4 14:19:46 2010 +0100
drm: Use ENOENT consistently for the error return for an unmatched handle.
This is consistent with trying to access a filename that not exist
within a directory which is a good analogy here. The main reason for the
change is that it is easy to confuse the error code of EBADF as an
performing an ioctl on an invalid file descriptor (rather than an
unknown object).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
after being told not to EBADF.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-31 11:41 ` Chris Wilson
@ 2019-05-31 11:52 ` Ser, Simon
2019-06-03 15:18 ` Daniel Vetter
0 siblings, 1 reply; 14+ messages in thread
From: Ser, Simon @ 2019-05-31 11:52 UTC (permalink / raw)
To: igt-dev, chris
On Fri, 2019-05-31 at 12:41 +0100, Chris Wilson wrote:
> Quoting Ser, Simon (2019-05-31 12:36:26)
> > Hi Martin,
> >
> > On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> > > These failures happen because of:
> > >
> > > (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> > > (gem_mmap:5289) CRITICAL: error: -2 != -22
> > >
> > > Is this a genuine driver bug? Is the driver supposed to fail with
> > > ENOENT or EINVAL?
> >
> > The authors haven't replied, so could we file a bug for this? Discussed
> > with Arek, the correct sequence of actions would be:
>
> Don't knowingly push a broken test purporting to fix one breakage. The
> test is wrong.
A test that fails is better than a test that silently does nothing. At
least we know it's broken.
> You have git and could have checked that ENOENT was the ABI we settled
> on in
>
> commit bf79cb914dbfe848add8bb76cbb8ff89110d29ff
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Aug 4 14:19:46 2010 +0100
>
> drm: Use ENOENT consistently for the error return for an unmatched handle.
>
> This is consistent with trying to access a filename that not exist
> within a directory which is a good analogy here. The main reason for the
> change is that it is easy to confuse the error code of EBADF as an
> performing an ioctl on an invalid file descriptor (rather than an
> unknown object).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
>
> after being told not to EBADF.
I have absolutely no idea how I could've find this 2010 commit. But,
thanks to your reply, at least I can write a fix now. Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
2019-05-31 11:52 ` Ser, Simon
@ 2019-06-03 15:18 ` Daniel Vetter
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Vetter @ 2019-06-03 15:18 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
On Fri, May 31, 2019 at 11:52:45AM +0000, Ser, Simon wrote:
> On Fri, 2019-05-31 at 12:41 +0100, Chris Wilson wrote:
> > Quoting Ser, Simon (2019-05-31 12:36:26)
> > > Hi Martin,
> > >
> > > On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> > > > These failures happen because of:
> > > >
> > > > (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> > > > (gem_mmap:5289) CRITICAL: error: -2 != -22
> > > >
> > > > Is this a genuine driver bug? Is the driver supposed to fail with
> > > > ENOENT or EINVAL?
> > >
> > > The authors haven't replied, so could we file a bug for this? Discussed
> > > with Arek, the correct sequence of actions would be:
> >
> > Don't knowingly push a broken test purporting to fix one breakage. The
> > test is wrong.
>
> A test that fails is better than a test that silently does nothing. At
> least we know it's broken.
>
> > You have git and could have checked that ENOENT was the ABI we settled
> > on in
> >
> > commit bf79cb914dbfe848add8bb76cbb8ff89110d29ff
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date: Wed Aug 4 14:19:46 2010 +0100
> >
> > drm: Use ENOENT consistently for the error return for an unmatched handle.
> >
> > This is consistent with trying to access a filename that not exist
> > within a directory which is a good analogy here. The main reason for the
> > change is that it is easy to confuse the error code of EBADF as an
> > performing an ioctl on an invalid file descriptor (rather than an
> > unknown object).
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> >
> > after being told not to EBADF.
>
> I have absolutely no idea how I could've find this 2010 commit. But,
> thanks to your reply, at least I can write a fix now. Thanks!
We documented error code best practices since then:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-06-03 15:18 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
2019-05-07 13:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-07 14:31 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-05-07 15:10 ` Ser, Simon
2019-05-08 11:27 ` Jani Nikula
2019-05-07 18:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-05-08 9:54 ` Ser, Simon
2019-05-20 6:26 ` Ser, Simon
2019-05-27 15:25 ` Ser, Simon
2019-05-31 11:36 ` Ser, Simon
2019-05-31 11:41 ` Chris Wilson
2019-05-31 11:52 ` Ser, Simon
2019-06-03 15:18 ` Daniel Vetter
2019-05-10 15:39 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.