All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL
@ 2019-06-03 16:08 ` Julien Grall
  0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2019-06-03 16:08 UTC (permalink / raw)
  To: xen-devel; +Cc: Oleksandr_Tyshchenko, Julien Grall, sstabellini, Andrii_Anisov

There are a few places in include/public/arch-arm.h that are still
suffixing immediate with ULL instead of using xen_mk_ullong.

The latter allows a consumer to easily tweak the header if ULL is not
supported.

So switch the remaining users of ULL to xen_mk_ullong.

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/include/public/arch-arm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index eb424e8286..f550137089 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
 /* ACPI tables physical address */
-#define GUEST_ACPI_BASE 0x20000000ULL
-#define GUEST_ACPI_SIZE 0x02000000ULL
+#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
+#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
 
 /* PL011 mappings */
-#define GUEST_PL011_BASE    0x22000000ULL
-#define GUEST_PL011_SIZE    0x00001000ULL
+#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
+#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL
@ 2019-06-03 16:08 ` Julien Grall
  0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2019-06-03 16:08 UTC (permalink / raw)
  To: xen-devel; +Cc: Oleksandr_Tyshchenko, Julien Grall, sstabellini, Andrii_Anisov

There are a few places in include/public/arch-arm.h that are still
suffixing immediate with ULL instead of using xen_mk_ullong.

The latter allows a consumer to easily tweak the header if ULL is not
supported.

So switch the remaining users of ULL to xen_mk_ullong.

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/include/public/arch-arm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index eb424e8286..f550137089 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
 
 /* ACPI tables physical address */
-#define GUEST_ACPI_BASE 0x20000000ULL
-#define GUEST_ACPI_SIZE 0x02000000ULL
+#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
+#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
 
 /* PL011 mappings */
-#define GUEST_PL011_BASE    0x22000000ULL
-#define GUEST_PL011_SIZE    0x00001000ULL
+#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
+#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
 
 /*
  * 16MB == 4096 pages reserved for guest to use as a region to map its
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL
  2019-06-03 16:08 ` [Xen-devel] " Julien Grall
  (?)
@ 2019-06-26 10:49 ` Julien Grall
  -1 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2019-06-26 10:49 UTC (permalink / raw)
  To: xen-devel; +Cc: Oleksandr_Tyshchenko, sstabellini, Andrii_Anisov

Hi,

Gentle ping.

Cheers,

On 03/06/2019 17:08, Julien Grall wrote:
> There are a few places in include/public/arch-arm.h that are still
> suffixing immediate with ULL instead of using xen_mk_ullong.
> 
> The latter allows a consumer to easily tweak the header if ULL is not
> supported.
> 
> So switch the remaining users of ULL to xen_mk_ullong.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> ---
>   xen/include/public/arch-arm.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index eb424e8286..f550137089 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -407,12 +407,12 @@ typedef uint64_t xen_callback_t;
>   #define GUEST_GICV3_GICR0_SIZE     xen_mk_ullong(0x01000000)
>   
>   /* ACPI tables physical address */
> -#define GUEST_ACPI_BASE 0x20000000ULL
> -#define GUEST_ACPI_SIZE 0x02000000ULL
> +#define GUEST_ACPI_BASE xen_mk_ullong(0x20000000)
> +#define GUEST_ACPI_SIZE xen_mk_ullong(0x02000000)
>   
>   /* PL011 mappings */
> -#define GUEST_PL011_BASE    0x22000000ULL
> -#define GUEST_PL011_SIZE    0x00001000ULL
> +#define GUEST_PL011_BASE    xen_mk_ullong(0x22000000)
> +#define GUEST_PL011_SIZE    xen_mk_ullong(0x00001000)
>   
>   /*
>    * 16MB == 4096 pages reserved for guest to use as a region to map its
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL
  2019-06-03 16:08 ` [Xen-devel] " Julien Grall
  (?)
  (?)
@ 2019-06-26 11:40 ` Alexandru Stefan ISAILA
  2019-07-29 20:42   ` Stefano Stabellini
  -1 siblings, 1 reply; 5+ messages in thread
From: Alexandru Stefan ISAILA @ 2019-06-26 11:40 UTC (permalink / raw)
  To: Julien Grall, xen-devel; +Cc: Oleksandr_Tyshchenko, sstabellini, Andrii_Anisov


Looks good to me

> There are a few places in include/public/arch-arm.h that are still
> suffixing immediate with ULL instead of using xen_mk_ullong.
> 
> The latter allows a consumer to easily tweak the header if ULL is not
> supported.
> 
> So switch the remaining users of ULL to xen_mk_ullong.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Alexandru Isaila <aisaila@bitdefender.com>

Cheers
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL
  2019-06-26 11:40 ` Alexandru Stefan ISAILA
@ 2019-07-29 20:42   ` Stefano Stabellini
  0 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2019-07-29 20:42 UTC (permalink / raw)
  To: Alexandru Stefan ISAILA
  Cc: xen-devel, Julien Grall, sstabellini, Andrii_Anisov,
	Oleksandr_Tyshchenko

On Wed, 26 Jun 2019, Alexandru Stefan ISAILA wrote:
> Looks good to me
> 
> > There are a few places in include/public/arch-arm.h that are still
> > suffixing immediate with ULL instead of using xen_mk_ullong.
> > 
> > The latter allows a consumer to easily tweak the header if ULL is not
> > supported.
> > 
> > So switch the remaining users of ULL to xen_mk_ullong.
> > 
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> 
> Reviewed-by: Alexandru Isaila <aisaila@bitdefender.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-29 20:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 16:08 [PATCH] xen/public: arch-arm: Use xen_mk_ullong instead of suffixing value with ULL Julien Grall
2019-06-03 16:08 ` [Xen-devel] " Julien Grall
2019-06-26 10:49 ` Julien Grall
2019-06-26 11:40 ` Alexandru Stefan ISAILA
2019-07-29 20:42   ` Stefano Stabellini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.