From: Steven Rostedt <rostedt@goodmis.org> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: David Woodhouse <dwmw2@infradead.org>, Joerg Roedel <joro@8bytes.org>, Bjorn Helgaas <bhelgaas@google.com>, Christoph Hellwig <hch@lst.de>, ashok.raj@intel.com, jacob.jun.pan@intel.com, alan.cox@intel.com, kevin.tian@intel.com, mika.westerberg@linux.intel.com, Ingo Molnar <mingo@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, pengfei.xu@intel.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, Jonathan Corbet <corbet@lwn.net>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan <jacob.jun.pan@linux.intel.com> Subject: Re: [PATCH v4 7/9] iommu/vt-d: Add trace events for domain map/unmap Date: Tue, 4 Jun 2019 05:01:22 -0400 [thread overview] Message-ID: <20190604050122.4a095569@oasis.local.home> (raw) In-Reply-To: <20190603011620.31999-8-baolu.lu@linux.intel.com> On Mon, 3 Jun 2019 09:16:18 +0800 Lu Baolu <baolu.lu@linux.intel.com> wrote: > +TRACE_EVENT(bounce_unmap_single, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), > + > + TP_ARGS(dev, dev_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(dma_addr_t, dev_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->dev_addr = dev_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s dev_addr=0x%llx size=%zu", > + __get_str(dev_name), > + (unsigned long long)__entry->dev_addr, > + __entry->size) > +); > + > +TRACE_EVENT(bounce_map_sg, > + TP_PROTO(struct device *dev, unsigned int i, unsigned int nelems, > + dma_addr_t dev_addr, phys_addr_t phys_addr, size_t size), > + > + TP_ARGS(dev, i, nelems, dev_addr, phys_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(unsigned int, i) > + __field(unsigned int, last) > + __field(dma_addr_t, dev_addr) > + __field(phys_addr_t, phys_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->i = i; > + __entry->last = nelems - 1; > + __entry->dev_addr = dev_addr; > + __entry->phys_addr = phys_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s elem=%u/%u dev_addr=0x%llx phys_addr=0x%llx size=%zu", > + __get_str(dev_name), __entry->i, __entry->last, > + (unsigned long long)__entry->dev_addr, > + (unsigned long long)__entry->phys_addr, > + __entry->size) > +); > + > +TRACE_EVENT(bounce_unmap_sg, > + TP_PROTO(struct device *dev, unsigned int i, unsigned int nelems, > + dma_addr_t dev_addr, phys_addr_t phys_addr, size_t size), > + > + TP_ARGS(dev, i, nelems, dev_addr, phys_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(unsigned int, i) > + __field(unsigned int, last) > + __field(dma_addr_t, dev_addr) > + __field(phys_addr_t, phys_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->i = i; > + __entry->last = nelems - 1; > + __entry->dev_addr = dev_addr; > + __entry->phys_addr = phys_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s elem=%u/%u dev_addr=0x%llx phys_addr=0x%llx size=%zu", > + __get_str(dev_name), __entry->i, __entry->last, > + (unsigned long long)__entry->dev_addr, > + (unsigned long long)__entry->phys_addr, > + __entry->size) > +); These last two events look identical. Please use the DECLARE_EVENT_CLASS() to describe the event and then DEFINE_EVENT() for the two events. Each TRACE_EVENT() can add up to 5k of data/text, where as a DEFINE_EVENT() just adds around 250 bytes. (Note, a TRACE_EVENT() is defined as a DECLARE_EVENT_CLASS()/DEFINE_EVENT() pair) -- Steve > +#endif /* _TRACE_INTEL_IOMMU_H */ > + > +/* This part must be outside protection */ > +#include <trace/define_trace.h>
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: alan.cox@intel.com, Christoph Hellwig <hch@lst.de>, Stefano Stabellini <sstabellini@kernel.org>, ashok.raj@intel.com, Jonathan Corbet <corbet@lwn.net>, pengfei.xu@intel.com, Ingo Molnar <mingo@redhat.com>, David Woodhouse <dwmw2@infradead.org>, kevin.tian@intel.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Bjorn Helgaas <bhelgaas@google.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, mika.westerberg@linux.intel.com, Juergen Gross <jgross@suse.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jacob.jun.pan@intel.com, Robin Murphy <robin.murphy@arm.com> Subject: Re: [PATCH v4 7/9] iommu/vt-d: Add trace events for domain map/unmap Date: Tue, 4 Jun 2019 05:01:22 -0400 [thread overview] Message-ID: <20190604050122.4a095569@oasis.local.home> (raw) In-Reply-To: <20190603011620.31999-8-baolu.lu@linux.intel.com> On Mon, 3 Jun 2019 09:16:18 +0800 Lu Baolu <baolu.lu@linux.intel.com> wrote: > +TRACE_EVENT(bounce_unmap_single, > + TP_PROTO(struct device *dev, dma_addr_t dev_addr, size_t size), > + > + TP_ARGS(dev, dev_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(dma_addr_t, dev_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->dev_addr = dev_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s dev_addr=0x%llx size=%zu", > + __get_str(dev_name), > + (unsigned long long)__entry->dev_addr, > + __entry->size) > +); > + > +TRACE_EVENT(bounce_map_sg, > + TP_PROTO(struct device *dev, unsigned int i, unsigned int nelems, > + dma_addr_t dev_addr, phys_addr_t phys_addr, size_t size), > + > + TP_ARGS(dev, i, nelems, dev_addr, phys_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(unsigned int, i) > + __field(unsigned int, last) > + __field(dma_addr_t, dev_addr) > + __field(phys_addr_t, phys_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->i = i; > + __entry->last = nelems - 1; > + __entry->dev_addr = dev_addr; > + __entry->phys_addr = phys_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s elem=%u/%u dev_addr=0x%llx phys_addr=0x%llx size=%zu", > + __get_str(dev_name), __entry->i, __entry->last, > + (unsigned long long)__entry->dev_addr, > + (unsigned long long)__entry->phys_addr, > + __entry->size) > +); > + > +TRACE_EVENT(bounce_unmap_sg, > + TP_PROTO(struct device *dev, unsigned int i, unsigned int nelems, > + dma_addr_t dev_addr, phys_addr_t phys_addr, size_t size), > + > + TP_ARGS(dev, i, nelems, dev_addr, phys_addr, size), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(unsigned int, i) > + __field(unsigned int, last) > + __field(dma_addr_t, dev_addr) > + __field(phys_addr_t, phys_addr) > + __field(size_t, size) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name(dev)); > + __entry->i = i; > + __entry->last = nelems - 1; > + __entry->dev_addr = dev_addr; > + __entry->phys_addr = phys_addr; > + __entry->size = size; > + ), > + > + TP_printk("dev=%s elem=%u/%u dev_addr=0x%llx phys_addr=0x%llx size=%zu", > + __get_str(dev_name), __entry->i, __entry->last, > + (unsigned long long)__entry->dev_addr, > + (unsigned long long)__entry->phys_addr, > + __entry->size) > +); These last two events look identical. Please use the DECLARE_EVENT_CLASS() to describe the event and then DEFINE_EVENT() for the two events. Each TRACE_EVENT() can add up to 5k of data/text, where as a DEFINE_EVENT() just adds around 250 bytes. (Note, a TRACE_EVENT() is defined as a DECLARE_EVENT_CLASS()/DEFINE_EVENT() pair) -- Steve > +#endif /* _TRACE_INTEL_IOMMU_H */ > + > +/* This part must be outside protection */ > +#include <trace/define_trace.h> _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-06-04 9:01 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-03 1:16 [PATCH v4 0/9] iommu: Bounce page for untrusted devices Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 1/9] PCI: Add dev_is_untrusted helper Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 2/9] swiotlb: Split size parameter to map/unmap APIs Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 3/9] swiotlb: Zero out bounce buffer for untrusted device Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-10 15:45 ` Konrad Rzeszutek Wilk 2019-06-10 15:45 ` Konrad Rzeszutek Wilk 2019-06-12 0:43 ` Lu Baolu 2019-06-12 0:43 ` Lu Baolu 2019-06-12 1:05 ` Konrad Rzeszutek Wilk 2019-06-12 1:05 ` Konrad Rzeszutek Wilk 2019-06-12 3:08 ` Lu Baolu 2019-06-12 3:08 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 4/9] iommu: Add bounce page APIs Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-10 15:56 ` Konrad Rzeszutek Wilk 2019-06-10 15:56 ` Konrad Rzeszutek Wilk 2019-06-12 0:45 ` Lu Baolu 2019-06-12 0:45 ` Lu Baolu 2019-06-11 12:10 ` Pavel Begunkov 2019-06-11 12:10 ` Pavel Begunkov 2019-06-12 0:52 ` Lu Baolu 2019-06-12 0:52 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 5/9] iommu/vt-d: Don't switch off swiotlb if use direct dma Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-10 15:54 ` Konrad Rzeszutek Wilk 2019-06-10 15:54 ` Konrad Rzeszutek Wilk 2019-06-12 2:03 ` Lu Baolu 2019-06-12 2:03 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 6/9] iommu/vt-d: Check whether device requires bounce buffer Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-10 16:08 ` Konrad Rzeszutek Wilk 2019-06-10 16:08 ` Konrad Rzeszutek Wilk 2019-06-12 2:22 ` Lu Baolu 2019-06-12 2:22 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 7/9] iommu/vt-d: Add trace events for domain map/unmap Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-04 9:01 ` Steven Rostedt [this message] 2019-06-04 9:01 ` Steven Rostedt 2019-06-05 6:48 ` Lu Baolu 2019-06-05 6:48 ` Lu Baolu 2019-06-10 16:08 ` Konrad Rzeszutek Wilk 2019-06-10 16:08 ` Konrad Rzeszutek Wilk 2019-06-12 2:31 ` Lu Baolu 2019-06-12 2:31 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 8/9] iommu/vt-d: Code refactoring for bounce map and unmap Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-03 1:16 ` [PATCH v4 9/9] iommu/vt-d: Use bounce buffer for untrusted devices Lu Baolu 2019-06-03 1:16 ` Lu Baolu 2019-06-10 15:42 ` [PATCH v4 0/9] iommu: Bounce page " Konrad Rzeszutek Wilk 2019-06-10 15:42 ` Konrad Rzeszutek Wilk 2019-06-12 3:00 ` Lu Baolu 2019-06-12 3:00 ` Lu Baolu 2019-06-12 6:22 ` Mika Westerberg 2019-06-12 6:22 ` Mika Westerberg 2019-06-10 16:10 ` Konrad Rzeszutek Wilk 2019-06-10 16:10 ` Konrad Rzeszutek Wilk 2019-06-12 3:04 ` Lu Baolu 2019-06-12 3:04 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190604050122.4a095569@oasis.local.home \ --to=rostedt@goodmis.org \ --cc=alan.cox@intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=bhelgaas@google.com \ --cc=boris.ostrovsky@oracle.com \ --cc=corbet@lwn.net \ --cc=dwmw2@infradead.org \ --cc=gregkh@linuxfoundation.org \ --cc=hch@lst.de \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jgross@suse.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mika.westerberg@linux.intel.com \ --cc=mingo@redhat.com \ --cc=pengfei.xu@intel.com \ --cc=robin.murphy@arm.com \ --cc=sstabellini@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.