From: Maxime Ripard <maxime.ripard@bootlin.com>
To: codekipper@gmail.com
Cc: wens@csie.org, linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
broonie@kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, be17068@iperbole.bo.it
Subject: Re: [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample
Date: Tue, 4 Jun 2019 09:43:01 +0200 [thread overview]
Message-ID: <20190604074301.p27e5towgehmraoy@flea> (raw)
In-Reply-To: <20190603174735.21002-4-codekipper@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Mon, Jun 03, 2019 at 07:47:29PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs this is set by default to transfer a 0 after
Which SoCs?
> each sample in each slot. However the platform that this driver
Which platform?
> was developed on had the default setting where it padded the audio
> gain with zeros. This isn't a problem whilst we have only support
> for 16bit audio but with larger sample resolution rates in the
> pipeline then it should be fixed to also pad. Without this the audio
> gets distorted.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
Once the commit log fixed,
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: wens-jdAy2FN1RRM@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
be17068-p0aYb1w59bq9tCD/VL7h6Q@public.gmane.org
Subject: Re: [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample
Date: Tue, 4 Jun 2019 09:43:01 +0200 [thread overview]
Message-ID: <20190604074301.p27e5towgehmraoy@flea> (raw)
In-Reply-To: <20190603174735.21002-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Mon, Jun 03, 2019 at 07:47:29PM +0200, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> On the newer SoCs this is set by default to transfer a 0 after
Which SoCs?
> each sample in each slot. However the platform that this driver
Which platform?
> was developed on had the default setting where it padded the audio
> gain with zeros. This isn't a problem whilst we have only support
> for 16bit audio but with larger sample resolution rates in the
> pipeline then it should be fixed to also pad. Without this the audio
> gets distorted.
>
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Once the commit log fixed,
Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: codekipper@gmail.com
Cc: alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
be17068@iperbole.bo.it, wens@csie.org, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample
Date: Tue, 4 Jun 2019 09:43:01 +0200 [thread overview]
Message-ID: <20190604074301.p27e5towgehmraoy@flea> (raw)
In-Reply-To: <20190603174735.21002-4-codekipper@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]
On Mon, Jun 03, 2019 at 07:47:29PM +0200, codekipper@gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs this is set by default to transfer a 0 after
Which SoCs?
> each sample in each slot. However the platform that this driver
Which platform?
> was developed on had the default setting where it padded the audio
> gain with zeros. This isn't a problem whilst we have only support
> for 16bit audio but with larger sample resolution rates in the
> pipeline then it should be fixed to also pad. Without this the audio
> gets distorted.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
Once the commit log fixed,
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-04 7:43 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 17:47 [PATCH v4 0/9]ASoC: sun4i-i2s: Updates to the driver codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-03 17:47 ` [PATCH v4 1/9] ASoC: sun4i-i2s: Fix sun8i tx channel offset mask codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 7:34 ` Maxime Ripard
2019-06-04 7:34 ` Maxime Ripard
2019-06-04 7:34 ` Maxime Ripard
2019-06-04 7:38 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-04 7:38 ` Chen-Yu Tsai
2019-06-04 7:38 ` Chen-Yu Tsai
2019-06-04 8:15 ` [linux-sunxi] " Code Kipper
2019-06-04 8:15 ` Code Kipper
2019-06-04 14:58 ` Applied "ASoC: sun4i-i2s: Fix sun8i tx channel offset mask" to the asoc tree Mark Brown
2019-06-04 14:58 ` Mark Brown
2019-06-04 14:58 ` Mark Brown
2019-06-03 17:47 ` [PATCH v4 2/9] ASoC: sun4i-i2s: Add offset to RX channel select codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 7:36 ` Maxime Ripard
2019-06-04 7:36 ` Maxime Ripard
2019-06-04 7:36 ` Maxime Ripard
2019-06-04 7:39 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-04 7:39 ` Chen-Yu Tsai
2019-06-04 7:39 ` Chen-Yu Tsai
2019-06-04 14:58 ` Applied "ASoC: sun4i-i2s: Add offset to RX channel select" to the asoc tree Mark Brown
2019-06-04 14:58 ` Mark Brown
2019-06-04 14:58 ` Mark Brown
2019-06-03 17:47 ` [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper
2019-06-03 17:47 ` codekipper
2019-06-04 7:43 ` Maxime Ripard [this message]
2019-06-04 7:43 ` Maxime Ripard
2019-06-04 7:43 ` Maxime Ripard
2019-06-04 7:53 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-04 7:53 ` Chen-Yu Tsai
2019-06-04 11:46 ` Code Kipper
2019-06-04 11:46 ` Code Kipper
2019-06-03 17:47 ` [PATCH v4 4/9] ASoC: sun4i-i2s: Reduce quirks for sun8i-h3 codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 7:46 ` Maxime Ripard
2019-06-04 7:46 ` Maxime Ripard
2019-06-04 7:46 ` Maxime Ripard
2019-06-04 9:33 ` Code Kipper
2019-06-04 9:33 ` Code Kipper
2019-06-04 9:33 ` Code Kipper
2019-06-03 17:47 ` [PATCH v4 5/9] ASoC: sun4i-i2s: Add set_tdm_slot functionality codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 7:49 ` Maxime Ripard
2019-06-04 7:49 ` Maxime Ripard
2019-06-04 7:49 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 6/9] ASoC: sun4i-i2s: Add multi-lane functionality codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 7:58 ` Maxime Ripard
2019-06-04 7:58 ` Maxime Ripard
2019-06-04 7:58 ` Maxime Ripard
2019-06-04 8:43 ` Code Kipper
2019-06-04 8:43 ` Code Kipper
2019-06-04 8:43 ` Code Kipper
2019-06-04 9:02 ` [linux-sunxi] " Christopher Obbard
2019-06-04 9:02 ` Christopher Obbard
2019-06-04 9:02 ` Christopher Obbard
2019-06-04 9:38 ` [linux-sunxi] " Code Kipper
2019-06-04 9:38 ` Code Kipper
2019-06-04 9:38 ` Code Kipper
2019-07-30 17:57 ` [linux-sunxi] " Jernej Škrabec
2019-07-30 17:57 ` Jernej Škrabec
2019-07-30 17:57 ` Jernej Škrabec
2019-07-31 12:29 ` [linux-sunxi] " Maxime Ripard
2019-07-31 12:29 ` Maxime Ripard
2019-07-31 12:29 ` Maxime Ripard
2019-08-01 5:31 ` [linux-sunxi] " Jernej Škrabec
2019-08-01 5:31 ` Jernej Škrabec
2019-08-01 5:31 ` Jernej Škrabec
2019-08-06 6:22 ` Chen-Yu Tsai
2019-08-06 6:22 ` Chen-Yu Tsai
2019-08-12 10:02 ` Maxime Ripard
2019-08-12 10:02 ` Maxime Ripard
2019-08-12 10:02 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 7/9] ASoC: sun4i-i2s: Add multichannel functionality codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-03 17:47 ` [PATCH v4 8/9] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 8:19 ` Maxime Ripard
2019-06-04 8:19 ` Maxime Ripard
2019-06-04 8:19 ` Maxime Ripard
2019-06-03 17:47 ` [PATCH v4 9/9] ASoC: sun4i-i2s: Adjust regmap settings codekipper
2019-06-03 17:47 ` codekipper
2019-06-03 17:47 ` codekipper-Re5JQEeQqe8AvxtiuMwx3w
2019-06-04 8:21 ` Maxime Ripard
2019-06-04 8:21 ` Maxime Ripard
2019-06-04 8:21 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604074301.p27e5towgehmraoy@flea \
--to=maxime.ripard@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.