* [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit
[not found] <cover.1559576250.git.alifm@linux.ibm.com>
@ 2019-06-03 15:42 ` Farhan Ali
2019-06-04 6:03 ` Cornelia Huck
2019-06-04 15:44 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Farhan Ali @ 2019-06-03 15:42 UTC (permalink / raw)
To: linux-s390, kvm; +Cc: cohuck, farman, alifm, pasic
Free the vfio_ccw_cmd_region on module exit.
Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
---
I guess I missed this earlier while reviewing, but should'nt
we destroy the vfio_ccw_cmd_region on module exit, as well?
drivers/s390/cio/vfio_ccw_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 66a66ac..9cee9f2 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
css_driver_unregister(&vfio_ccw_sch_driver);
isc_unregister(VFIO_CCW_ISC);
kmem_cache_destroy(vfio_ccw_io_region);
+ kmem_cache_destroy(vfio_ccw_cmd_region);
destroy_workqueue(vfio_ccw_work_q);
}
module_init(vfio_ccw_sch_init);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit
2019-06-03 15:42 ` [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit Farhan Ali
@ 2019-06-04 6:03 ` Cornelia Huck
2019-06-04 15:44 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2019-06-04 6:03 UTC (permalink / raw)
To: Farhan Ali; +Cc: linux-s390, kvm, farman, pasic
On Mon, 3 Jun 2019 11:42:47 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> Free the vfio_ccw_cmd_region on module exit.
>
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
>
> I guess I missed this earlier while reviewing, but should'nt
> we destroy the vfio_ccw_cmd_region on module exit, as well?
>
> drivers/s390/cio/vfio_ccw_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 66a66ac..9cee9f2 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
> css_driver_unregister(&vfio_ccw_sch_driver);
> isc_unregister(VFIO_CCW_ISC);
> kmem_cache_destroy(vfio_ccw_io_region);
> + kmem_cache_destroy(vfio_ccw_cmd_region);
> destroy_workqueue(vfio_ccw_work_q);
> }
> module_init(vfio_ccw_sch_init);
Yes, you're right. Will queue when the pull req has been processed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit
2019-06-03 15:42 ` [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit Farhan Ali
2019-06-04 6:03 ` Cornelia Huck
@ 2019-06-04 15:44 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2019-06-04 15:44 UTC (permalink / raw)
To: Farhan Ali; +Cc: linux-s390, kvm, farman, pasic
On Mon, 3 Jun 2019 11:42:47 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> Free the vfio_ccw_cmd_region on module exit.
Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
>
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
>
> I guess I missed this earlier while reviewing, but should'nt
> we destroy the vfio_ccw_cmd_region on module exit, as well?
>
> drivers/s390/cio/vfio_ccw_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 66a66ac..9cee9f2 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void)
> css_driver_unregister(&vfio_ccw_sch_driver);
> isc_unregister(VFIO_CCW_ISC);
> kmem_cache_destroy(vfio_ccw_io_region);
> + kmem_cache_destroy(vfio_ccw_cmd_region);
> destroy_workqueue(vfio_ccw_work_q);
> }
> module_init(vfio_ccw_sch_init);
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-04 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1559576250.git.alifm@linux.ibm.com>
2019-06-03 15:42 ` [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit Farhan Ali
2019-06-04 6:03 ` Cornelia Huck
2019-06-04 15:44 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.