From: Vinod Koul <vkoul@kernel.org>
To: yibin.gong@nxp.com
Cc: robh@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, mark.rutland@arm.com,
dan.j.williams@intel.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610
Date: Tue, 4 Jun 2019 18:03:31 +0530 [thread overview]
Message-ID: <20190604123331.GE15118@vkoul-mobl> (raw)
In-Reply-To: <20190529090848.34350-6-yibin.gong@nxp.com>
On 29-05-19, 17:08, yibin.gong@nxp.com wrote:
> @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct platform_device *pdev)
> if (!fsl_edma)
> return -ENOMEM;
>
> - fsl_edma->version = v1;
> - fsl_edma->dmamux_nr = DMAMUX_NR;
> + fsl_edma->drvdata = drvdata;
> + fsl_edma->version = drvdata->version;
> + fsl_edma->dmamux_nr = drvdata->dmamuxs;
And can we avoid the duplication here, you have version and dmamuxs
represented in two places. But right now it looks logical so the removal
should be done after this series
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: yibin.gong@nxp.com
Cc: mark.rutland@arm.com, robh@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610
Date: Tue, 4 Jun 2019 18:03:31 +0530 [thread overview]
Message-ID: <20190604123331.GE15118@vkoul-mobl> (raw)
In-Reply-To: <20190529090848.34350-6-yibin.gong@nxp.com>
On 29-05-19, 17:08, yibin.gong@nxp.com wrote:
> @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct platform_device *pdev)
> if (!fsl_edma)
> return -ENOMEM;
>
> - fsl_edma->version = v1;
> - fsl_edma->dmamux_nr = DMAMUX_NR;
> + fsl_edma->drvdata = drvdata;
> + fsl_edma->version = drvdata->version;
> + fsl_edma->dmamux_nr = drvdata->dmamuxs;
And can we avoid the duplication here, you have version and dmamuxs
represented in two places. But right now it looks logical so the removal
should be done after this series
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-04 12:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:08 [PATCH v3 0/8] add edma2 for i.mx7ulp yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 1/8] dmaengine: fsl-edma: add dmamux_nr for next version yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 2/8] dmaengine: mcf-edma: update to 'dmamux_nr' yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 3/8] dmaengine: fsl-edma-common: move dmamux register to another single function yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 4/8] dmaengine: fsl-edma-common: version check for v2 instead yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610 yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-06-04 12:33 ` Vinod Koul [this message]
2019-06-04 12:33 ` Vinod Koul
2019-06-05 2:25 ` Robin Gong
2019-06-05 2:25 ` Robin Gong
2019-06-05 2:25 ` Robin Gong
2019-05-29 9:08 ` [PATCH v3 6/8] dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-05-29 9:08 ` [PATCH v3 7/8] dmaengine: fsl-edma: add i.mx7ulp edma2 version support yibin.gong
2019-05-29 9:08 ` yibin.gong
2019-06-04 12:37 ` Vinod Koul
2019-06-04 12:37 ` Vinod Koul
2019-06-05 2:29 ` Robin Gong
2019-06-05 2:29 ` Robin Gong
2019-06-05 2:29 ` Robin Gong
2019-05-29 9:08 ` [PATCH v3 8/8] ARM: dts: imx7ulp: add edma device node yibin.gong
2019-05-29 9:08 ` yibin.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604123331.GE15118@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.