* [PATCH] s390: fix unrecognized __aligned() in uapi header
@ 2019-06-04 8:29 Masahiro Yamada
2019-06-04 14:54 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-06-04 8:29 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390
Cc: Masahiro Yamada, linux-kernel
__aligned() is a shorthand that is only available in the kernel space
because it is defined in include/linux/compiler_attributes.h, which is
not exported to the user space.
Detected by compile-testing exported headers.
./usr/include/asm/runtime_instr.h:60:37: error: expected declaration specifiers or ‘...’ before numeric constant
} __attribute__((packed)) __aligned(8);
^
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/s390/include/uapi/asm/runtime_instr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/include/uapi/asm/runtime_instr.h b/arch/s390/include/uapi/asm/runtime_instr.h
index 45c9ec984e6b..455da46e3193 100644
--- a/arch/s390/include/uapi/asm/runtime_instr.h
+++ b/arch/s390/include/uapi/asm/runtime_instr.h
@@ -57,7 +57,7 @@ struct runtime_instr_cb {
__u64 sf;
__u64 rsic;
__u64 reserved8;
-} __packed __aligned(8);
+} __attribute__((__packed__, __aligned__(8)));
static inline void load_runtime_instr_cb(struct runtime_instr_cb *cb)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: fix unrecognized __aligned() in uapi header
2019-06-04 8:29 [PATCH] s390: fix unrecognized __aligned() in uapi header Masahiro Yamada
@ 2019-06-04 14:54 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2019-06-04 14:54 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Vasily Gorbik, Christian Borntraeger, linux-s390, linux-kernel
On Tue, Jun 04, 2019 at 05:29:47PM +0900, Masahiro Yamada wrote:
> __aligned() is a shorthand that is only available in the kernel space
> because it is defined in include/linux/compiler_attributes.h, which is
> not exported to the user space.
>
> Detected by compile-testing exported headers.
>
> ./usr/include/asm/runtime_instr.h:60:37: error: expected declaration specifiers or ‘...’ before numeric constant
> } __attribute__((packed)) __aligned(8);
> ^
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/s390/include/uapi/asm/runtime_instr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 14:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 8:29 [PATCH] s390: fix unrecognized __aligned() in uapi header Masahiro Yamada
2019-06-04 14:54 ` Heiko Carstens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.