[igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Petri Latvala]

In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
library") perf_pmu was converted to use gem_context_has_engine()
instead of gem_require_engine, but missing the crucial part of
igt_require().

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 tests/perf_pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 72b9166a..fdaf96da 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1714,7 +1714,7 @@ igt_main
 
 		igt_subtest_group {
 			igt_fixture {
-				gem_context_has_engine(fd, 0, e->flags);
+				igt_require(gem_context_has_engine(fd, 0, e->flags));
 			}
 
 			/**
@@ -1903,8 +1903,8 @@ igt_main
 		__for_each_physical_engine(render_fd, e) {
 			igt_subtest_group {
 				igt_fixture {
-					gem_context_has_engine(render_fd,
-							   0, e->flags);
+					igt_require(gem_context_has_engine(render_fd,
+									   0, e->flags));
 				}
 
 				igt_subtest_f("render-node-busy-%s", e->name)
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Tvrtko Ursulin]

On 04/06/2019 09:46, Petri Latvala wrote:
> In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
> library") perf_pmu was converted to use gem_context_has_engine()
> instead of gem_require_engine, but missing the crucial part of
> igt_require().
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>   tests/perf_pmu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index 72b9166a..fdaf96da 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -1714,7 +1714,7 @@ igt_main
>   
>   		igt_subtest_group {
>   			igt_fixture {
> -				gem_context_has_engine(fd, 0, e->flags);
> +				igt_require(gem_context_has_engine(fd, 0, e->flags));

Hmmm.. is the line even needed? I think iterator will only contain 
available engines.

Regards,

Tvrtko

>   			}
>   
>   			/**
> @@ -1903,8 +1903,8 @@ igt_main
>   		__for_each_physical_engine(render_fd, e) {
>   			igt_subtest_group {
>   				igt_fixture {
> -					gem_context_has_engine(render_fd,
> -							   0, e->flags);
> +					igt_require(gem_context_has_engine(render_fd,
> +									   0, e->flags));
>   				}
>   
>   				igt_subtest_f("render-node-busy-%s", e->name)
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for perf_pmu: Actually require engines again

[Patchwork]

== Series Details ==

Series: perf_pmu: Actually require engines again
URL   : https://patchwork.freedesktop.org/series/61568/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6183 -> IGTPW_3099
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61568/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3099 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-icl-u3/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-icl-u3/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-bxt-dsi:         [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-bxt-dsi/igt@kms_flip@basic-flip-vs-dpms.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-bxt-dsi/igt@kms_flip@basic-flip-vs-dpms.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-dsi:         [PASS][5] -> [FAIL][6] ([fdo#103167])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-icl-dsi/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-icl-dsi/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@gem_exec_fence@basic-busy-default:
    - {fi-icl-guc}:       [INCOMPLETE][7] ([fdo#107713]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-icl-guc/igt@gem_exec_fence@basic-busy-default.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-icl-guc/igt@gem_exec_fence@basic-busy-default.html

  * igt@i915_getparams_basic@basic-subslice-total:
    - fi-icl-u3:          [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-icl-u3/igt@i915_getparams_basic@basic-subslice-total.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-icl-u3/igt@i915_getparams_basic@basic-subslice-total.html

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [DMESG-FAIL][11] ([fdo#110235]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@vgem_basic@dmabuf-export:
    - fi-icl-dsi:         [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/fi-icl-dsi/igt@vgem_basic@dmabuf-export.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/fi-icl-dsi/igt@vgem_basic@dmabuf-export.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
  [fdo#110818 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110818 


Participating hosts (53 -> 46)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5033 -> IGTPW_3099

  CI_DRM_6183: aff09dc14e1d9f03f9e6c8c157d4abccf4ca2b14 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3099: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/
  IGT_5033: 8eddc43c75c2ae4ec6e3bee70e4f815e08a928c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for perf_pmu: Actually require engines again

[Patchwork]

== Series Details ==

Series: perf_pmu: Actually require engines again
URL   : https://patchwork.freedesktop.org/series/61568/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6183_full -> IGTPW_3099_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61568/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3099_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_ctx_shared@exec-single-timeline-default}:
    - shard-iclb:         NOTRUN -> [SKIP][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-default.html

  
Known issues
------------

  Here are the changes found in IGTPW_3099_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@fences-dpms:
    - shard-iclb:         [PASS][2] -> [INCOMPLETE][3] ([fdo#107713] / [fdo#108840])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb6/igt@i915_pm_rpm@fences-dpms.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb2/igt@i915_pm_rpm@fences-dpms.html

  * igt@i915_suspend@debugfs-reader:
    - shard-apl:          [PASS][4] -> [DMESG-WARN][5] ([fdo#108566]) +5 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-apl6/igt@i915_suspend@debugfs-reader.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-apl1/igt@i915_suspend@debugfs-reader.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
    - shard-apl:          [PASS][6] -> [FAIL][7] ([fdo#103232])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-apl5/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
    - shard-kbl:          [PASS][8] -> [FAIL][9] ([fdo#103232])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][10] -> [FAIL][11] ([fdo#105767])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
    - shard-hsw:          [PASS][12] -> [SKIP][13] ([fdo#109271]) +15 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw1/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
    - shard-hsw:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103540])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][16] -> [FAIL][17] ([fdo#102887] / [fdo#105363])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
    - shard-iclb:         [PASS][18] -> [FAIL][19] ([fdo#103167]) +4 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
    - shard-apl:          [PASS][20] -> [FAIL][21] ([fdo#103167])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
    - shard-kbl:          [PASS][22] -> [FAIL][23] ([fdo#103167])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-onoff:
    - shard-glk:          [PASS][24] -> [FAIL][25] ([fdo#103167])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-onoff.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-onoff.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][26] -> [FAIL][27] ([fdo#103166])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][28] -> [SKIP][29] ([fdo#109441]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][30] -> [FAIL][31] ([fdo#99912])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-apl7/igt@kms_setmode@basic.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-apl8/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [DMESG-WARN][32] ([fdo#108686]) -> [PASS][33]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-kbl6/igt@gem_tiled_swapping@non-threaded.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-kbl6/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [DMESG-WARN][34] ([fdo#108566]) -> [PASS][35] +3 similar issues
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-apl3/igt@gem_workarounds@suspend-resume-context.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-apl6/igt@gem_workarounds@suspend-resume-context.html

  * igt@kms_atomic_transition@plane-toggle-modeset-transition:
    - shard-iclb:         [INCOMPLETE][36] ([fdo#107713]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb7/igt@kms_atomic_transition@plane-toggle-modeset-transition.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb2/igt@kms_atomic_transition@plane-toggle-modeset-transition.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [SKIP][38] ([fdo#109271]) -> [PASS][39] +15 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw1/igt@kms_flip@2x-plain-flip.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw1/igt@kms_flip@2x-plain-flip.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-iclb:         [FAIL][40] ([fdo#103167]) -> [PASS][41] +2 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [SKIP][42] ([fdo#109441]) -> [PASS][43] +1 similar issue
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-iclb8/igt@kms_psr@psr2_sprite_render.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][44] ([fdo#99912]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-kbl7/igt@kms_setmode@basic.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-kbl3/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-hsw:          [FAIL][46] ([fdo#100047]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw1/igt@kms_sysfs_edid_timing.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw6/igt@kms_sysfs_edid_timing.html

  * igt@perf_pmu@rc6-runtime-pm-long:
    - shard-kbl:          [FAIL][48] ([fdo#105010]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-kbl6/igt@perf_pmu@rc6-runtime-pm-long.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-kbl6/igt@perf_pmu@rc6-runtime-pm-long.html

  
#### Warnings ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-hsw:          [FAIL][50] ([fdo#108686]) -> [INCOMPLETE][51] ([fdo#103540])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6183/shard-hsw8/igt@gem_tiled_swapping@non-threaded.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/shard-hsw5/igt@gem_tiled_swapping@non-threaded.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110836]: https://bugs.freedesktop.org/show_bug.cgi?id=110836
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5033 -> IGTPW_3099
  * Piglit: piglit_4509 -> None

  CI_DRM_6183: aff09dc14e1d9f03f9e6c8c157d4abccf4ca2b14 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3099: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/
  IGT_5033: 8eddc43c75c2ae4ec6e3bee70e4f815e08a928c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3099/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Petri Latvala]

On Tue, Jun 04, 2019 at 09:51:17AM +0100, Tvrtko Ursulin wrote:
> 
> On 04/06/2019 09:46, Petri Latvala wrote:
> > In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
> > library") perf_pmu was converted to use gem_context_has_engine()
> > instead of gem_require_engine, but missing the crucial part of
> > igt_require().
> > 
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Andi Shyti <andi.shyti@intel.com>
> > ---
> >   tests/perf_pmu.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> > index 72b9166a..fdaf96da 100644
> > --- a/tests/perf_pmu.c
> > +++ b/tests/perf_pmu.c
> > @@ -1714,7 +1714,7 @@ igt_main
> >   		igt_subtest_group {
> >   			igt_fixture {
> > -				gem_context_has_engine(fd, 0, e->flags);
> > +				igt_require(gem_context_has_engine(fd, 0, e->flags));
> 
> Hmmm.. is the line even needed? I think iterator will only contain available
> engines.


Good question, looks like no.

Does the iterator only give available engines on ye olde kernels too?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Tvrtko Ursulin]

On 05/06/2019 10:08, Petri Latvala wrote:
> On Tue, Jun 04, 2019 at 09:51:17AM +0100, Tvrtko Ursulin wrote:
>>
>> On 04/06/2019 09:46, Petri Latvala wrote:
>>> In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
>>> library") perf_pmu was converted to use gem_context_has_engine()
>>> instead of gem_require_engine, but missing the crucial part of
>>> igt_require().
>>>
>>> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Andi Shyti <andi.shyti@intel.com>
>>> ---
>>>    tests/perf_pmu.c | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
>>> index 72b9166a..fdaf96da 100644
>>> --- a/tests/perf_pmu.c
>>> +++ b/tests/perf_pmu.c
>>> @@ -1714,7 +1714,7 @@ igt_main
>>>    		igt_subtest_group {
>>>    			igt_fixture {
>>> -				gem_context_has_engine(fd, 0, e->flags);
>>> +				igt_require(gem_context_has_engine(fd, 0, e->flags));
>>
>> Hmmm.. is the line even needed? I think iterator will only contain available
>> engines.
> 
> 
> Good question, looks like no.
> 
> Does the iterator only give available engines on ye olde kernels too?

There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list 
on the legacy path so I think it filters them there as well.

Andi?

Regards,

Tvrtko


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Andi Shyti]

Hi,

> > > >    		igt_subtest_group {
> > > >    			igt_fixture {
> > > > -				gem_context_has_engine(fd, 0, e->flags);
> > > > +				igt_require(gem_context_has_engine(fd, 0, e->flags));
> > > 
> > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > engines.
> > 
> > 
> > Good question, looks like no.
> > 
> > Does the iterator only give available engines on ye olde kernels too?
> 
> There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> the legacy path so I think it filters them there as well.
> 
> Andi?

yes, indeed, what exactly is the issue?

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Petri Latvala]

On Wed, Jun 05, 2019 at 02:27:50PM +0300, Andi Shyti wrote:
> Hi,
> 
> > > > >    		igt_subtest_group {
> > > > >    			igt_fixture {
> > > > > -				gem_context_has_engine(fd, 0, e->flags);
> > > > > +				igt_require(gem_context_has_engine(fd, 0, e->flags));
> > > > 
> > > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > > engines.
> > > 
> > > 
> > > Good question, looks like no.
> > > 
> > > Does the iterator only give available engines on ye olde kernels too?
> > 
> > There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> > the legacy path so I think it filters them there as well.
> > 
> > Andi?
> 
> yes, indeed, what exactly is the issue?

Whether gem_context_has_engine check is needed inside the
__for_each_physical_engine loop, for any kernel.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Tvrtko Ursulin]

On 05/06/2019 12:27, Andi Shyti wrote:
> Hi,
> 
>>>>>     		igt_subtest_group {
>>>>>     			igt_fixture {
>>>>> -				gem_context_has_engine(fd, 0, e->flags);
>>>>> +				igt_require(gem_context_has_engine(fd, 0, e->flags));
>>>>
>>>> Hmmm.. is the line even needed? I think iterator will only contain available
>>>> engines.
>>>
>>>
>>> Good question, looks like no.
>>>
>>> Does the iterator only give available engines on ye olde kernels too?
>>
>> There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
>> the legacy path so I think it filters them there as well.
>>
>> Andi?
> 
> yes, indeed, what exactly is the issue?

I don't know if there was an actual issue but at least Petri found some 
dead code as you can see in the patch.

Discussion was whether his patch should be applied or updated to remove 
those lines altogether.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again

[Petri Latvala]

On Wed, Jun 05, 2019 at 03:03:48PM +0300, Petri Latvala wrote:
> On Wed, Jun 05, 2019 at 02:27:50PM +0300, Andi Shyti wrote:
> > Hi,
> > 
> > > > > >    		igt_subtest_group {
> > > > > >    			igt_fixture {
> > > > > > -				gem_context_has_engine(fd, 0, e->flags);
> > > > > > +				igt_require(gem_context_has_engine(fd, 0, e->flags));
> > > > > 
> > > > > Hmmm.. is the line even needed? I think iterator will only contain available
> > > > > engines.
> > > > 
> > > > 
> > > > Good question, looks like no.
> > > > 
> > > > Does the iterator only give available engines on ye olde kernels too?
> > > 
> > > There is a gem_has_ring in gem_engine_topology.c/intel_init_engine_list on
> > > the legacy path so I think it filters them there as well.
> > > 
> > > Andi?
> > 
> > yes, indeed, what exactly is the issue?
> 
> Whether gem_context_has_engine check is needed inside the
> __for_each_physical_engine loop, for any kernel.


Andi confirmed here that indeed, for any kernel, etc.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev