All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benson Leung <bleung@google.com>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: Rob Herring <robh@kernel.org>, Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Benson Leung <bleung@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg.
Date: Tue, 4 Jun 2019 10:57:31 -0700	[thread overview]
Message-ID: <20190604175731.GB241153@google.com> (raw)
In-Reply-To: <20190531073848.155444-6-pihsun@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1951 bytes --]

On Fri, May 31, 2019 at 03:38:46PM +0800, Pi-Hsun Shih wrote:
> Add a DT binding documentation for ChromeOS EC driver over rpmsg.
> 
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Benson Leung <bleung@chromium.org>

> 
> ---
> Changes from v8, v7, v6:
>  - No change.
> 
> Changes from v5:
>  - New patch.
> ---
>  Documentation/devicetree/bindings/mfd/cros-ec.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 6245c9b1a68b..4860eabd0f72 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
>  Google's ChromeOS EC is a Cortex-M device which talks to the AP and
>  implements various function such as keyboard and battery charging.
>  
> -The EC can be connect through various means (I2C, SPI, LPC) and the
> +The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
>  compatible string used depends on the interface. Each connection method has
>  its own driver which connects to the top level interface-agnostic EC driver.
>  Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,9 @@ Required properties (SPI):
>  - compatible: "google,cros-ec-spi"
>  - reg: SPI chip select
>  
> +Required properties (RPMSG):
> +- compatible: "google,cros-ec-rpmsg"
> +
>  Optional properties (SPI):
>  - google,cros-ec-spi-pre-delay: Some implementations of the EC need a little
>    time to wake up from sleep before they can receive SPI transfers at a high
> -- 
> 2.22.0.rc1.257.g3120a18244-goog
> 

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2019-06-04 17:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  7:38 [PATCH v9 0/7] Add support for mt8183 SCP Pi-Hsun Shih
2019-05-31  7:38 ` Pi-Hsun Shih
2019-05-31  7:38 ` [PATCH v9 1/7] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38 ` [PATCH v9 2/7] remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38 ` [PATCH v9 3/7] remoteproc: mt8183: add reserved memory manager API Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38 ` [PATCH v9 4/7] rpmsg: add rpmsg support for mt8183 SCP Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38 ` [PATCH v9 5/7] dt-bindings: Add binding for cros-ec-rpmsg Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-06-04 17:57   ` Benson Leung [this message]
2019-06-04 17:57     ` Benson Leung
2019-05-31  7:38 ` [PATCH v9 6/7] mfd: cros_ec: differentiate SCP from EC by feature bit Pi-Hsun Shih
2019-05-31  8:54   ` Enric Balletbo i Serra
2019-06-04 17:55   ` Benson Leung
2019-05-31  7:38 ` [PATCH v9 7/7] arm64: dts: mt8183: add scp node Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih
2019-05-31  7:38   ` Pi-Hsun Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604175731.GB241153@google.com \
    --to=bleung@google.com \
    --cc=bleung@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pihsun@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.