All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 1/5] lib/tests: fix conflicting args test
@ 2019-05-29 23:27 Lucas De Marchi
  2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
                   ` (7 more replies)
  0 siblings, 8 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-29 23:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

We want to check if the long option conflicts with one from the core.
The check for conflicting short option already exists just above.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/tests/igt_conflicting_args.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tests/igt_conflicting_args.c b/lib/tests/igt_conflicting_args.c
index c357b6c5..d8be138e 100644
--- a/lib/tests/igt_conflicting_args.c
+++ b/lib/tests/igt_conflicting_args.c
@@ -91,7 +91,7 @@ int main(int argc, char **argv)
 	internal_assert_wsignaled(do_fork(), SIGABRT);
 
 	/* conflict on long option 'val' representations */
-	long_options[0] = (struct option) { "iterations", required_argument, NULL, 0};
+	long_options[0] = (struct option) { "list-subtests", required_argument, NULL, 0};
 	short_options = "";
 	internal_assert_wsignaled(do_fork(), SIGABRT);
 
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
@ 2019-05-29 23:27 ` Lucas De Marchi
  2019-05-30  0:03   ` Antonio Argenziano
  2019-05-31 10:00   ` Petri Latvala
  2019-05-29 23:27 ` [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options Lucas De Marchi
                   ` (6 subsequent siblings)
  7 siblings, 2 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-29 23:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

Start the core optiosn from 500 so the individual tests can have their
own options starting from 0. This makes it easier to set the long
options without conflicting.

500 is just a magic number, higher than any ascii char that could be
used in the individual test.

While at it, fix the coding style to use tab rather than space.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_core.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 9c86d664..814f5c72 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -280,12 +280,16 @@ int test_children_sz;
 bool test_child;
 
 enum {
- OPT_LIST_SUBTESTS,
- OPT_RUN_SUBTEST,
- OPT_DESCRIPTION,
- OPT_DEBUG,
- OPT_INTERACTIVE_DEBUG,
- OPT_HELP = 'h'
+	/*
+	 * Let the first values be used by individual tests so options don't
+	 * conflict with core ones
+	 */
+	OPT_LIST_SUBTESTS = 500,
+	OPT_RUN_SUBTEST,
+	OPT_DESCRIPTION,
+	OPT_DEBUG,
+	OPT_INTERACTIVE_DEBUG,
+	OPT_HELP = 'h'
 };
 
 static int igt_exitcode = IGT_EXIT_SUCCESS;
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
  2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
@ 2019-05-29 23:27 ` Lucas De Marchi
  2019-05-31 10:05   ` Petri Latvala
  2019-05-29 23:27 ` [PATCH i-g-t 4/5] testdisplay: use first available option values Lucas De Marchi
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-29 23:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

This is usually used by long options when working with enum to set long
option values. So replace the strchr() with a memchr() to take that into
account.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 814f5c72..a0b7e581 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -680,6 +680,7 @@ static int common_init(int *argc, char **argv,
 	};
 	char *short_opts;
 	const char *std_short_opts = "h";
+	size_t std_short_opts_len = strlen(std_short_opts);
 	struct option *combined_opts;
 	int extra_opt_count;
 	int all_opt_count;
@@ -713,7 +714,7 @@ static int common_init(int *argc, char **argv,
 
 		/* check for conflicts with standard short options */
 		if (extra_long_opts[extra_opt_count].val != ':'
-		    && (conflicting_char = strchr(std_short_opts, extra_long_opts[extra_opt_count].val))) {
+		    && (conflicting_char = memchr(std_short_opts, extra_long_opts[extra_opt_count].val, std_short_opts_len))) {
 			igt_critical("Conflicting long and short option 'val' representation between --%s and -%c\n",
 				     extra_long_opts[extra_opt_count].name,
 				     *conflicting_char);
@@ -727,7 +728,7 @@ static int common_init(int *argc, char **argv,
 			continue;
 
 		/* check for conflicts with standard short options */
-		if (strchr(std_short_opts, extra_short_opts[i])) {
+		if (memchr(std_short_opts, extra_short_opts[i], std_short_opts_len)) {
 			igt_critical("Conflicting short option: -%c\n", std_short_opts[i]);
 			assert(0);
 		}
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH i-g-t 4/5] testdisplay: use first available option values
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
  2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
  2019-05-29 23:27 ` [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options Lucas De Marchi
@ 2019-05-29 23:27 ` Lucas De Marchi
  2019-05-30  0:05   ` Antonio Argenziano
  2019-05-31 10:06   ` Petri Latvala
  2019-05-29 23:27 ` [PATCH i-g-t 5/5] lib/igt_core: add -h to usage Lucas De Marchi
                   ` (4 subsequent siblings)
  7 siblings, 2 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-29 23:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

Now that core options are set to 500 and above, start from the lowest
values without causing problems with conflicts. This also rename the
constants to follow the names from the core.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 tests/testdisplay.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index b4f0d45f..32590547 100644
--- a/tests/testdisplay.c
+++ b/tests/testdisplay.c
@@ -69,8 +69,10 @@
 #include <stdlib.h>
 #include <signal.h>
 
-#define Yb_OPT		 5
-#define Yf_OPT		 6
+enum {
+	OPT_YB,
+	OPT_YF,
+};
 
 static int tio_fd;
 struct termios saved_tio;
@@ -573,8 +575,8 @@ static void set_termio_mode(void)
 
 static char optstr[] = "3iaf:s:d:p:mrto:j:y";
 static struct option long_opts[] = {
-	{"yb", 0, 0, Yb_OPT},
-	{"yf", 0, 0, Yf_OPT},
+	{"yb", 0, 0, OPT_YB},
+	{"yf", 0, 0, OPT_YF},
 	{ 0, 0, 0, 0 }
 };
 
@@ -648,10 +650,10 @@ static int opt_handler(int opt, int opt_index, void *data)
 		tiling = LOCAL_I915_FORMAT_MOD_X_TILED;
 		break;
 	case 'y':
-	case Yb_OPT:
+	case OPT_YB:
 		tiling = LOCAL_I915_FORMAT_MOD_Y_TILED;
 		break;
-	case Yf_OPT:
+	case OPT_YF:
 		tiling = LOCAL_I915_FORMAT_MOD_Yf_TILED;
 		break;
 	case 'r':
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* [PATCH i-g-t 5/5] lib/igt_core: add -h to usage
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
                   ` (2 preceding siblings ...)
  2019-05-29 23:27 ` [PATCH i-g-t 4/5] testdisplay: use first available option values Lucas De Marchi
@ 2019-05-29 23:27 ` Lucas De Marchi
  2019-05-31 10:07   ` Petri Latvala
  2019-05-30  1:27 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] lib/tests: fix conflicting args test Patchwork
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-29 23:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lucas De Marchi

We also accept the short option -h.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index a0b7e581..6b9f0425 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -558,7 +558,7 @@ static void print_usage(const char *help_str, bool output_on_stderr)
 		   "  --debug[=log-domain]\n"
 		   "  --interactive-debug[=domain]\n"
 		   "  --help-description\n"
-		   "  --help\n");
+		   "  --help|-h\n");
 	if (help_str)
 		fprintf(f, "%s\n", help_str);
 }
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests
  2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
@ 2019-05-30  0:03   ` Antonio Argenziano
  2019-05-31 10:00   ` Petri Latvala
  1 sibling, 0 replies; 19+ messages in thread
From: Antonio Argenziano @ 2019-05-30  0:03 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx



On 29/05/19 16:27, Lucas De Marchi wrote:
> Start the core optiosn from 500 so the individual tests can have their
> own options starting from 0. This makes it easier to set the long
> options without conflicting.
> 
> 500 is just a magic number, higher than any ascii char that could be
> used in the individual test.
> 
> While at it, fix the coding style to use tab rather than space.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   lib/igt_core.c | 16 ++++++++++------
>   1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 9c86d664..814f5c72 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -280,12 +280,16 @@ int test_children_sz;
>   bool test_child;
>   
>   enum {
> - OPT_LIST_SUBTESTS,
> - OPT_RUN_SUBTEST,
> - OPT_DESCRIPTION,
> - OPT_DEBUG,
> - OPT_INTERACTIVE_DEBUG,
> - OPT_HELP = 'h'
> +	/*
> +	 * Let the first values be used by individual tests so options don't
> +	 * conflict with core ones
> +	 */
> +	OPT_LIST_SUBTESTS = 500,
> +	OPT_RUN_SUBTEST,
> +	OPT_DESCRIPTION,
> +	OPT_DEBUG,
> +	OPT_INTERACTIVE_DEBUG,
> +	OPT_HELP = 'h'
>   };
>   
>   static int igt_exitcode = IGT_EXIT_SUCCESS;
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 4/5] testdisplay: use first available option values
  2019-05-29 23:27 ` [PATCH i-g-t 4/5] testdisplay: use first available option values Lucas De Marchi
@ 2019-05-30  0:05   ` Antonio Argenziano
  2019-05-31 10:06   ` Petri Latvala
  1 sibling, 0 replies; 19+ messages in thread
From: Antonio Argenziano @ 2019-05-30  0:05 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx



On 29/05/19 16:27, Lucas De Marchi wrote:
> Now that core options are set to 500 and above, start from the lowest
> values without causing problems with conflicts. This also rename the
> constants to follow the names from the core.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

> ---
>   tests/testdisplay.c | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index b4f0d45f..32590547 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -69,8 +69,10 @@
>   #include <stdlib.h>
>   #include <signal.h>
>   
> -#define Yb_OPT		 5
> -#define Yf_OPT		 6
> +enum {
> +	OPT_YB,
> +	OPT_YF,
> +};
>   
>   static int tio_fd;
>   struct termios saved_tio;
> @@ -573,8 +575,8 @@ static void set_termio_mode(void)
>   
>   static char optstr[] = "3iaf:s:d:p:mrto:j:y";
>   static struct option long_opts[] = {
> -	{"yb", 0, 0, Yb_OPT},
> -	{"yf", 0, 0, Yf_OPT},
> +	{"yb", 0, 0, OPT_YB},
> +	{"yf", 0, 0, OPT_YF},
>   	{ 0, 0, 0, 0 }
>   };
>   
> @@ -648,10 +650,10 @@ static int opt_handler(int opt, int opt_index, void *data)
>   		tiling = LOCAL_I915_FORMAT_MOD_X_TILED;
>   		break;
>   	case 'y':
> -	case Yb_OPT:
> +	case OPT_YB:
>   		tiling = LOCAL_I915_FORMAT_MOD_Y_TILED;
>   		break;
> -	case Yf_OPT:
> +	case OPT_YF:
>   		tiling = LOCAL_I915_FORMAT_MOD_Yf_TILED;
>   		break;
>   	case 'r':
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/5] lib/tests: fix conflicting args test
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
                   ` (3 preceding siblings ...)
  2019-05-29 23:27 ` [PATCH i-g-t 5/5] lib/igt_core: add -h to usage Lucas De Marchi
@ 2019-05-30  1:27 ` Patchwork
  2019-05-31  7:31 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-05-30  1:27 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] lib/tests: fix conflicting args test
URL   : https://patchwork.freedesktop.org/series/61355/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6166 -> IGTPW_3078
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3078 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3078, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61355/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3078:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_execlists:
    - fi-icl-u2:          NOTRUN -> [DMESG-WARN][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-u2/igt@i915_selftest@live_execlists.html

  
#### Warnings ####

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u2:          [INCOMPLETE][2] ([fdo#107713] / [fdo#108569]) -> [DMESG-WARN][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-u2/igt@i915_selftest@live_hangcheck.html

  
Known issues
------------

  Here are the changes found in IGTPW_3078 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-write-no-prefault:
    - fi-icl-u3:          [PASS][4] -> [DMESG-WARN][5] ([fdo#107724])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - {fi-apl-guc}:       [DMESG-WARN][6] ([fdo#108566]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [DMESG-FAIL][8] ([fdo#110235]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * {igt@i915_selftest@live_reset}:
    - fi-skl-iommu:       [INCOMPLETE][10] ([fdo#108602]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-skl-iommu/igt@i915_selftest@live_reset.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-skl-iommu/igt@i915_selftest@live_reset.html

  
#### Warnings ####

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-y:           [DMESG-WARN][12] -> [INCOMPLETE][13] ([fdo#107713] / [fdo#108569])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-y/igt@i915_selftest@live_hangcheck.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-y/igt@i915_selftest@live_hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (50 -> 44)
------------------------------

  Missing    (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-guc fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3078

  CI_DRM_6166: 0bd6fdd57b1e01b228ba81fea2b3e9fc381b3298 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3078: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/5] lib/tests: fix conflicting args test
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
                   ` (4 preceding siblings ...)
  2019-05-30  1:27 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] lib/tests: fix conflicting args test Patchwork
@ 2019-05-31  7:31 ` Patchwork
  2019-05-31  9:59 ` [PATCH i-g-t 1/5] " Petri Latvala
  2019-05-31 14:47 ` ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
  7 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-05-31  7:31 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] lib/tests: fix conflicting args test
URL   : https://patchwork.freedesktop.org/series/61355/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6166 -> IGTPW_3078
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61355/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3078 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-write-no-prefault:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - {fi-apl-guc}:       [DMESG-WARN][3] ([fdo#108566]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-apl-guc/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [DMESG-FAIL][5] ([fdo#110235]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * {igt@i915_selftest@live_reset}:
    - fi-skl-iommu:       [INCOMPLETE][7] ([fdo#108602]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-skl-iommu/igt@i915_selftest@live_reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-skl-iommu/igt@i915_selftest@live_reset.html

  
#### Warnings ####

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u2:          [INCOMPLETE][9] ([fdo#107713] / [fdo#108569]) -> [DMESG-WARN][10] ([fdo#110801])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
    - fi-icl-y:           [DMESG-WARN][11] ([fdo#110801]) -> [INCOMPLETE][12] ([fdo#107713] / [fdo#108569])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/fi-icl-y/igt@i915_selftest@live_hangcheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/fi-icl-y/igt@i915_selftest@live_hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
  [fdo#110801]: https://bugs.freedesktop.org/show_bug.cgi?id=110801


Participating hosts (50 -> 44)
------------------------------

  Missing    (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-guc fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3078

  CI_DRM_6166: 0bd6fdd57b1e01b228ba81fea2b3e9fc381b3298 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3078: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 1/5] lib/tests: fix conflicting args test
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
                   ` (5 preceding siblings ...)
  2019-05-31  7:31 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-05-31  9:59 ` Petri Latvala
  2019-05-31 14:55   ` Lucas De Marchi
  2019-05-31 14:47 ` ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
  7 siblings, 1 reply; 19+ messages in thread
From: Petri Latvala @ 2019-05-31  9:59 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
> We want to check if the long option conflicts with one from the core.
> The check for conflicting short option already exists just above.

No, this one is checking that the val (the 0) doesn't conflict.


-- 
Petri Latvala


> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  lib/tests/igt_conflicting_args.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/tests/igt_conflicting_args.c b/lib/tests/igt_conflicting_args.c
> index c357b6c5..d8be138e 100644
> --- a/lib/tests/igt_conflicting_args.c
> +++ b/lib/tests/igt_conflicting_args.c
> @@ -91,7 +91,7 @@ int main(int argc, char **argv)
>  	internal_assert_wsignaled(do_fork(), SIGABRT);
>  
>  	/* conflict on long option 'val' representations */
> -	long_options[0] = (struct option) { "iterations", required_argument, NULL, 0};
> +	long_options[0] = (struct option) { "list-subtests", required_argument, NULL, 0};
>  	short_options = "";
>  	internal_assert_wsignaled(do_fork(), SIGABRT);
>  
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests
  2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
  2019-05-30  0:03   ` Antonio Argenziano
@ 2019-05-31 10:00   ` Petri Latvala
  1 sibling, 0 replies; 19+ messages in thread
From: Petri Latvala @ 2019-05-31 10:00 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, May 29, 2019 at 04:27:34PM -0700, Lucas De Marchi wrote:
> Start the core optiosn from 500 so the individual tests can have their
> own options starting from 0. This makes it easier to set the long
> options without conflicting.
> 
> 500 is just a magic number, higher than any ascii char that could be
> used in the individual test.
> 
> While at it, fix the coding style to use tab rather than space.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

This is much better than requiring additional opts to begin from a particular number.


Reviewed-by: Petri Latvala <petri.latvala@intel.com>


> ---
>  lib/igt_core.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 9c86d664..814f5c72 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -280,12 +280,16 @@ int test_children_sz;
>  bool test_child;
>  
>  enum {
> - OPT_LIST_SUBTESTS,
> - OPT_RUN_SUBTEST,
> - OPT_DESCRIPTION,
> - OPT_DEBUG,
> - OPT_INTERACTIVE_DEBUG,
> - OPT_HELP = 'h'
> +	/*
> +	 * Let the first values be used by individual tests so options don't
> +	 * conflict with core ones
> +	 */
> +	OPT_LIST_SUBTESTS = 500,
> +	OPT_RUN_SUBTEST,
> +	OPT_DESCRIPTION,
> +	OPT_DEBUG,
> +	OPT_INTERACTIVE_DEBUG,
> +	OPT_HELP = 'h'
>  };
>  
>  static int igt_exitcode = IGT_EXIT_SUCCESS;
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options
  2019-05-29 23:27 ` [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options Lucas De Marchi
@ 2019-05-31 10:05   ` Petri Latvala
  0 siblings, 0 replies; 19+ messages in thread
From: Petri Latvala @ 2019-05-31 10:05 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, May 29, 2019 at 04:27:35PM -0700, Lucas De Marchi wrote:
> This is usually used by long options when working with enum to set long
> option values. So replace the strchr() with a memchr() to take that into
> account.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>

The latter strchr-memchr change is needless but meh.


> ---
>  lib/igt_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 814f5c72..a0b7e581 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -680,6 +680,7 @@ static int common_init(int *argc, char **argv,
>  	};
>  	char *short_opts;
>  	const char *std_short_opts = "h";
> +	size_t std_short_opts_len = strlen(std_short_opts);
>  	struct option *combined_opts;
>  	int extra_opt_count;
>  	int all_opt_count;
> @@ -713,7 +714,7 @@ static int common_init(int *argc, char **argv,
>  
>  		/* check for conflicts with standard short options */
>  		if (extra_long_opts[extra_opt_count].val != ':'
> -		    && (conflicting_char = strchr(std_short_opts, extra_long_opts[extra_opt_count].val))) {
> +		    && (conflicting_char = memchr(std_short_opts, extra_long_opts[extra_opt_count].val, std_short_opts_len))) {
>  			igt_critical("Conflicting long and short option 'val' representation between --%s and -%c\n",
>  				     extra_long_opts[extra_opt_count].name,
>  				     *conflicting_char);
> @@ -727,7 +728,7 @@ static int common_init(int *argc, char **argv,
>  			continue;
>  
>  		/* check for conflicts with standard short options */
> -		if (strchr(std_short_opts, extra_short_opts[i])) {
> +		if (memchr(std_short_opts, extra_short_opts[i], std_short_opts_len)) {
>  			igt_critical("Conflicting short option: -%c\n", std_short_opts[i]);
>  			assert(0);
>  		}
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 4/5] testdisplay: use first available option values
  2019-05-29 23:27 ` [PATCH i-g-t 4/5] testdisplay: use first available option values Lucas De Marchi
  2019-05-30  0:05   ` Antonio Argenziano
@ 2019-05-31 10:06   ` Petri Latvala
  1 sibling, 0 replies; 19+ messages in thread
From: Petri Latvala @ 2019-05-31 10:06 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, May 29, 2019 at 04:27:36PM -0700, Lucas De Marchi wrote:
> Now that core options are set to 500 and above, start from the lowest
> values without causing problems with conflicts. This also rename the
> constants to follow the names from the core.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>

> ---
>  tests/testdisplay.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/testdisplay.c b/tests/testdisplay.c
> index b4f0d45f..32590547 100644
> --- a/tests/testdisplay.c
> +++ b/tests/testdisplay.c
> @@ -69,8 +69,10 @@
>  #include <stdlib.h>
>  #include <signal.h>
>  
> -#define Yb_OPT		 5
> -#define Yf_OPT		 6
> +enum {
> +	OPT_YB,
> +	OPT_YF,
> +};
>  
>  static int tio_fd;
>  struct termios saved_tio;
> @@ -573,8 +575,8 @@ static void set_termio_mode(void)
>  
>  static char optstr[] = "3iaf:s:d:p:mrto:j:y";
>  static struct option long_opts[] = {
> -	{"yb", 0, 0, Yb_OPT},
> -	{"yf", 0, 0, Yf_OPT},
> +	{"yb", 0, 0, OPT_YB},
> +	{"yf", 0, 0, OPT_YF},
>  	{ 0, 0, 0, 0 }
>  };
>  
> @@ -648,10 +650,10 @@ static int opt_handler(int opt, int opt_index, void *data)
>  		tiling = LOCAL_I915_FORMAT_MOD_X_TILED;
>  		break;
>  	case 'y':
> -	case Yb_OPT:
> +	case OPT_YB:
>  		tiling = LOCAL_I915_FORMAT_MOD_Y_TILED;
>  		break;
> -	case Yf_OPT:
> +	case OPT_YF:
>  		tiling = LOCAL_I915_FORMAT_MOD_Yf_TILED;
>  		break;
>  	case 'r':
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 5/5] lib/igt_core: add -h to usage
  2019-05-29 23:27 ` [PATCH i-g-t 5/5] lib/igt_core: add -h to usage Lucas De Marchi
@ 2019-05-31 10:07   ` Petri Latvala
  2019-05-31 19:23     ` Lucas De Marchi
  0 siblings, 1 reply; 19+ messages in thread
From: Petri Latvala @ 2019-05-31 10:07 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

On Wed, May 29, 2019 at 04:27:37PM -0700, Lucas De Marchi wrote:
> We also accept the short option -h.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Please send (CC or otherwise) IGT patches to igt-dev in the future, please.




> ---
>  lib/igt_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index a0b7e581..6b9f0425 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -558,7 +558,7 @@ static void print_usage(const char *help_str, bool output_on_stderr)
>  		   "  --debug[=log-domain]\n"
>  		   "  --interactive-debug[=domain]\n"
>  		   "  --help-description\n"
> -		   "  --help\n");
> +		   "  --help|-h\n");
>  	if (help_str)
>  		fprintf(f, "%s\n", help_str);
>  }
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/5] lib/tests: fix conflicting args test
  2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
                   ` (6 preceding siblings ...)
  2019-05-31  9:59 ` [PATCH i-g-t 1/5] " Petri Latvala
@ 2019-05-31 14:47 ` Patchwork
  7 siblings, 0 replies; 19+ messages in thread
From: Patchwork @ 2019-05-31 14:47 UTC (permalink / raw)
  To: Lucas De Marchi; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/5] lib/tests: fix conflicting args test
URL   : https://patchwork.freedesktop.org/series/61355/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6166_full -> IGTPW_3078_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61355/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3078_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-apl5/igt@gem_eio@in-flight-suspend.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-apl4/igt@gem_eio@in-flight-suspend.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-iclb:         [PASS][3] -> [FAIL][4] ([fdo#110802]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb7/igt@gem_workarounds@suspend-resume-fd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb2/igt@gem_workarounds@suspend-resume-fd.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-hsw:          [PASS][5] -> [SKIP][6] ([fdo#109271]) +15 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-hsw5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-hsw1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [PASS][7] -> [FAIL][8] ([fdo#103167]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][11] -> [FAIL][12] ([fdo#103166])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#109441])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [PASS][15] -> [FAIL][16] ([fdo#99912])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-hsw1/igt@kms_setmode@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-hsw1/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@drm_read@short-buffer-block:
    - shard-apl:          [INCOMPLETE][17] ([fdo#103927]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-apl4/igt@drm_read@short-buffer-block.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-apl8/igt@drm_read@short-buffer-block.html

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-kbl:          [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20] +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-kbl6/igt@gem_ctx_isolation@vecs0-s3.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-kbl2/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [SKIP][21] ([fdo#109271]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-snb1/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-glk:          [FAIL][23] ([fdo#104873]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][25] ([fdo#109349]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@2x-plain-flip-ts-check-interruptible:
    - shard-hsw:          [SKIP][27] ([fdo#109271]) -> [PASS][28] +27 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-hsw8/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-apl:          [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [FAIL][31] ([fdo#103167]) -> [PASS][32] +6 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_psr@psr2_primary_page_flip:
    - shard-iclb:         [SKIP][33] ([fdo#109441]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-iclb:         [INCOMPLETE][35] ([fdo#107713] / [fdo#110026]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb7/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb6/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html

  * igt@tools_test@tools_test:
    - shard-apl:          [SKIP][37] ([fdo#109271]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-apl5/igt@tools_test@tools_test.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-apl6/igt@tools_test@tools_test.html

  
#### Warnings ####

  * igt@gem_mmap_gtt@forked-big-copy:
    - shard-iclb:         [TIMEOUT][39] ([fdo#109673]) -> [INCOMPLETE][40] ([fdo#107713] / [fdo#109100])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6166/shard-iclb2/igt@gem_mmap_gtt@forked-big-copy.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/shard-iclb1/igt@gem_mmap_gtt@forked-big-copy.html

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
  [fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
  [fdo#110802]: https://bugs.freedesktop.org/show_bug.cgi?id=110802
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5024 -> IGTPW_3078
  * Piglit: piglit_4509 -> None

  CI_DRM_6166: 0bd6fdd57b1e01b228ba81fea2b3e9fc381b3298 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3078: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
  IGT_5024: f414756be2ac57e194919973da7b86644ba61241 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3078/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 1/5] lib/tests: fix conflicting args test
  2019-05-31  9:59 ` [PATCH i-g-t 1/5] " Petri Latvala
@ 2019-05-31 14:55   ` Lucas De Marchi
  2019-06-04 21:38     ` Lucas De Marchi
  0 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-31 14:55 UTC (permalink / raw)
  To: intel-gfx

On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote:
>On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
>> We want to check if the long option conflicts with one from the core.
>> The check for conflicting short option already exists just above.
>
>No, this one is checking that the val (the 0) doesn't conflict.

My point is that this check is already done above. We don't need to do
it again.

If you insist, then we will need to raise it to magic number 500,
because 0 won't be a conflict after this series.

Lucas De Marchi

>
>
>-- 
>Petri Latvala
>
>
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>>  lib/tests/igt_conflicting_args.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/tests/igt_conflicting_args.c b/lib/tests/igt_conflicting_args.c
>> index c357b6c5..d8be138e 100644
>> --- a/lib/tests/igt_conflicting_args.c
>> +++ b/lib/tests/igt_conflicting_args.c
>> @@ -91,7 +91,7 @@ int main(int argc, char **argv)
>>  	internal_assert_wsignaled(do_fork(), SIGABRT);
>>
>>  	/* conflict on long option 'val' representations */
>> -	long_options[0] = (struct option) { "iterations", required_argument, NULL, 0};
>> +	long_options[0] = (struct option) { "list-subtests", required_argument, NULL, 0};
>>  	short_options = "";
>>  	internal_assert_wsignaled(do_fork(), SIGABRT);
>>
>> --
>> 2.21.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 5/5] lib/igt_core: add -h to usage
  2019-05-31 10:07   ` Petri Latvala
@ 2019-05-31 19:23     ` Lucas De Marchi
  0 siblings, 0 replies; 19+ messages in thread
From: Lucas De Marchi @ 2019-05-31 19:23 UTC (permalink / raw)
  To: intel-gfx

On Fri, May 31, 2019 at 01:07:33PM +0300, Petri Latvala wrote:
>On Wed, May 29, 2019 at 04:27:37PM -0700, Lucas De Marchi wrote:
>> We also accept the short option -h.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
>Please send (CC or otherwise) IGT patches to igt-dev in the future, please.

yeah, I was doing it from a different machine and went the route of
opening the mailing list and copy the address from someone's patch.
Just to realize later his patch was sent to both mailing lists and I
copied only the wrong one.

thanks for the review

Lucas De Marchi

>
>
>
>
>> ---
>>  lib/igt_core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/igt_core.c b/lib/igt_core.c
>> index a0b7e581..6b9f0425 100644
>> --- a/lib/igt_core.c
>> +++ b/lib/igt_core.c
>> @@ -558,7 +558,7 @@ static void print_usage(const char *help_str, bool output_on_stderr)
>>  		   "  --debug[=log-domain]\n"
>>  		   "  --interactive-debug[=domain]\n"
>>  		   "  --help-description\n"
>> -		   "  --help\n");
>> +		   "  --help|-h\n");
>>  	if (help_str)
>>  		fprintf(f, "%s\n", help_str);
>>  }
>> --
>> 2.21.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 1/5] lib/tests: fix conflicting args test
  2019-05-31 14:55   ` Lucas De Marchi
@ 2019-06-04 21:38     ` Lucas De Marchi
  2019-06-05  9:04       ` Petri Latvala
  0 siblings, 1 reply; 19+ messages in thread
From: Lucas De Marchi @ 2019-06-04 21:38 UTC (permalink / raw)
  To: intel-gfx

On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote:
>On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote:
>>On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
>>>We want to check if the long option conflicts with one from the core.
>>>The check for conflicting short option already exists just above.
>>
>>No, this one is checking that the val (the 0) doesn't conflict.
>
>My point is that this check is already done above. We don't need to do
>it again.
>
>If you insist, then we will need to raise it to magic number 500,
>because 0 won't be a conflict after this series.

and just a reminder that I can't merge the rest without this one,
otherwise it would break igt checks.

Lucas De Marchi

>
>Lucas De Marchi
>
>>
>>
>>-- 
>>Petri Latvala
>>
>>
>>>
>>>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>>>---
>>> lib/tests/igt_conflicting_args.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/lib/tests/igt_conflicting_args.c b/lib/tests/igt_conflicting_args.c
>>>index c357b6c5..d8be138e 100644
>>>--- a/lib/tests/igt_conflicting_args.c
>>>+++ b/lib/tests/igt_conflicting_args.c
>>>@@ -91,7 +91,7 @@ int main(int argc, char **argv)
>>> 	internal_assert_wsignaled(do_fork(), SIGABRT);
>>>
>>> 	/* conflict on long option 'val' representations */
>>>-	long_options[0] = (struct option) { "iterations", required_argument, NULL, 0};
>>>+	long_options[0] = (struct option) { "list-subtests", required_argument, NULL, 0};
>>> 	short_options = "";
>>> 	internal_assert_wsignaled(do_fork(), SIGABRT);
>>>
>>>--
>>>2.21.0
>>>
>>>_______________________________________________
>>>Intel-gfx mailing list
>>>Intel-gfx@lists.freedesktop.org
>>>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH i-g-t 1/5] lib/tests: fix conflicting args test
  2019-06-04 21:38     ` Lucas De Marchi
@ 2019-06-05  9:04       ` Petri Latvala
  0 siblings, 0 replies; 19+ messages in thread
From: Petri Latvala @ 2019-06-05  9:04 UTC (permalink / raw)
  To: Lucas De Marchi, intel-gfx


On 6/5/19 12:38 AM, Lucas De Marchi wrote:
> On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote:
>> On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote:
>>> On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote:
>>>> We want to check if the long option conflicts with one from the core.
>>>> The check for conflicting short option already exists just above.
>>>
>>> No, this one is checking that the val (the 0) doesn't conflict.
>>
>> My point is that this check is already done above. We don't need to do
>> it again.


There's two val conflict tests. One checks for conflicts against core 
short options, the latter (modified here) checks for conflicts against 
core long option values.



>>
>> If you insist, then we will need to raise it to magic number 500,
>> because 0 won't be a conflict after this series.

Yeah that would be the correct change.



Petri


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-06-05  9:04 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 23:27 [PATCH i-g-t 1/5] lib/tests: fix conflicting args test Lucas De Marchi
2019-05-29 23:27 ` [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests Lucas De Marchi
2019-05-30  0:03   ` Antonio Argenziano
2019-05-31 10:00   ` Petri Latvala
2019-05-29 23:27 ` [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options Lucas De Marchi
2019-05-31 10:05   ` Petri Latvala
2019-05-29 23:27 ` [PATCH i-g-t 4/5] testdisplay: use first available option values Lucas De Marchi
2019-05-30  0:05   ` Antonio Argenziano
2019-05-31 10:06   ` Petri Latvala
2019-05-29 23:27 ` [PATCH i-g-t 5/5] lib/igt_core: add -h to usage Lucas De Marchi
2019-05-31 10:07   ` Petri Latvala
2019-05-31 19:23     ` Lucas De Marchi
2019-05-30  1:27 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] lib/tests: fix conflicting args test Patchwork
2019-05-31  7:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-31  9:59 ` [PATCH i-g-t 1/5] " Petri Latvala
2019-05-31 14:55   ` Lucas De Marchi
2019-06-04 21:38     ` Lucas De Marchi
2019-06-05  9:04       ` Petri Latvala
2019-05-31 14:47 ` ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.