From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Lee Jones <lee.jones@linaro.org> Cc: alokc@codeaurora.org, kramasub@codeaurora.org, andy.gross@linaro.org, david.brown@linaro.org, wsa+renesas@sang-engineering.com, linus.walleij@linaro.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jlhugo@gmail.com, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 8/8] usb: dwc3: qcom: Improve error handling Date: Wed, 5 Jun 2019 00:03:30 -0700 [thread overview] Message-ID: <20190605070330.GO22737@tuxbook-pro> (raw) In-Reply-To: <20190604104455.8877-8-lee.jones@linaro.org> On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > dwc3_qcom_clk_init() is called with of_count_phandle_with_args() as an > argument. If of_count_phandle_with_args() returns an error, the number > of clocks will be a negative value and will lead to undefined behaviour. > > Ensure we check for an error before attempting to blindly use the value. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/usb/dwc3/dwc3-qcom.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index f21fdd6cdd1a..633482926497 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -419,6 +419,9 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count) > if (!count || ACPI_HANDLE(dev)) > return 0; > > + if (count < 0) > + return count; > + > qcom->clks = devm_kcalloc(dev, qcom->num_clocks, > sizeof(struct clk *), GFP_KERNEL); > if (!qcom->clks) > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Lee Jones <lee.jones@linaro.org> Cc: balbi@kernel.org, wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.brown@linaro.org, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] usb: dwc3: qcom: Improve error handling Date: Wed, 5 Jun 2019 00:03:30 -0700 [thread overview] Message-ID: <20190605070330.GO22737@tuxbook-pro> (raw) In-Reply-To: <20190604104455.8877-8-lee.jones@linaro.org> On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > dwc3_qcom_clk_init() is called with of_count_phandle_with_args() as an > argument. If of_count_phandle_with_args() returns an error, the number > of clocks will be a negative value and will lead to undefined behaviour. > > Ensure we check for an error before attempting to blindly use the value. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/usb/dwc3/dwc3-qcom.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index f21fdd6cdd1a..633482926497 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -419,6 +419,9 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count) > if (!count || ACPI_HANDLE(dev)) > return 0; > > + if (count < 0) > + return count; > + > qcom->clks = devm_kcalloc(dev, qcom->num_clocks, > sizeof(struct clk *), GFP_KERNEL); > if (!qcom->clks) > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-05 7:02 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-04 10:44 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:20 ` Bjorn Andersson 2019-06-05 6:20 ` Bjorn Andersson 2019-06-05 7:16 ` Lee Jones 2019-06-05 7:16 ` Lee Jones 2019-06-05 7:22 ` Ard Biesheuvel 2019-06-05 7:22 ` Ard Biesheuvel 2019-06-05 8:23 ` Lee Jones 2019-06-05 8:23 ` Lee Jones 2019-06-05 7:56 ` Johan Hovold 2019-06-05 7:56 ` Johan Hovold 2019-06-05 8:20 ` Lee Jones 2019-06-05 8:20 ` Lee Jones 2019-06-05 8:33 ` Johan Hovold 2019-06-05 8:33 ` Johan Hovold 2019-06-05 8:49 ` Lee Jones 2019-06-05 8:49 ` Lee Jones 2019-06-05 8:55 ` Johan Hovold 2019-06-05 8:55 ` Johan Hovold 2019-06-05 14:18 ` Wolfram Sang 2019-06-05 14:18 ` Wolfram Sang 2019-06-05 18:49 ` Lee Jones 2019-06-05 18:49 ` Lee Jones 2019-06-12 14:54 ` Johan Hovold 2019-06-12 14:54 ` Johan Hovold 2019-06-04 10:44 ` [PATCH 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 4/8] pinctrl: qcom: sdm845: Provide ACPI support Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:17 ` Bjorn Andersson 2019-06-05 6:17 ` Bjorn Andersson 2019-06-05 7:31 ` Lee Jones 2019-06-05 7:31 ` Lee Jones 2019-06-05 19:06 ` Bjorn Andersson 2019-06-05 19:06 ` Bjorn Andersson 2019-06-05 19:35 ` Lee Jones 2019-06-05 19:35 ` Lee Jones 2019-06-04 10:44 ` [PATCH 5/8] soc: qcom: geni: Add support for ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 6/8] usb: dwc3: qcom: Add support for booting with ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:35 ` Bjorn Andersson 2019-06-05 6:35 ` Bjorn Andersson 2019-06-05 7:09 ` Lee Jones 2019-06-05 7:09 ` Lee Jones 2019-06-05 9:55 ` Lee Jones 2019-06-05 9:55 ` Lee Jones 2019-06-04 10:44 ` [PATCH 7/8] usb: dwc3: qcom: Start USB in 'host mode' on the SDM845 Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 7:00 ` Bjorn Andersson 2019-06-05 7:00 ` Bjorn Andersson 2019-06-05 8:34 ` Lee Jones 2019-06-05 8:34 ` Lee Jones 2019-06-05 14:07 ` Jeffrey Hugo 2019-06-05 14:07 ` Jeffrey Hugo 2019-06-05 18:50 ` Lee Jones 2019-06-05 18:50 ` Lee Jones 2019-06-05 19:14 ` Bjorn Andersson 2019-06-05 19:14 ` Bjorn Andersson 2019-06-05 19:29 ` Lee Jones 2019-06-05 19:29 ` Lee Jones 2019-06-04 10:44 ` [PATCH 8/8] usb: dwc3: qcom: Improve error handling Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 7:03 ` Bjorn Andersson [this message] 2019-06-05 7:03 ` Bjorn Andersson 2019-06-05 11:42 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones 2019-06-05 11:43 ` [PATCH 8/8] usb: dwc3: qcom: Improve error handling Lee Jones 2019-06-05 11:43 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190605070330.GO22737@tuxbook-pro \ --to=bjorn.andersson@linaro.org \ --cc=alokc@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=balbi@kernel.org \ --cc=david.brown@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jlhugo@gmail.com \ --cc=kramasub@codeaurora.org \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.