All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: balducci@units.it
Cc: bugzilla-daemon@bugzilla.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org
Subject: Re: [Bug 203715] New: BUG: unable to handle kernel NULL pointer dereference under stress (possibly related to https://lkml.org/lkml/2019/5/24/292 ?)
Date: Wed, 5 Jun 2019 18:21:36 +0100	[thread overview]
Message-ID: <20190605172136.GC4626@techsingularity.net> (raw)
In-Reply-To: <11510.1559738359@dschgrazlin2.units.it>

On Wed, Jun 05, 2019 at 02:38:55PM +0200, balducci@units.it wrote:
> hello
> 
> > Sorry, I was on holidays and only playing catchup now. Does this happen
> > to trigger with 5.2-rc3? I ask because there were other fixes in there
> > with stable cc'd that have not been picked up yet. They are a poor match
> > for this particular bug but it would be nice to confirm.
> 
> I have built v5.2-rc3 from git (stable/linux-stable.git) and tested it
> against firefox-67.0.1 build: no joy. 
> 
> I'm going to upload the kernel log and the config I used for v5.2-rc3
> (there were a couple of new opts) to bugzilla, if that can help
> 

Can you try the following compile-tested only patch please?

diff --git a/mm/compaction.c b/mm/compaction.c
index 9e1b9acb116b..b3f18084866c 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -277,8 +277,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
 	}
 
 	/* Ensure the end of the pageblock or zone is online and valid */
-	block_pfn += pageblock_nr_pages;
-	block_pfn = min(block_pfn, zone_end_pfn(zone) - 1);
+	block_pfn = min(pageblock_end_pfn(block_pfn), zone_end_pfn(zone) - 1);
 	end_page = pfn_to_online_page(block_pfn);
 	if (!end_page)
 		return false;

-- 
Mel Gorman
SUSE Labs


  parent reply	other threads:[~2019-06-05 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-203715-27@https.bugzilla.kernel.org/>
2019-05-29 23:04 ` [Bug 203715] New: BUG: unable to handle kernel NULL pointer dereference under stress (possibly related to https://lkml.org/lkml/2019/5/24/292 ?) Andrew Morton
2019-06-04 11:05   ` Mel Gorman
2019-06-04 11:43     ` balducci
2019-06-05 12:38     ` balducci
2019-06-05 12:48       ` Mel Gorman
2019-06-05 17:21       ` Mel Gorman [this message]
2019-06-06 13:20         ` balducci
2019-06-06 14:44           ` Mel Gorman
2019-06-11  9:03             ` Mel Gorman
2019-06-11  9:30               ` balducci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605172136.GC4626@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=balducci@units.it \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.