All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: balducci@units.it
Cc: bugzilla-daemon@bugzilla.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org
Subject: Re: [Bug 203715] New: BUG: unable to handle kernel NULL pointer dereference under stress (possibly related to https://lkml.org/lkml/2019/5/24/292 ?)
Date: Tue, 11 Jun 2019 10:03:45 +0100	[thread overview]
Message-ID: <20190611090345.GC28744@techsingularity.net> (raw)
In-Reply-To: <20190606142600.GA2782@techsingularity.net>

On Thu, Jun 06, 2019 at 03:44:24PM +0100, Mel Gorman wrote:
> > (I applied the patch on top of e577c8b64d58fe307ea4d5149d31615df2d90861,
> > right?)
> 
> Please try the following on top of 5.2-rc3
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9e1b9acb116b..69f4ddfddfa4 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -277,8 +277,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
>  	}
>  
>  	/* Ensure the end of the pageblock or zone is online and valid */
> -	block_pfn += pageblock_nr_pages;
> -	block_pfn = min(block_pfn, zone_end_pfn(zone) - 1);
> +	block_pfn = min(pageblock_end_pfn(block_pfn), zone_end_pfn(zone) - 1);
>  	end_page = pfn_to_online_page(block_pfn);
>  	if (!end_page)
>  		return false;
> @@ -289,7 +288,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
>  	 * is necessary for the block to be a migration source/target.
>  	 */
>  	do {
> -		if (pfn_valid_within(pfn)) {
> +		if (pfn_valid(pfn)) {
>  			if (check_source && PageLRU(page)) {
>  				clear_pageblock_skip(page);
>  				return true;

Any news with this patch?

-- 
Mel Gorman
SUSE Labs


  reply	other threads:[~2019-06-11  9:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-203715-27@https.bugzilla.kernel.org/>
2019-05-29 23:04 ` [Bug 203715] New: BUG: unable to handle kernel NULL pointer dereference under stress (possibly related to https://lkml.org/lkml/2019/5/24/292 ?) Andrew Morton
2019-06-04 11:05   ` Mel Gorman
2019-06-04 11:43     ` balducci
2019-06-05 12:38     ` balducci
2019-06-05 12:48       ` Mel Gorman
2019-06-05 17:21       ` Mel Gorman
2019-06-06 13:20         ` balducci
2019-06-06 14:44           ` Mel Gorman
2019-06-11  9:03             ` Mel Gorman [this message]
2019-06-11  9:30               ` balducci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190611090345.GC28744@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=balducci@units.it \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.