[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pre-icl can't scale fp16 formats so let's skip those. Since we
already have the can_rotate() function let's add a similar one
for scaling.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_plane_scaling.c | 32 ++++++++++++++++++++++++++++----
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3d24713045c0..0bd3690450b4 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -201,6 +201,26 @@ static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
 	return true;
 }
 
+static bool can_scale(data_t *d, unsigned format)
+{
+	if (!is_i915_device(d->drm_fd))
+		return true;
+
+	switch (format) {
+	case DRM_FORMAT_XRGB16161616F:
+	case DRM_FORMAT_XBGR16161616F:
+	case DRM_FORMAT_ARGB16161616F:
+	case DRM_FORMAT_ABGR16161616F:
+		if (intel_gen(d->devid) >= 11)
+			return true;
+		/* fall through */
+	case DRM_FORMAT_C8:
+		return false;
+	default:
+		return true;
+	}
+}
+
 static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
 					   igt_output_t *output)
 {
@@ -221,7 +241,8 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
 
 				if (igt_fb_supported_format(format) &&
 				    igt_plane_has_format_mod(plane, format, tiling) &&
-				    can_rotate(d, format, tiling, rot))
+				    can_rotate(d, format, tiling, rot) &&
+				    can_scale(d, format))
 					check_scaling_pipe_plane_rot(d, plane, format,
 								     tiling, pipe,
 								     output, rot);
@@ -255,7 +276,8 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
 				uint32_t format = plane->drm_plane->formats[j];
 
 				if (igt_fb_supported_format(format) &&
-				    igt_plane_has_format_mod(plane, format, tiling))
+				    igt_plane_has_format_mod(plane, format, tiling) &&
+				    can_scale(d, format))
 					check_scaling_pipe_plane_rot(d, plane,
 								     format, tiling,
 								     pipe, output, IGT_ROTATION_0);
@@ -490,13 +512,15 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
 
 	for (int i = 0; i < d->plane1->drm_plane->count_formats; i++) {
 		unsigned f1 = d->plane1->drm_plane->formats[i];
-		if (!igt_fb_supported_format(f1))
+		if (!igt_fb_supported_format(f1) ||
+		    !can_scale(d, f1))
 			continue;
 
 		for (int j = 0; j < d->plane2->drm_plane->count_formats; j++) {
 			unsigned f2 = d->plane2->drm_plane->formats[j];
 
-			if (!igt_fb_supported_format(f2))
+			if (!igt_fb_supported_format(f2) ||
+			    !can_scale(d, f2))
 				continue;
 
 			__test_scaler_with_clipping_clamping_scenario(d, mode, f1, f2);
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Skip fp16 formats on pre-icl
URL   : https://patchwork.freedesktop.org/series/61676/
State : success

== Summary ==

CI Bug Log - changes from IGT_5041 -> IGTPW_3122
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61676/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3122 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-small-bo-tiledy:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html

  * igt@i915_selftest@live_contexts:
    - fi-icl-dsi:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/fi-icl-dsi/igt@i915_selftest@live_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/fi-icl-dsi/igt@i915_selftest@live_contexts.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-cml-u2:          [PASS][5] -> [FAIL][6] ([fdo#110627])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html

  
#### Possible fixes ####

  * igt@gem_ringfill@basic-default-forked:
    - fi-icl-u3:          [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/fi-icl-u3/igt@gem_ringfill@basic-default-forked.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/fi-icl-u3/igt@gem_ringfill@basic-default-forked.html

  
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#110627]: https://bugs.freedesktop.org/show_bug.cgi?id=110627


Participating hosts (53 -> 46)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5041 -> IGTPW_3122

  CI_DRM_6196: 7a984cf09665b9ef4c63e82a8551bdde5da229ae @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3122: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/
  IGT_5041: 4f2b9f5930fa33d091cf89637dc6e7f76f632a88 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Patchwork]

== Series Details ==

Series: tests/kms_plane_scaling: Skip fp16 formats on pre-icl
URL   : https://patchwork.freedesktop.org/series/61676/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5041_full -> IGTPW_3122_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3122_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3122_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/61676/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3122_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_eio@in-flight-suspend:
    - shard-snb:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-snb1/igt@gem_eio@in-flight-suspend.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-snb1/igt@gem_eio@in-flight-suspend.html

  * igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
    - shard-iclb:         NOTRUN -> [SKIP][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html

  
Known issues
------------

  Here are the changes found in IGTPW_3122_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@forked-big-copy:
    - shard-iclb:         [PASS][4] -> [INCOMPLETE][5] ([fdo#107713] / [fdo#109100])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb4/igt@gem_mmap_gtt@forked-big-copy.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb1/igt@gem_mmap_gtt@forked-big-copy.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [PASS][6] -> [FAIL][7] ([fdo#108686])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb3/igt@gem_tiled_swapping@non-threaded.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb7/igt@gem_tiled_swapping@non-threaded.html
    - shard-hsw:          [PASS][8] -> [FAIL][9] ([fdo#108686])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-hsw7/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [PASS][10] -> [SKIP][11] ([fdo#109271])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-kbl7/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-apl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#108566])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_fence_pin_leak:
    - shard-snb:          [PASS][14] -> [SKIP][15] ([fdo#109271])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-snb1/igt@kms_fence_pin_leak.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-snb5/igt@kms_fence_pin_leak.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-apl:          [PASS][16] -> [FAIL][17] ([fdo#102887] / [fdo#105363])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-apl4/igt@kms_flip@flip-vs-expired-vblank.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-apl8/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [PASS][18] -> [SKIP][19] ([fdo#109271]) +20 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][20] -> [FAIL][21] ([fdo#103167]) +4 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][22] -> [FAIL][23] ([fdo#103166])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_sprite_plane_onoff:
    - shard-iclb:         [PASS][24] -> [SKIP][25] ([fdo#109441]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb5/igt@kms_psr@psr2_sprite_plane_onoff.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [PASS][26] -> [FAIL][27] ([fdo#99912])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-hsw1/igt@kms_setmode@basic.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-hsw1/igt@kms_setmode@basic.html
    - shard-kbl:          [PASS][28] -> [FAIL][29] ([fdo#99912])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-kbl6/igt@kms_setmode@basic.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-kbl6/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-kbl:          [DMESG-WARN][30] ([fdo#103313]) -> [PASS][31]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-kbl3/igt@gem_ctx_isolation@vecs0-s3.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-kbl7/igt@gem_ctx_isolation@vecs0-s3.html

  * {igt@gem_exec_balancer@bonded-imm}:
    - shard-iclb:         [FAIL][32] -> [PASS][33] +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb2/igt@gem_exec_balancer@bonded-imm.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb5/igt@gem_exec_balancer@bonded-imm.html

  * igt@gem_mmap_gtt@forked-medium-copy-xy:
    - shard-iclb:         [TIMEOUT][34] ([fdo#109673]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb8/igt@gem_mmap_gtt@forked-medium-copy-xy.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@gem_mmap_gtt@forked-medium-copy-xy.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [DMESG-WARN][36] ([fdo#108686]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-glk3/igt@gem_tiled_swapping@non-threaded.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-glk3/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_suspend@debugfs-reader:
    - shard-apl:          [DMESG-WARN][38] ([fdo#108566]) -> [PASS][39] +6 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-apl7/igt@i915_suspend@debugfs-reader.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-apl4/igt@i915_suspend@debugfs-reader.html

  * igt@kms_big_fb@linear-8bpp-rotate-180:
    - shard-hsw:          [INCOMPLETE][40] ([fdo#103540]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-hsw1/igt@kms_big_fb@linear-8bpp-rotate-180.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-hsw7/igt@kms_big_fb@linear-8bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
    - shard-snb:          [SKIP][42] ([fdo#109271]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-snb6/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-snb7/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-hsw:          [SKIP][44] ([fdo#109271]) -> [PASS][45] +52 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-hsw1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-hsw7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][46] ([fdo#109349]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
    - shard-glk:          [FAIL][48] ([fdo#103167]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-iclb:         [FAIL][50] ([fdo#103167]) -> [PASS][51] +3 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][52] ([fdo#103166]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][54] ([fdo#109441]) -> [PASS][55] +2 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu:
    - shard-iclb:         [INCOMPLETE][56] ([fdo#107713]) -> [SKIP][57] ([fdo#109280])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 6)
------------------------------

  Missing    (1): shard-skl 


Build changes
-------------

  * IGT: IGT_5041 -> IGTPW_3122

  CI_DRM_6196: 7a984cf09665b9ef4c63e82a8551bdde5da229ae @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3122: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/
  IGT_5041: 4f2b9f5930fa33d091cf89637dc6e7f76f632a88 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Ville Syrjälä]

On Fri, Jun 07, 2019 at 10:48:09AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: tests/kms_plane_scaling: Skip fp16 formats on pre-icl
> URL   : https://patchwork.freedesktop.org/series/61676/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from IGT_5041_full -> IGTPW_3122_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_3122_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_3122_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/61676/revisions/1/mbox/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_3122_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_eio@in-flight-suspend:
>     - shard-snb:          [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-snb1/igt@gem_eio@in-flight-suspend.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-snb1/igt@gem_eio@in-flight-suspend.html

Maybe
https://bugs.freedesktop.org/show_bug.cgi?id=109723

> 
>   * igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
>     - shard-iclb:         NOTRUN -> [SKIP][3]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-iclb2/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html

The test gained 8bpp support in the meantime. Nothing to see here.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Chris Wilson]

Quoting Ville Syrjälä (2019-06-12 16:20:54)
> On Fri, Jun 07, 2019 at 10:48:09AM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: tests/kms_plane_scaling: Skip fp16 formats on pre-icl
> > URL   : https://patchwork.freedesktop.org/series/61676/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from IGT_5041_full -> IGTPW_3122_full
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with IGTPW_3122_full absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in IGTPW_3122_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://patchwork.freedesktop.org/api/1.0/series/61676/revisions/1/mbox/
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in IGTPW_3122_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@gem_eio@in-flight-suspend:
> >     - shard-snb:          [PASS][1] -> [FAIL][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5041/shard-snb1/igt@gem_eio@in-flight-suspend.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3122/shard-snb1/igt@gem_eio@in-flight-suspend.html
> 
> Maybe
> https://bugs.freedesktop.org/show_bug.cgi?id=109723

It is not that one, but it's not yours either. It some weird fallout of
the new engine iterator.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Skip fp16 formats on pre-icl

[Ser, Simon]

On Wed, 2019-06-05 at 20:11 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Pre-icl can't scale fp16 formats so let's skip those. Since we
> already have the can_rotate() function let's add a similar one
> for scaling.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Also LGTM.

Reviewed-by: Simon Ser <simon.ser@intel.com>

> ---
>  tests/kms_plane_scaling.c | 32 ++++++++++++++++++++++++++++----
>  1 file changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 3d24713045c0..0bd3690450b4 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -201,6 +201,26 @@ static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
>  	return true;
>  }
>  
> +static bool can_scale(data_t *d, unsigned format)
> +{
> +	if (!is_i915_device(d->drm_fd))
> +		return true;
> +
> +	switch (format) {
> +	case DRM_FORMAT_XRGB16161616F:
> +	case DRM_FORMAT_XBGR16161616F:
> +	case DRM_FORMAT_ARGB16161616F:
> +	case DRM_FORMAT_ABGR16161616F:
> +		if (intel_gen(d->devid) >= 11)
> +			return true;
> +		/* fall through */
> +	case DRM_FORMAT_C8:
> +		return false;
> +	default:
> +		return true;
> +	}
> +}
> +
>  static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
>  					   igt_output_t *output)
>  {
> @@ -221,7 +241,8 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
>  
>  				if (igt_fb_supported_format(format) &&
>  				    igt_plane_has_format_mod(plane, format, tiling) &&
> -				    can_rotate(d, format, tiling, rot))
> +				    can_rotate(d, format, tiling, rot) &&
> +				    can_scale(d, format))
>  					check_scaling_pipe_plane_rot(d, plane, format,
>  								     tiling, pipe,
>  								     output, rot);
> @@ -255,7 +276,8 @@ static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_ou
>  				uint32_t format = plane->drm_plane->formats[j];
>  
>  				if (igt_fb_supported_format(format) &&
> -				    igt_plane_has_format_mod(plane, format, tiling))
> +				    igt_plane_has_format_mod(plane, format, tiling) &&
> +				    can_scale(d, format))
>  					check_scaling_pipe_plane_rot(d, plane,
>  								     format, tiling,
>  								     pipe, output, IGT_ROTATION_0);
> @@ -490,13 +512,15 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
>  
>  	for (int i = 0; i < d->plane1->drm_plane->count_formats; i++) {
>  		unsigned f1 = d->plane1->drm_plane->formats[i];
> -		if (!igt_fb_supported_format(f1))
> +		if (!igt_fb_supported_format(f1) ||
> +		    !can_scale(d, f1))
>  			continue;
>  
>  		for (int j = 0; j < d->plane2->drm_plane->count_formats; j++) {
>  			unsigned f2 = d->plane2->drm_plane->formats[j];
>  
> -			if (!igt_fb_supported_format(f2))
> +			if (!igt_fb_supported_format(f2) ||
> +			    !can_scale(d, f2))
>  				continue;
>  
>  			__test_scaler_with_clipping_clamping_scenario(d, mode, f1, f2);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev