* [PATCH v2] json-c: Make implicit-fallthrough only a warning for compilation under icecc
@ 2019-06-06 1:13 Douglas Royds
2019-06-06 2:09 ` Douglas Royds
0 siblings, 1 reply; 2+ messages in thread
From: Douglas Royds @ 2019-06-06 1:13 UTC (permalink / raw)
To: openembedded-core
icecc preprocesses source files locally before shipping them off to be compiled
on remote hosts. This preprocessing removes comments, including /* fallthrough */
comments in switch statements that normally prevent the implicit-fallthrough
warning. Rather than turning off -Werror completely, just reduce
implicit-fallthrough to a warning only.
In the -native case, we might be building on an earlier gcc, eg. gcc 5.4
under Ubuntu 16.04, so we do disable -Werror completely.
See https://github.com/icecc/icecream/issues/419
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
meta/recipes-devtools/json-c/json-c_0.13.1.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
index 5b10e68297..87a87aec44 100644
--- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
@@ -22,6 +22,9 @@ inherit autotools
EXTRA_OECONF = "--enable-rdrand"
+TARGET_CPPFLAGS =+ "-Wno-error=implicit-fallthrough"
+BUILD_CPPFLAGS =+ "-Wno-error"
+
do_configure_prepend() {
# Clean up autoconf cruft that should not be in the tarball
rm -f ${S}/config.status
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] json-c: Make implicit-fallthrough only a warning for compilation under icecc
2019-06-06 1:13 [PATCH v2] json-c: Make implicit-fallthrough only a warning for compilation under icecc Douglas Royds
@ 2019-06-06 2:09 ` Douglas Royds
0 siblings, 0 replies; 2+ messages in thread
From: Douglas Royds @ 2019-06-06 2:09 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
Please disregard this one, I have submitted a newer patch under a new
subject-line:
json-c: Disable icecc to avoid implicit-fallthrough warning as error
On 6/06/19 1:13 PM, Douglas Royds wrote:
> icecc preprocesses source files locally before shipping them off to be compiled
> on remote hosts. This preprocessing removes comments, including /* fallthrough */
> comments in switch statements that normally prevent the implicit-fallthrough
> warning. Rather than turning off -Werror completely, just reduce
> implicit-fallthrough to a warning only.
>
> In the -native case, we might be building on an earlier gcc, eg. gcc 5.4
> under Ubuntu 16.04, so we do disable -Werror completely.
>
> See https://github.com/icecc/icecream/issues/419
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
> meta/recipes-devtools/json-c/json-c_0.13.1.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> index 5b10e68297..87a87aec44 100644
> --- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> +++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> @@ -22,6 +22,9 @@ inherit autotools
>
> EXTRA_OECONF = "--enable-rdrand"
>
> +TARGET_CPPFLAGS =+ "-Wno-error=implicit-fallthrough"
> +BUILD_CPPFLAGS =+ "-Wno-error"
> +
> do_configure_prepend() {
> # Clean up autoconf cruft that should not be in the tarball
> rm -f ${S}/config.status
[-- Attachment #2: Type: text/html, Size: 2040 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-06 2:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 1:13 [PATCH v2] json-c: Make implicit-fallthrough only a warning for compilation under icecc Douglas Royds
2019-06-06 2:09 ` Douglas Royds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.