* [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, mchehab,
p.zabel, hkallweit1, lee.jones, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media,
Anders Roxell
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800
enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko
Rework to rename the name.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/regulator/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76e78fa449a2..6906938071f5 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -11,7 +11,8 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs := 88pm800.o
obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, mchehab,
p.zabel, hkallweit1, lee.jones, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media,
Anders Roxell
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800
enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko
Rework to rename the name.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/regulator/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76e78fa449a2..6906938071f5 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -11,7 +11,8 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs := 88pm800.o
obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
--
2.20.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: lgirdwood, broonie
Cc: andrew, linux-fbdev, airlied, stefan, a.hajda, lee.jones, marex,
f.fainelli, Anders Roxell, vivien.didelot, linux-media, daniel,
b.zolnierkie, s.hauer, dri-devel, mchehab, linux-arm-kernel,
netdev, linux-kernel, p.zabel, shawnguo, davem, hkallweit1
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800
enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko
Rework to rename the name.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/regulator/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76e78fa449a2..6906938071f5 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -11,7 +11,8 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs := 88pm800.o
obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
2019-06-06 9:47 ` Anders Roxell
(?)
(?)
@ 2019-06-06 10:59 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2019-06-06 10:59 UTC (permalink / raw)
To: Anders Roxell
Cc: lgirdwood, andrew, vivien.didelot, f.fainelli, marex, stefan,
airlied, daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda,
mchehab, p.zabel, hkallweit1, lee.jones, davem, netdev,
linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
> obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> +88pm800-regulator-objs := 88pm800.o
Don't do this, no need for this driver to look different to all the
others in the Makefile - just rename the whole file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 10:59 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2019-06-06 10:59 UTC (permalink / raw)
To: Anders Roxell
Cc: andrew, linux-fbdev, airlied, linux-kernel, lee.jones, marex,
f.fainelli, vivien.didelot, linux-media, b.zolnierkie, dri-devel,
mchehab, linux-arm-kernel, netdev, lgirdwood, shawnguo, davem,
hkallweit1
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
> obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> +88pm800-regulator-objs := 88pm800.o
Don't do this, no need for this driver to look different to all the
others in the Makefile - just rename the whole file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 10:59 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2019-06-06 10:59 UTC (permalink / raw)
To: Anders Roxell
Cc: andrew, linux-fbdev, airlied, stefan, linux-kernel, a.hajda,
lee.jones, marex, f.fainelli, vivien.didelot, linux-media,
daniel, b.zolnierkie, s.hauer, dri-devel, mchehab,
linux-arm-kernel, netdev, lgirdwood, p.zabel, shawnguo, davem,
hkallweit1
[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]
On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
> obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> +88pm800-regulator-objs := 88pm800.o
Don't do this, no need for this driver to look different to all the
others in the Makefile - just rename the whole file.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-06 10:59 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2019-06-06 10:59 UTC (permalink / raw)
To: Anders Roxell
Cc: andrew, linux-fbdev, airlied, linux-kernel, lee.jones, marex,
f.fainelli, vivien.didelot, linux-media, b.zolnierkie, dri-devel,
mchehab, linux-arm-kernel, netdev, lgirdwood, shawnguo, davem,
hkallweit1
[-- Attachment #1.1: Type: text/plain, Size: 380 bytes --]
On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
> obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> +88pm800-regulator-objs := 88pm800.o
Don't do this, no need for this driver to look different to all the
others in the Makefile - just rename the whole file.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
2019-06-06 10:59 ` Mark Brown
(?)
@ 2019-06-10 13:01 ` Anders Roxell
-1 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-10 13:01 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, andrew, vivien.didelot, f.fainelli, marex, stefan,
David Airlie, Daniel Vetter, shawnguo, s.hauer, b.zolnierkie,
a.hajda, Mauro Carvalho Chehab, p.zabel, hkallweit1, Lee Jones,
David Miller, Networking, Linux Kernel Mailing List, dri-devel,
Linux ARM, linux-fbdev, linux-media
On Thu, 6 Jun 2019 at 13:00, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
>
> > obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> > -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> > +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> > +88pm800-regulator-objs := 88pm800.o
>
> Don't do this, no need for this driver to look different to all the
> others in the Makefile - just rename the whole file.
Thank you for your review, I'll rework and resend v2 shortly.
Cheers,
Anders
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-10 13:01 ` Anders Roxell
0 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-10 13:01 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, andrew, vivien.didelot, f.fainelli, marex, stefan,
David Airlie, Daniel Vetter, shawnguo, s.hauer, b.zolnierkie,
a.hajda, Mauro Carvalho Chehab, p.zabel, hkallweit1, Lee Jones,
David Miller, Networking, Linux Kernel Mailing List, dri-devel,
Linux ARM, linux-fbdev, linux-media
On Thu, 6 Jun 2019 at 13:00, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
>
> > obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> > -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> > +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> > +88pm800-regulator-objs := 88pm800.o
>
> Don't do this, no need for this driver to look different to all the
> others in the Makefile - just rename the whole file.
Thank you for your review, I'll rework and resend v2 shortly.
Cheers,
Anders
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names
@ 2019-06-10 13:01 ` Anders Roxell
0 siblings, 0 replies; 10+ messages in thread
From: Anders Roxell @ 2019-06-10 13:01 UTC (permalink / raw)
To: Mark Brown
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, Daniel Vetter, b.zolnierkie,
s.hauer, dri-devel, Mauro Carvalho Chehab, Linux ARM, Networking,
Liam Girdwood, p.zabel, shawnguo, David Miller, hkallweit1
On Thu, 6 Jun 2019 at 13:00, Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
>
> > obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> > -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> > +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> > +88pm800-regulator-objs := 88pm800.o
>
> Don't do this, no need for this driver to look different to all the
> others in the Makefile - just rename the whole file.
Thank you for your review, I'll rework and resend v2 shortly.
Cheers,
Anders
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-06-10 13:02 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 8/8] drivers: regulator: 88pm800: fix warning same module names Anders Roxell
2019-06-06 9:47 ` Anders Roxell
2019-06-06 9:47 ` Anders Roxell
2019-06-06 10:59 ` Mark Brown
2019-06-06 10:59 ` Mark Brown
2019-06-06 10:59 ` Mark Brown
2019-06-06 10:59 ` Mark Brown
2019-06-10 13:01 ` Anders Roxell
2019-06-10 13:01 ` Anders Roxell
2019-06-10 13:01 ` Anders Roxell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.