All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Royds <douglas.royds@taitradio.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error
Date: Fri,  7 Jun 2019 13:21:57 +1200	[thread overview]
Message-ID: <20190607012157.16757-1-douglas.royds@taitradio.com> (raw)
In-Reply-To: <20190606020544.26181-1-douglas.royds@taitradio.com>

icecc preprocesses source files locally before shipping them off to be compiled
on remote hosts. This preprocessing removes comments, including /* fallthrough */
comments in switch statements that normally prevent the implicit-fallthrough
warning.

Rather than turning off -Werror by patching configure.ac, it is simpler to
disable icecc completely for json-c. There are very few source files to compile,
so the compilation is quick even without icecc.

See https://github.com/icecc/icecream/issues/419

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/icecc.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index edb0e10434..c0f21bdbfd 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -76,6 +76,7 @@ ICECC_ENV_DEBUG ??= ""
 # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
 #                             prefix" error.
 ICECC_SYSTEM_PACKAGE_BL += "\
+    json-c \
     libgcc-initial \
     target-sdk-provides-dummy \
     "
-- 
2.17.1



  parent reply	other threads:[~2019-06-07  1:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06  2:05 [PATCH] json-c: Disable icecc to avoid implicit-fallthrough warning as error Douglas Royds
2019-06-06  9:45 ` Burton, Ross
2019-06-06 21:03   ` Douglas Royds
2019-06-06 21:15     ` Joshua Watt
2019-06-06 21:53       ` Douglas Royds
2019-06-06 22:04     ` Burton, Ross
2019-06-07  1:21 ` Douglas Royds [this message]
2019-06-07 11:20   ` [PATCH v2] " Burton, Ross
2019-06-09 19:56     ` Burton, Ross
2019-06-11  1:59   ` Douglas Royds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190607012157.16757-1-douglas.royds@taitradio.com \
    --to=douglas.royds@taitradio.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.