From: "Burton, Ross" <ross.burton@intel.com>
To: Douglas Royds <douglas.royds@taitradio.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error
Date: Fri, 7 Jun 2019 12:20:14 +0100 [thread overview]
Message-ID: <CAJTo0LaXrqCh6Nn9V8QWZS8+ivUdbOwTAcVvwXi7xziETMQKtw@mail.gmail.com> (raw)
In-Reply-To: <20190607012157.16757-1-douglas.royds@taitradio.com>
FWIW I still believe that just patching out -Werror is the correct fix
here. To be honest I'm really close to writing a QA check that
-Werror and friends isn't being used at all...
Filed https://github.com/json-c/json-c/issues/489 in the hope that
upstream will handle it.
Ross
On Fri, 7 Jun 2019 at 02:22, Douglas Royds via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
>
> icecc preprocesses source files locally before shipping them off to be compiled
> on remote hosts. This preprocessing removes comments, including /* fallthrough */
> comments in switch statements that normally prevent the implicit-fallthrough
> warning.
>
> Rather than turning off -Werror by patching configure.ac, it is simpler to
> disable icecc completely for json-c. There are very few source files to compile,
> so the compilation is quick even without icecc.
>
> See https://github.com/icecc/icecream/issues/419
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
> meta/classes/icecc.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> index edb0e10434..c0f21bdbfd 100644
> --- a/meta/classes/icecc.bbclass
> +++ b/meta/classes/icecc.bbclass
> @@ -76,6 +76,7 @@ ICECC_ENV_DEBUG ??= ""
> # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
> # prefix" error.
> ICECC_SYSTEM_PACKAGE_BL += "\
> + json-c \
> libgcc-initial \
> target-sdk-provides-dummy \
> "
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2019-06-07 11:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 2:05 [PATCH] json-c: Disable icecc to avoid implicit-fallthrough warning as error Douglas Royds
2019-06-06 9:45 ` Burton, Ross
2019-06-06 21:03 ` Douglas Royds
2019-06-06 21:15 ` Joshua Watt
2019-06-06 21:53 ` Douglas Royds
2019-06-06 22:04 ` Burton, Ross
2019-06-07 1:21 ` [PATCH v2] " Douglas Royds
2019-06-07 11:20 ` Burton, Ross [this message]
2019-06-09 19:56 ` Burton, Ross
2019-06-11 1:59 ` Douglas Royds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJTo0LaXrqCh6Nn9V8QWZS8+ivUdbOwTAcVvwXi7xziETMQKtw@mail.gmail.com \
--to=ross.burton@intel.com \
--cc=douglas.royds@taitradio.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.