[PATCH] drm/fb: document dirty helper better

[PATCH] drm/fb: document dirty helper better

[Daniel Vetter]

Apparently little none fact that there's no need to hand-roll your own
anymore. Cc'ing a bunch of driver people who might want to know this
too.

Cc: Rob Clark <robdclark@gmail.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Lechner <david@lechnology.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_framebuffer.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
index c23016748e3f..c0e0256e3e98 100644
--- a/include/drm/drm_framebuffer.h
+++ b/include/drm/drm_framebuffer.h
@@ -87,6 +87,9 @@ struct drm_framebuffer_funcs {
 	 * for more information as all the semantics and arguments have a one to
 	 * one mapping on this function.
 	 *
+	 * Atomic drivers should use drm_atomic_helper_dirtyfb() to implement
+	 * this hook.
+	 *
 	 * RETURNS:
 	 *
 	 * 0 on success or a negative error code on failure.
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb: document dirty helper better

[Chris Wilson]

Quoting Daniel Vetter (2019-06-11 12:28:59)
> Apparently little none fact that there's no need to hand-roll your own
s/none/known/
> anymore. Cc'ing a bunch of driver people who might want to know this
> too.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb: document dirty helper better

[Noralf Trønnes]

Den 11.06.2019 13.28, skrev Daniel Vetter:
> Apparently little none fact that there's no need to hand-roll your own
> anymore. Cc'ing a bunch of driver people who might want to know this
> too.
> 
> Cc: Rob Clark <robdclark@gmail.com>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: David Lechner <david@lechnology.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---

With Chris's comment adressed:

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>


>  include/drm/drm_framebuffer.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
> index c23016748e3f..c0e0256e3e98 100644
> --- a/include/drm/drm_framebuffer.h
> +++ b/include/drm/drm_framebuffer.h
> @@ -87,6 +87,9 @@ struct drm_framebuffer_funcs {
>  	 * for more information as all the semantics and arguments have a one to
>  	 * one mapping on this function.
>  	 *
> +	 * Atomic drivers should use drm_atomic_helper_dirtyfb() to implement
> +	 * this hook.
> +	 *
>  	 * RETURNS:
>  	 *
>  	 * 0 on success or a negative error code on failure.
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb: document dirty helper better

[Daniel Vetter]

On Tue, Jun 11, 2019 at 03:34:52PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 11.06.2019 13.28, skrev Daniel Vetter:
> > Apparently little none fact that there's no need to hand-roll your own
> > anymore. Cc'ing a bunch of driver people who might want to know this
> > too.
> > 
> > Cc: Rob Clark <robdclark@gmail.com>
> > Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: David Lechner <david@lechnology.com>
> > Cc: Noralf Trønnes <noralf@tronnes.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> 
> With Chris's comment adressed:

Done&merged, thanks to both of you for taking a look.
-Daniel

> 
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
> 
> 
> >  include/drm/drm_framebuffer.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
> > index c23016748e3f..c0e0256e3e98 100644
> > --- a/include/drm/drm_framebuffer.h
> > +++ b/include/drm/drm_framebuffer.h
> > @@ -87,6 +87,9 @@ struct drm_framebuffer_funcs {
> >  	 * for more information as all the semantics and arguments have a one to
> >  	 * one mapping on this function.
> >  	 *
> > +	 * Atomic drivers should use drm_atomic_helper_dirtyfb() to implement
> > +	 * this hook.
> > +	 *
> >  	 * RETURNS:
> >  	 *
> >  	 * 0 on success or a negative error code on failure.
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel