linux-next: Fixes tag needs some work in the scmi tree

linux-next: Fixes tag needs some work in the scmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi Sudeep,

In commit

  e322dcbd75e8 ("dt-bindings: arm: fix the document ID for SCMI protocol documentation")

Fixes tag

  Fixes: fe7be8b297b2 ("dt-bindings: arm: add support for ARM System Control

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line (it is ok for
that to be a long line).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scmi tree

[Sudeep Holla]

On Wed, Jun 12, 2019 at 07:29:46AM +1000, Stephen Rothwell wrote:
> Hi Sudeep,
>
> In commit
>
>   e322dcbd75e8 ("dt-bindings: arm: fix the document ID for SCMI protocol documentation")
>
> Fixes tag
>
>   Fixes: fe7be8b297b2 ("dt-bindings: arm: add support for ARM System Control
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line (it is ok for
> that to be a long line).
>

Thanks, will fix accordingly.

--
Regards,
Sudeep

Re: linux-next: Fixes tag needs some work in the scmi tree

[Sudeep Holla]

On Tue, Apr 05, 2022 at 08:02:48AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   1b855727f915 ("firmware: arm_scmi: Fix sorting of retrieved clock rates")
> 
> Fixes tag
> 
>   Fixes: dccec73de91 ("firmware: arm_scmi: Keep the discrete clock rates sorted")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
>

Thanks for finding this, it is now fixed.

-- 
Regards,
Sudeep

linux-next: Fixes tag needs some work in the scmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

In commit

  1b855727f915 ("firmware: arm_scmi: Fix sorting of retrieved clock rates")

Fixes tag

  Fixes: dccec73de91 ("firmware: arm_scmi: Keep the discrete clock rates sorted")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the scmi tree

[Sudeep Holla]

On Thu, Jun 04, 2020 at 10:13:28PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   8a8cd9a91081 ("arm: dts: vexpress: Move mcc node back into motherboard node")
> 
> Fixes tag
> 
>   Fixes: d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node")
> 

Sorry for that, I must have checked it. Will fix it.

-- 
Regards,
Sudeep

linux-next: Fixes tag needs some work in the scmi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi all,

In commit

  8a8cd9a91081 ("arm: dts: vexpress: Move mcc node back into motherboard node")

Fixes tag

  Fixes: d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]