All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs/146: remove unnecessary scratch unmount to avoid test failure
@ 2019-06-12 10:05 fdmanana
  0 siblings, 0 replies; only message in thread
From: fdmanana @ 2019-06-12 10:05 UTC (permalink / raw)
  To: fstests; +Cc: linux-btrfs, Filipe Manana

From: Filipe Manana <fdmanana@suse.com>

Right at the beginning of the test we are unmonting the scratch device,
however at this point the device was never mounted, so the unmount fails
with an error message like the following:

  umount: /home/fdmanana/btrfs-tests/scratch_1: not mounted

Which is not expected by the golden output and therefore causes the test
to fail.

Since the device/mount point was not mounted yet in the test, and since
the test framework unmounts the scratch device after each test finishes,
just remove the call to _scratch_unmount.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 tests/btrfs/146 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/btrfs/146 b/tests/btrfs/146
index 8ec3128b..18e2eec0 100755
--- a/tests/btrfs/146
+++ b/tests/btrfs/146
@@ -38,7 +38,6 @@ _require_test_program fsync-err
 _require_test_program dmerror
 
 # bring up dmerror device
-_scratch_unmount
 _dmerror_init
 
 # Replace first device with error-test device
-- 
2.11.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-06-12 10:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 10:05 [PATCH] btrfs/146: remove unnecessary scratch unmount to avoid test failure fdmanana

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.