From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>
Cc: bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, brouer@redhat.com, bpf@vger.kernel.org,
bruce.richardson@intel.com, ciara.loftus@intel.com,
xiaolong.ye@intel.com, qi.z.zhang@intel.com,
maximmi@mellanox.com, sridhar.samudrala@intel.com,
kevin.laatz@intel.com, ilias.apalodimas@linaro.org,
kiran.patil@intel.com, axboe@kernel.dk,
maciej.fijalkowski@intel.com, maciejromanfijalkowski@gmail.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH bpf-next 2/6] xsk: add support for need_wakeup flag in AF_XDP rings
Date: Thu, 13 Jun 2019 12:04:11 -0700 [thread overview]
Message-ID: <20190613120411.35ef3c52@cakuba.netronome.com> (raw)
In-Reply-To: <1560411450-29121-3-git-send-email-magnus.karlsson@intel.com>
On Thu, 13 Jun 2019 09:37:26 +0200, Magnus Karlsson wrote:
>
> - if (!dev->netdev_ops->ndo_bpf ||
> - !dev->netdev_ops->ndo_xsk_async_xmit) {
> + if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_wakeup) {
> err = -EOPNOTSUPP;
> goto err_unreg_umem;
> }
> @@ -198,7 +258,8 @@ static int xsk_zc_xmit(struct sock *sk)
> struct xdp_sock *xs = xdp_sk(sk);
> struct net_device *dev = xs->dev;
>
> - return dev->netdev_ops->ndo_xsk_async_xmit(dev, xs->queue_id);
> + return dev->netdev_ops->ndo_xsk_wakeup(dev, xs->queue_id,
> + XDP_WAKEUP_TX);
> }
>
> static void xsk_destruct_skb(struct sk_buff *skb)
Those two look like they should be in the previous patch? Won't it
break build?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH bpf-next 2/6] xsk: add support for need_wakeup flag in AF_XDP rings
Date: Thu, 13 Jun 2019 12:04:11 -0700 [thread overview]
Message-ID: <20190613120411.35ef3c52@cakuba.netronome.com> (raw)
In-Reply-To: <1560411450-29121-3-git-send-email-magnus.karlsson@intel.com>
On Thu, 13 Jun 2019 09:37:26 +0200, Magnus Karlsson wrote:
>
> - if (!dev->netdev_ops->ndo_bpf ||
> - !dev->netdev_ops->ndo_xsk_async_xmit) {
> + if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_wakeup) {
> err = -EOPNOTSUPP;
> goto err_unreg_umem;
> }
> @@ -198,7 +258,8 @@ static int xsk_zc_xmit(struct sock *sk)
> struct xdp_sock *xs = xdp_sk(sk);
> struct net_device *dev = xs->dev;
>
> - return dev->netdev_ops->ndo_xsk_async_xmit(dev, xs->queue_id);
> + return dev->netdev_ops->ndo_xsk_wakeup(dev, xs->queue_id,
> + XDP_WAKEUP_TX);
> }
>
> static void xsk_destruct_skb(struct sk_buff *skb)
Those two look like they should be in the previous patch? Won't it
break build?
next prev parent reply other threads:[~2019-06-13 19:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 7:37 [PATCH bpf-next 0/6] add need_wakeup flag to the AF_XDP rings Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 1/6] xsk: replace ndo_xsk_async_xmit with ndo_xsk_wakeup Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 2/6] xsk: add support for need_wakeup flag in AF_XDP rings Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 19:04 ` Jakub Kicinski [this message]
2019-06-13 19:04 ` Jakub Kicinski
2019-06-13 19:07 ` Magnus Karlsson
2019-06-13 19:07 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 3/6] i40e: add support for AF_XDP need_wakup feature Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 4/6] ixgbe: " Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 5/6] libbpf: add support for need_wakeup flag in AF_XDP part Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 6/6] samples/bpf: add use of need_sleep flag in xdpsock Magnus Karlsson
2019-06-13 7:37 ` [Intel-wired-lan] " Magnus Karlsson
2019-06-13 23:34 ` [Intel-wired-lan] [PATCH bpf-next 0/6] add need_wakeup flag to the AF_XDP rings Jeff Kirsher
2019-06-13 23:34 ` Jeff Kirsher
2019-06-14 13:38 ` Maxim Mikityanskiy
2019-06-14 13:38 ` [Intel-wired-lan] " Maxim Mikityanskiy
2019-06-14 14:17 ` Maciej Fijalkowski
2019-06-14 14:17 ` [Intel-wired-lan] " Maciej Fijalkowski
2019-06-15 19:13 ` Magnus Karlsson
2019-06-15 19:13 ` [Intel-wired-lan] " Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613120411.35ef3c52@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=daniel@iogearbox.net \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kevin.laatz@intel.com \
--cc=kiran.patil@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.