From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: daniel@ffwll.ch, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, yuq825@gmail.com, eric@anholt.net, peterz@infradead.org, thellstrom@vmware.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, lima@lists.freedesktop.org Subject: [PATCH 4/6] drm/etnaviv: use new ww_mutex_(un)lock_for_each macros Date: Fri, 14 Jun 2019 14:41:23 +0200 [thread overview] Message-ID: <20190614124125.124181-5-christian.koenig@amd.com> (raw) In-Reply-To: <20190614124125.124181-1-christian.koenig@amd.com> Use the provided macros instead of implementing deadlock handling on our own. Signed-off-by: Christian König <christian.koenig@amd.com> --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 55 +++++--------------- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index e054f09ac828..923b8a71f80d 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -118,55 +118,28 @@ static void submit_unlock_object(struct etnaviv_gem_submit *submit, int i) static int submit_lock_objects(struct etnaviv_gem_submit *submit, struct ww_acquire_ctx *ticket) { - int contended, slow_locked = -1, i, ret = 0; - -retry: - for (i = 0; i < submit->nr_bos; i++) { - struct drm_gem_object *obj = &submit->bos[i].obj->base; - - if (slow_locked == i) - slow_locked = -1; - - contended = i; + struct ww_mutex *contended; + int i, ret = 0; - if (!(submit->bos[i].flags & BO_LOCKED)) { - ret = ww_mutex_lock_interruptible(&obj->resv->lock, - ticket); - if (ret == -EALREADY) - DRM_ERROR("BO at index %u already on submit list\n", - i); - if (ret) - goto fail; - submit->bos[i].flags |= BO_LOCKED; - } + ww_mutex_lock_for_each(for (i = 0; i < submit->nr_bos; i++), + &submit->bos[i].obj->base.resv->lock, + contended, ret, true, ticket) { + if (ret == -EALREADY) + DRM_ERROR("BO at index %u already on submit list\n", i); + if (ret) + goto fail; } + for (i = 0; i < submit->nr_bos; i++) + submit->bos[i].flags |= BO_LOCKED; ww_acquire_done(ticket); return 0; fail: - for (; i >= 0; i--) - submit_unlock_object(submit, i); - - if (slow_locked > 0) - submit_unlock_object(submit, slow_locked); - - if (ret == -EDEADLK) { - struct drm_gem_object *obj; - - obj = &submit->bos[contended].obj->base; - - /* we lost out in a seqno race, lock and retry.. */ - ret = ww_mutex_lock_slow_interruptible(&obj->resv->lock, - ticket); - if (!ret) { - submit->bos[contended].flags |= BO_LOCKED; - slow_locked = contended; - goto retry; - } - } - + ww_mutex_unlock_for_each(for (i = 0; i < submit->nr_bos; i++), + &submit->bos[i].obj->base.resv->lock, + contended); return ret; } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: daniel@ffwll.ch, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, yuq825@gmail.com, eric@anholt.net, peterz@infradead.org, thellstrom@vmware.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, lima@lists.freedesktop.org Subject: [PATCH 4/6] drm/etnaviv: use new ww_mutex_(un)lock_for_each macros Date: Fri, 14 Jun 2019 14:41:23 +0200 [thread overview] Message-ID: <20190614124125.124181-5-christian.koenig@amd.com> (raw) In-Reply-To: <20190614124125.124181-1-christian.koenig@amd.com> Use the provided macros instead of implementing deadlock handling on our own. Signed-off-by: Christian König <christian.koenig@amd.com> --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 55 +++++--------------- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index e054f09ac828..923b8a71f80d 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -118,55 +118,28 @@ static void submit_unlock_object(struct etnaviv_gem_submit *submit, int i) static int submit_lock_objects(struct etnaviv_gem_submit *submit, struct ww_acquire_ctx *ticket) { - int contended, slow_locked = -1, i, ret = 0; - -retry: - for (i = 0; i < submit->nr_bos; i++) { - struct drm_gem_object *obj = &submit->bos[i].obj->base; - - if (slow_locked == i) - slow_locked = -1; - - contended = i; + struct ww_mutex *contended; + int i, ret = 0; - if (!(submit->bos[i].flags & BO_LOCKED)) { - ret = ww_mutex_lock_interruptible(&obj->resv->lock, - ticket); - if (ret == -EALREADY) - DRM_ERROR("BO at index %u already on submit list\n", - i); - if (ret) - goto fail; - submit->bos[i].flags |= BO_LOCKED; - } + ww_mutex_lock_for_each(for (i = 0; i < submit->nr_bos; i++), + &submit->bos[i].obj->base.resv->lock, + contended, ret, true, ticket) { + if (ret == -EALREADY) + DRM_ERROR("BO at index %u already on submit list\n", i); + if (ret) + goto fail; } + for (i = 0; i < submit->nr_bos; i++) + submit->bos[i].flags |= BO_LOCKED; ww_acquire_done(ticket); return 0; fail: - for (; i >= 0; i--) - submit_unlock_object(submit, i); - - if (slow_locked > 0) - submit_unlock_object(submit, slow_locked); - - if (ret == -EDEADLK) { - struct drm_gem_object *obj; - - obj = &submit->bos[contended].obj->base; - - /* we lost out in a seqno race, lock and retry.. */ - ret = ww_mutex_lock_slow_interruptible(&obj->resv->lock, - ticket); - if (!ret) { - submit->bos[contended].flags |= BO_LOCKED; - slow_locked = contended; - goto retry; - } - } - + ww_mutex_unlock_for_each(for (i = 0; i < submit->nr_bos; i++), + &submit->bos[i].obj->base.resv->lock, + contended); return ret; } -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-14 12:41 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-14 12:41 ww_mutex deadlock handling cleanup Christian König 2019-06-14 12:41 ` [PATCH 1/6] locking: add ww_mutex_(un)lock_for_each helpers Christian König 2019-06-14 12:56 ` Peter Zijlstra 2019-06-14 12:56 ` Peter Zijlstra 2019-06-14 13:04 ` Christian König 2019-06-14 12:41 ` [PATCH 2/6] drm/ttm: use new ww_mutex_(un)lock_for_each macros Christian König 2019-06-14 12:41 ` [PATCH 3/6] drm/gem: " Christian König 2019-06-14 12:41 ` Christian König 2019-06-14 12:59 ` Peter Zijlstra 2019-06-14 12:59 ` Peter Zijlstra 2019-06-14 13:06 ` Christian König 2019-06-14 13:21 ` Peter Zijlstra 2019-06-14 13:19 ` Peter Zijlstra 2019-06-14 15:22 ` Daniel Vetter 2019-06-14 18:10 ` Christian König 2019-06-14 18:24 ` Daniel Vetter 2019-06-14 18:24 ` Daniel Vetter 2019-06-14 18:51 ` Christian König 2019-06-14 20:30 ` Daniel Vetter 2019-06-14 20:30 ` Daniel Vetter 2019-06-15 13:56 ` Daniel Vetter 2019-06-15 13:56 ` Daniel Vetter 2019-06-17 9:30 ` Christian König 2019-06-14 12:41 ` Christian König [this message] 2019-06-14 12:41 ` [PATCH 4/6] drm/etnaviv: " Christian König 2019-06-14 12:41 ` [PATCH 5/6] drm/lima: " Christian König 2019-06-14 12:41 ` Christian König 2019-06-14 12:41 ` [PATCH 6/6] drm/vc4: " Christian König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190614124125.124181-5-christian.koenig@amd.com \ --to=ckoenig.leichtzumerken@gmail.com \ --cc=christian.gmeiner@gmail.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=etnaviv@lists.freedesktop.org \ --cc=l.stach@pengutronix.de \ --cc=lima@lists.freedesktop.org \ --cc=linux+etnaviv@armlinux.org.uk \ --cc=linux-kernel@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=thellstrom@vmware.com \ --cc=yuq825@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.