* [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup
@ 2019-06-15 22:53 Anton Protopopov
2019-06-17 11:17 ` Toke Høiland-Jørgensen
2019-06-17 21:20 ` Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: Anton Protopopov @ 2019-06-15 22:53 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, David S. Miller, netdev, bpf, linux-kernel
Cc: Anton Protopopov
The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
when forwarding is disabled for the input device. However instead of checking
if forwarding is enabled on the input device, it checked the global
net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
---
net/core/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index f615e42cf4ef..3fdf1b21be36 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -4737,7 +4737,7 @@ static int bpf_ipv6_fib_lookup(struct net *net, struct bpf_fib_lookup *params,
return -ENODEV;
idev = __in6_dev_get_safely(dev);
- if (unlikely(!idev || !net->ipv6.devconf_all->forwarding))
+ if (unlikely(!idev || !idev->cnf.forwarding))
return BPF_FIB_LKUP_RET_FWD_DISABLED;
if (flags & BPF_FIB_LOOKUP_OUTPUT) {
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup
2019-06-15 22:53 [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup Anton Protopopov
@ 2019-06-17 11:17 ` Toke Høiland-Jørgensen
2019-06-17 14:14 ` David Ahern
2019-06-17 21:20 ` Daniel Borkmann
1 sibling, 1 reply; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-06-17 11:17 UTC (permalink / raw)
To: Anton Protopopov, Alexei Starovoitov, Daniel Borkmann,
Martin KaFai Lau, Song Liu, Yonghong Song, David S. Miller,
netdev, bpf, linux-kernel
Cc: Anton Protopopov
Anton Protopopov <a.s.protopopov@gmail.com> writes:
> The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
> when forwarding is disabled for the input device. However instead of checking
> if forwarding is enabled on the input device, it checked the global
> net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Thanks!
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup
2019-06-17 11:17 ` Toke Høiland-Jørgensen
@ 2019-06-17 14:14 ` David Ahern
0 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2019-06-17 14:14 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, Anton Protopopov,
Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, David S. Miller, netdev, bpf, linux-kernel
On 6/17/19 5:17 AM, Toke Høiland-Jørgensen wrote:
> Anton Protopopov <a.s.protopopov@gmail.com> writes:
>
>> The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
>> when forwarding is disabled for the input device. However instead of checking
>> if forwarding is enabled on the input device, it checked the global
>> net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
>>
>> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
>
> Thanks!
>
> Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
Fixes: 87f5fc7e48dd ("bpf: Provide helper to do forwarding lookups in
kernel FIB table")
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup
2019-06-15 22:53 [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup Anton Protopopov
2019-06-17 11:17 ` Toke Høiland-Jørgensen
@ 2019-06-17 21:20 ` Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2019-06-17 21:20 UTC (permalink / raw)
To: Anton Protopopov, Alexei Starovoitov, Martin KaFai Lau, Song Liu,
Yonghong Song, David S. Miller, netdev, bpf, linux-kernel
On 06/16/2019 12:53 AM, Anton Protopopov wrote:
> The bpf_ipv6_fib_lookup function should return BPF_FIB_LKUP_RET_FWD_DISABLED
> when forwarding is disabled for the input device. However instead of checking
> if forwarding is enabled on the input device, it checked the global
> net->ipv6.devconf_all->forwarding flag. Change it to behave as expected.
>
> Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-17 21:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-15 22:53 [PATCH bpf] bpf: fix the check that forwarding is enabled in bpf_ipv6_fib_lookup Anton Protopopov
2019-06-17 11:17 ` Toke Høiland-Jørgensen
2019-06-17 14:14 ` David Ahern
2019-06-17 21:20 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.