[PATCH] iio: adc: xilinx: support all platforms

[PATCH] iio: adc: xilinx: support all platforms

[Robert Hancock]

Since the XADC logic can be used with standalone Xilinx FPGAs, this
driver can potentially be used with many different platforms, not just
the Zynq and MicroBlaze platforms this driver was allowed to be built
for. There should be no platform-specific code in this driver, so just
delete the platform dependency.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---

This is an updated version of an earlier patch "iio: adc: xilinx: support all
ARM platforms", but this one just deletes the platform restriction entirely
as it seems unnecessary.

 drivers/iio/adc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index f96a770..7e32862 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
 
 config XILINX_XADC
 	tristate "Xilinx XADC driver"
-	depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
 	depends on HAS_IOMEM
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
-- 
1.8.3.1

Re: [PATCH] iio: adc: xilinx: support all platforms

[Ardelean, Alexandru]

On Mon, 2019-06-10 at 10:23 -0600, Robert Hancock wrote:
> [External]
> 
> 
> Since the XADC logic can be used with standalone Xilinx FPGAs, this
> driver can potentially be used with many different platforms, not just
> the Zynq and MicroBlaze platforms this driver was allowed to be built
> for. There should be no platform-specific code in this driver, so just
> delete the platform dependency.
> 
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
> ---
> 
> This is an updated version of an earlier patch "iio: adc: xilinx: support all
> ARM platforms", but this one just deletes the platform restriction entirely
> as it seems unnecessary.
> 
>  drivers/iio/adc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index f96a770..7e32862 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
> 
>  config XILINX_XADC
>         tristate "Xilinx XADC driver"
> -       depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST

Just curios here: is `depends COMPILE_TEST` needed so that this gets included in a compile-test build ?
I'm somewhat vague on Linux's makefile logic/structure.

Thanks
Alex

>         depends on HAS_IOMEM
>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
> --
> 1.8.3.1
> 

Re: [PATCH] iio: adc: xilinx: support all platforms

[Lars-Peter Clausen]

On 6/11/19 8:28 AM, Ardelean, Alexandru wrote:
> On Mon, 2019-06-10 at 10:23 -0600, Robert Hancock wrote:
>> [External]
>>
>>
>> Since the XADC logic can be used with standalone Xilinx FPGAs, this
>> driver can potentially be used with many different platforms, not just
>> the Zynq and MicroBlaze platforms this driver was allowed to be built
>> for. There should be no platform-specific code in this driver, so just
>> delete the platform dependency.
>>
>> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
>> ---
>>
>> This is an updated version of an earlier patch "iio: adc: xilinx: support all
>> ARM platforms", but this one just deletes the platform restriction entirely
>> as it seems unnecessary.
>>
>>  drivers/iio/adc/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
>> index f96a770..7e32862 100644
>> --- a/drivers/iio/adc/Kconfig
>> +++ b/drivers/iio/adc/Kconfig
>> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
>>
>>  config XILINX_XADC
>>         tristate "Xilinx XADC driver"
>> -       depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
> 
> Just curios here: is `depends COMPILE_TEST` needed so that this gets included in a compile-test build ?
> I'm somewhat vague on Linux's makefile logic/structure.

COMPILE_TEST enables the driver for compile testing if it is not already
enabled otherwise. Now that the driver has no dependencies at all it
will always be enabled, which includes compile testing.

Re: [PATCH] iio: adc: xilinx: support all platforms

[Ardelean, Alexandru]

On Tue, 2019-06-11 at 08:52 +0200, Lars-Peter Clausen wrote:
> [External]
> 
> 
> On 6/11/19 8:28 AM, Ardelean, Alexandru wrote:
> > On Mon, 2019-06-10 at 10:23 -0600, Robert Hancock wrote:
> > > [External]
> > > 
> > > 
> > > Since the XADC logic can be used with standalone Xilinx FPGAs, this
> > > driver can potentially be used with many different platforms, not just
> > > the Zynq and MicroBlaze platforms this driver was allowed to be built
> > > for. There should be no platform-specific code in this driver, so just
> > > delete the platform dependency.
> > > 
> > > Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
> > > ---
> > > 
> > > This is an updated version of an earlier patch "iio: adc: xilinx: support all
> > > ARM platforms", but this one just deletes the platform restriction entirely
> > > as it seems unnecessary.
> > > 
> > >  drivers/iio/adc/Kconfig | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > > index f96a770..7e32862 100644
> > > --- a/drivers/iio/adc/Kconfig
> > > +++ b/drivers/iio/adc/Kconfig
> > > @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
> > > 
> > >  config XILINX_XADC
> > >         tristate "Xilinx XADC driver"
> > > -       depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
> > 
> > Just curios here: is `depends COMPILE_TEST` needed so that this gets included in a compile-test build ?
> > I'm somewhat vague on Linux's makefile logic/structure.
> 
> COMPILE_TEST enables the driver for compile testing if it is not already
> enabled otherwise. Now that the driver has no dependencies at all it
> will always be enabled, which includes compile testing.

I see.
Thanks for the info

Re: [PATCH] iio: adc: xilinx: support all platforms

[Jonathan Cameron]

On Mon, 10 Jun 2019 10:23:44 -0600
Robert Hancock <hancock@sedsystems.ca> wrote:

> Since the XADC logic can be used with standalone Xilinx FPGAs, this
> driver can potentially be used with many different platforms, not just
> the Zynq and MicroBlaze platforms this driver was allowed to be built
> for. There should be no platform-specific code in this driver, so just
> delete the platform dependency.
> 
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Applied to the togreg branch of iio.git and pushed out as testing
to see if any of us missed anything.  Hopefully the many compiles 0-day
will do on this will highlight if there is anything hiding we haven't thought
of to make this a bad idea (more likely needing a little fix ;)

Jonathan

> ---
> 
> This is an updated version of an earlier patch "iio: adc: xilinx: support all
> ARM platforms", but this one just deletes the platform restriction entirely
> as it seems unnecessary.
> 
>  drivers/iio/adc/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index f96a770..7e32862 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC
>  
>  config XILINX_XADC
>  	tristate "Xilinx XADC driver"
> -	depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
>  	depends on HAS_IOMEM
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER