From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Jim Gill <jgill@vmware.com>,
Cathy Avery <cavery@redhat.com>,
"Ewan D . Milne" <emilne@redhat.com>,
Brian King <brking@us.ibm.com>,
James Smart <james.smart@broadcom.com>,
"Juergen E . Fischer" <fischer@norbit.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Finn Thain <fthain@telegraphics.com.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Benjamin Block <bblock@linux.ibm.com>,
Kim Bradley <kim.jamie.bradley@gmail.com>
Subject: Re: [PATCH V4 09/16] staging: rtsx: use sg helper to operate scatterlist
Date: Mon, 17 Jun 2019 11:24:46 +0200 [thread overview]
Message-ID: <20190617092446.GA8707@lst.de> (raw)
In-Reply-To: <20190617091524.GB31002@ming.t460p>
> + struct scatterlist *sg = *cur_sg ?:
> + (struct scatterlist *)scsi_sglist(srb);
> +
No need for the cast here. And I have to say I hate that GNU C
non-standard shortshut in ? :.
Why not simply:
struct scatterlist *sg = *cur_sg;
if (!sg)
sg = scsi_sglist(srb);
Which is a little more verbose, but much more readabe.
The rest of the patch looks fine to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
devel@driverdev.osuosl.org, Hannes Reinecke <hare@suse.com>,
Benjamin Block <bblock@linux.ibm.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, James Smart <james.smart@broadcom.com>,
"Ewan D . Milne" <emilne@redhat.com>, Jim Gill <jgill@vmware.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Brian King <brking@us.ibm.com>,
Finn Thain <fthain@telegraphics.com.au>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Kim Bradley <kim.jamie.bradley@gmail.com>,
"Juergen E . Fischer" <fischer@norbit.de>,
Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH V4 09/16] staging: rtsx: use sg helper to operate scatterlist
Date: Mon, 17 Jun 2019 11:24:46 +0200 [thread overview]
Message-ID: <20190617092446.GA8707@lst.de> (raw)
In-Reply-To: <20190617091524.GB31002@ming.t460p>
> + struct scatterlist *sg = *cur_sg ?:
> + (struct scatterlist *)scsi_sglist(srb);
> +
No need for the cast here. And I have to say I hate that GNU C
non-standard shortshut in ? :.
Why not simply:
struct scatterlist *sg = *cur_sg;
if (!sg)
sg = scsi_sglist(srb);
Which is a little more verbose, but much more readabe.
The rest of the patch looks fine to me.
next prev parent reply other threads:[~2019-06-17 9:25 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 3:03 [PATCH V4 00/16] use sg helper to operate scatterlist Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 3:03 ` [PATCH V4 01/16] scsi: vmw_pscsi: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 02/16] scsi: advansys: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 03/16] scsi: lpfc: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 04/16] scsi: mvumi: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 8:22 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 05/16] scsi: ipr: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:24 ` Christoph Hellwig
2019-06-17 8:24 ` Christoph Hellwig
2019-06-17 8:50 ` Ming Lei
2019-06-17 8:50 ` Ming Lei
2019-06-17 3:03 ` [PATCH V4 06/16] scsi: pmcraid: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:24 ` Christoph Hellwig
2019-06-17 8:24 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 07/16] usb: image: microtek: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:25 ` Christoph Hellwig
2019-06-17 8:25 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 08/16] staging: unisys: visorhba: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:25 ` Christoph Hellwig
2019-06-17 8:25 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 09/16] staging: rtsx: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:27 ` Christoph Hellwig
2019-06-17 8:27 ` Christoph Hellwig
2019-06-17 9:15 ` Ming Lei
2019-06-17 9:15 ` Ming Lei
2019-06-17 9:24 ` Christoph Hellwig [this message]
2019-06-17 9:24 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 10/16] s390: zfcp_fc: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:27 ` Christoph Hellwig
2019-06-17 8:27 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 11/16] scsi: aha152x: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 3:35 ` Finn Thain
2019-06-17 3:35 ` Finn Thain
2019-06-17 23:35 ` Finn Thain
2019-06-17 23:35 ` Finn Thain
2019-06-18 0:15 ` Ming Lei
2019-06-18 0:15 ` Ming Lei
2019-06-17 8:28 ` Christoph Hellwig
2019-06-17 8:28 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 12/16] scsi: imm: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:28 ` Christoph Hellwig
2019-06-17 8:28 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 13/16] scsi: pcmcia: nsp_cs: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 14/16] scsi: ppa: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 15/16] scsi: wd33c93: " Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 8:29 ` Christoph Hellwig
2019-06-17 3:03 ` [PATCH V4 16/16] NCR5380: Support chained sg lists Ming Lei
2019-06-17 3:03 ` Ming Lei
2019-06-17 8:30 ` Christoph Hellwig
2019-06-17 8:30 ` Christoph Hellwig
2019-06-17 23:52 ` [PATCH V4 00/16] use sg helper to operate scatterlist Bart Van Assche
2019-06-17 23:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617092446.GA8707@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bblock@linux.ibm.com \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=fischer@norbit.de \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=james.smart@broadcom.com \
--cc=jgill@vmware.com \
--cc=kim.jamie.bradley@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.