From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe
Date: Mon, 17 Jun 2019 13:45:03 +0200 [thread overview]
Message-ID: <20190617114503.pclqsf6bo3ih47nt@flea> (raw)
In-Reply-To: <20190614164324.9427-6-jagan@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote:
> TCON TOP have clock gates for TV0, TV1, dsi and right
> now these are register during bind call.
>
> Of which, dsi clock gate would required during DPHY probe
> but same can miss to get since tcon top is not bound at
> that time.
>
> To solve, this circular dependency move the clock gate
> registration from bind to probe so-that DPHY can get the
> dsi gate clock on time.
It's not really clear to me what the circular dependency is?
if you have a chain that is:
tcon-top +-> DSI
+-> D-PHY
There's no loop, right?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe
Date: Mon, 17 Jun 2019 13:45:03 +0200 [thread overview]
Message-ID: <20190617114503.pclqsf6bo3ih47nt@flea> (raw)
In-Reply-To: <20190614164324.9427-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote:
> TCON TOP have clock gates for TV0, TV1, dsi and right
> now these are register during bind call.
>
> Of which, dsi clock gate would required during DPHY probe
> but same can miss to get since tcon top is not bound at
> that time.
>
> To solve, this circular dependency move the clock gate
> registration from bind to probe so-that DPHY can get the
> dsi gate clock on time.
It's not really clear to me what the circular dependency is?
if you have a chain that is:
tcon-top +-> DSI
+-> D-PHY
There's no loop, right?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Chen-Yu Tsai <wens@csie.org>,
Daniel Vetter <daniel@ffwll.ch>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-amarula@amarulasolutions.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe
Date: Mon, 17 Jun 2019 13:45:03 +0200 [thread overview]
Message-ID: <20190617114503.pclqsf6bo3ih47nt@flea> (raw)
In-Reply-To: <20190614164324.9427-6-jagan@amarulasolutions.com>
[-- Attachment #1.1: Type: text/plain, Size: 683 bytes --]
On Fri, Jun 14, 2019 at 10:13:20PM +0530, Jagan Teki wrote:
> TCON TOP have clock gates for TV0, TV1, dsi and right
> now these are register during bind call.
>
> Of which, dsi clock gate would required during DPHY probe
> but same can miss to get since tcon top is not bound at
> that time.
>
> To solve, this circular dependency move the clock gate
> registration from bind to probe so-that DPHY can get the
> dsi gate clock on time.
It's not really clear to me what the circular dependency is?
if you have a chain that is:
tcon-top +-> DSI
+-> D-PHY
There's no loop, right?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-17 11:45 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 16:43 [PATCH v2 0/9] drm/sun4i: Allwinner R40 MIPI-DSI support Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` [PATCH v2 1/9] dt-bindings: display: Add TCON LCD compatible for R40 Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-07-09 14:49 ` Rob Herring
2019-07-09 14:49 ` Rob Herring
2019-07-09 14:49 ` Rob Herring
2019-06-14 16:43 ` [PATCH v2 2/9] drm/sun4i: tcon: Add TCON LCD support " Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` [PATCH v2 3/9] ARM: dts: sun8i: r40: Use tcon top clock index macros Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` [PATCH v2 4/9] drm/sun4i: tcon_top: Use clock name " Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` [PATCH v2 5/9] drm/sun4i: tcon_top: Register clock gates in probe Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-16 5:31 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-16 5:31 ` Chen-Yu Tsai
2019-06-16 5:31 ` Chen-Yu Tsai
2019-06-17 10:29 ` [linux-sunxi] " Jagan Teki
2019-06-17 10:29 ` Jagan Teki
2019-06-17 10:29 ` Jagan Teki
2019-06-18 7:19 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-18 7:19 ` Chen-Yu Tsai
2019-06-18 7:19 ` Chen-Yu Tsai
2019-06-18 7:45 ` [linux-sunxi] " Jagan Teki
2019-06-18 7:45 ` Jagan Teki
2019-06-18 7:53 ` Chen-Yu Tsai
2019-06-18 7:53 ` Chen-Yu Tsai
2019-06-18 7:53 ` Chen-Yu Tsai
2019-06-18 10:34 ` [linux-sunxi] " Jagan Teki
2019-06-18 10:34 ` Jagan Teki
2019-06-18 10:34 ` Jagan Teki
2019-06-18 10:54 ` Chen-Yu Tsai
2019-06-18 10:54 ` Chen-Yu Tsai
2019-06-18 10:54 ` Chen-Yu Tsai
2019-06-20 16:24 ` [linux-sunxi] " Jagan Teki
2019-06-20 16:24 ` Jagan Teki
2019-06-21 8:00 ` Chen-Yu Tsai
2019-06-21 8:00 ` Chen-Yu Tsai
2019-06-21 8:00 ` Chen-Yu Tsai
2019-06-17 11:45 ` Maxime Ripard [this message]
2019-06-17 11:45 ` Maxime Ripard
2019-06-17 11:45 ` Maxime Ripard
2019-06-17 13:01 ` [linux-sunxi] " Chen-Yu Tsai
2019-06-17 13:01 ` Chen-Yu Tsai
2019-06-17 13:01 ` Chen-Yu Tsai
2019-06-17 14:54 ` [linux-sunxi] " Maxime Ripard
2019-06-17 14:54 ` Maxime Ripard
2019-06-17 14:54 ` Maxime Ripard
2019-06-18 7:12 ` [linux-sunxi] " Jagan Teki
2019-06-18 7:12 ` Jagan Teki
2019-06-18 7:23 ` Chen-Yu Tsai
2019-06-18 7:23 ` Chen-Yu Tsai
2019-06-18 7:23 ` Chen-Yu Tsai
2019-06-18 7:46 ` [linux-sunxi] " Jagan Teki
2019-06-18 7:46 ` Jagan Teki
2019-06-18 7:46 ` Jagan Teki
2019-06-14 16:43 ` [PATCH v2 6/9] dt-bindings: sun6i-dsi: Add R40 MIPI-DSI compatible (w/ A64 fallback) Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-07-09 14:50 ` Rob Herring
2019-07-09 14:50 ` Rob Herring
2019-07-09 14:50 ` Rob Herring
2019-06-14 16:43 ` [PATCH v2 7/9] dt-bindings: sun6i-dsi: Add R40 DPHY compatible (w/ A31 fallback) Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-07-09 16:16 ` Rob Herring
2019-07-09 16:16 ` Rob Herring
2019-07-09 16:16 ` Rob Herring
2019-06-14 16:43 ` [PATCH v2 8/9] ARM: dts: sun8i: r40: Add MIPI DSI pipeline Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` [DO NOT MERGE] [PATCH v2 9/9] ARM: dts: sun8i-r40: bananapi-m2-ultra: Enable Bananapi S070WV20-CT16 DSI panel Jagan Teki
2019-06-14 16:43 ` Jagan Teki
2019-06-14 16:43 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617114503.pclqsf6bo3ih47nt@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=michael@amarulasolutions.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.