* [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-17 13:16 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-06-17 13:16 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Arnd Bergmann, YueHaibing, Ira Weiny, Andrew Morton, dri-devel,
linux-fbdev, linux-kernel
When the driver is built-in for PCI, we reference the exit function
after discarding it:
`pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
Just remove the __exit annotation as the easiest workaround.
Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/pvr2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 299ea7db9220..cf9cfdc5e685 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
return pci_register_driver(&pvr2fb_pci_driver);
}
-static void __exit pvr2fb_pci_exit(void)
+static void pvr2fb_pci_exit(void)
{
pci_unregister_driver(&pvr2fb_pci_driver);
}
--
2.20.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-17 13:16 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-06-17 13:16 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-fbdev, Arnd Bergmann, YueHaibing, linux-kernel, dri-devel,
Andrew Morton, Ira Weiny
When the driver is built-in for PCI, we reference the exit function
after discarding it:
`pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
Just remove the __exit annotation as the easiest workaround.
Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/pvr2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 299ea7db9220..cf9cfdc5e685 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
return pci_register_driver(&pvr2fb_pci_driver);
}
-static void __exit pvr2fb_pci_exit(void)
+static void pvr2fb_pci_exit(void)
{
pci_unregister_driver(&pvr2fb_pci_driver);
}
--
2.20.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-17 13:16 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-06-17 13:16 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-fbdev, Arnd Bergmann, YueHaibing, linux-kernel, dri-devel,
Andrew Morton, Ira Weiny
When the driver is built-in for PCI, we reference the exit function
after discarding it:
`pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
Just remove the __exit annotation as the easiest workaround.
Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/pvr2fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 299ea7db9220..cf9cfdc5e685 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
return pci_register_driver(&pvr2fb_pci_driver);
}
-static void __exit pvr2fb_pci_exit(void)
+static void pvr2fb_pci_exit(void)
{
pci_unregister_driver(&pvr2fb_pci_driver);
}
--
2.20.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
2019-06-17 13:16 ` Arnd Bergmann
@ 2019-06-21 10:58 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 9+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 10:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel, linux-fbdev,
linux-kernel
Hi,
On 6/17/19 3:16 PM, Arnd Bergmann wrote:
> When the driver is built-in for PCI, we reference the exit function
> after discarding it:
>
> `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
>
> Just remove the __exit annotation as the easiest workaround.
Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index 299ea7db9220..cf9cfdc5e685 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
> return pci_register_driver(&pvr2fb_pci_driver);
> }
>
> -static void __exit pvr2fb_pci_exit(void)
> +static void pvr2fb_pci_exit(void)
> {
> pci_unregister_driver(&pvr2fb_pci_driver);
> }
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-21 10:58 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 9+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 10:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel, linux-fbdev,
linux-kernel
Hi,
On 6/17/19 3:16 PM, Arnd Bergmann wrote:
> When the driver is built-in for PCI, we reference the exit function
> after discarding it:
>
> `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
>
> Just remove the __exit annotation as the easiest workaround.
Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index 299ea7db9220..cf9cfdc5e685 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
> return pci_register_driver(&pvr2fb_pci_driver);
> }
>
> -static void __exit pvr2fb_pci_exit(void)
> +static void pvr2fb_pci_exit(void)
> {
> pci_unregister_driver(&pvr2fb_pci_driver);
> }
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
2019-06-21 10:58 ` Bartlomiej Zolnierkiewicz
@ 2019-06-21 11:05 ` Arnd Bergmann
-1 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-06-21 11:05 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel,
Linux Fbdev development list, Linux Kernel Mailing List
On Fri, Jun 21, 2019 at 12:58 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> On 6/17/19 3:16 PM, Arnd Bergmann wrote:
> > When the driver is built-in for PCI, we reference the exit function
> > after discarding it:
> >
> > `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
> >
> > Just remove the __exit annotation as the easiest workaround.
>
> Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
I think that's correct, yes. Can you fix that up when applying the patch?
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-21 11:05 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2019-06-21 11:05 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel,
Linux Fbdev development list, Linux Kernel Mailing List
On Fri, Jun 21, 2019 at 12:58 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> On 6/17/19 3:16 PM, Arnd Bergmann wrote:
> > When the driver is built-in for PCI, we reference the exit function
> > after discarding it:
> >
> > `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
> >
> > Just remove the __exit annotation as the easiest workaround.
>
> Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
I think that's correct, yes. Can you fix that up when applying the patch?
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
2019-06-21 11:05 ` Arnd Bergmann
@ 2019-06-21 11:23 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 9+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 11:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel,
Linux Fbdev development list, Linux Kernel Mailing List
On 6/21/19 1:05 PM, Arnd Bergmann wrote:
> On Fri, Jun 21, 2019 at 12:58 PM Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>> On 6/17/19 3:16 PM, Arnd Bergmann wrote:
>>> When the driver is built-in for PCI, we reference the exit function
>>> after discarding it:
>>>
>>> `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
>>>
>>> Just remove the __exit annotation as the easiest workaround.
>>
>> Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
>
> I think that's correct, yes. Can you fix that up when applying the patch?
Sure.
I've queued the patch for v5.3, thanks!
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit
@ 2019-06-21 11:23 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 9+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 11:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: YueHaibing, Ira Weiny, Andrew Morton, dri-devel,
Linux Fbdev development list, Linux Kernel Mailing List
On 6/21/19 1:05 PM, Arnd Bergmann wrote:
> On Fri, Jun 21, 2019 at 12:58 PM Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>>
>> On 6/17/19 3:16 PM, Arnd Bergmann wrote:
>>> When the driver is built-in for PCI, we reference the exit function
>>> after discarding it:
>>>
>>> `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
>>>
>>> Just remove the __exit annotation as the easiest workaround.
>>
>> Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
>
> I think that's correct, yes. Can you fix that up when applying the patch?
Sure.
I've queued the patch for v5.3, thanks!
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-06-21 11:23 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190617131645epcas1p3340c80f9e83af93bcbb4c68128b1ea44@epcas1p3.samsung.com>
2019-06-17 13:16 ` [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit Arnd Bergmann
2019-06-17 13:16 ` Arnd Bergmann
2019-06-17 13:16 ` Arnd Bergmann
2019-06-21 10:58 ` Bartlomiej Zolnierkiewicz
2019-06-21 10:58 ` Bartlomiej Zolnierkiewicz
2019-06-21 11:05 ` Arnd Bergmann
2019-06-21 11:05 ` Arnd Bergmann
2019-06-21 11:23 ` Bartlomiej Zolnierkiewicz
2019-06-21 11:23 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.