All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display
@ 2019-06-14 18:07 Matt Roper
  2019-06-14 18:32 ` Ville Syrjälä
                   ` (8 more replies)
  0 siblings, 9 replies; 17+ messages in thread
From: Matt Roper @ 2019-06-14 18:07 UTC (permalink / raw)
  To: intel-gfx

EHL has a mux on combo PHY A that allows it to be driven either by an
internal display (using DDI-A or DSI DPHY) or by an external display
(using DDI-D).  This is a motherboard design decision that can not be
changed on the fly.  Let's use the VBT child device settings to try to
figure out our board's configuration and program the mux accordingly.

Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/i915_reg.h        |  1 +
 drivers/gpu/drm/i915/intel_bios.c      | 24 ++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_bios.h      |  1 +
 drivers/gpu/drm/i915/intel_combo_phy.c | 13 +++++++++++++
 4 files changed, 39 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 368ee717580c..0ae0d85304b5 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -11121,6 +11121,7 @@ enum skl_power_gate {
 #define _ICL_PHY_MISC_B		0x64C04
 #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
 						 _ICL_PHY_MISC_B)
+#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
 #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
 
 /* Icelake Display Stream Compression Registers */
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index d3d473934ea4..ac861852e843 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1667,6 +1667,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
 		if (!child->device_type)
 			continue;
 
+		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
+			      child->device_type);
+
 		/*
 		 * Copy as much as we know (sizeof) and is available
 		 * (child_dev_size) of the child device. Accessing the data must
@@ -2259,3 +2262,24 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
 
 	return aux_ch;
 }
+
+/**
+ * intel_bios_has_internal_display - are any child devices marked 'internal?'
+ * @dev_priv:	i915 device instance
+ *
+ * Returns true if any of the child devices have a device type containing
+ * the %DEVICE_TYPE_INTERNAL_CONNECTOR bit.
+ */
+bool intel_bios_has_internal_display(struct drm_i915_private *dev_priv)
+{
+	int i;
+
+	for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
+		struct child_device_config *child = &dev_priv->vbt.child_dev[i];
+
+		if (child->device_type & DEVICE_TYPE_INTERNAL_CONNECTOR)
+			return true;
+	}
+
+	return false;
+}
diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu/drm/i915/intel_bios.h
index 4e42cfaf61a7..df822a1efe55 100644
--- a/drivers/gpu/drm/i915/intel_bios.h
+++ b/drivers/gpu/drm/i915/intel_bios.h
@@ -240,5 +240,6 @@ bool intel_bios_is_port_hpd_inverted(const struct drm_i915_private *i915,
 bool intel_bios_is_lspcon_present(const struct drm_i915_private *i915,
 				  enum port port);
 enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv, enum port port);
+bool intel_bios_has_internal_display(struct drm_i915_private *dev_priv);
 
 #endif /* _INTEL_BIOS_H_ */
diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
index 841708da5a56..3bf3e41c5296 100644
--- a/drivers/gpu/drm/i915/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/intel_combo_phy.c
@@ -273,7 +273,20 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
 			continue;
 		}
 
+		/*
+		 * EHL's combo PHY A can be hooked up to either an external
+		 * display (via DDI-D) or an internal display (via DDI-A or
+		 * the DSI DPHY).  This is a motherboard design decision that
+		 * can't be changed on the fly, so initialize the PHY's mux
+		 * based on whether our VBT indicates the presence of any
+		 * "internal" child devices.
+		 */
 		val = I915_READ(ICL_PHY_MISC(port));
+		if (!IS_ICELAKE(dev_priv) && port == PORT_A &&
+		    !intel_bios_has_internal_display(dev_priv))
+			val |= ICL_PHY_MISC_MUX_DDID;
+		else
+			val &= ~ICL_PHY_MISC_MUX_DDID;
 		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
 		I915_WRITE(ICL_PHY_MISC(port), val);
 
-- 
2.14.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
@ 2019-06-14 18:32 ` Ville Syrjälä
  2019-06-17 23:48   ` [PATCH v2] " Matt Roper
  2019-06-15  5:25 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-06-14 18:32 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

On Fri, Jun 14, 2019 at 11:07:34AM -0700, Matt Roper wrote:
> EHL has a mux on combo PHY A that allows it to be driven either by an
> internal display (using DDI-A or DSI DPHY) or by an external display
> (using DDI-D).  This is a motherboard design decision that can not be
> changed on the fly.  Let's use the VBT child device settings to try to
> figure out our board's configuration and program the mux accordingly.
> 
> Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h        |  1 +
>  drivers/gpu/drm/i915/intel_bios.c      | 24 ++++++++++++++++++++++++
>  drivers/gpu/drm/i915/intel_bios.h      |  1 +
>  drivers/gpu/drm/i915/intel_combo_phy.c | 13 +++++++++++++
>  4 files changed, 39 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 368ee717580c..0ae0d85304b5 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -11121,6 +11121,7 @@ enum skl_power_gate {
>  #define _ICL_PHY_MISC_B		0x64C04
>  #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
>  						 _ICL_PHY_MISC_B)
> +#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
>  #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
>  
>  /* Icelake Display Stream Compression Registers */
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index d3d473934ea4..ac861852e843 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1667,6 +1667,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
>  		if (!child->device_type)
>  			continue;
>  
> +		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
> +			      child->device_type);
> +
>  		/*
>  		 * Copy as much as we know (sizeof) and is available
>  		 * (child_dev_size) of the child device. Accessing the data must
> @@ -2259,3 +2262,24 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
>  
>  	return aux_ch;
>  }
> +
> +/**
> + * intel_bios_has_internal_display - are any child devices marked 'internal?'
> + * @dev_priv:	i915 device instance
> + *
> + * Returns true if any of the child devices have a device type containing
> + * the %DEVICE_TYPE_INTERNAL_CONNECTOR bit.
> + */
> +bool intel_bios_has_internal_display(struct drm_i915_private *dev_priv)
> +{
> +	int i;
> +
> +	for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
> +		struct child_device_config *child = &dev_priv->vbt.child_dev[i];
> +
> +		if (child->device_type & DEVICE_TYPE_INTERNAL_CONNECTOR)
> +			return true;
> +	}
> +
> +	return false;
> +}

This feels super fragile. No hw strap for this?

Is the VBT DVO port referring to DDI or PHY?

If it's referring to DDI then I think we could check
for child device being present on DDI D and no child
device on DDI A/DSI. Not sure which way we should go
if there's a conflict.

But if it's referring to the PHY then we're hosed because
we can't tell which DDI is driving DVO port A aka. PHY A.
I guess in that case we should check for an internal/DSI vs.
external connector on DVO port A?

Not sure how many places we have in the code which assumes
1:1 mapping between DDI:PHY. I think we really need to
introduce a new namespace for the PHY so that we aren't
super confused all the time which thing we're talking about.

> diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu/drm/i915/intel_bios.h
> index 4e42cfaf61a7..df822a1efe55 100644
> --- a/drivers/gpu/drm/i915/intel_bios.h
> +++ b/drivers/gpu/drm/i915/intel_bios.h
> @@ -240,5 +240,6 @@ bool intel_bios_is_port_hpd_inverted(const struct drm_i915_private *i915,
>  bool intel_bios_is_lspcon_present(const struct drm_i915_private *i915,
>  				  enum port port);
>  enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv, enum port port);
> +bool intel_bios_has_internal_display(struct drm_i915_private *dev_priv);
>  
>  #endif /* _INTEL_BIOS_H_ */
> diff --git a/drivers/gpu/drm/i915/intel_combo_phy.c b/drivers/gpu/drm/i915/intel_combo_phy.c
> index 841708da5a56..3bf3e41c5296 100644
> --- a/drivers/gpu/drm/i915/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/intel_combo_phy.c
> @@ -273,7 +273,20 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
>  			continue;
>  		}
>  
> +		/*
> +		 * EHL's combo PHY A can be hooked up to either an external
> +		 * display (via DDI-D) or an internal display (via DDI-A or
> +		 * the DSI DPHY).  This is a motherboard design decision that
> +		 * can't be changed on the fly, so initialize the PHY's mux
> +		 * based on whether our VBT indicates the presence of any
> +		 * "internal" child devices.
> +		 */
>  		val = I915_READ(ICL_PHY_MISC(port));
> +		if (!IS_ICELAKE(dev_priv) && port == PORT_A &&
> +		    !intel_bios_has_internal_display(dev_priv))
> +			val |= ICL_PHY_MISC_MUX_DDID;
> +		else
> +			val &= ~ICL_PHY_MISC_MUX_DDID;
>  		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
>  		I915_WRITE(ICL_PHY_MISC(port), val);
>  
> -- 
> 2.14.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
  2019-06-14 18:32 ` Ville Syrjälä
@ 2019-06-15  5:25 ` Patchwork
  2019-06-17 10:26 ` ✓ Fi.CI.IGT: " Patchwork
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-15  5:25 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display
URL   : https://patchwork.freedesktop.org/series/62131/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6277 -> Patchwork_13293
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/

Known issues
------------

  Here are the changes found in Patchwork_13293 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_evict:
    - fi-bsw-kefka:       [PASS][1] -> [DMESG-WARN][2] ([fdo#107709])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/fi-bsw-kefka/igt@i915_selftest@live_evict.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/fi-bsw-kefka/igt@i915_selftest@live_evict.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic:
    - fi-icl-guc:         [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/fi-icl-guc/igt@gem_ctx_exec@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/fi-icl-guc/igt@gem_ctx_exec@basic.html
    - fi-icl-y:           [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/fi-icl-y/igt@gem_ctx_exec@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/fi-icl-y/igt@gem_ctx_exec@basic.html

  * igt@i915_selftest@live_gtt:
    - fi-glk-dsi:         [INCOMPLETE][7] ([fdo#103359] / [k.org#198133]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/fi-glk-dsi/igt@i915_selftest@live_gtt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/fi-glk-dsi/igt@i915_selftest@live_gtt.html

  
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (50 -> 45)
------------------------------

  Additional (3): fi-kbl-7567u fi-skl-iommu fi-icl-u3 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6277 -> Patchwork_13293

  CI_DRM_6277: a0195925ba8732ffae5fed3c0b966ca331bae66c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5057: 3b91c82b90d45c1a30569410c1142b541956740a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13293: 8742bede989c183b9c080134d6b27ebc7ed70f0f @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

8742bede989c drm/i915/ehl: Allow combo PHY A to drive a third external display

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.IGT: success for drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
  2019-06-14 18:32 ` Ville Syrjälä
  2019-06-15  5:25 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-06-17 10:26 ` Patchwork
  2019-06-18  0:10 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2) Patchwork
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-17 10:26 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display
URL   : https://patchwork.freedesktop.org/series/62131/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6277_full -> Patchwork_13293_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13293_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@in-flight-1us:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-glk4/igt@gem_eio@in-flight-1us.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-glk9/igt@gem_eio@in-flight-1us.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#110854])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb7/igt@gem_exec_balancer@smoke.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-snb:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110789] / [fdo#110913 ])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-apl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-apl2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
    - shard-skl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-skl3/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-skl6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-kbl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#110913 ]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-kbl7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-kbl7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-iclb:         [PASS][13] -> [DMESG-WARN][14] ([fdo#110913 ])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
    - shard-snb:          [PASS][15] -> [DMESG-WARN][16] ([fdo#110913 ])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-apl7/igt@i915_suspend@sysfs-reader.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-apl1/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [PASS][19] -> [DMESG-WARN][20] ([fdo#108566])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-kbl7/igt@kms_flip@flip-vs-suspend.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-kbl7/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_flip@modeset-vs-vblank-race-interruptible:
    - shard-glk:          [PASS][21] -> [FAIL][22] ([fdo#103060])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-glk5/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-glk8/igt@kms_flip@modeset-vs-vblank-race-interruptible.html

  * igt@kms_flip@plain-flip-ts-check-interruptible:
    - shard-glk:          [PASS][23] -> [FAIL][24] ([fdo#100368])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-glk5/igt@kms_flip@plain-flip-ts-check-interruptible.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-glk8/igt@kms_flip@plain-flip-ts-check-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [PASS][25] -> [FAIL][26] ([fdo#103167]) +7 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][27] -> [FAIL][28] ([fdo#103166])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [PASS][29] -> [SKIP][30] ([fdo#109441]) +2 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb8/igt@kms_psr@psr2_no_drrs.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-kbl:          [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +4 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-kbl1/igt@gem_ctx_isolation@bcs0-s3.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-kbl6/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_eio@in-flight-suspend:
    - shard-apl:          [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-apl1/igt@gem_eio@in-flight-suspend.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-apl8/igt@gem_eio@in-flight-suspend.html
    - shard-iclb:         [FAIL][35] ([fdo#110667]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb8/igt@gem_eio@in-flight-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb1/igt@gem_eio@in-flight-suspend.html

  * igt@gem_eio@wait-wedge-1us:
    - shard-glk:          [DMESG-WARN][37] ([fdo#110913 ]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-glk8/igt@gem_eio@wait-wedge-1us.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-glk3/igt@gem_eio@wait-wedge-1us.html

  * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
    - shard-apl:          [DMESG-WARN][39] ([fdo#110913 ]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-apl7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-apl7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-snb:          [DMESG-WARN][41] ([fdo#110789] / [fdo#110913 ]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-snb4/igt@gem_persistent_relocs@forked-thrashing.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-kbl:          [DMESG-WARN][43] ([fdo#110913 ]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-kbl2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
    - shard-snb:          [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-skl:          [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48] +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-skl2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-skl8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@i915_pm_backlight@fade_with_suspend:
    - shard-skl:          [INCOMPLETE][49] ([fdo#104108]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-skl3/igt@i915_pm_backlight@fade_with_suspend.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-skl2/igt@i915_pm_backlight@fade_with_suspend.html

  * igt@i915_pm_rpm@universal-planes-dpms:
    - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] / [fdo#108840]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb2/igt@i915_pm_rpm@universal-planes-dpms.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb3/igt@i915_pm_rpm@universal-planes-dpms.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          [FAIL][53] ([fdo#102887] / [fdo#105363]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [FAIL][55] ([fdo#103167]) -> [PASS][56] +4 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [FAIL][57] ([fdo#108145]) -> [PASS][58] +1 similar issue
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [SKIP][59] ([fdo#109642]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb5/igt@kms_psr2_su@frontbuffer.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb2/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
    - shard-skl:          [FAIL][63] ([fdo#103167]) -> [FAIL][64] ([fdo#108040])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6277/shard-skl8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/shard-skl9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html

  
  [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6277 -> Patchwork_13293

  CI_DRM_6277: a0195925ba8732ffae5fed3c0b966ca331bae66c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5057: 3b91c82b90d45c1a30569410c1142b541956740a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13293: 8742bede989c183b9c080134d6b27ebc7ed70f0f @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13293/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v2] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-14 18:32 ` Ville Syrjälä
@ 2019-06-17 23:48   ` Matt Roper
  2019-06-18 16:08     ` Ville Syrjälä
  0 siblings, 1 reply; 17+ messages in thread
From: Matt Roper @ 2019-06-17 23:48 UTC (permalink / raw)
  To: intel-gfx

EHL has a mux on combo PHY A that allows it to be driven either by an
internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
This is a motherboard design decision that can not be changed on the
fly.  Unfortunately there are no strap registers that allow us to detect
the board configuration directly, so let's use the VBT to try to figure
it out and program the mux accordingly.

v2:
 - Confirmed that VBT's dvo port refers to the DDI and not the PHY.
   Thus we can check more explicitly for (ddi_d && !(ddi_a || dsi)).  If
   a bad VBT contradicts itself, let internal display win.  (Ville)

Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c     |  3 ++
 .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h               |  1 +
 3 files changed, 40 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index c4710889cb32..0c9808132d67 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1668,6 +1668,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
 		if (!child->device_type)
 			continue;
 
+		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
+			      child->device_type);
+
 		/*
 		 * Copy as much as we know (sizeof) and is available
 		 * (child_dev_size) of the child device. Accessing the data must
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index 841708da5a56..c18079a09a2e 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -260,6 +260,32 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,
 	I915_WRITE(ICL_PORT_CL_DW10(port), val);
 }
 
+static u32 ehl_combo_phy_a_mux(struct drm_i915_private *i915, u32 val)
+{
+	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
+	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
+	bool dsi_present = intel_bios_is_dsi_present(i915, NULL);
+
+	/*
+	 * VBT's 'dvo port' field for child devices references the DDI, not
+	 * the PHY.  So if combo PHY A is wired up to drive an external
+	 * display, we should see a child device present on PORT_D and
+	 * nothing on PORT_A and no DSI.
+	 */
+	if (ddi_d_present && !ddi_a_present && !dsi_present)
+		return val | ICL_PHY_MISC_MUX_DDID;
+
+	/*
+	 * If we encounter a VBT that claims to have an external display on
+	 * DDI-D _and_ an internal display on DDI-A/DSI leave an error message
+	 * in the log and let the internal display win.
+	 */
+	if (ddi_d_present)
+		DRM_ERROR("VBT claims to have both internal and external displays on PHY A.  Configuring for internal.\n");
+
+	return val & ~ICL_PHY_MISC_MUX_DDID;
+}
+
 static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
 {
 	enum port port;
@@ -273,7 +299,17 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
 			continue;
 		}
 
+		/*
+		 * EHL's combo PHY A can be hooked up to either an external
+		 * display (via DDI-D) or an internal display (via DDI-A or
+		 * the DSI DPHY).  This is a motherboard design decision that
+		 * can't be changed on the fly, so initialize the PHY's mux
+		 * based on whether our VBT indicates the presence of any
+		 * "internal" child devices.
+		 */
 		val = I915_READ(ICL_PHY_MISC(port));
+		if (!IS_ICELAKE(dev_priv) && port == PORT_A)
+			val = ehl_combo_phy_a_mux(dev_priv, val);
 		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
 		I915_WRITE(ICL_PHY_MISC(port), val);
 
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 1ae36b9efc85..68afafafd312 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -11138,6 +11138,7 @@ enum skl_power_gate {
 #define _ICL_PHY_MISC_B		0x64C04
 #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
 						 _ICL_PHY_MISC_B)
+#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
 #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
 
 /* Icelake Display Stream Compression Registers */
-- 
2.17.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (2 preceding siblings ...)
  2019-06-17 10:26 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-06-18  0:10 ` Patchwork
  2019-06-18  0:31 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-18  0:10 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
URL   : https://patchwork.freedesktop.org/series/62131/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
128ee0ddef48 drm/i915/ehl: Allow combo PHY A to drive a third external display
-:50: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_A].child"
#50: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:265:
+	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;

-:51: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_D].child"
#51: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:266:
+	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;

total: 0 errors, 0 warnings, 2 checks, 65 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (3 preceding siblings ...)
  2019-06-18  0:10 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2) Patchwork
@ 2019-06-18  0:31 ` Patchwork
  2019-06-18 14:32 ` ✗ Fi.CI.IGT: failure " Patchwork
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-18  0:31 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
URL   : https://patchwork.freedesktop.org/series/62131/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6289 -> Patchwork_13318
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/

Known issues
------------

  Here are the changes found in Patchwork_13318 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_switch@basic-default:
    - fi-icl-guc:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/fi-icl-guc/igt@gem_ctx_switch@basic-default.html

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - fi-icl-y:           [INCOMPLETE][3] ([fdo#107713] / [fdo#109100]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/fi-icl-y/igt@gem_ctx_create@basic-files.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/fi-icl-y/igt@gem_ctx_create@basic-files.html

  * igt@gem_exec_create@basic:
    - fi-icl-u2:          [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/fi-icl-u2/igt@gem_exec_create@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/fi-icl-u2/igt@gem_exec_create@basic.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][7] ([fdo#102614]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-ilk-650:         [DMESG-WARN][9] ([fdo#106387]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100


Participating hosts (43 -> 37)
------------------------------

  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6289 -> Patchwork_13318

  CI_DRM_6289: 897314e20de3b565ab91637f69817ebeddde07ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13318: 128ee0ddef48fe9b5045825b1b00e775f163b650 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

128ee0ddef48 drm/i915/ehl: Allow combo PHY A to drive a third external display

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.IGT: failure for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (4 preceding siblings ...)
  2019-06-18  0:31 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-18 14:32 ` Patchwork
  2019-06-18 18:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3) Patchwork
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-18 14:32 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2)
URL   : https://patchwork.freedesktop.org/series/62131/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6289_full -> Patchwork_13318_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_13318_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_13318_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13318_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_switch@basic-queue-light:
    - shard-apl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl6/igt@gem_ctx_switch@basic-queue-light.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl1/igt@gem_ctx_switch@basic-queue-light.html

  
Known issues
------------

  Here are the changes found in Patchwork_13318_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-snb:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-skl:          [PASS][7] -> [INCOMPLETE][8] ([fdo#104108])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-skl3/igt@gem_workarounds@suspend-resume-context.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-skl8/igt@gem_workarounds@suspend-resume-context.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl5/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#103355])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset:
    - shard-hsw:          [PASS][13] -> [SKIP][14] ([fdo#109271]) +35 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-hsw7/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-hsw1/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103167]) +5 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-iclb:         [PASS][19] -> [INCOMPLETE][20] ([fdo#106978] / [fdo#107713])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][21] -> [FAIL][22] ([fdo#108341])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb5/igt@kms_psr@no_drrs.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [PASS][23] -> [SKIP][24] ([fdo#109441]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb6/igt@kms_psr@psr2_no_drrs.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [PASS][25] -> [FAIL][26] ([fdo#100047])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb6/igt@kms_sysfs_edid_timing.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb2/igt@kms_sysfs_edid_timing.html

  * igt@kms_vblank@pipe-c-query-busy-hang:
    - shard-iclb:         [PASS][27] -> [INCOMPLETE][28] ([fdo#107713])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb8/igt@kms_vblank@pipe-c-query-busy-hang.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb7/igt@kms_vblank@pipe-c-query-busy-hang.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@hang:
    - shard-apl:          [DMESG-WARN][29] ([fdo#110913 ]) -> [PASS][30] +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl7/igt@gem_mmap_gtt@hang.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl3/igt@gem_mmap_gtt@hang.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
    - shard-apl:          [INCOMPLETE][31] ([fdo#103927]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-snb:          [DMESG-WARN][33] ([fdo#110789] / [fdo#110913 ]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-snb1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-kbl:          [INCOMPLETE][35] ([fdo#103665]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-skl:          [FAIL][37] ([fdo#102670]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [SKIP][39] ([fdo#109271]) -> [PASS][40] +31 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-hsw1/igt@kms_flip@2x-plain-flip.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-hsw4/igt@kms_flip@2x-plain-flip.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank:
    - shard-hsw:          [INCOMPLETE][41] ([fdo#103540]) -> [PASS][42] +1 similar issue
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-hsw5/igt@kms_flip@flip-vs-absolute-wf_vblank.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-hsw7/igt@kms_flip@flip-vs-absolute-wf_vblank.html

  * igt@kms_flip_tiling@flip-yf-tiled:
    - shard-skl:          [FAIL][43] ([fdo#108145]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-skl8/igt@kms_flip_tiling@flip-yf-tiled.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-skl2/igt@kms_flip_tiling@flip-yf-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
    - shard-iclb:         [FAIL][45] ([fdo#103167]) -> [PASS][46] +6 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-apl:          [DMESG-WARN][47] ([fdo#108566]) -> [PASS][48] +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-kbl:          [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [SKIP][51] ([fdo#109441]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-iclb6/igt@kms_psr@psr2_suspend.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-iclb2/igt@kms_psr@psr2_suspend.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][53] ([fdo#99912]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-kbl3/igt@kms_setmode@basic.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-kbl1/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
    - shard-skl:          [INCOMPLETE][55] ([fdo#104108]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-skl1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html

  * igt@tools_test@tools_test:
    - shard-glk:          [SKIP][57] ([fdo#109271]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6289/shard-glk1/igt@tools_test@tools_test.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/shard-glk6/igt@tools_test@tools_test.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6289 -> Patchwork_13318

  CI_DRM_6289: 897314e20de3b565ab91637f69817ebeddde07ef @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13318: 128ee0ddef48fe9b5045825b1b00e775f163b650 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13318/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-17 23:48   ` [PATCH v2] " Matt Roper
@ 2019-06-18 16:08     ` Ville Syrjälä
  2019-06-18 17:30       ` Matt Roper
  0 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-06-18 16:08 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

On Mon, Jun 17, 2019 at 04:48:10PM -0700, Matt Roper wrote:
> EHL has a mux on combo PHY A that allows it to be driven either by an
> internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
> This is a motherboard design decision that can not be changed on the
> fly.  Unfortunately there are no strap registers that allow us to detect
> the board configuration directly, so let's use the VBT to try to figure
> it out and program the mux accordingly.
> 
> v2:
>  - Confirmed that VBT's dvo port refers to the DDI and not the PHY.
>    Thus we can check more explicitly for (ddi_d && !(ddi_a || dsi)).  If
>    a bad VBT contradicts itself, let internal display win.  (Ville)
> 
> Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c     |  3 ++
>  .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++++++++
>  drivers/gpu/drm/i915/i915_reg.h               |  1 +
>  3 files changed, 40 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index c4710889cb32..0c9808132d67 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1668,6 +1668,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
>  		if (!child->device_type)
>  			continue;
>  
> +		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
> +			      child->device_type);
> +

Was this hunk intentional?

>  		/*
>  		 * Copy as much as we know (sizeof) and is available
>  		 * (child_dev_size) of the child device. Accessing the data must
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index 841708da5a56..c18079a09a2e 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -260,6 +260,32 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,
>  	I915_WRITE(ICL_PORT_CL_DW10(port), val);
>  }
>  
> +static u32 ehl_combo_phy_a_mux(struct drm_i915_private *i915, u32 val)
> +{
> +	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
> +	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
> +	bool dsi_present = intel_bios_is_dsi_present(i915, NULL);
> +
> +	/*
> +	 * VBT's 'dvo port' field for child devices references the DDI, not
> +	 * the PHY.  So if combo PHY A is wired up to drive an external
> +	 * display, we should see a child device present on PORT_D and
> +	 * nothing on PORT_A and no DSI.
> +	 */
> +	if (ddi_d_present && !ddi_a_present && !dsi_present)
> +		return val | ICL_PHY_MISC_MUX_DDID;
> +
> +	/*
> +	 * If we encounter a VBT that claims to have an external display on
> +	 * DDI-D _and_ an internal display on DDI-A/DSI leave an error message
> +	 * in the log and let the internal display win.
> +	 */
> +	if (ddi_d_present)
> +		DRM_ERROR("VBT claims to have both internal and external displays on PHY A.  Configuring for internal.\n");
> +
> +	return val & ~ICL_PHY_MISC_MUX_DDID;
> +}
> +
>  static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
>  {
>  	enum port port;
> @@ -273,7 +299,17 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
>  			continue;
>  		}
>  
> +		/*
> +		 * EHL's combo PHY A can be hooked up to either an external
> +		 * display (via DDI-D) or an internal display (via DDI-A or
> +		 * the DSI DPHY).  This is a motherboard design decision that
> +		 * can't be changed on the fly, so initialize the PHY's mux
> +		 * based on whether our VBT indicates the presence of any
> +		 * "internal" child devices.
> +		 */
>  		val = I915_READ(ICL_PHY_MISC(port));
> +		if (!IS_ICELAKE(dev_priv) && port == PORT_A)

Maybe IS_EHL instead?

Patch is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> +			val = ehl_combo_phy_a_mux(dev_priv, val);
>  		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
>  		I915_WRITE(ICL_PHY_MISC(port), val);
>  
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 1ae36b9efc85..68afafafd312 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -11138,6 +11138,7 @@ enum skl_power_gate {
>  #define _ICL_PHY_MISC_B		0x64C04
>  #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
>  						 _ICL_PHY_MISC_B)
> +#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
>  #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
>  
>  /* Icelake Display Stream Compression Registers */
> -- 
> 2.17.2

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-18 16:08     ` Ville Syrjälä
@ 2019-06-18 17:30       ` Matt Roper
  2019-06-18 17:39         ` Ville Syrjälä
  0 siblings, 1 reply; 17+ messages in thread
From: Matt Roper @ 2019-06-18 17:30 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: intel-gfx

On Tue, Jun 18, 2019 at 07:08:55PM +0300, Ville Syrjälä wrote:
> On Mon, Jun 17, 2019 at 04:48:10PM -0700, Matt Roper wrote:
> > EHL has a mux on combo PHY A that allows it to be driven either by an
> > internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
> > This is a motherboard design decision that can not be changed on the
> > fly.  Unfortunately there are no strap registers that allow us to detect
> > the board configuration directly, so let's use the VBT to try to figure
> > it out and program the mux accordingly.
> > 
> > v2:
> >  - Confirmed that VBT's dvo port refers to the DDI and not the PHY.
> >    Thus we can check more explicitly for (ddi_d && !(ddi_a || dsi)).  If
> >    a bad VBT contradicts itself, let internal display win.  (Ville)
> > 
> > Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_bios.c     |  3 ++
> >  .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++++++++
> >  drivers/gpu/drm/i915/i915_reg.h               |  1 +
> >  3 files changed, 40 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > index c4710889cb32..0c9808132d67 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > @@ -1668,6 +1668,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> >  		if (!child->device_type)
> >  			continue;
> >  
> > +		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
> > +			      child->device_type);
> > +
> 
> Was this hunk intentional?
> 

Yeah, I figured that having a little more detail on the child device
details will probably be useful for debugging any cases where the VBT
seems to contradict itself.  I'll add a note about the debug message to
the commit message to make it clear it's intentional.


> >  		/*
> >  		 * Copy as much as we know (sizeof) and is available
> >  		 * (child_dev_size) of the child device. Accessing the data must
> > diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > index 841708da5a56..c18079a09a2e 100644
> > --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > @@ -260,6 +260,32 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,
> >  	I915_WRITE(ICL_PORT_CL_DW10(port), val);
> >  }
> >  
> > +static u32 ehl_combo_phy_a_mux(struct drm_i915_private *i915, u32 val)
> > +{
> > +	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
> > +	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
> > +	bool dsi_present = intel_bios_is_dsi_present(i915, NULL);
> > +
> > +	/*
> > +	 * VBT's 'dvo port' field for child devices references the DDI, not
> > +	 * the PHY.  So if combo PHY A is wired up to drive an external
> > +	 * display, we should see a child device present on PORT_D and
> > +	 * nothing on PORT_A and no DSI.
> > +	 */
> > +	if (ddi_d_present && !ddi_a_present && !dsi_present)
> > +		return val | ICL_PHY_MISC_MUX_DDID;
> > +
> > +	/*
> > +	 * If we encounter a VBT that claims to have an external display on
> > +	 * DDI-D _and_ an internal display on DDI-A/DSI leave an error message
> > +	 * in the log and let the internal display win.
> > +	 */
> > +	if (ddi_d_present)
> > +		DRM_ERROR("VBT claims to have both internal and external displays on PHY A.  Configuring for internal.\n");
> > +
> > +	return val & ~ICL_PHY_MISC_MUX_DDID;
> > +}
> > +
> >  static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
> >  {
> >  	enum port port;
> > @@ -273,7 +299,17 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
> >  			continue;
> >  		}
> >  
> > +		/*
> > +		 * EHL's combo PHY A can be hooked up to either an external
> > +		 * display (via DDI-D) or an internal display (via DDI-A or
> > +		 * the DSI DPHY).  This is a motherboard design decision that
> > +		 * can't be changed on the fly, so initialize the PHY's mux
> > +		 * based on whether our VBT indicates the presence of any
> > +		 * "internal" child devices.
> > +		 */
> >  		val = I915_READ(ICL_PHY_MISC(port));
> > +		if (!IS_ICELAKE(dev_priv) && port == PORT_A)
> 
> Maybe IS_EHL instead?

That's how I was originally going to write it, but I switched it to !icl
to follow the general convention of "assume future platforms inherit all
behavior of current platform."


Matt

> 
> Patch is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> > +			val = ehl_combo_phy_a_mux(dev_priv, val);
> >  		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
> >  		I915_WRITE(ICL_PHY_MISC(port), val);
> >  
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 1ae36b9efc85..68afafafd312 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -11138,6 +11138,7 @@ enum skl_power_gate {
> >  #define _ICL_PHY_MISC_B		0x64C04
> >  #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
> >  						 _ICL_PHY_MISC_B)
> > +#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
> >  #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
> >  
> >  /* Icelake Display Stream Compression Registers */
> > -- 
> > 2.17.2
> 
> -- 
> Ville Syrjälä
> Intel

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-18 17:30       ` Matt Roper
@ 2019-06-18 17:39         ` Ville Syrjälä
  2019-06-18 17:51           ` [PATCH v3] " Matt Roper
  0 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-06-18 17:39 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

On Tue, Jun 18, 2019 at 10:30:06AM -0700, Matt Roper wrote:
> On Tue, Jun 18, 2019 at 07:08:55PM +0300, Ville Syrjälä wrote:
> > On Mon, Jun 17, 2019 at 04:48:10PM -0700, Matt Roper wrote:
> > > EHL has a mux on combo PHY A that allows it to be driven either by an
> > > internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
> > > This is a motherboard design decision that can not be changed on the
> > > fly.  Unfortunately there are no strap registers that allow us to detect
> > > the board configuration directly, so let's use the VBT to try to figure
> > > it out and program the mux accordingly.
> > > 
> > > v2:
> > >  - Confirmed that VBT's dvo port refers to the DDI and not the PHY.
> > >    Thus we can check more explicitly for (ddi_d && !(ddi_a || dsi)).  If
> > >    a bad VBT contradicts itself, let internal display win.  (Ville)
> > > 
> > > Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_bios.c     |  3 ++
> > >  .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++++++++
> > >  drivers/gpu/drm/i915/i915_reg.h               |  1 +
> > >  3 files changed, 40 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > > index c4710889cb32..0c9808132d67 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > > @@ -1668,6 +1668,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
> > >  		if (!child->device_type)
> > >  			continue;
> > >  
> > > +		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
> > > +			      child->device_type);
> > > +
> > 
> > Was this hunk intentional?
> > 
> 
> Yeah, I figured that having a little more detail on the child device
> details will probably be useful for debugging any cases where the VBT
> seems to contradict itself.  I'll add a note about the debug message to
> the commit message to make it clear it's intentional.
> 
> 
> > >  		/*
> > >  		 * Copy as much as we know (sizeof) and is available
> > >  		 * (child_dev_size) of the child device. Accessing the data must
> > > diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > > index 841708da5a56..c18079a09a2e 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> > > @@ -260,6 +260,32 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,
> > >  	I915_WRITE(ICL_PORT_CL_DW10(port), val);
> > >  }
> > >  
> > > +static u32 ehl_combo_phy_a_mux(struct drm_i915_private *i915, u32 val)
> > > +{
> > > +	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
> > > +	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
> > > +	bool dsi_present = intel_bios_is_dsi_present(i915, NULL);
> > > +
> > > +	/*
> > > +	 * VBT's 'dvo port' field for child devices references the DDI, not
> > > +	 * the PHY.  So if combo PHY A is wired up to drive an external
> > > +	 * display, we should see a child device present on PORT_D and
> > > +	 * nothing on PORT_A and no DSI.
> > > +	 */
> > > +	if (ddi_d_present && !ddi_a_present && !dsi_present)
> > > +		return val | ICL_PHY_MISC_MUX_DDID;
> > > +
> > > +	/*
> > > +	 * If we encounter a VBT that claims to have an external display on
> > > +	 * DDI-D _and_ an internal display on DDI-A/DSI leave an error message
> > > +	 * in the log and let the internal display win.
> > > +	 */
> > > +	if (ddi_d_present)
> > > +		DRM_ERROR("VBT claims to have both internal and external displays on PHY A.  Configuring for internal.\n");
> > > +
> > > +	return val & ~ICL_PHY_MISC_MUX_DDID;
> > > +}
> > > +
> > >  static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
> > >  {
> > >  	enum port port;
> > > @@ -273,7 +299,17 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
> > >  			continue;
> > >  		}
> > >  
> > > +		/*
> > > +		 * EHL's combo PHY A can be hooked up to either an external
> > > +		 * display (via DDI-D) or an internal display (via DDI-A or
> > > +		 * the DSI DPHY).  This is a motherboard design decision that
> > > +		 * can't be changed on the fly, so initialize the PHY's mux
> > > +		 * based on whether our VBT indicates the presence of any
> > > +		 * "internal" child devices.
> > > +		 */
> > >  		val = I915_READ(ICL_PHY_MISC(port));
> > > +		if (!IS_ICELAKE(dev_priv) && port == PORT_A)
> > 
> > Maybe IS_EHL instead?
> 
> That's how I was originally going to write it, but I switched it to !icl
> to follow the general convention of "assume future platforms inherit all
> behavior of current platform."

This feels like a one off cost saving measure to me. So not entirely
sure it makes sense to assume future platforms would follow this
apporach.

> 
> 
> Matt
> 
> > 
> > Patch is
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > > +			val = ehl_combo_phy_a_mux(dev_priv, val);
> > >  		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
> > >  		I915_WRITE(ICL_PHY_MISC(port), val);
> > >  
> > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > > index 1ae36b9efc85..68afafafd312 100644
> > > --- a/drivers/gpu/drm/i915/i915_reg.h
> > > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > > @@ -11138,6 +11138,7 @@ enum skl_power_gate {
> > >  #define _ICL_PHY_MISC_B		0x64C04
> > >  #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
> > >  						 _ICL_PHY_MISC_B)
> > > +#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
> > >  #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
> > >  
> > >  /* Icelake Display Stream Compression Registers */
> > > -- 
> > > 2.17.2
> > 
> > -- 
> > Ville Syrjälä
> > Intel
> 
> -- 
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v3] drm/i915/ehl: Allow combo PHY A to drive a third external display
  2019-06-18 17:39         ` Ville Syrjälä
@ 2019-06-18 17:51           ` Matt Roper
  0 siblings, 0 replies; 17+ messages in thread
From: Matt Roper @ 2019-06-18 17:51 UTC (permalink / raw)
  To: intel-gfx

EHL has a mux on combo PHY A that allows it to be driven either by an
internal display (DDI-A or DSI DPHY) or by an external display (DDI-D).
This is a motherboard design decision that can not be changed on the
fly.  Unfortunately there are no strap registers that allow us to detect
the board configuration directly, so let's use the VBT to try to figure
it out and program the mux accordingly.

For now if we run across a broken VBT that tries to claim that PHY A
is attached to both internal and external displays at the same time,
we'll resolve the conflict in favor of the internal display.  To help
debug these kind of bad VBT's, let's also add a quick DRM_DEBUG message
during child device parsing so that it's easier to understand these
cases if they show up in bug reports.

v2:
 - Confirmed that VBT's dvo port refers to the DDI and not the PHY.
   Thus we can check more explicitly for (ddi_d && !(ddi_a || dsi)).  If
   a bad VBT contradicts itself, let internal display win.  (Ville)

v3:
 - Switch condition from !IS_ICELAKE to IS_ELKHARTLAKE.  Although the
   convention is usually to assume that future platforms will inherit
   all current platform behavior, this feels more like a one-platform
   quirk.  (Ville)
 - Update commit message to describe what we do if/when we encounter
   broken VBT's, and note that the new debug print during child device
   parsing is intentional.

Cc: Clint Taylor <Clinton.A.Taylor@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_bios.c     |  3 ++
 .../gpu/drm/i915/display/intel_combo_phy.c    | 36 +++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h               |  1 +
 3 files changed, 40 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index c4710889cb32..0c9808132d67 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1668,6 +1668,9 @@ parse_general_definitions(struct drm_i915_private *dev_priv,
 		if (!child->device_type)
 			continue;
 
+		DRM_DEBUG_KMS("Found VBT child device with type 0x%x\n",
+			      child->device_type);
+
 		/*
 		 * Copy as much as we know (sizeof) and is available
 		 * (child_dev_size) of the child device. Accessing the data must
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index 841708da5a56..075bab2500eb 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -260,6 +260,32 @@ void intel_combo_phy_power_up_lanes(struct drm_i915_private *dev_priv,
 	I915_WRITE(ICL_PORT_CL_DW10(port), val);
 }
 
+static u32 ehl_combo_phy_a_mux(struct drm_i915_private *i915, u32 val)
+{
+	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;
+	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;
+	bool dsi_present = intel_bios_is_dsi_present(i915, NULL);
+
+	/*
+	 * VBT's 'dvo port' field for child devices references the DDI, not
+	 * the PHY.  So if combo PHY A is wired up to drive an external
+	 * display, we should see a child device present on PORT_D and
+	 * nothing on PORT_A and no DSI.
+	 */
+	if (ddi_d_present && !ddi_a_present && !dsi_present)
+		return val | ICL_PHY_MISC_MUX_DDID;
+
+	/*
+	 * If we encounter a VBT that claims to have an external display on
+	 * DDI-D _and_ an internal display on DDI-A/DSI leave an error message
+	 * in the log and let the internal display win.
+	 */
+	if (ddi_d_present)
+		DRM_ERROR("VBT claims to have both internal and external displays on PHY A.  Configuring for internal.\n");
+
+	return val & ~ICL_PHY_MISC_MUX_DDID;
+}
+
 static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
 {
 	enum port port;
@@ -273,7 +299,17 @@ static void icl_combo_phys_init(struct drm_i915_private *dev_priv)
 			continue;
 		}
 
+		/*
+		 * EHL's combo PHY A can be hooked up to either an external
+		 * display (via DDI-D) or an internal display (via DDI-A or
+		 * the DSI DPHY).  This is a motherboard design decision that
+		 * can't be changed on the fly, so initialize the PHY's mux
+		 * based on whether our VBT indicates the presence of any
+		 * "internal" child devices.
+		 */
 		val = I915_READ(ICL_PHY_MISC(port));
+		if (IS_ELKHARTLAKE(dev_priv) && port == PORT_A)
+			val = ehl_combo_phy_a_mux(dev_priv, val);
 		val &= ~ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN;
 		I915_WRITE(ICL_PHY_MISC(port), val);
 
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index d6483b5dc8e5..d98142940c38 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -11145,6 +11145,7 @@ enum skl_power_gate {
 #define _ICL_PHY_MISC_B		0x64C04
 #define ICL_PHY_MISC(port)	_MMIO_PORT(port, _ICL_PHY_MISC_A, \
 						 _ICL_PHY_MISC_B)
+#define  ICL_PHY_MISC_MUX_DDID			(1 << 28)
 #define  ICL_PHY_MISC_DE_IO_COMP_PWR_DOWN	(1 << 23)
 
 /* Icelake Display Stream Compression Registers */
-- 
2.17.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (5 preceding siblings ...)
  2019-06-18 14:32 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-06-18 18:33 ` Patchwork
  2019-06-18 18:49 ` ✓ Fi.CI.BAT: success " Patchwork
  2019-06-19 13:28 ` ✗ Fi.CI.IGT: failure " Patchwork
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-18 18:33 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
URL   : https://patchwork.freedesktop.org/series/62131/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d46fd4652551 drm/i915/ehl: Allow combo PHY A to drive a third external display
-:67: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_A].child"
#67: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:265:
+	bool ddi_a_present = i915->vbt.ddi_port_info[PORT_A].child != NULL;

-:68: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "i915->vbt.ddi_port_info[PORT_D].child"
#68: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:266:
+	bool ddi_d_present = i915->vbt.ddi_port_info[PORT_D].child != NULL;

total: 0 errors, 0 warnings, 2 checks, 65 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (6 preceding siblings ...)
  2019-06-18 18:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3) Patchwork
@ 2019-06-18 18:49 ` Patchwork
  2019-06-19 13:28 ` ✗ Fi.CI.IGT: failure " Patchwork
  8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-18 18:49 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
URL   : https://patchwork.freedesktop.org/series/62131/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6297 -> Patchwork_13334
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/

Known issues
------------

  Here are the changes found in Patchwork_13334 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - fi-icl-dsi:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108840])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-icl-dsi/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-icl-dsi/igt@i915_pm_rpm@module-reload.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [PASS][3] -> [FAIL][4] ([fdo#103167])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@debugfs_test@read_all_entries:
    - fi-icl-u3:          [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-icl-u3/igt@debugfs_test@read_all_entries.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-icl-u3/igt@debugfs_test@read_all_entries.html

  * igt@gem_sync@basic-store-each:
    - fi-bdw-5557u:       [FAIL][7] -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-bdw-5557u/igt@gem_sync@basic-store-each.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-bdw-5557u/igt@gem_sync@basic-store-each.html

  * igt@i915_selftest@live_contexts:
    - fi-skl-gvtdvm:      [DMESG-FAIL][9] ([fdo#110235]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][11] ([fdo#103167]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235


Participating hosts (44 -> 36)
------------------------------

  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6297 -> Patchwork_13334

  CI_DRM_6297: 8ebd162995143d1cc5c3ec699891e7fe059cea4c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13334: d46fd46525511427a67d9b29881a8ce45bfea1c7 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d46fd4652551 drm/i915/ehl: Allow combo PHY A to drive a third external display

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* ✗ Fi.CI.IGT: failure for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
  2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
                   ` (7 preceding siblings ...)
  2019-06-18 18:49 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-19 13:28 ` Patchwork
  2019-06-19 18:31   ` Matt Roper
  8 siblings, 1 reply; 17+ messages in thread
From: Patchwork @ 2019-06-19 13:28 UTC (permalink / raw)
  To: Matt Roper; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
URL   : https://patchwork.freedesktop.org/series/62131/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6297_full -> Patchwork_13334_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_13334_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_13334_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13334_full:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - shard-kbl:          NOTRUN -> ([FAIL][1], [FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6], [FAIL][7]) ([fdo#108903] / [fdo#108904] / [fdo#108905] / [fdo#110938])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@runner@aborted.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_13334_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-snb:          [PASS][8] -> [DMESG-WARN][9] ([fdo#110913 ])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-kbl:          [PASS][10] -> [DMESG-WARN][11] ([fdo#110913 ])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
    - shard-apl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#110913 ]) +2 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@i915_selftest@live_evict:
    - shard-kbl:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103665] / [fdo#110938])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl6/igt@i915_selftest@live_evict.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@i915_selftest@live_evict.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl6/igt@i915_suspend@sysfs-reader.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl3/igt@i915_suspend@sysfs-reader.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
    - shard-kbl:          [PASS][18] -> [FAIL][19] ([fdo#103232])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][20] -> [FAIL][21] ([fdo#105767])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
    - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#103184] / [fdo#103232])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [PASS][24] -> [SKIP][25] ([fdo#109271]) +14 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw6/igt@kms_flip@2x-plain-flip.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw1/igt@kms_flip@2x-plain-flip.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          [PASS][26] -> [INCOMPLETE][27] ([fdo#105411])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb4/igt@kms_flip@flip-vs-suspend.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
    - shard-iclb:         [PASS][28] -> [FAIL][29] ([fdo#103167]) +4 similar issues
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [PASS][30] -> [DMESG-WARN][31] ([fdo#108566])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][32] -> [FAIL][33] ([fdo#103166])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_psr@psr2_suspend.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_psr@psr2_suspend.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [PASS][36] -> [FAIL][37] ([fdo#99912])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw7/igt@kms_setmode@basic.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw8/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_eio@unwedge-stress:
    - shard-apl:          [DMESG-WARN][38] ([fdo#110913 ]) -> [PASS][39] +2 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@gem_eio@unwedge-stress.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl4/igt@gem_eio@unwedge-stress.html

  * igt@gem_mmap_gtt@hang:
    - shard-kbl:          [DMESG-WARN][40] ([fdo#110913 ]) -> [PASS][41] +1 similar issue
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl4/igt@gem_mmap_gtt@hang.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@gem_mmap_gtt@hang.html

  * igt@gem_sync@basic-store-each:
    - shard-skl:          [FAIL][42] ([fdo#110946]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl2/igt@gem_sync@basic-store-each.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl8/igt@gem_sync@basic-store-each.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-snb:          [DMESG-WARN][44] ([fdo#110913 ]) -> [PASS][45] +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-kbl:          [INCOMPLETE][46] ([fdo#103665]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl7/igt@gem_workarounds@suspend-resume-context.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl2/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-apl:          [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +2 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl2/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-skl:          [INCOMPLETE][50] ([fdo#110741]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
    - shard-hsw:          [SKIP][54] ([fdo#109271]) -> [PASS][55] +12 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw1/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw6/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html

  * igt@kms_flip_tiling@flip-yf-tiled:
    - shard-skl:          [FAIL][56] ([fdo#108145]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl4/igt@kms_flip_tiling@flip-yf-tiled.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_flip_tiling@flip-yf-tiled.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-iclb:         [FAIL][58] ([fdo#103167]) -> [PASS][59] +3 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [FAIL][60] ([fdo#108341]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb1/igt@kms_psr@no_drrs.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb7/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_primary_mmap_gtt:
    - shard-iclb:         [SKIP][62] ([fdo#109441]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [FAIL][64] ([fdo#100047]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_sysfs_edid_timing.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_sysfs_edid_timing.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
    - shard-skl:          [FAIL][66] ([fdo#103167]) -> [FAIL][67] ([fdo#108040])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108903]: https://bugs.freedesktop.org/show_bug.cgi?id=108903
  [fdo#108904]: https://bugs.freedesktop.org/show_bug.cgi?id=108904
  [fdo#108905]: https://bugs.freedesktop.org/show_bug.cgi?id=108905
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#110938]: https://bugs.freedesktop.org/show_bug.cgi?id=110938
  [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6297 -> Patchwork_13334

  CI_DRM_6297: 8ebd162995143d1cc5c3ec699891e7fe059cea4c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13334: d46fd46525511427a67d9b29881a8ce45bfea1c7 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: ✗ Fi.CI.IGT: failure for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
  2019-06-19 13:28 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-06-19 18:31   ` Matt Roper
  2019-06-19 19:04     ` Saarinen, Jani
  0 siblings, 1 reply; 17+ messages in thread
From: Matt Roper @ 2019-06-19 18:31 UTC (permalink / raw)
  To: intel-gfx

On Wed, Jun 19, 2019 at 01:28:04PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
> URL   : https://patchwork.freedesktop.org/series/62131/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6297_full -> Patchwork_13334_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_13334_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_13334_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_13334_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@runner@aborted:
>     - shard-kbl:          NOTRUN -> ([FAIL][1], [FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6], [FAIL][7]) ([fdo#108903] / [fdo#108904] / [fdo#108905] / [fdo#110938])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@runner@aborted.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@runner@aborted.html

I'm not sure I understand what CI is saying here; link #4 here gives a
404, and the other six links are all the same, but show empty boot/dmesg
logs.  There are some fdo bug numbers reported here for known bugs, so I
guess those are what CI detected, even though the logfiles themselves
appear to be empty?

Anyway, whatever is going on with this KBL system doesn't appear to be
caused by my patch since I'm updating code that only runs on gen11
platforms.

The rest of the CI results look okay, so applied to dinq.  Thanks Ville
for the review.


Matt


> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_13334_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
>     - shard-snb:          [PASS][8] -> [DMESG-WARN][9] ([fdo#110913 ])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
>     - shard-kbl:          [PASS][10] -> [DMESG-WARN][11] ([fdo#110913 ])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>     - shard-apl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#110913 ]) +2 similar issues
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> 
>   * igt@i915_selftest@live_evict:
>     - shard-kbl:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103665] / [fdo#110938])
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl6/igt@i915_selftest@live_evict.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@i915_selftest@live_evict.html
> 
>   * igt@i915_suspend@sysfs-reader:
>     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566])
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl6/igt@i915_suspend@sysfs-reader.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl3/igt@i915_suspend@sysfs-reader.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
>     - shard-kbl:          [PASS][18] -> [FAIL][19] ([fdo#103232])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
> 
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
>     - shard-hsw:          [PASS][20] -> [FAIL][21] ([fdo#105767])
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
>     - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#103184] / [fdo#103232])
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
> 
>   * igt@kms_flip@2x-plain-flip:
>     - shard-hsw:          [PASS][24] -> [SKIP][25] ([fdo#109271]) +14 similar issues
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw6/igt@kms_flip@2x-plain-flip.html
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw1/igt@kms_flip@2x-plain-flip.html
> 
>   * igt@kms_flip@flip-vs-suspend:
>     - shard-snb:          [PASS][26] -> [INCOMPLETE][27] ([fdo#105411])
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb4/igt@kms_flip@flip-vs-suspend.html
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb1/igt@kms_flip@flip-vs-suspend.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
>     - shard-iclb:         [PASS][28] -> [FAIL][29] ([fdo#103167]) +4 similar issues
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
> 
>   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
>     - shard-kbl:          [PASS][30] -> [DMESG-WARN][31] ([fdo#108566])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
> 
>   * igt@kms_plane_lowres@pipe-a-tiling-y:
>     - shard-iclb:         [PASS][32] -> [FAIL][33] ([fdo#103166])
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
> 
>   * igt@kms_psr@psr2_suspend:
>     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441])
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_psr@psr2_suspend.html
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_psr@psr2_suspend.html
> 
>   * igt@kms_setmode@basic:
>     - shard-hsw:          [PASS][36] -> [FAIL][37] ([fdo#99912])
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw7/igt@kms_setmode@basic.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw8/igt@kms_setmode@basic.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_eio@unwedge-stress:
>     - shard-apl:          [DMESG-WARN][38] ([fdo#110913 ]) -> [PASS][39] +2 similar issues
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@gem_eio@unwedge-stress.html
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl4/igt@gem_eio@unwedge-stress.html
> 
>   * igt@gem_mmap_gtt@hang:
>     - shard-kbl:          [DMESG-WARN][40] ([fdo#110913 ]) -> [PASS][41] +1 similar issue
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl4/igt@gem_mmap_gtt@hang.html
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl7/igt@gem_mmap_gtt@hang.html
> 
>   * igt@gem_sync@basic-store-each:
>     - shard-skl:          [FAIL][42] ([fdo#110946]) -> [PASS][43]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl2/igt@gem_sync@basic-store-each.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl8/igt@gem_sync@basic-store-each.html
> 
>   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
>     - shard-snb:          [DMESG-WARN][44] ([fdo#110913 ]) -> [PASS][45] +1 similar issue
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> 
>   * igt@gem_workarounds@suspend-resume-context:
>     - shard-kbl:          [INCOMPLETE][46] ([fdo#103665]) -> [PASS][47]
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl7/igt@gem_workarounds@suspend-resume-context.html
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl2/igt@gem_workarounds@suspend-resume-context.html
> 
>   * igt@i915_suspend@fence-restore-untiled:
>     - shard-apl:          [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +2 similar issues
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-apl8/igt@i915_suspend@fence-restore-untiled.html
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-apl2/igt@i915_suspend@fence-restore-untiled.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
>     - shard-skl:          [INCOMPLETE][50] ([fdo#110741]) -> [PASS][51]
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
>     - shard-kbl:          [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53]
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> 
>   * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
>     - shard-hsw:          [SKIP][54] ([fdo#109271]) -> [PASS][55] +12 similar issues
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-hsw1/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-hsw6/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
> 
>   * igt@kms_flip_tiling@flip-yf-tiled:
>     - shard-skl:          [FAIL][56] ([fdo#108145]) -> [PASS][57]
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl4/igt@kms_flip_tiling@flip-yf-tiled.html
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_flip_tiling@flip-yf-tiled.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
>     - shard-iclb:         [FAIL][58] ([fdo#103167]) -> [PASS][59] +3 similar issues
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
> 
>   * igt@kms_psr@no_drrs:
>     - shard-iclb:         [FAIL][60] ([fdo#108341]) -> [PASS][61]
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb1/igt@kms_psr@no_drrs.html
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb7/igt@kms_psr@no_drrs.html
> 
>   * igt@kms_psr@psr2_primary_mmap_gtt:
>     - shard-iclb:         [SKIP][62] ([fdo#109441]) -> [PASS][63]
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> 
>   * igt@kms_sysfs_edid_timing:
>     - shard-iclb:         [FAIL][64] ([fdo#100047]) -> [PASS][65]
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-iclb2/igt@kms_sysfs_edid_timing.html
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-iclb8/igt@kms_sysfs_edid_timing.html
> 
>   
> #### Warnings ####
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
>     - shard-skl:          [FAIL][66] ([fdo#103167]) -> [FAIL][67] ([fdo#108040])
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
> 
>   
>   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>   [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#108903]: https://bugs.freedesktop.org/show_bug.cgi?id=108903
>   [fdo#108904]: https://bugs.freedesktop.org/show_bug.cgi?id=108904
>   [fdo#108905]: https://bugs.freedesktop.org/show_bug.cgi?id=108905
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
>   [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
>   [fdo#110938]: https://bugs.freedesktop.org/show_bug.cgi?id=110938
>   [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_6297 -> Patchwork_13334
> 
>   CI_DRM_6297: 8ebd162995143d1cc5c3ec699891e7fe059cea4c @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_13334: d46fd46525511427a67d9b29881a8ce45bfea1c7 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: ✗ Fi.CI.IGT: failure for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
  2019-06-19 18:31   ` Matt Roper
@ 2019-06-19 19:04     ` Saarinen, Jani
  0 siblings, 0 replies; 17+ messages in thread
From: Saarinen, Jani @ 2019-06-19 19:04 UTC (permalink / raw)
  To: Roper, Matthew D, intel-gfx, Sarvela, Tomi P, Peres, Martin

HI, 


> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
> Matt Roper
> Sent: keskiviikko 19. kesäkuuta 2019 21.31
> To: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: Allow combo PHY A to
> drive a third external display (rev3)
> 
> On Wed, Jun 19, 2019 at 01:28:04PM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3)
> > URL   : https://patchwork.freedesktop.org/series/62131/
> > State : failure
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_6297_full -> Patchwork_13334_full
> > ====================================================
> >
> > Summary
> > -------
> >
> >   **FAILURE**
> >
> >   Serious unknown changes coming with Patchwork_13334_full absolutely need
> to be
> >   verified manually.
> >
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_13334_full, please notify your bug team to allow
> them
> >   to document this new failure mode, which will reduce false positives in CI.
> >
> >
> >
> > Possible new issues
> > -------------------
> >
> >   Here are the unknown changes that may have been introduced in
> Patchwork_13334_full:
> >
> > ### IGT changes ###
> >
> > #### Possible regressions ####
> >
> >   * igt@runner@aborted:
> >     - shard-kbl:          NOTRUN -> ([FAIL][1], [FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5],
> [FAIL][6], [FAIL][7]) ([fdo#108903] / [fdo#108904] / [fdo#108905] / [fdo#110938])
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl7/igt@runner@aborted.html
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@runner@aborted.html
> 
> I'm not sure I understand what CI is saying here; link #4 here gives a
> 404, and the other six links are all the same, but show empty boot/dmesg
> logs.  There are some fdo bug numbers reported here for known bugs, so I
> guess those are what CI detected, even though the logfiles themselves
> appear to be empty?
It tries to say that each of these run none of the run was done as  eg.
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-kbl4/run33.log
It seems that CI files are not sent. Anyway on this normally dmesg logs should tell that there has been kernel tainted and that is why
no tests run on these runs...perhaps, Tomi, Martin?  

> 
> Anyway, whatever is going on with this KBL system doesn't appear to be
> caused by my patch since I'm updating code that only runs on gen11
> platforms.
> 
> The rest of the CI results look okay, so applied to dinq.  Thanks Ville
> for the review.
> 
> 
> Matt
> 
> 
> >
> >
> > Known issues
> > ------------
> >
> >   Here are the changes found in Patchwork_13334_full that come from known
> issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> >   * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
> >     - shard-snb:          [PASS][8] -> [DMESG-WARN][9] ([fdo#110913 ])
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
> >
> >   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
> >     - shard-kbl:          [PASS][10] -> [DMESG-WARN][11] ([fdo#110913 ])
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> >    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> >     - shard-apl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#110913 ]) +2 similar
> issues
> >    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> apl8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> >    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> apl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
> >
> >   * igt@i915_selftest@live_evict:
> >     - shard-kbl:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103665] /
> [fdo#110938])
> >    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl6/igt@i915_selftest@live_evict.html
> >    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl7/igt@i915_selftest@live_evict.html
> >
> >   * igt@i915_suspend@sysfs-reader:
> >     - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566])
> >    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> apl6/igt@i915_suspend@sysfs-reader.html
> >    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> apl3/igt@i915_suspend@sysfs-reader.html
> >
> >   * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
> >     - shard-kbl:          [PASS][18] -> [FAIL][19] ([fdo#103232])
> >    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
> >    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl2/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
> >
> >   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
> >     - shard-hsw:          [PASS][20] -> [FAIL][21] ([fdo#105767])
> >    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> >    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> >
> >   * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
> >     - shard-skl:          [PASS][22] -> [FAIL][23] ([fdo#103184] / [fdo#103232])
> >    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
> >    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> skl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
> >
> >   * igt@kms_flip@2x-plain-flip:
> >     - shard-hsw:          [PASS][24] -> [SKIP][25] ([fdo#109271]) +14 similar issues
> >    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> hsw6/igt@kms_flip@2x-plain-flip.html
> >    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> hsw1/igt@kms_flip@2x-plain-flip.html
> >
> >   * igt@kms_flip@flip-vs-suspend:
> >     - shard-snb:          [PASS][26] -> [INCOMPLETE][27] ([fdo#105411])
> >    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> snb4/igt@kms_flip@flip-vs-suspend.html
> >    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> snb1/igt@kms_flip@flip-vs-suspend.html
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
> >     - shard-iclb:         [PASS][28] -> [FAIL][29] ([fdo#103167]) +4 similar issues
> >    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
> >    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
> >
> >   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
> >     - shard-kbl:          [PASS][30] -> [DMESG-WARN][31] ([fdo#108566])
> >    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
> >    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
> >
> >   * igt@kms_plane_lowres@pipe-a-tiling-y:
> >     - shard-iclb:         [PASS][32] -> [FAIL][33] ([fdo#103166])
> >    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
> >    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
> >
> >   * igt@kms_psr@psr2_suspend:
> >     - shard-iclb:         [PASS][34] -> [SKIP][35] ([fdo#109441])
> >    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb2/igt@kms_psr@psr2_suspend.html
> >    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb8/igt@kms_psr@psr2_suspend.html
> >
> >   * igt@kms_setmode@basic:
> >     - shard-hsw:          [PASS][36] -> [FAIL][37] ([fdo#99912])
> >    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> hsw7/igt@kms_setmode@basic.html
> >    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> hsw8/igt@kms_setmode@basic.html
> >
> >
> > #### Possible fixes ####
> >
> >   * igt@gem_eio@unwedge-stress:
> >     - shard-apl:          [DMESG-WARN][38] ([fdo#110913 ]) -> [PASS][39] +2 similar
> issues
> >    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> apl8/igt@gem_eio@unwedge-stress.html
> >    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> apl4/igt@gem_eio@unwedge-stress.html
> >
> >   * igt@gem_mmap_gtt@hang:
> >     - shard-kbl:          [DMESG-WARN][40] ([fdo#110913 ]) -> [PASS][41] +1 similar
> issue
> >    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl4/igt@gem_mmap_gtt@hang.html
> >    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl7/igt@gem_mmap_gtt@hang.html
> >
> >   * igt@gem_sync@basic-store-each:
> >     - shard-skl:          [FAIL][42] ([fdo#110946]) -> [PASS][43]
> >    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> skl2/igt@gem_sync@basic-store-each.html
> >    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> skl8/igt@gem_sync@basic-store-each.html
> >
> >   * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
> >     - shard-snb:          [DMESG-WARN][44] ([fdo#110913 ]) -> [PASS][45] +1 similar
> issue
> >    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> >    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> >
> >   * igt@gem_workarounds@suspend-resume-context:
> >     - shard-kbl:          [INCOMPLETE][46] ([fdo#103665]) -> [PASS][47]
> >    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl7/igt@gem_workarounds@suspend-resume-context.html
> >    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl2/igt@gem_workarounds@suspend-resume-context.html
> >
> >   * igt@i915_suspend@fence-restore-untiled:
> >     - shard-apl:          [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +2 similar
> issues
> >    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> apl8/igt@i915_suspend@fence-restore-untiled.html
> >    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> apl2/igt@i915_suspend@fence-restore-untiled.html
> >
> >   * igt@kms_cursor_crc@pipe-b-cursor-suspend:
> >     - shard-skl:          [INCOMPLETE][50] ([fdo#110741]) -> [PASS][51]
> >    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> >    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> skl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
> >
> >   * igt@kms_cursor_crc@pipe-c-cursor-suspend:
> >     - shard-kbl:          [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53]
> >    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> >    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
> >
> >   * igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
> >     - shard-hsw:          [SKIP][54] ([fdo#109271]) -> [PASS][55] +12 similar issues
> >    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> hsw1/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
> >    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> hsw6/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
> >
> >   * igt@kms_flip_tiling@flip-yf-tiled:
> >     - shard-skl:          [FAIL][56] ([fdo#108145]) -> [PASS][57]
> >    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> skl4/igt@kms_flip_tiling@flip-yf-tiled.html
> >    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> skl4/igt@kms_flip_tiling@flip-yf-tiled.html
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
> >     - shard-iclb:         [FAIL][58] ([fdo#103167]) -> [PASS][59] +3 similar issues
> >    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-
> pwrite.html
> >    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-
> pwrite.html
> >
> >   * igt@kms_psr@no_drrs:
> >     - shard-iclb:         [FAIL][60] ([fdo#108341]) -> [PASS][61]
> >    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb1/igt@kms_psr@no_drrs.html
> >    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb7/igt@kms_psr@no_drrs.html
> >
> >   * igt@kms_psr@psr2_primary_mmap_gtt:
> >     - shard-iclb:         [SKIP][62] ([fdo#109441]) -> [PASS][63]
> >    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
> >    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
> >
> >   * igt@kms_sysfs_edid_timing:
> >     - shard-iclb:         [FAIL][64] ([fdo#100047]) -> [PASS][65]
> >    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> iclb2/igt@kms_sysfs_edid_timing.html
> >    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> iclb8/igt@kms_sysfs_edid_timing.html
> >
> >
> > #### Warnings ####
> >
> >   * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-
> gtt:
> >     - shard-skl:          [FAIL][66] ([fdo#103167]) -> [FAIL][67] ([fdo#108040])
> >    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6297/shard-
> skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-
> gtt.html
> >    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13334/shard-
> skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-
> gtt.html
> >
> >
> >   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
> >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >   [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
> >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> >   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
> >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> >   [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
> >   [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
> >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >   [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
> >   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> >   [fdo#108903]: https://bugs.freedesktop.org/show_bug.cgi?id=108903
> >   [fdo#108904]: https://bugs.freedesktop.org/show_bug.cgi?id=108904
> >   [fdo#108905]: https://bugs.freedesktop.org/show_bug.cgi?id=108905
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> >   [fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
> >   [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
> >   [fdo#110938]: https://bugs.freedesktop.org/show_bug.cgi?id=110938
> >   [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
> >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >
> >
> > Participating hosts (10 -> 10)
> > ------------------------------
> >
> >   No changes in participating hosts
> >
> >
> > Build changes
> > -------------
> >
> >   * Linux: CI_DRM_6297 -> Patchwork_13334
> >
> >   CI_DRM_6297: 8ebd162995143d1cc5c3ec699891e7fe059cea4c @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   Patchwork_13334: d46fd46525511427a67d9b29881a8ce45bfea1c7 @
> git://anongit.freedesktop.org/gfx-ci/linux
> >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_13334/
> 
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2019-06-19 19:04 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 18:07 [PATCH] drm/i915/ehl: Allow combo PHY A to drive a third external display Matt Roper
2019-06-14 18:32 ` Ville Syrjälä
2019-06-17 23:48   ` [PATCH v2] " Matt Roper
2019-06-18 16:08     ` Ville Syrjälä
2019-06-18 17:30       ` Matt Roper
2019-06-18 17:39         ` Ville Syrjälä
2019-06-18 17:51           ` [PATCH v3] " Matt Roper
2019-06-15  5:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-17 10:26 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-18  0:10 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev2) Patchwork
2019-06-18  0:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-18 14:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-18 18:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ehl: Allow combo PHY A to drive a third external display (rev3) Patchwork
2019-06-18 18:49 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-19 13:28 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-06-19 18:31   ` Matt Roper
2019-06-19 19:04     ` Saarinen, Jani

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.