Serious bug calling ALSA lib functions from .so vs. .o file

* Serious bug calling ALSA lib functions from .so vs. .o file
@ 2019-06-18  6:24 scott andrew franco
  2019-06-18 15:16 ` scott andrew franco
  0 siblings, 1 reply; 9+ messages in thread
From: scott andrew franco @ 2019-06-18  6:24 UTC (permalink / raw)
  To: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 2161 bytes --]

Hi, I am having a strange issue calling snd_pcm_* alsa-lib functions from a .so file.

The example is a pretty run of the mill .wav file output example in C from the internet, which I have placed in playwav.c.
I put the routine that does the pcm play, alsaplaywave(), into a routine and have a duplicate in another external file, test2.c.
I named the one in playwav.c alsaplaywav1(), and the one in test2.c alsaplaywav().

The compile is done as follows:

gcc -g3 -Iinclude -fPIC -c test2.c -o test2.o
gcc -shared test2.o -o test2.so
#
# Compiling from .so causes bug, compiling from .o does not
#
gcc -g3 -Iinclude linux/playwav.c ./test2.so -lasound -o playwav
#gcc -g3 -Iinclude linux/playwav.c ./test2.o -lasound -o playwav
 If the test2.so file is used, the playback has its parameters such as rate messed up, and the result is it plays
 as fast as possible (series of chirps). If the above line is just changed to test2.o, the playback is fine.
 Further, if the copy of alsaplaywav() local to the playwav.c file is executed, the playback is correct. It is only
 when playing from the routine in the .so file that it messes up.
 To find out what the key point of failure is, I put all of the preamble for the routine up until it does a

 snd_pcm_hw_params_set_rate_near() at the calling point (in playwav.c) and commented that out in the routine.
 The idea was to see exactly which alsa call being done inside the .so caused the malfunction.
 The rate set appears to be the key. Do that outside the .so, it works, do it inside, it does not.
 I note that snd_pcm_hw_params_set_rate_near() goes through a few macros in alsa-lib.
 I think I could debug this better if I can get alsa symbols into gdb. As in the other message, I cannot figure out
 where the libasound.so gets constructed in the build. I see libasound.a, but no libasound.so.
 Apologies for not cutting the example down further, but the failure mode is quite complex and that is
 difficult.
 Find playwav.c and test2.c attached, and the compile instructions I used above or in cplaywav. The
 files are fairly small.
 Thanks for any help.

 Scott Franco

[-- Attachment #2: test2.c --]
[-- Type: text/x-c, Size: 3649 bytes --]

#include <pthread.h>
#include <alsa/asoundlib.h>
#include <sys/time.h>
#include <sys/timerfd.h>

/*******************************************************************************

Play ALSA sound file

Plays the given ALSA sound file given the filename.

*******************************************************************************/

void alsaplaywave(char* fn, FILE* fh, snd_pcm_t *pcm_handle,
                  snd_pcm_hw_params_t *params, unsigned int channels, unsigned int rate)

{

    unsigned int pcm, tmp;
//    unsigned int rate/*, channels*/;
//   snd_pcm_t *pcm_handle;
//    snd_pcm_hw_params_t *params;
    snd_pcm_uframes_t frames;
    char *buff;
    int buff_size;
    int r;
    int end;
//    FILE* fh;

    channels = 2;
    rate = 10000;

fprintf(stderr, "\n\nalsaplaywave: begin\n");
//fprintf(stderr, "alsaplaywave: bottom version: begin: file: %s\n", fn);
    /* open input .wav file */
//    fh = fopen(fn, "r");
//    if (!fh) printf("Cannot open input .wav file");

    /* open pcm device */
//    r = snd_pcm_open(&pcm_handle, "default", SND_PCM_STREAM_PLAYBACK, 0);
//fprintf(stderr, "alsawave: 0: r: %d\n", r);
//    if (r < 0) printf("Cannot open PCM output device");

//    snd_pcm_hw_params_alloca(&params); /* get hw parameter block */
//    snd_pcm_hw_params_any(pcm_handle, params);

    /* Set parameters */
//    r = snd_pcm_hw_params_set_access(pcm_handle, params, SND_PCM_ACCESS_RW_INTERLEAVED);
//fprintf(stderr, "alsawave: 1: r: %d\n", r);
//    if (r < 0) printf("Cannot set interleaved mode");

//    r = snd_pcm_hw_params_set_format(pcm_handle, params, SND_PCM_FORMAT_S16_LE);
//    if (r < 0) printf("Cannot set format");

//    r = snd_pcm_hw_params_set_channels(pcm_handle, params, channels);
//    if (r < 0) printf("Cannot set channels number");

fprintf(stderr, "alsaplaywave: before set rate: rate: %d\n", rate);
    r = snd_pcm_hw_params_set_rate_near(pcm_handle, params, &rate, 0);
    if (r < 0) printf("Cannot set rate");
fprintf(stderr, "alsaplaywave: after set rate: rate: %d\n", rate);

    /* Write parameters */
    r = snd_pcm_hw_params(pcm_handle, params);
    if (r < 0) printf("cannot set hardware parameters\n");

    /* get number of channels */
    snd_pcm_hw_params_get_channels(params, &channels);

    /* get sample rate */
    snd_pcm_hw_params_get_rate(params, &rate, 0);
fprintf(stderr, "alsaplaywave: rate: %d\n", rate);
rate = 10000;

    /* Allocate buffer to hold single period */
    snd_pcm_hw_params_get_period_size(params, &frames, 0);
fprintf(stderr, "frames: %ld\n", frames);
frames = 1024;

    buff_size = frames * channels * 2 /* 2 -> sample size */;
fprintf(stderr, "channels: %d frames: %ld buff_size: %d\n", channels, frames, buff_size);
    buff = (char *) malloc(buff_size);

    snd_pcm_hw_params_get_period_time(params, &tmp, NULL);

fprintf(stderr, "alsaplaywave: 4\n");
    end = 0;
    while (!end) {

        /* read input .wav file */
//fprintf(stderr, "alsaplaywave: buff_size: %d\n", buff_size);
        r = fread(buff, buff_size, 1, fh);
//fprintf(stderr, "alsaplaywave: r: %d\n", r);
        end = r == 0;
        if (!end) {

            /* write samples to PCM device */
            r = snd_pcm_writei(pcm_handle, buff, frames);
            if (r == -EPIPE) snd_pcm_prepare(pcm_handle);
            else if (r < 0) { printf("Cannot write to PCM device\n"); exit(1); }

        }
//fprintf(stderr, "alsaplaywave: 6\n");

    }

    snd_pcm_drain(pcm_handle);
    snd_pcm_close(pcm_handle);
    free(buff);
    fclose(fh);

}

[-- Attachment #3: cplaywav --]
[-- Type: text/plain, Size: 271 bytes --]

gcc -g3 -Iinclude -fPIC -c test2.c -o test2.o
gcc -shared test2.o -o test2.so
#
# Compiling from .so causes bug, compiling from .o does not
#
gcc -g3 -Iinclude linux/playwav.c ./test2.so -lasound -o playwav
#gcc -g3 -Iinclude linux/playwav.c ./test2.o -lasound -o playwav

[-- Attachment #4: playwav.c --]
[-- Type: text/x-c, Size: 6636 bytes --]

/*
 * Simple sound playback using ALSA API and libasound.
 *
 * Compile:
 * $ cc -o play sound_playback.c -lasound
 *
 * Usage:
 * $ ./play <sample_rate> <channels> <seconds> < <file>
 *
 * Examples:
 * $ ./play 44100 2 5 < /dev/urandom
 * $ ./play 22050 1 8 < /path/to/file.wav
 *
 * Copyright (C) 2009 Alessandro Ghedini <alessandro@ghedini.me>
 * --------------------------------------------------------------
 * "THE BEER-WARE LICENSE" (Revision 42):
 * Alessandro Ghedini wrote this file. As long as you retain this
 * notice you can do whatever you want with this stuff. If we
 * meet some day, and you think this stuff is worth it, you can
 * buy me a beer in return.
 * --------------------------------------------------------------
 */

#include <alsa/asoundlib.h>
#include <stdio.h>

static void alsaplaywave1(char* fn, FILE* fh, snd_pcm_t *pcm_handle,
                          snd_pcm_hw_params_t *params, unsigned int channels, unsigned int rate)

{

    unsigned int pcm, tmp;
//    unsigned int rate/*, channels*/;
//    snd_pcm_t *pcm_handle;
//    snd_pcm_hw_params_t *params;
    snd_pcm_uframes_t frames;
    char *buff;
    int buff_size;
    int r;
    int end;
//    FILE* fh;

    channels = 2;
    rate = 10000;

fprintf(stderr, "\n\nalsaplaywave1: begin\n");
//fprintf(stderr, "alsaplaywave: top version: begin: file: %s\n", fn);
    /* open input .wav file */
//    fh = fopen(fn, "r");
//    if (!fh) printf("Cannot open input .wav file");

    /* open pcm device */
//    r = snd_pcm_open(&pcm_handle, "default", SND_PCM_STREAM_PLAYBACK, 0);
//fprintf(stderr, "alsawave: 0: r: %d\n", r);
//    if (r < 0) printf("Cannot open PCM output device");

//    snd_pcm_hw_params_alloca(&params); /* get hw parameter block */
//    snd_pcm_hw_params_any(pcm_handle, params);
    /* Set parameters */
//    r = snd_pcm_hw_params_set_access(pcm_handle, params, SND_PCM_ACCESS_RW_INTERLEAVED);
//fprintf(stderr, "alsawave: 1: r: %d\n", r);
//    if (r < 0) printf("Cannot set interleaved mode");

//    r = snd_pcm_hw_params_set_format(pcm_handle, params, SND_PCM_FORMAT_S16_LE);
//    if (r < 0) printf("Cannot set format");

//    r = snd_pcm_hw_params_set_channels(pcm_handle, params, channels);
//    if (r < 0) printf("Cannot set channels number");

fprintf(stderr, "alsaplaywave: before set rate: rate: %d\n", rate);
    r = snd_pcm_hw_params_set_rate_near(pcm_handle, params, &rate, 0);
    if (r < 0) printf("Cannot set rate");
fprintf(stderr, "alsaplaywave: after set rate: rate: %d\n", rate);

    /* Write parameters */
    r = snd_pcm_hw_params(pcm_handle, params);
    if (r < 0) printf("cannot set hardware parameters");

    /* get number of channels */
    snd_pcm_hw_params_get_channels(params, &channels);

    /* get sample rate */
    snd_pcm_hw_params_get_rate(params, &rate, 0);
fprintf(stderr, "alsaplaywave: rate: %d\n", rate);
rate = 10000;

    /* Allocate buffer to hold single period */
    snd_pcm_hw_params_get_period_size(params, &frames, 0);
fprintf(stderr, "frames: %ld\n", frames);
frames = 1024;

    buff_size = frames * channels * 2 /* 2 -> sample size */;
fprintf(stderr, "channels: %d frames: %ld buff_size: %d\n", channels, frames, buff_size);
    buff = (char *) malloc(buff_size);

    snd_pcm_hw_params_get_period_time(params, &tmp, NULL);

fprintf(stderr, "alsaplaywave: 4\n");
    end = 0;
    while (!end) {

        /* read input .wav file */
//fprintf(stderr, "alsaplaywave: before fread: buff_size: %d\n", buff_size);
        r = fread(buff, buff_size, 1, fh);
//fprintf(stderr, "alsaplaywave: after fread: r: %d\n", r);
        end = r == 0;
        if (!end) {

            /* write samples to PCM device */
            r = snd_pcm_writei(pcm_handle, buff, frames);
            if (r == -EPIPE) snd_pcm_prepare(pcm_handle);
            else if (r < 0) { printf("Cannot write to PCM device"); exit(1); }

        }
//fprintf(stderr, "alsaplaywave: 6\n");

    }
fprintf(stderr, "alsaplaywave: 5\n");

    snd_pcm_drain(pcm_handle);
    snd_pcm_close(pcm_handle);
    free(buff);
    fclose(fh);

}

extern void alsaplaywave(char* fn, FILE* fh, snd_pcm_t *pcm_handle,
                         snd_pcm_hw_params_t *params, unsigned int channels, unsigned int rate);

int main(int argc, char **argv)

{

    FILE* fh;
    snd_pcm_t *pcm_handle;
    snd_pcm_hw_params_t *params;
    unsigned int channels = 2;
    unsigned int rate = 10000;
    int r;

    fh = fopen("test.wav", "r");
    if (!fh) printf("Cannot open input .wav file");
    r = snd_pcm_open(&pcm_handle, "default", SND_PCM_STREAM_PLAYBACK, 0);
    if (r < 0) printf("Cannot open PCM output device");
    snd_pcm_hw_params_alloca(&params); /* get hw parameter block */
    snd_pcm_hw_params_any(pcm_handle, params);
    r = snd_pcm_hw_params_set_access(pcm_handle, params, SND_PCM_ACCESS_RW_INTERLEAVED);
    fprintf(stderr, "alsawave: 1: r: %d\n", r);
    if (r < 0) printf("Cannot set interleaved mode");
    r = snd_pcm_hw_params_set_format(pcm_handle, params, SND_PCM_FORMAT_S16_LE);
    if (r < 0) printf("Cannot set format");
    r = snd_pcm_hw_params_set_channels(pcm_handle, params, channels);
    if (r < 0) printf("Cannot set channels number");
//    fprintf(stderr, "alsaplaywave: before set rate: rate: %d\n", rate);
//    r = snd_pcm_hw_params_set_rate_near(pcm_handle, params, &rate, 0);
//    if (r < 0) printf("Cannot set rate");
//    fprintf(stderr, "alsaplaywave: after set rate: rate: %d\n", rate);
    alsaplaywave("test.wav", fh, pcm_handle, params, channels, rate);

    fh = fopen("test.wav", "r");
    if (!fh) printf("Cannot open input .wav file");
    r = snd_pcm_open(&pcm_handle, "default", SND_PCM_STREAM_PLAYBACK, 0);
    if (r < 0) printf("Cannot open PCM output device");
    snd_pcm_hw_params_alloca(&params); /* get hw parameter block */
    snd_pcm_hw_params_any(pcm_handle, params);
    r = snd_pcm_hw_params_set_access(pcm_handle, params, SND_PCM_ACCESS_RW_INTERLEAVED);
    fprintf(stderr, "alsawave: 1: r: %d\n", r);
    if (r < 0) printf("Cannot set interleaved mode");
    r = snd_pcm_hw_params_set_format(pcm_handle, params, SND_PCM_FORMAT_S16_LE);
    if (r < 0) printf("Cannot set format");
    r = snd_pcm_hw_params_set_channels(pcm_handle, params, channels);
    if (r < 0) printf("Cannot set channels number");
    fprintf(stderr, "alsaplaywave: before set rate: rate: %d\n", rate);
    r = snd_pcm_hw_params_set_rate_near(pcm_handle, params, &rate, 0);
    if (r < 0) printf("Cannot set rate");
    fprintf(stderr, "alsaplaywave: after set rate: rate: %d\n", rate);
    alsaplaywave1("test.wav", fh, pcm_handle, params, channels, rate);

    return 0;
}

[-- Attachment #5: Type: text/plain, Size: 0 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread