All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Christoph Hellwig <hch@lst.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/powernv: remove dead NPU DMA code
Date: Thu, 20 Jun 2019 08:21:26 +0200	[thread overview]
Message-ID: <20190620062126.GA20765@lst.de> (raw)
In-Reply-To: <309781b5-108f-c219-2cda-49179dca6b13@ozlabs.ru>

On Thu, Jun 20, 2019 at 04:20:08PM +1000, Alexey Kardashevskiy wrote:
> 
> 
> On 20/06/2019 16:03, Christoph Hellwig wrote:
> > Hi Linus,
> > 
> > this goes back to the discussion at last years kernel summit, where
> > we had the discussion on removing code never used by any in-kernel
> > user an no prospects of one.  The IBM folks are unfortunately still
> > dragging their feet on the powerpc side.  Can we revise this discussion?
> > 
> > The use case here is a IBM specific bus for which they only have an
> > out of tree driver that their partner doesn't want to submit for mainline,
> > but keep insisting on keeping the code around (which is also built
> > uncondіtionally for the platform).
> 
> 
> I personally keep insisting on correct commit logs, i.e. not calling
> working code dead and providing actual reasons for the change. Thanks,

If that is the only thing you are complaining about I can clarify it
a little of course.  But it didn't sound like that was the actual
problem.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/4] powerpc/powernv: remove dead NPU DMA code
Date: Thu, 20 Jun 2019 08:21:26 +0200	[thread overview]
Message-ID: <20190620062126.GA20765@lst.de> (raw)
In-Reply-To: <309781b5-108f-c219-2cda-49179dca6b13@ozlabs.ru>

On Thu, Jun 20, 2019 at 04:20:08PM +1000, Alexey Kardashevskiy wrote:
> 
> 
> On 20/06/2019 16:03, Christoph Hellwig wrote:
> > Hi Linus,
> > 
> > this goes back to the discussion at last years kernel summit, where
> > we had the discussion on removing code never used by any in-kernel
> > user an no prospects of one.  The IBM folks are unfortunately still
> > dragging their feet on the powerpc side.  Can we revise this discussion?
> > 
> > The use case here is a IBM specific bus for which they only have an
> > out of tree driver that their partner doesn't want to submit for mainline,
> > but keep insisting on keeping the code around (which is also built
> > uncondіtionally for the platform).
> 
> 
> I personally keep insisting on correct commit logs, i.e. not calling
> working code dead and providing actual reasons for the change. Thanks,

If that is the only thing you are complaining about I can clarify it
a little of course.  But it didn't sound like that was the actual
problem.

  reply	other threads:[~2019-06-20  6:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  7:49 remove dead powernv code v2 Christoph Hellwig
2019-05-23  7:49 ` [PATCH 1/4] powerpc/powernv: remove the unused pnv_pci_set_p2p function Christoph Hellwig
2019-05-23  7:49 ` [PATCH 2/4] powerpc/powernv: remove the unused tunneling exports Christoph Hellwig
2019-06-21  1:47   ` Oliver O'Halloran
2019-06-21  1:47     ` Oliver O'Halloran
2019-06-21  9:21     ` Frederic Barrat
2019-06-21  9:21       ` Frederic Barrat
2019-06-21  9:24       ` Christoph Hellwig
2019-06-21  9:24         ` Christoph Hellwig
2019-05-23  7:49 ` [PATCH 3/4] powerpc/powernv: remove dead NPU DMA code Christoph Hellwig
2019-06-19  0:34   ` Alexey Kardashevskiy
2019-06-19  0:34     ` Alexey Kardashevskiy
2019-06-19  7:28     ` Christoph Hellwig
2019-06-19  7:28       ` Christoph Hellwig
2019-06-20  1:45       ` Alexey Kardashevskiy
2019-06-20  1:45         ` Alexey Kardashevskiy
2019-06-20  6:03         ` Christoph Hellwig
2019-06-20  6:03           ` Christoph Hellwig
2019-06-20  6:20           ` Alexey Kardashevskiy
2019-06-20  6:20             ` Alexey Kardashevskiy
2019-06-20  6:21             ` Christoph Hellwig [this message]
2019-06-20  6:21               ` Christoph Hellwig
2019-06-20  6:48               ` Alexey Kardashevskiy
2019-06-20  6:48                 ` Alexey Kardashevskiy
2019-05-23  7:49 ` [PATCH 4/4] powerpc/powernv: remove the unused vas_win_paste_addr and vas_win_id functions Christoph Hellwig
2019-06-21  1:40   ` Oliver O'Halloran
2019-06-21  1:40     ` Oliver O'Halloran
2019-06-17  6:46 ` remove dead powernv code v2 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620062126.GA20765@lst.de \
    --to=hch@lst.de \
    --cc=aik@ozlabs.ru \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.