[igt-dev] [PATCH i-g-t] Add Arm drivers as supported drivers by igt.

[igt-dev] [PATCH i-g-t] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

Add the drivers maintained by Arm developers to the igt.

Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
 lib/drmtest.c | 3 +++
 lib/drmtest.h | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 25f203530..17e1ce8fd 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -211,6 +211,9 @@ static const struct module {
 	{ DRIVER_VC4, "vc4" },
 	{ DRIVER_VGEM, "vgem" },
 	{ DRIVER_VIRTIO, "virtio_gpu", modprobe_virtio },
+	{ DRIVER_HDLCD, "hdlcd" },
+	{ DRIVER_MALIDP, "mali_dp" },
+	{ DRIVER_KOMEDA, "komeda" },
 	{}
 };
 
diff --git a/lib/drmtest.h b/lib/drmtest.h
index 6c4c3899c..952f0c4b6 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -45,6 +45,10 @@
 #define DRIVER_AMDGPU	(1 << 4)
 #define DRIVER_V3D	(1 << 5)
 #define DRIVER_PANFROST	(1 << 6)
+#define DRIVER_HDLCD	(1 << 7)
+#define DRIVER_MALIDP	(1 << 8)
+#define DRIVER_KOMEDA	(1 << 9)
+
 /*
  * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
  * with vgem as well as a supported driver, you can end up with a
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for Add Arm drivers as supported drivers by igt.

[Patchwork]

== Series Details ==

Series: Add Arm drivers as supported drivers by igt.
URL   : https://patchwork.freedesktop.org/series/62227/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6286 -> IGTPW_3164
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3164 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3164, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62227/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3164:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_evict:
    - fi-skl-guc:         NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-skl-guc/igt@i915_selftest@live_evict.html
    - fi-skl-iommu:       NOTRUN -> [INCOMPLETE][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-skl-iommu/igt@i915_selftest@live_evict.html
    - fi-whl-u:           NOTRUN -> [INCOMPLETE][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-whl-u/igt@i915_selftest@live_evict.html

  * igt@runner@aborted:
    - fi-whl-u:           NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-whl-u/igt@runner@aborted.html
    - fi-cml-u2:          NOTRUN -> [FAIL][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-cml-u2/igt@runner@aborted.html
    - fi-cml-u:           NOTRUN -> [FAIL][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-cml-u/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in IGTPW_3164 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_hangcheck:
    - fi-icl-u2:          [PASS][7] -> [DMESG-FAIL][8] ([fdo#110429])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
    - fi-icl-dsi:         [PASS][9] -> [INCOMPLETE][10] ([fdo#107713] / [fdo#108569])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html

  
#### Possible fixes ####

  * igt@gem_ctx_switch@basic-default:
    - fi-icl-guc:         [INCOMPLETE][11] ([fdo#107713] / [fdo#108569]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-icl-guc/igt@gem_ctx_switch@basic-default.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
    - fi-icl-u2:          [FAIL][15] ([fdo#103167]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-ilk-650:         [DMESG-WARN][17] ([fdo#106387]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#110429]: https://bugs.freedesktop.org/show_bug.cgi?id=110429


Participating hosts (46 -> 44)
------------------------------

  Additional (6): fi-cml-u2 fi-skl-guc fi-whl-u fi-skl-iommu fi-pnv-d510 fi-cml-u 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-x1275 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5059 -> IGTPW_3164

  CI_DRM_6286: 4853198e8f13330c123082ef1f0759d476ca62d8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3164: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3164/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] Add Arm drivers as supported drivers by igt.

[Petri Latvala]

On Mon, Jun 17, 2019 at 04:18:41PM +0100, Liviu Dudau wrote:
> Add the drivers maintained by Arm developers to the igt.
> 
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
>  lib/drmtest.c | 3 +++
>  lib/drmtest.h | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 25f203530..17e1ce8fd 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -211,6 +211,9 @@ static const struct module {
>  	{ DRIVER_VC4, "vc4" },
>  	{ DRIVER_VGEM, "vgem" },
>  	{ DRIVER_VIRTIO, "virtio_gpu", modprobe_virtio },
> +	{ DRIVER_HDLCD, "hdlcd" },
> +	{ DRIVER_MALIDP, "mali_dp" },
> +	{ DRIVER_KOMEDA, "komeda" },
>  	{}

This array needs to be alphabetically sorted, binary search is used for it.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

Add the drivers maintained by Arm developers to the igt.

v2: Order the modules array entries alphabetically, as per
Petri Latvala's suggestion.

Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
 lib/drmtest.c | 3 +++
 lib/drmtest.h | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 25f203530..17bb87d1f 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -205,7 +205,10 @@ static const struct module {
 	void (*modprobe)(const char *name);
 } modules[] = {
 	{ DRIVER_AMDGPU, "amdgpu" },
+	{ DRIVER_HDLCD, "hdlcd" },
 	{ DRIVER_INTEL, "i915", modprobe_i915 },
+	{ DRIVER_KOMEDA, "komeda" },
+	{ DRIVER_MALIDP, "mali_dp" },
 	{ DRIVER_PANFROST, "panfrost" },
 	{ DRIVER_V3D, "v3d" },
 	{ DRIVER_VC4, "vc4" },
diff --git a/lib/drmtest.h b/lib/drmtest.h
index 6c4c3899c..952f0c4b6 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -45,6 +45,10 @@
 #define DRIVER_AMDGPU	(1 << 4)
 #define DRIVER_V3D	(1 << 5)
 #define DRIVER_PANFROST	(1 << 6)
+#define DRIVER_HDLCD	(1 << 7)
+#define DRIVER_MALIDP	(1 << 8)
+#define DRIVER_KOMEDA	(1 << 9)
+
 /*
  * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
  * with vgem as well as a supported driver, you can end up with a
-- 
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Add Arm drivers as supported drivers by igt. (rev2)

[Patchwork]

== Series Details ==

Series: Add Arm drivers as supported drivers by igt. (rev2)
URL   : https://patchwork.freedesktop.org/series/62227/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6308 -> IGTPW_3177
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62227/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3177 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_create@basic-files:
    - fi-icl-u3:          [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-icl-u3/igt@gem_ctx_create@basic-files.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-icl-u3/igt@gem_ctx_create@basic-files.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [PASS][5] -> [DMESG-FAIL][6] ([fdo#110235])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@i915_selftest@live_evict:
    - fi-kbl-8809g:       [PASS][7] -> [INCOMPLETE][8] ([fdo#110938])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-kbl-8809g/igt@i915_selftest@live_evict.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-kbl-8809g/igt@i915_selftest@live_evict.html
    - fi-kbl-guc:         [PASS][9] -> [INCOMPLETE][10] ([fdo#110938])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-kbl-guc/igt@i915_selftest@live_evict.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-kbl-guc/igt@i915_selftest@live_evict.html

  
#### Possible fixes ####

  * igt@gem_sync@basic-store-each:
    - fi-skl-6770hq:      [FAIL][11] ([fdo#110946]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/fi-skl-6770hq/igt@gem_sync@basic-store-each.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/fi-skl-6770hq/igt@gem_sync@basic-store-each.html

  
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
  [fdo#110938]: https://bugs.freedesktop.org/show_bug.cgi?id=110938
  [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946


Participating hosts (49 -> 45)
------------------------------

  Additional (4): fi-skl-guc fi-byt-n2820 fi-icl-guc fi-pnv-d510 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5061 -> IGTPW_3177

  CI_DRM_6308: 73f0a22ad1085881cf50f7866ddf885bf6229b9b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3177: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/
  IGT_5061: c88ced79a7b71aec58f1d9c5c599ac2f431bcf7a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Petri Latvala]

On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> Add the drivers maintained by Arm developers to the igt.
> 
> v2: Order the modules array entries alphabetically, as per
> Petri Latvala's suggestion.
> 
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
>  lib/drmtest.c | 3 +++
>  lib/drmtest.h | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 25f203530..17bb87d1f 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -205,7 +205,10 @@ static const struct module {
>  	void (*modprobe)(const char *name);
>  } modules[] = {
>  	{ DRIVER_AMDGPU, "amdgpu" },
> +	{ DRIVER_HDLCD, "hdlcd" },
>  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> +	{ DRIVER_KOMEDA, "komeda" },
> +	{ DRIVER_MALIDP, "mali_dp" },


Should this be "mali-dp" instead?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

On Thu, Jun 20, 2019 at 11:00:24AM +0300, Petri Latvala wrote:
> On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > Add the drivers maintained by Arm developers to the igt.
> > 
> > v2: Order the modules array entries alphabetically, as per
> > Petri Latvala's suggestion.
> > 
> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > ---
> >  lib/drmtest.c | 3 +++
> >  lib/drmtest.h | 4 ++++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > index 25f203530..17bb87d1f 100644
> > --- a/lib/drmtest.c
> > +++ b/lib/drmtest.c
> > @@ -205,7 +205,10 @@ static const struct module {
> >  	void (*modprobe)(const char *name);
> >  } modules[] = {
> >  	{ DRIVER_AMDGPU, "amdgpu" },
> > +	{ DRIVER_HDLCD, "hdlcd" },
> >  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> > +	{ DRIVER_KOMEDA, "komeda" },
> > +	{ DRIVER_MALIDP, "mali_dp" },
> 

Hi Petri,

> 
> Should this be "mali-dp" instead?
>

insmod/modprobe places some equivalence between dashes and underscores. The
platform driver structure in the kernel is called "mali-dp", but the module
is called "mali_dp" (confusing, I know, but at least that is what lsmod shows
after inserting "mali-dp" module).

Not sure what the correct answer is here, I thought we're using module names.

Best regards,
Liviu

> 
> 
> -- 
> Petri Latvala

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Add Arm drivers as supported drivers by igt. (rev2)

[Patchwork]

== Series Details ==

Series: Add Arm drivers as supported drivers by igt. (rev2)
URL   : https://patchwork.freedesktop.org/series/62227/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6308_full -> IGTPW_3177_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62227/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3177_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@wait-wedge-10ms:
    - shard-kbl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl1/igt@gem_eio@wait-wedge-10ms.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl6/igt@gem_eio@wait-wedge-10ms.html

  * igt@gem_exec_schedule@smoketest-all:
    - shard-glk:          [PASS][3] -> [FAIL][4] ([fdo#110946])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-glk1/igt@gem_exec_schedule@smoketest-all.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-glk2/igt@gem_exec_schedule@smoketest-all.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-apl2/igt@gem_userptr_blits@sync-unmap-cycles.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-apl2/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +4 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-apl3/igt@gem_workarounds@suspend-resume.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-apl1/igt@gem_workarounds@suspend-resume.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-snb:          [PASS][11] -> [SKIP][12] ([fdo#109271]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-snb4/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-snb4/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#102887])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-modeset-vs-hang-interruptible:
    - shard-snb:          [PASS][15] -> [DMESG-WARN][16] ([fdo#110789] / [fdo#110913 ])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-snb6/igt@kms_flip@flip-vs-modeset-vs-hang-interruptible.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-snb1/igt@kms_flip@flip-vs-modeset-vs-hang-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-glk:          [PASS][17] -> [INCOMPLETE][18] ([fdo#103359] / [k.org#198133])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-glk1/igt@kms_flip@flip-vs-suspend-interruptible.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-glk3/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][19] -> [FAIL][20] ([fdo#99912])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl6/igt@kms_setmode@basic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl7/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_ctx_shared@exec-shared-gtt-bsd:
    - shard-glk:          [FAIL][21] -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-glk4/igt@gem_ctx_shared@exec-shared-gtt-bsd.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-glk3/igt@gem_ctx_shared@exec-shared-gtt-bsd.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-snb:          [DMESG-WARN][23] ([fdo#110789] / [fdo#110913 ]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-kbl:          [DMESG-WARN][25] ([fdo#108686]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl4/igt@gem_tiled_swapping@non-threaded.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl1/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-apl:          [DMESG-WARN][27] ([fdo#110913 ]) -> [PASS][28] +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-apl7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-apl8/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
    - shard-snb:          [DMESG-WARN][29] ([fdo#110913 ]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-kbl:          [DMESG-WARN][31] ([fdo#110913 ]) -> [PASS][32] +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl7/igt@gem_userptr_blits@sync-unmap-cycles.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl7/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_suspend@sysfs-reader:
    - shard-kbl:          [INCOMPLETE][33] ([fdo#103665] / [fdo#108767]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl4/igt@i915_suspend@sysfs-reader.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl7/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [SKIP][35] ([fdo#109271]) -> [PASS][36] +15 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-hsw1/igt@kms_flip@2x-plain-flip.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-hsw6/igt@kms_flip@2x-plain-flip.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-kbl:          [INCOMPLETE][37] ([fdo#103665]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-apl:          [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40] +3 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6308/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (8 -> 5)
------------------------------

  Missing    (3): shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5061 -> IGTPW_3177
  * Piglit: piglit_4509 -> None

  CI_DRM_6308: 73f0a22ad1085881cf50f7866ddf885bf6229b9b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3177: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/
  IGT_5061: c88ced79a7b71aec58f1d9c5c599ac2f431bcf7a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3177/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Petri Latvala]

On Thu, Jun 20, 2019 at 10:28:42AM +0100, Liviu Dudau wrote:
> On Thu, Jun 20, 2019 at 11:00:24AM +0300, Petri Latvala wrote:
> > On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > > Add the drivers maintained by Arm developers to the igt.
> > > 
> > > v2: Order the modules array entries alphabetically, as per
> > > Petri Latvala's suggestion.
> > > 
> > > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > > ---
> > >  lib/drmtest.c | 3 +++
> > >  lib/drmtest.h | 4 ++++
> > >  2 files changed, 7 insertions(+)
> > > 
> > > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > > index 25f203530..17bb87d1f 100644
> > > --- a/lib/drmtest.c
> > > +++ b/lib/drmtest.c
> > > @@ -205,7 +205,10 @@ static const struct module {
> > >  	void (*modprobe)(const char *name);
> > >  } modules[] = {
> > >  	{ DRIVER_AMDGPU, "amdgpu" },
> > > +	{ DRIVER_HDLCD, "hdlcd" },
> > >  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> > > +	{ DRIVER_KOMEDA, "komeda" },
> > > +	{ DRIVER_MALIDP, "mali_dp" },
> > 
> 
> Hi Petri,
> 
> > 
> > Should this be "mali-dp" instead?
> >
> 
> insmod/modprobe places some equivalence between dashes and underscores. The
> platform driver structure in the kernel is called "mali-dp", but the module
> is called "mali_dp" (confusing, I know, but at least that is what lsmod shows
> after inserting "mali-dp" module).
> 
> Not sure what the correct answer is here, I thought we're using module names.


It's both :P

The string is compared to the driver_name field (or what was the name)
to see if the device is DRIVER_MALIDP, and if the function pointer is
not set, the string is also used for modprobe().

So the string should be the device's driver_name, and the function
pointer set to a function that loads the .ko if the module name is
different.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Daniel Vetter]

On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> Add the drivers maintained by Arm developers to the igt.
> 
> v2: Order the modules array entries alphabetically, as per
> Petri Latvala's suggestion.
> 
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>

Still kinda wondering why you need this here ... kms is supposed to be
hw/driver agnostic, so DRIVER_ANY should work.

Maybe you want to check specific constraints in your tests, but then we
need something like igt_require(is_komeda_driver(fd)); which can inspect
what you're actually running on when the test executes.

The drivers in this list thus far are all about exercising the gem side of
things, where you _really_ don't want to open random garbage. Because the
ioctls aren't even defined.

On kms all ioctls are cross-driver, and only once you've opened something
does it make sense to check for features and stuff (looking at properties,
or getcap flags, or whatever).

Cheers, Daniel

PS: Yes I know that some of the DRIVER_I915 | DRIVER_AMDGPU tests really
should have been converted to DRIVER_ANY instead. I didn't catch that in
review way back, but I think I explained to Harry et al meanwhile ...

> ---
>  lib/drmtest.c | 3 +++
>  lib/drmtest.h | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 25f203530..17bb87d1f 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -205,7 +205,10 @@ static const struct module {
>  	void (*modprobe)(const char *name);
>  } modules[] = {
>  	{ DRIVER_AMDGPU, "amdgpu" },
> +	{ DRIVER_HDLCD, "hdlcd" },
>  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> +	{ DRIVER_KOMEDA, "komeda" },
> +	{ DRIVER_MALIDP, "mali_dp" },
>  	{ DRIVER_PANFROST, "panfrost" },
>  	{ DRIVER_V3D, "v3d" },
>  	{ DRIVER_VC4, "vc4" },
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 6c4c3899c..952f0c4b6 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -45,6 +45,10 @@
>  #define DRIVER_AMDGPU	(1 << 4)
>  #define DRIVER_V3D	(1 << 5)
>  #define DRIVER_PANFROST	(1 << 6)
> +#define DRIVER_HDLCD	(1 << 7)
> +#define DRIVER_MALIDP	(1 << 8)
> +#define DRIVER_KOMEDA	(1 << 9)
> +
>  /*
>   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
>   * with vgem as well as a supported driver, you can end up with a
> -- 
> 2.22.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

On Thu, Jun 20, 2019 at 01:50:21PM +0300, Petri Latvala wrote:
> On Thu, Jun 20, 2019 at 10:28:42AM +0100, Liviu Dudau wrote:
> > On Thu, Jun 20, 2019 at 11:00:24AM +0300, Petri Latvala wrote:
> > > On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > > > Add the drivers maintained by Arm developers to the igt.
> > > > 
> > > > v2: Order the modules array entries alphabetically, as per
> > > > Petri Latvala's suggestion.
> > > > 
> > > > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > > > ---
> > > >  lib/drmtest.c | 3 +++
> > > >  lib/drmtest.h | 4 ++++
> > > >  2 files changed, 7 insertions(+)
> > > > 
> > > > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > > > index 25f203530..17bb87d1f 100644
> > > > --- a/lib/drmtest.c
> > > > +++ b/lib/drmtest.c
> > > > @@ -205,7 +205,10 @@ static const struct module {
> > > >  	void (*modprobe)(const char *name);
> > > >  } modules[] = {
> > > >  	{ DRIVER_AMDGPU, "amdgpu" },
> > > > +	{ DRIVER_HDLCD, "hdlcd" },
> > > >  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> > > > +	{ DRIVER_KOMEDA, "komeda" },
> > > > +	{ DRIVER_MALIDP, "mali_dp" },
> > > 
> > 
> > Hi Petri,
> > 
> > > 
> > > Should this be "mali-dp" instead?
> > >
> > 
> > insmod/modprobe places some equivalence between dashes and underscores. The
> > platform driver structure in the kernel is called "mali-dp", but the module
> > is called "mali_dp" (confusing, I know, but at least that is what lsmod shows
> > after inserting "mali-dp" module).
> > 
> > Not sure what the correct answer is here, I thought we're using module names.
> 
> 
> It's both :P
> 
> The string is compared to the driver_name field (or what was the name)
> to see if the device is DRIVER_MALIDP, and if the function pointer is
> not set, the string is also used for modprobe().
> 
> So the string should be the device's driver_name, and the function
> pointer set to a function that loads the .ko if the module name is
> different.

Went back to the list of modules and (cough) the module is called mali-dp.ko.
No idea why lsmod shows it as mali_dp :(

I'm sending v3 now with the fix, thank you for reporting it!

Best regards,
Liviu

> 
> 
> -- 
> Petri Latvala

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

On Thu, Jun 20, 2019 at 02:36:32PM +0200, Daniel Vetter wrote:
> On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > Add the drivers maintained by Arm developers to the igt.
> > 
> > v2: Order the modules array entries alphabetically, as per
> > Petri Latvala's suggestion.
> > 
> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> 
> Still kinda wondering why you need this here ... kms is supposed to be
> hw/driver agnostic, so DRIVER_ANY should work.

I'm looking at adding writeback scaling tests that not all drivers are going to
support from the start, so I thought it is better to have a more specific
driver that I can target, even if the DRM APIs are generic.

Best regards,
Liviu

> 
> Maybe you want to check specific constraints in your tests, but then we
> need something like igt_require(is_komeda_driver(fd)); which can inspect
> what you're actually running on when the test executes.
> 
> The drivers in this list thus far are all about exercising the gem side of
> things, where you _really_ don't want to open random garbage. Because the
> ioctls aren't even defined.
> 
> On kms all ioctls are cross-driver, and only once you've opened something
> does it make sense to check for features and stuff (looking at properties,
> or getcap flags, or whatever).
> 
> Cheers, Daniel
> 
> PS: Yes I know that some of the DRIVER_I915 | DRIVER_AMDGPU tests really
> should have been converted to DRIVER_ANY instead. I didn't catch that in
> review way back, but I think I explained to Harry et al meanwhile ...
> 
> > ---
> >  lib/drmtest.c | 3 +++
> >  lib/drmtest.h | 4 ++++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > index 25f203530..17bb87d1f 100644
> > --- a/lib/drmtest.c
> > +++ b/lib/drmtest.c
> > @@ -205,7 +205,10 @@ static const struct module {
> >  	void (*modprobe)(const char *name);
> >  } modules[] = {
> >  	{ DRIVER_AMDGPU, "amdgpu" },
> > +	{ DRIVER_HDLCD, "hdlcd" },
> >  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> > +	{ DRIVER_KOMEDA, "komeda" },
> > +	{ DRIVER_MALIDP, "mali_dp" },
> >  	{ DRIVER_PANFROST, "panfrost" },
> >  	{ DRIVER_V3D, "v3d" },
> >  	{ DRIVER_VC4, "vc4" },
> > diff --git a/lib/drmtest.h b/lib/drmtest.h
> > index 6c4c3899c..952f0c4b6 100644
> > --- a/lib/drmtest.h
> > +++ b/lib/drmtest.h
> > @@ -45,6 +45,10 @@
> >  #define DRIVER_AMDGPU	(1 << 4)
> >  #define DRIVER_V3D	(1 << 5)
> >  #define DRIVER_PANFROST	(1 << 6)
> > +#define DRIVER_HDLCD	(1 << 7)
> > +#define DRIVER_MALIDP	(1 << 8)
> > +#define DRIVER_KOMEDA	(1 << 9)
> > +
> >  /*
> >   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
> >   * with vgem as well as a supported driver, you can end up with a
> > -- 
> > 2.22.0
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v3] Add Arm drivers as supported drivers by igt.

[Liviu Dudau]

Add the drivers maintained by Arm developers to the igt.

v3: Update the mali-dp driver's name to match kernel driver code.
v2: Order the modules array entries alphabetically, as per
    Petri Latvala's suggestion.

Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
 lib/drmtest.c | 3 +++
 lib/drmtest.h | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 25f203530..8243247a3 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -205,7 +205,10 @@ static const struct module {
 	void (*modprobe)(const char *name);
 } modules[] = {
 	{ DRIVER_AMDGPU, "amdgpu" },
+	{ DRIVER_HDLCD, "hdlcd" },
 	{ DRIVER_INTEL, "i915", modprobe_i915 },
+	{ DRIVER_KOMEDA, "komeda" },
+	{ DRIVER_MALIDP, "mali-dp" },
 	{ DRIVER_PANFROST, "panfrost" },
 	{ DRIVER_V3D, "v3d" },
 	{ DRIVER_VC4, "vc4" },
diff --git a/lib/drmtest.h b/lib/drmtest.h
index 6c4c3899c..952f0c4b6 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -45,6 +45,10 @@
 #define DRIVER_AMDGPU	(1 << 4)
 #define DRIVER_V3D	(1 << 5)
 #define DRIVER_PANFROST	(1 << 6)
+#define DRIVER_HDLCD	(1 << 7)
+#define DRIVER_MALIDP	(1 << 8)
+#define DRIVER_KOMEDA	(1 << 9)
+
 /*
  * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
  * with vgem as well as a supported driver, you can end up with a
-- 
2.22.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] Add Arm drivers as supported drivers by igt.

[Petri Latvala]

On Thu, Jun 20, 2019 at 01:42:54PM +0100, Liviu Dudau wrote:
> Add the drivers maintained by Arm developers to the igt.
> 
> v3: Update the mali-dp driver's name to match kernel driver code.
> v2: Order the modules array entries alphabetically, as per
>     Petri Latvala's suggestion.
> 
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>


Reviewed-by: Petri Latvala <petri.latvala@intel.com>


> ---
>  lib/drmtest.c | 3 +++
>  lib/drmtest.h | 4 ++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 25f203530..8243247a3 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -205,7 +205,10 @@ static const struct module {
>  	void (*modprobe)(const char *name);
>  } modules[] = {
>  	{ DRIVER_AMDGPU, "amdgpu" },
> +	{ DRIVER_HDLCD, "hdlcd" },
>  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> +	{ DRIVER_KOMEDA, "komeda" },
> +	{ DRIVER_MALIDP, "mali-dp" },
>  	{ DRIVER_PANFROST, "panfrost" },
>  	{ DRIVER_V3D, "v3d" },
>  	{ DRIVER_VC4, "vc4" },
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 6c4c3899c..952f0c4b6 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -45,6 +45,10 @@
>  #define DRIVER_AMDGPU	(1 << 4)
>  #define DRIVER_V3D	(1 << 5)
>  #define DRIVER_PANFROST	(1 << 6)
> +#define DRIVER_HDLCD	(1 << 7)
> +#define DRIVER_MALIDP	(1 << 8)
> +#define DRIVER_KOMEDA	(1 << 9)
> +
>  /*
>   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
>   * with vgem as well as a supported driver, you can end up with a
> -- 
> 2.22.0
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Daniel Vetter]

On Thu, Jun 20, 2019 at 01:41:21PM +0100, Liviu Dudau wrote:
> On Thu, Jun 20, 2019 at 02:36:32PM +0200, Daniel Vetter wrote:
> > On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > > Add the drivers maintained by Arm developers to the igt.
> > > 
> > > v2: Order the modules array entries alphabetically, as per
> > > Petri Latvala's suggestion.
> > > 
> > > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > 
> > Still kinda wondering why you need this here ... kms is supposed to be
> > hw/driver agnostic, so DRIVER_ANY should work.
> 
> I'm looking at adding writeback scaling tests that not all drivers are going to
> support from the start, so I thought it is better to have a more specific
> driver that I can target, even if the DRM APIs are generic.

Yeah, but for that test I'd still expect you want to open DRIVER_ANY, then
check there's writeback, and then check for scaling (using TEST_ONLY
maybe). At least for some of the more generic ones.

You can always then add even more malidp/komeda specific tests with an
igt_require(is_malid(fd)) on top for some subtests. But imo the basic igt
should be generic, otherwise the entire idea of kms as being something
cross vendor/driver is out of the window.

Hence why I think this is totally the wrong direction here. What might be
good is some helper which gets the drm driver name and compares it to what
you need, i.e. igt_drmtest_require_driver(fd, "malidp");
-Daniel

> 
> Best regards,
> Liviu
> 
> > 
> > Maybe you want to check specific constraints in your tests, but then we
> > need something like igt_require(is_komeda_driver(fd)); which can inspect
> > what you're actually running on when the test executes.
> > 
> > The drivers in this list thus far are all about exercising the gem side of
> > things, where you _really_ don't want to open random garbage. Because the
> > ioctls aren't even defined.
> > 
> > On kms all ioctls are cross-driver, and only once you've opened something
> > does it make sense to check for features and stuff (looking at properties,
> > or getcap flags, or whatever).
> > 
> > Cheers, Daniel
> > 
> > PS: Yes I know that some of the DRIVER_I915 | DRIVER_AMDGPU tests really
> > should have been converted to DRIVER_ANY instead. I didn't catch that in
> > review way back, but I think I explained to Harry et al meanwhile ...
> > 
> > > ---
> > >  lib/drmtest.c | 3 +++
> > >  lib/drmtest.h | 4 ++++
> > >  2 files changed, 7 insertions(+)
> > > 
> > > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > > index 25f203530..17bb87d1f 100644
> > > --- a/lib/drmtest.c
> > > +++ b/lib/drmtest.c
> > > @@ -205,7 +205,10 @@ static const struct module {
> > >  	void (*modprobe)(const char *name);
> > >  } modules[] = {
> > >  	{ DRIVER_AMDGPU, "amdgpu" },
> > > +	{ DRIVER_HDLCD, "hdlcd" },
> > >  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> > > +	{ DRIVER_KOMEDA, "komeda" },
> > > +	{ DRIVER_MALIDP, "mali_dp" },
> > >  	{ DRIVER_PANFROST, "panfrost" },
> > >  	{ DRIVER_V3D, "v3d" },
> > >  	{ DRIVER_VC4, "vc4" },
> > > diff --git a/lib/drmtest.h b/lib/drmtest.h
> > > index 6c4c3899c..952f0c4b6 100644
> > > --- a/lib/drmtest.h
> > > +++ b/lib/drmtest.h
> > > @@ -45,6 +45,10 @@
> > >  #define DRIVER_AMDGPU	(1 << 4)
> > >  #define DRIVER_V3D	(1 << 5)
> > >  #define DRIVER_PANFROST	(1 << 6)
> > > +#define DRIVER_HDLCD	(1 << 7)
> > > +#define DRIVER_MALIDP	(1 << 8)
> > > +#define DRIVER_KOMEDA	(1 << 9)
> > > +
> > >  /*
> > >   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
> > >   * with vgem as well as a supported driver, you can end up with a
> > > -- 
> > > 2.22.0
> > > 
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> > 
> > -- 
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> 
> -- 
> ====================
> | I would like to |
> | fix the world,  |
> | but they're not |
> | giving me the   |
>  \ source code!  /
>   ---------------
>     ¯\_(ツ)_/¯

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Add Arm drivers as supported drivers by igt. (rev3)

[Patchwork]

== Series Details ==

Series: Add Arm drivers as supported drivers by igt. (rev3)
URL   : https://patchwork.freedesktop.org/series/62227/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6314 -> IGTPW_3182
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_3182 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3182, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62227/revisions/3/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3182:

### IGT changes ###

#### Warnings ####

  * igt@i915_selftest@live_contexts:
    - fi-bdw-gvtdvm:      [DMESG-FAIL][1] ([fdo#110235]) -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html

  
Known issues
------------

  Here are the changes found in IGTPW_3182 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_reloc@basic-cpu-active:
    - fi-byt-j1900:       [PASS][3] -> [INCOMPLETE][4] ([fdo#102657])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-byt-j1900/igt@gem_exec_reloc@basic-cpu-active.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-byt-j1900/igt@gem_exec_reloc@basic-cpu-active.html

  * igt@gem_sync@basic-store-each:
    - fi-skl-6700k2:      [PASS][5] -> [FAIL][6] ([fdo#110946])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-skl-6700k2/igt@gem_sync@basic-store-each.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-skl-6700k2/igt@gem_sync@basic-store-each.html

  * igt@gem_tiled_fence_blits@basic:
    - fi-icl-dsi:         [PASS][7] -> [INCOMPLETE][8] ([fdo#107713])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-icl-dsi/igt@gem_tiled_fence_blits@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-icl-dsi/igt@gem_tiled_fence_blits@basic.html

  * igt@i915_module_load@reload:
    - fi-blb-e6850:       [PASS][9] -> [INCOMPLETE][10] ([fdo#107718])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-blb-e6850/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-blb-e6850/igt@i915_module_load@reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live_contexts:
    - fi-skl-gvtdvm:      [DMESG-FAIL][11] ([fdo#110235]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][13] ([fdo#109485]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       [DMESG-WARN][15] ([fdo#102614]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
    - fi-icl-u2:          [FAIL][17] ([fdo#103167]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
  [fdo#110946]: https://bugs.freedesktop.org/show_bug.cgi?id=110946


Participating hosts (51 -> 45)
------------------------------

  Additional (1): fi-icl-u3 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5064 -> IGTPW_3182

  CI_DRM_6314: 1180972dbd2a00f60a4d707772bd7e7ae6732ed5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3182: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/
  IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Add Arm drivers as supported drivers by igt. (rev3)

[Patchwork]

== Series Details ==

Series: Add Arm drivers as supported drivers by igt. (rev3)
URL   : https://patchwork.freedesktop.org/series/62227/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6314_full -> IGTPW_3182_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/62227/revisions/3/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3182_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +4 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-iclb:         [PASS][3] -> [FAIL][4] ([fdo#108686])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb7/igt@gem_tiled_swapping@non-threaded.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb5/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-kbl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-apl7/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-kbl:          [PASS][11] -> [INCOMPLETE][12] ([fdo#103665])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl1/igt@i915_suspend@fence-restore-untiled.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl3/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#106509] / [fdo#107409])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk3/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-glk2/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible:
    - shard-iclb:         [PASS][15] -> [INCOMPLETE][16] ([fdo#107713]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb7/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb7/igt@kms_flip@plain-flip-fb-recreate-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-rte:
    - shard-hsw:          [PASS][17] -> [SKIP][18] ([fdo#109271]) +18 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-rte.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
    - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103167]) +4 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109642])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb1/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [PASS][23] -> [SKIP][24] ([fdo#109441]) +3 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@perf@blocking:
    - shard-hsw:          [PASS][25] -> [INCOMPLETE][26] ([fdo#103540])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw4/igt@perf@blocking.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw8/igt@perf@blocking.html

  * igt@perf_pmu@rc6:
    - shard-kbl:          [PASS][27] -> [SKIP][28] ([fdo#109271])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl4/igt@perf_pmu@rc6.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl2/igt@perf_pmu@rc6.html

  * igt@syncobj_wait@invalid-signal-zero-handles:
    - shard-glk:          [PASS][29] -> [INCOMPLETE][30] ([fdo#103359] / [k.org#198133])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk8/igt@syncobj_wait@invalid-signal-zero-handles.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-glk7/igt@syncobj_wait@invalid-signal-zero-handles.html

  
#### Possible fixes ####

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][31] ([fdo#110854]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb3/igt@gem_exec_balancer@smoke.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb2/igt@gem_exec_balancer@smoke.html

  * igt@gem_persistent_relocs@forked-interruptible-thrashing:
    - shard-snb:          [DMESG-WARN][33] ([fdo#110789] / [fdo#110913 ]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-apl:          [DMESG-WARN][35] ([fdo#110913 ]) -> [PASS][36] +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-apl4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-kbl:          [DMESG-WARN][37] ([fdo#110913 ]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl3/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40] +2 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-apl3/igt@gem_workarounds@suspend-resume.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-apl8/igt@gem_workarounds@suspend-resume.html

  * igt@i915_pm_rpm@i2c:
    - shard-hsw:          [FAIL][41] ([fdo#104097]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw4/igt@i915_pm_rpm@i2c.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw5/igt@i915_pm_rpm@i2c.html

  * igt@i915_pm_rpm@system-suspend:
    - shard-kbl:          [INCOMPLETE][43] ([fdo#103665] / [fdo#107807]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl3/igt@i915_pm_rpm@system-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl7/igt@i915_pm_rpm@system-suspend.html

  * igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait:
    - shard-snb:          [SKIP][45] ([fdo#109271]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-snb1/igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait.html

  * igt@kms_busy@extended-modeset-hang-newfb-render-a:
    - shard-snb:          [SKIP][47] ([fdo#109271] / [fdo#109278]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-snb2/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-snb1/igt@kms_busy@extended-modeset-hang-newfb-render-a.html

  * igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
    - shard-hsw:          [FAIL][49] ([fdo#103355]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-varying-size.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-hsw:          [SKIP][51] ([fdo#109271]) -> [PASS][52] +19 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-glk:          [INCOMPLETE][53] ([fdo#103359] / [k.org#198133]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk7/igt@kms_flip@flip-vs-suspend.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-glk8/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
    - shard-glk:          [FAIL][55] ([fdo#103167]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
    - shard-iclb:         [FAIL][57] ([fdo#103167]) -> [PASS][58] +4 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][59] ([fdo#103166]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][61] ([fdo#109441]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][63] ([fdo#99912]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-kbl2/igt@kms_setmode@basic.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-kbl2/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-hsw:          [FAIL][65] ([fdo#100047]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-hsw1/igt@kms_sysfs_edid_timing.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-hsw7/igt@kms_sysfs_edid_timing.html

  
#### Warnings ####

  * igt@i915_pm_rps@min-max-config-loaded:
    - shard-iclb:         [INCOMPLETE][67] ([fdo#107713]) -> [FAIL][68] ([fdo#108059])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6314/shard-iclb7/igt@i915_pm_rps@min-max-config-loaded.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/shard-iclb2/igt@i915_pm_rps@min-max-config-loaded.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
  [fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_5064 -> IGTPW_3182
  * Piglit: piglit_4509 -> None

  CI_DRM_6314: 1180972dbd2a00f60a4d707772bd7e7ae6732ed5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3182: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/
  IGT_5064: 22850c1906550fb97b405c019275dcfb34be8cf7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3182/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] Add Arm drivers as supported drivers by igt.

[Daniel Vetter]

On Thu, Jun 20, 2019 at 3:12 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Thu, Jun 20, 2019 at 01:41:21PM +0100, Liviu Dudau wrote:
> > On Thu, Jun 20, 2019 at 02:36:32PM +0200, Daniel Vetter wrote:
> > > On Wed, Jun 19, 2019 at 04:13:58PM +0100, Liviu Dudau wrote:
> > > > Add the drivers maintained by Arm developers to the igt.
> > > >
> > > > v2: Order the modules array entries alphabetically, as per
> > > > Petri Latvala's suggestion.
> > > >
> > > > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > >
> > > Still kinda wondering why you need this here ... kms is supposed to be
> > > hw/driver agnostic, so DRIVER_ANY should work.
> >
> > I'm looking at adding writeback scaling tests that not all drivers are going to
> > support from the start, so I thought it is better to have a more specific
> > driver that I can target, even if the DRM APIs are generic.
>
> Yeah, but for that test I'd still expect you want to open DRIVER_ANY, then
> check there's writeback, and then check for scaling (using TEST_ONLY
> maybe). At least for some of the more generic ones.
>
> You can always then add even more malidp/komeda specific tests with an
> igt_require(is_malid(fd)) on top for some subtests. But imo the basic igt
> should be generic, otherwise the entire idea of kms as being something
> cross vendor/driver is out of the window.
>
> Hence why I think this is totally the wrong direction here. What might be
> good is some helper which gets the drm driver name and compares it to what
> you need, i.e. igt_drmtest_require_driver(fd, "malidp");

btw last autumn I've dropped the same review onto the vmwgfx folks,
and they adjusted their patches. I really do want igt to be
cross-vendor for kms, but we won't get there if we just keep piling up
vendor-only tests ...
-Daniel

> -Daniel
>
> >
> > Best regards,
> > Liviu
> >
> > >
> > > Maybe you want to check specific constraints in your tests, but then we
> > > need something like igt_require(is_komeda_driver(fd)); which can inspect
> > > what you're actually running on when the test executes.
> > >
> > > The drivers in this list thus far are all about exercising the gem side of
> > > things, where you _really_ don't want to open random garbage. Because the
> > > ioctls aren't even defined.
> > >
> > > On kms all ioctls are cross-driver, and only once you've opened something
> > > does it make sense to check for features and stuff (looking at properties,
> > > or getcap flags, or whatever).
> > >
> > > Cheers, Daniel
> > >
> > > PS: Yes I know that some of the DRIVER_I915 | DRIVER_AMDGPU tests really
> > > should have been converted to DRIVER_ANY instead. I didn't catch that in
> > > review way back, but I think I explained to Harry et al meanwhile ...
> > >
> > > > ---
> > > >  lib/drmtest.c | 3 +++
> > > >  lib/drmtest.h | 4 ++++
> > > >  2 files changed, 7 insertions(+)
> > > >
> > > > diff --git a/lib/drmtest.c b/lib/drmtest.c
> > > > index 25f203530..17bb87d1f 100644
> > > > --- a/lib/drmtest.c
> > > > +++ b/lib/drmtest.c
> > > > @@ -205,7 +205,10 @@ static const struct module {
> > > >   void (*modprobe)(const char *name);
> > > >  } modules[] = {
> > > >   { DRIVER_AMDGPU, "amdgpu" },
> > > > + { DRIVER_HDLCD, "hdlcd" },
> > > >   { DRIVER_INTEL, "i915", modprobe_i915 },
> > > > + { DRIVER_KOMEDA, "komeda" },
> > > > + { DRIVER_MALIDP, "mali_dp" },
> > > >   { DRIVER_PANFROST, "panfrost" },
> > > >   { DRIVER_V3D, "v3d" },
> > > >   { DRIVER_VC4, "vc4" },
> > > > diff --git a/lib/drmtest.h b/lib/drmtest.h
> > > > index 6c4c3899c..952f0c4b6 100644
> > > > --- a/lib/drmtest.h
> > > > +++ b/lib/drmtest.h
> > > > @@ -45,6 +45,10 @@
> > > >  #define DRIVER_AMDGPU    (1 << 4)
> > > >  #define DRIVER_V3D       (1 << 5)
> > > >  #define DRIVER_PANFROST  (1 << 6)
> > > > +#define DRIVER_HDLCD     (1 << 7)
> > > > +#define DRIVER_MALIDP    (1 << 8)
> > > > +#define DRIVER_KOMEDA    (1 << 9)
> > > > +
> > > >  /*
> > > >   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
> > > >   * with vgem as well as a supported driver, you can end up with a
> > > > --
> > > > 2.22.0
> > > >
> > > > _______________________________________________
> > > > igt-dev mailing list
> > > > igt-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation
> > > http://blog.ffwll.ch
> >
> > --
> > ====================
> > | I would like to |
> > | fix the world,  |
> > | but they're not |
> > | giving me the   |
> >  \ source code!  /
> >   ---------------
> >     ¯\_(ツ)_/¯
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev