* [PATCH] nvme-fc: clean up error messages
@ 2019-06-21 21:19 Ewan D. Milne
2019-06-22 0:38 ` Minwoo Im
0 siblings, 1 reply; 2+ messages in thread
From: Ewan D. Milne @ 2019-06-21 21:19 UTC (permalink / raw)
Some of the error messages are inconsistent, and one of them is wrong
(i.e. "queue_size 128 > ctrl maxcmd 32, reducing to queue_size").
Make them more clear and distinguishable for log analysis.
Signed-off-by: Ewan D. Milne <emilne at redhat.com>
---
drivers/nvme/host/fc.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 9b497d785ed7..5da2bef0b193 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -1259,7 +1259,7 @@ nvme_fc_connect_admin_queue(struct nvme_fc_ctrl *ctrl,
if (fcret) {
ret = -EBADF;
dev_err(ctrl->dev,
- "q %d connect failed: %s\n",
+ "queue %d connect admin queue failed: %s\n",
queue->qnum, validation_errors[fcret]);
} else {
ctrl->association_id =
@@ -1358,7 +1358,7 @@ nvme_fc_connect_queue(struct nvme_fc_ctrl *ctrl, struct nvme_fc_queue *queue,
if (fcret) {
ret = -EBADF;
dev_err(ctrl->dev,
- "q %d connect failed: %s\n",
+ "queue %d connect failed: %s\n",
queue->qnum, validation_errors[fcret]);
} else {
queue->connection_id =
@@ -1371,7 +1371,7 @@ nvme_fc_connect_queue(struct nvme_fc_ctrl *ctrl, struct nvme_fc_queue *queue,
out_no_memory:
if (ret)
dev_err(ctrl->dev,
- "queue %d connect command failed (%d).\n",
+ "queue %d connect failed (%d).\n",
queue->qnum, ret);
return ret;
}
@@ -2678,16 +2678,18 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
/* warn if maxcmd is lower than queue_size */
dev_warn(ctrl->ctrl.device,
"queue_size %zu > ctrl maxcmd %u, reducing "
- "to queue_size\n",
- opts->queue_size, ctrl->ctrl.maxcmd);
+ "queue_size to %u\n",
+ opts->queue_size, ctrl->ctrl.maxcmd, ctrl->ctrl.maxcmd);
opts->queue_size = ctrl->ctrl.maxcmd;
}
if (opts->queue_size > ctrl->ctrl.sqsize + 1) {
/* warn if sqsize is lower than queue_size */
dev_warn(ctrl->ctrl.device,
- "queue_size %zu > ctrl sqsize %u, clamping down\n",
- opts->queue_size, ctrl->ctrl.sqsize + 1);
+ "queue_size %zu > ctrl sqsize %u, reducing "
+ "queue_size to %u\n",
+ opts->queue_size, ctrl->ctrl.sqsize + 1,
+ ctrl->ctrl.sqsize + 1);
opts->queue_size = ctrl->ctrl.sqsize + 1;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-fc: clean up error messages
2019-06-21 21:19 [PATCH] nvme-fc: clean up error messages Ewan D. Milne
@ 2019-06-22 0:38 ` Minwoo Im
0 siblings, 0 replies; 2+ messages in thread
From: Minwoo Im @ 2019-06-22 0:38 UTC (permalink / raw)
Hello, Ewan.
On 19-06-21 17:19:44, Ewan D. Milne wrote:
> Some of the error messages are inconsistent, and one of them is wrong
> (i.e. "queue_size 128 > ctrl maxcmd 32, reducing to queue_size").
> Make them more clear and distinguishable for log analysis.
>
> Signed-off-by: Ewan D. Milne <emilne at redhat.com>
> ---
> @@ -1259,7 +1259,7 @@ nvme_fc_connect_admin_queue(struct nvme_fc_ctrl *ctrl,
> if (fcret) {
> ret = -EBADF;
> dev_err(ctrl->dev,
> - "q %d connect failed: %s\n",
> + "queue %d connect admin queue failed: %s\n",
> queue->qnum, validation_errors[fcret]);
> } else {
> ctrl->association_id =
> @@ -1358,7 +1358,7 @@ nvme_fc_connect_queue(struct nvme_fc_ctrl *ctrl, struct nvme_fc_queue *queue,
> if (fcret) {
> ret = -EBADF;
> dev_err(ctrl->dev,
> - "q %d connect failed: %s\n",
> + "queue %d connect failed: %s\n",
> queue->qnum, validation_errors[fcret]);
Hmm.. It looks like the first one and the second ond are not pretty
consistent because the second one does not have any queue property like
I/O queue even the first shows "admin queue" itself.
> } else {
> queue->connection_id =
> @@ -1371,7 +1371,7 @@ nvme_fc_connect_queue(struct nvme_fc_ctrl *ctrl, struct nvme_fc_queue *queue,
> out_no_memory:
> if (ret)
> dev_err(ctrl->dev,
> - "queue %d connect command failed (%d).\n",
> + "queue %d connect failed (%d).\n",
> queue->qnum, ret);
> return ret;
> }
> @@ -2678,16 +2678,18 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
> /* warn if maxcmd is lower than queue_size */
> dev_warn(ctrl->ctrl.device,
> "queue_size %zu > ctrl maxcmd %u, reducing "
> - "to queue_size\n",
> - opts->queue_size, ctrl->ctrl.maxcmd);
> + "queue_size to %u\n",
> + opts->queue_size, ctrl->ctrl.maxcmd, ctrl->ctrl.maxcmd);
> opts->queue_size = ctrl->ctrl.maxcmd;
> }
>
> if (opts->queue_size > ctrl->ctrl.sqsize + 1) {
> /* warn if sqsize is lower than queue_size */
> dev_warn(ctrl->ctrl.device,
> - "queue_size %zu > ctrl sqsize %u, clamping down\n",
> - opts->queue_size, ctrl->ctrl.sqsize + 1);
> + "queue_size %zu > ctrl sqsize %u, reducing "
> + "queue_size to %u\n",
> + opts->queue_size, ctrl->ctrl.sqsize + 1,
> + ctrl->ctrl.sqsize + 1);
This part looks good to me, though.
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-22 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 21:19 [PATCH] nvme-fc: clean up error messages Ewan D. Milne
2019-06-22 0:38 ` Minwoo Im
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.