From: Greg KH <gregkh@linuxfoundation.org>
To: liaoweixiong <liaoweixiong@allwinnertech.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Frieder Schrempf <frieder.schrempf@exceet.de>,
Peter Pan <peterpandong@micron.com>,
Chuanhong Guo <gch981213@gmail.com>,
Schrempf Frieder <frieder.schrempf@kontron.de>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips
Date: Tue, 25 Jun 2019 11:08:07 +0800 [thread overview]
Message-ID: <20190625030807.GA11074@kroah.com> (raw)
In-Reply-To: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com>
On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
>
> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
> ---
> drivers/mtd/nand/spi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: liaoweixiong <liaoweixiong@allwinnertech.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Chuanhong Guo <gch981213@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Frieder Schrempf <frieder.schrempf@exceet.de>,
linux-mtd@lists.infradead.org,
Schrempf Frieder <frieder.schrempf@kontron.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
stable@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Peter Pan <peterpandong@micron.com>
Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips
Date: Tue, 25 Jun 2019 11:08:07 +0800 [thread overview]
Message-ID: <20190625030807.GA11074@kroah.com> (raw)
In-Reply-To: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com>
On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
>
> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
> ---
> drivers/mtd/nand/spi/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-25 3:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 1:02 [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
2019-06-25 1:02 ` liaoweixiong
2019-06-25 3:08 ` Greg KH [this message]
2019-06-25 3:08 ` Greg KH
2019-06-25 7:04 ` Schrempf Frieder
2019-06-25 7:04 ` Schrempf Frieder
2019-06-25 11:56 ` liaoweixiong
2019-06-25 11:56 ` liaoweixiong
2019-06-25 12:04 ` Schrempf Frieder
2019-06-25 12:04 ` Schrempf Frieder
2019-06-27 17:06 ` Miquel Raynal
2019-06-27 17:06 ` Miquel Raynal
2019-06-27 18:17 ` Miquel Raynal
2019-06-27 18:17 ` Miquel Raynal
2019-06-28 3:51 ` liaoweixiong
2019-06-28 3:51 ` liaoweixiong
-- strict thread matches above, loose matches on Subject: below --
2019-06-25 12:03 liaoweixiong
2019-06-25 12:03 ` liaoweixiong
2019-06-24 12:15 liaoweixiong
2019-06-24 12:15 ` liaoweixiong
2019-06-24 14:47 ` Schrempf Frieder
2019-06-24 14:47 ` Schrempf Frieder
2019-06-25 1:00 ` liaoweixiong
2019-06-25 1:00 ` liaoweixiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625030807.GA11074@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@exceet.de \
--cc=frieder.schrempf@kontron.de \
--cc=gch981213@gmail.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=peterpandong@micron.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.